[GitHub] zeppelin pull request #:

[khalidhuseynov]

Github user khalidhuseynov commented on the pull request:


https://github.com/apache/zeppelin/commit/13178aee18c0a4aed1dda0c72750e08c9ed9f53c#commitcomment-20062571
  
In 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java:
In 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java
 on line 138:
actually that was for a bit edge case if some instance was cast into 
`Object` and then into `Revision`, but generally that may not be needed. 
addressed all in 0408c9a3159f7e130e524f74d8fbbbca4acffc41


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...

[1ambda]

GitHub user 1ambda reopened a pull request:

https://github.com/apache/zeppelin/pull/1689

[ZEPPELIN-1709] Update checkstyle rule file, plugin

### What is this PR for?

We have

- outdated checkstyle.xml
- old maven checkstyle plugin
- no detailed style plugin guide (e.g available plugins, how to use them in 
your IDEA)

By fixing those issues, we can keep our code clean. It will results the 
number of rebase count (reduced conflict due to just style) and boost our 
productivity.

**important note**

1. This PR set an option to print all checkstyle warnings into stdout. The 
reason is, people should be told about invalid styles of not only errors but 
also warnings.
2. They would fix it progressionally. (unfortunately, we can fix all 
warnings in this PR. too much)
3. Once those warnings are all fixed, we can set 
`warning` to fail build even when 
checkstyle warning is occurred. That means we have more strict rule for our 
java code :)

```xml
true

```

### What type of PR is it?
[Improvement]

### Todos
* [x] - update check style plugin (6.19, the most recent for java 7)
* [x] - update checkstyle.xml  (brought from checkstyle 6.19 release)
* [x] - fix some styles
* [x] - print checkstyle WARN
* [x] - update docs

### What is the Jira issue?

[ZEPPELIN-1709](https://issues.apache.org/jira/browse/ZEPPELIN-1709)

### How should this be tested?

```
mvn validate -Denforcer.skip=true
```


### Questions:
* Does the licenses files need update - NO
* Is there breaking changes for older versions - NO
* Does this needs documentation - NO, but I added some docs about how to 
use checkstyle.xml in IDEA (https://github.com/apache/zeppelin/pull/1690)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin feat/update-checkstyle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1689.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1689


commit faef368b7955e731171049cec2aa46a05959cb9e
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:27:18Z

chore: Use pluginManagement block

so that config be shared in children projects

commit 9d28e188b8758ae56b99f5ddd88db0f161aa1df2
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:28:29Z

chore: Remove useless failOnViolation config

its default value is already `true`

see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html

commit d1d5cfea0d236f999f1e52f2a94cff6d753188ec
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:29:46Z

chore: Remove duplicated  exclude

commit 7e57fada02a589a57e6502f5094bf547135338ae
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:52:15Z

style: Fix Invalid indents in interpreter

[INFO] 

[INFO] Building Zeppelin: Interpreter 0.7.0-SNAPSHOT
[INFO] 

[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ 
zeppelin-interpreter ---
[INFO] There are 5 errors reported by Checkstyle 6.11.2 with 
_tools/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/zeppelin/dep/DependencyResolver.java:[162] 
(indentation) Indentation: 'Collection' have incorrect indentation level 4, 
expected level should be 6.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:[242]
 (indentation) Indentation: 'getClassName' have incorrect indentation level 10, 
expected level should be 12.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[59]
 (indentation) Indentation: 'extends' have incorrect indentation level 2, 
expected level should be 4.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[60]
 (indentation) Indentation: 'implements' have incorrect indentation level 2, 
expected level should be 4.
[ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile: 
File does not end with a newline.
[INFO] 

[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ... SUCCESS [  
3.587 s]
[INFO] Zeppelin: Interpreter .. FAILURE [  
0.901 s]

commit aebdc82c85a52d84fff9572c798e738c9227f451
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T03:03:06Z

style: Fix invalid indents in zengine

[INFO] 

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

[krskoondra]

Github user krskoondra commented on the issue:

https://github.com/apache/zeppelin/pull/1688
  
@Leemoonsoo my id is krskoondra.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1723: [ZEPPELIN-1747] Fix Korean notename input problem

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1723
  
Thanks @marchpig for the fix.
Thanks @tae-jun for the review.

LGTM and merge to master if there're no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1724: [ZEPPELIN-1674] save barchart, areachart type

[Leemoonsoo]

GitHub user Leemoonsoo opened a pull request:

https://github.com/apache/zeppelin/pull/1724

[ZEPPELIN-1674] save barchart, areachart type

### What is this PR for?
Persist 
 - bar graph options (grouped, stacked)
 - area graph option: (stacked, stream, expanded)

### What type of PR is it?
Improvement

### Todos
* [x] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1674

### How should this be tested?
Change graph option and refresh the page and see if change is restored

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Leemoonsoo/zeppelin zeppelin-1674-rebased

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1724


commit d040e4e2c3e74515e843c5c9555c06e77877feba
Author: Lee moon soo 
Date:   2016-12-03T00:13:07Z

save barchart, areachart type




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1711: [ZEPPELIN-1721] Let each visualization define '...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1711


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1688
  
@krskoondra Could you let me know you apache JIRA id? 
so i can assign you in this 
https://issues.apache.org/jira/browse/ZEPPELIN-1637 issue and resolve.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1723: [ZEPPELIN-1747] Fix Korean notename input problem

[marchpig]

Github user marchpig commented on the issue:

https://github.com/apache/zeppelin/pull/1723
  
@tae-jun Thanks for your quick reply.
I triggered CI again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...

[marchpig]

GitHub user marchpig reopened a pull request:

https://github.com/apache/zeppelin/pull/1723

[ZEPPELIN-1747] Fix Korean notename input problem

### What is this PR for?
Korean notename is incorrectly typed on Firefox.
This PR fixes the issue by changing placeholder attribute of the input 
field.
Getting the placeholder text from `noteName()` is unnecessary because the 
text is visible only when the notename is blank.

### What type of PR is it?
Bug Fix

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1747

### How should this be tested?
Type Korean notename in action bar using Firefox browser.

### Screenshots (if appropriate)

![korean-notename-issue](https://cloud.githubusercontent.com/assets/17305893/20859768/d7f5cf60-b9ab-11e6-926d-814b8e0cafb3.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/marchpig/zeppelin fix-korean-notename

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1723.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1723


commit 666f30ced0acdbf05aa4c4ce445f4d090f461c52
Author: Sangwoo Lee 
Date:   2016-12-03T13:52:47Z

Fix Korean notename input problem




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...

[marchpig]

Github user marchpig closed the pull request at:

https://github.com/apache/zeppelin/pull/1723


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1688: [ZEPPELIN-1637] Add button for "create next blo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1688


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1715: [ZEPPELIN-1740] Focus next paragraph after para...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1715


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1712: [ZEPPELIN-1742] send error info to popup when c...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1712


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1630
  
Great work @tae-jun. LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1723: [ZEPPELIN-1747] Fix Korean notename input problem

[tae-jun]

Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1723
  
I tested on Firefox and the error is gone. LGTM 👍 


![image](https://cloud.githubusercontent.com/assets/8201019/20860307/4507f57c-b9b8-11e6-9b15-fd6944ede2d5.png)

And I guess the CI failure is unrelated. Could you re-trigger CI?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

[tae-jun]

Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1630
  
I found out bugs by adding loggers and fixed them!

CI is green and it seems to work perfectly. I think it's good to go now 
😄 

Please when you have some time. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #:

[anthonycorbacho]

Github user anthonycorbacho commented on the pull request:


https://github.com/apache/zeppelin/commit/13178aee18c0a4aed1dda0c72750e08c9ed9f53c#commitcomment-20060217
  
In 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java:
In 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java
 on line 141:
I think we can just do `return (revision == null || 
EMPTY.equals(revision));` here to avoid redundancy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #:

[anthonycorbacho]

Github user anthonycorbacho commented on the pull request:


https://github.com/apache/zeppelin/commit/13178aee18c0a4aed1dda0c72750e08c9ed9f53c#commitcomment-20060216
  
In 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java:
In 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java
 on line 138:
I am not sure if we really need this here since in the method signature we 
set the type to be `Revision`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...

[marchpig]

GitHub user marchpig opened a pull request:

https://github.com/apache/zeppelin/pull/1723

[ZEPPELIN-1747] Fix Korean notename input problem

### What is this PR for?
Korean notename is incorrectly typed on Firefox.
This PR fixes the issue by changing placeholder attribute of the input 
field.
Getting the placeholder text from `noteName()` is unnecessary because the 
text is only visible when the notename is blank.

### What type of PR is it?
Bug Fix

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1747

### How should this be tested?
Type Korean notename in action bar using Firefox browser.

### Screenshots (if appropriate)

![korean-notename-issue](https://cloud.githubusercontent.com/assets/17305893/20859768/d7f5cf60-b9ab-11e6-926d-814b8e0cafb3.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/marchpig/zeppelin fix-korean-notename

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1723.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1723


commit 666f30ced0acdbf05aa4c4ce445f4d090f461c52
Author: Sangwoo Lee 
Date:   2016-12-03T13:52:47Z

Fix Korean notename input problem




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1747) Korean notename is incorrectly typed on Firefox

[Sangwoo Lee (JIRA)]

Sangwoo Lee created ZEPPELIN-1747:
-

 Summary: Korean notename is incorrectly typed on Firefox
 Key: ZEPPELIN-1747
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1747
 Project: Zeppelin
  Issue Type: Bug
  Components: front-end
Affects Versions: 0.7.0
 Environment: OS: Ubuntu 16.04 64-bit
Browser: Firefox 50.0
Reporter: Sangwoo Lee
Priority: Minor


Korean notename is incorrectly typed on Firefox.
Please see the attached gif.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1746) Flaky test: PySparkInterpreterTest

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-1746:


 Summary: Flaky test: PySparkInterpreterTest
 Key: ZEPPELIN-1746
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1746
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Jeff Zhang


{noformat}
import org.apache.spark.sql.functions._
16/12/03 11:25:07 INFO PySparkInterpreter: File 
/tmp/zeppelin_pyspark-6720028130103128200.py created
16/12/03 11:25:07 INFO SparkInterpreter: Sending metainfos to Zeppelin server: 
{url=http://172.17.0.3:4040}
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 51.398 sec <<< 
FAILURE! - in org.apache.zeppelin.spark.PySparkInterpreterTest
testBasicIntp(org.apache.zeppelin.spark.PySparkInterpreterTest)  Time elapsed: 
49.033 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.zeppelin.spark.PySparkInterpreterTest.testBasicIntp(PySparkInterpreterTest.java:128)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin pull request #1612: ZEPPELIN-1607. Refactor Livy Interpreter to ada...

[zjffdu]

GitHub user zjffdu reopened a pull request:

https://github.com/apache/zeppelin/pull/1612

ZEPPELIN-1607. Refactor Livy Interpreter to adapt scope mode

### What is this PR for?
ZEPPELIN-1606 will make scoped mode as the default interpreter mode of 
livy. This PR is to refactor livy interpreter to adapt the scoped mode. 
Besides, it also fix several bugs of livy interpreter.  like ZEPPELIN-1516. 
Besides that I also enable livy integration test in travis to make sure the 
refactoring correct. 


### What type of PR is it?
[Refactoring]

### Todos
* Move session creation to open()
* Other refactoring in livy interpreter, especially LivyHelper.java

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1607

### How should this be tested?
Travis is also enabled for livy integration test. 

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1607

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1612






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1612: ZEPPELIN-1607. Refactor Livy Interpreter to ada...

[zjffdu]

Github user zjffdu closed the pull request at:

https://github.com/apache/zeppelin/pull/1612


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---