[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] Visit and switch notebook revis...

[khalidhuseynov]

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/1675


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] Visit and switch notebook revis...

[khalidhuseynov]

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/1675

[ZEPPELIN-1190] Visit and switch notebook revisions

### What is this PR for?
This is to enable switching between revisions and being able to set 
`Head`/current note to one of those revisions. Currently notes are editable 
when switching between them, next step after this PR would be make them 
non-editable during revision switches. 

### What type of PR is it?
Improvement | Feature

### Todos
* [x] - routes and switching revisions
* [x] - set revision button and api
* [x] - test for setting revision

### What is the Jira issue?
[ZEPPELIN-1190](https://issues.apache.org/jira/browse/ZEPPELIN-1190)

### How should this be tested?
set config in conf/zeppelin-env.sh
```
export 
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
and switch between notes in note action bar, as well as set certain 
revisions as shown below

### Screenshots (if appropriate)
![switch 
revisions](https://cloud.githubusercontent.com/assets/1642088/20833665/2b7d67d4-b8d4-11e6-95d0-0c4ae66e349d.gif)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
feat/switch-revisions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1675


commit d1a16e0c6aa226dac4429f0c25b5152ad83b77f8
Author: Khalid Huseynov 
Date:   2016-11-24T04:59:42Z

create new root and call revision

commit e78add69f41a33619eb1597f4fa09834b7f7070d
Author: Khalid Huseynov 
Date:   2016-11-24T05:55:18Z

load revision note

commit 105f609801fa9f5a11a116d4dee2baa335f20370
Author: Khalid Huseynov 
Date:   2016-11-24T06:19:56Z

visit revision when click in dropdown

commit de1cc005537f41983c794dfd7564bc25b39a1c1f
Author: Khalid Huseynov 
Date:   2016-11-24T06:44:12Z

set current revision name

commit f54f2e82984ca746a92f64c0dc5bcc26d806c937
Author: Khalid Huseynov 
Date:   2016-11-24T07:16:25Z

fix quotes

commit dd4d2d9691df119172a0fd038e8a5e86974cce93
Author: Khalid Huseynov 
Date:   2016-11-24T09:49:32Z

fix getNote name change

commit 3f508d470d73afe9e8963d23d34938ed29e2e6f6
Author: Khalid Huseynov 
Date:   2016-11-25T08:29:33Z

fix pass data

commit 9628d64391aec9bceb914af8436a29464a39b679
Author: Khalid Huseynov 
Date:   2016-11-27T11:02:57Z

fix parameters

commit bc15533a39668271aa6604e8ff6ea22afb3cbff9
Author: Khalid Huseynov 
Date:   2016-11-30T03:58:30Z

add set revision button

commit 30a2ebc25b5dd6902cef30bcbb143d74ae83d1c3
Author: Khalid Huseynov 
Date:   2016-11-30T04:46:34Z

add ws api on front

commit a657ab5cf18fdece113ad77844135a5afb6ab6ef
Author: Khalid Huseynov 
Date:   2016-11-30T09:03:19Z

add backend api for setting revision

commit a05a335a2c7d063d286a477eb1f1747d5637db78
Author: Khalid Huseynov 
Date:   2016-11-30T16:44:40Z

go to note after setting revision

commit b6a0ba2f56535933d4bbd28fda281752e261b8c6
Author: Khalid Huseynov 
Date:   2016-12-01T04:12:47Z

fix log and checkstyle

commit fae51cb26a556519560d087dff15686ae407159a
Author: Khalid Huseynov 
Date:   2016-12-01T05:19:47Z

add writer permission check

commit 989c5df1c56a8e3c3cc61663f4414470bfac09b3
Author: Khalid Huseynov 
Date:   2016-12-01T09:27:46Z

return result status and reload to head if ok

commit 737ce15bd9cd3a2db408f0764cd4012be5874a64
Author: Khalid Huseynov 
Date:   2016-12-01T09:37:44Z

show error message popup if couldn't set revision

commit c70a20069f8cd70ce97a77a80e4f945b01d60e38
Author: Khalid Huseynov 
Date:   2016-12-02T09:48:18Z

add test

commit f4f9dcc762a342f47cc932cf2be0e716126d1ef2
Author: Khalid Huseynov 
Date:   2016-12-02T10:12:24Z

add broadcast

commit ab7db290eb1e701fb9e01e28f4f5d8a33ce2d0e0
Author: Khalid Huseynov 
Date:   2016-12-02T11:59:32Z

add disable flag for setting revision

only when enabled when in certain revision




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this 

[GitHub] zeppelin pull request #1745: ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and...

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1745

ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPELIN_INTERPRETER_DIR 
from common.sh

### What is this PR for?
We should remove `ZEPPELIN_NOTEBOOK_DIR` and `ZEPPELIN_INTERPRETER_DIR` 
from `common.sh` otherwise the corresponding property defined in 
`zeppelin-site.xml` won't take effect. I also check other properties like 
ZEPPELIN_CONF_DIR and ZEPPELIN_WAR. Although we define them explicitly in 
common.sh, we didn't expose them in document `install.md` and 
`zeppelin-site.xml.template`, so I think these are only for internal use and it 
is OK to keep them in common.sh although their correponding property in 
zeppelin-site.xml won't take effect too. 


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1785

### How should this be tested?
Tested manually

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

…

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1785

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1745


commit 141ec68f98fd215664efb36506e1a38d295f461c
Author: Jeff Zhang 
Date:   2016-12-12T05:31:15Z

ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPELIN_INTERPRETER_DIR 
from common.sh




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1786) Refactor LivyHelper

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-1786:


 Summary: Refactor LivyHelper
 Key: ZEPPELIN-1786
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1786
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1694
  
I agree with @prabhjyotsingh and @cloverhearts blocking to change the 
permission on a backend side too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1743: add hadoop-2.7 to available hadoop version

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1743


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1742: [ZEPPELIN-1781] Failed to run the script 'test_zeppeli...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1742
  
Looks like the Python2 CI test failed, could you take a look?
```
16/12/09 15:15:01 INFO PySparkInterpreter: File 
/tmp/zeppelin_pyspark-9170445727539307406.py created
16/12/09 15:15:01 INFO SparkInterpreter: Sending metainfos to Zeppelin 
server: {url=http://172.17.0.14:4040}
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 132.031 sec 
<<< FAILURE! - in org.apache.zeppelin.spark.PySparkInterpreterTest
testBasicIntp(org.apache.zeppelin.spark.PySparkInterpreterTest)  Time 
elapsed: 129.658 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.zeppelin.spark.PySparkInterpreterTest.testBasicIntp(PySparkInterpreterTest.java:128)

```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1587: [ZEPPELIN-1609] using pyspark(python3) with livy inter...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1587
  
lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1587: [ZEPPELIN-1609] using pyspark(python3) with livy inter...

[purechoc]

Github user purechoc commented on the issue:

https://github.com/apache/zeppelin/pull/1587
  
refector code based on  #1612


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1744
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Integrating SSO to Zeepelin Shiro

[Niraj Kumar]

Hi All,

I am trying to integrate SSO to Zeppelin using shiro. Identity provider is 
Siteminder and protocol is SAML.
Could you please send me or point me to link where I find the procedure to do 
this.?

Thanks in advance
Niraj
Disclaimer : 
This email communication may contain privileged and confidential information 
and is intended for the use of the addressee only. If you are not an intended 
recipient you are requested not to reproduce, copy disseminate or in any manner 
distribute this email communication as the same is strictly prohibited. If you 
have received this email in error, please notify the sender immediately by 
return e-mail and delete the communication sent in error. Email communications 
cannot be guaranteed to be secure & error free and Incedo Inc. is not liable 
for any errors in the email communication or for the proper, timely and 
complete transmission thereof.

[GitHub] zeppelin pull request #1612: ZEPPELIN-1607. Refactor Livy Interpreter to ada...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1612


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

[tae-jun]

Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1730
  
### CI is green! 😄 
I **changed Selenium test codes** affected by my PR and it works now.

 Failed reason
`remove note` button changed to `move to trash` but test code still wanted 
to click `remove note`. So I made it click `move to trash` button and now it 
works :)

Please review!
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

[tae-jun]

Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1730
  
Thanks for your careful review @marchpig 😄 I fixed the bug you found!

It turns out that I didn't normalize folder ID when creating a folder. It 
could be a serious bug if you didn't find it.

Thanks 👍


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1735: [ZEPPELIN-1767] Blank paragraph should not be run.

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1735
  
@astroshim Thanks for your prompt update. Tested and it works well! 
But sadly 3 of CI tests are failed likw below and looks relevant with this 
change. Could you take a look this again please?
```
Results :

Failed tests: 
  NoteTest.runNormalTest:80 
No interactions wanted here:
-> at org.apache.zeppelin.notebook.NoteTest.runNormalTest(NoteTest.java:80)
But found this interaction on mock 'interpreterFactory':
-> at 
org.apache.zeppelin.notebook.Paragraph.isValidInterpreter(Paragraph.java:598)
***
For your reference, here is the list of all invocations ([?] - means 
unverified).
1. [?]-> at 
org.apache.zeppelin.notebook.Paragraph.isValidInterpreter(Paragraph.java:598)
2. [?]-> at org.apache.zeppelin.notebook.Note.run(Note.java:550)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1735: [ZEPPELIN-1767] Blank paragraph should not be run.

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1735
  
Testcase also added. @AhyoungRyu Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---