[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2017-01-01 Thread AhyoungRyu 
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1775
  
Tested again and now I can see the text in the looknfeel dropdown menu of 
non-editable mode note. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...

2017-01-01 Thread astroshim 
GitHub user astroshim reopened a pull request:

https://github.com/apache/zeppelin/pull/1832

[ZEPPELIN-1884] Prevent NullPointerException when JDBC query.

### What is this PR for?
Sometimes users don't want to set the properties which they don't want to 
care about and `common.max_count` of JDBC interpreter is one of that property.
If it does not set the `common.max_count`, NullPointerException will occur.


### What type of PR is it?
Bug Fix 


### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1884


### How should this be tested?
 - Set properties like as following image and run select query.

![image](https://cloud.githubusercontent.com/assets/3348133/21585284/02c433ee-d072-11e6-8ca1-d120617bb7f1.png)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1884

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1832


commit f1efda772d70d9f0247d07195ab8913050e2339d
Author: astroshim 
Date:   2017-01-02T06:22:49Z

add checking commonkey exists




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...

2017-01-01 Thread astroshim 
Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/1832


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1833: [ZEPPELIN-1880] Fix shell interpreter output st...

2017-01-01 Thread AhyoungRyu 
GitHub user AhyoungRyu opened a pull request:

https://github.com/apache/zeppelin/pull/1833

[ZEPPELIN-1880] Fix shell interpreter output streaming result

### What is this PR for?
Shell interpreter streaming output had been available by #683, but 
currently it's broken after #1087 merged. This patch is for putting it back.

### What type of PR is it?
Bug Fix

### Todos
* [ ] - Task

### What is the Jira issue?
[ZEPPELIN-1880](https://issues.apache.org/jira/browse/ZEPPELIN-1880)

### How should this be tested?
```
%sh

date && sleep 3 && date
```

the each timestamp must be printed as streaming output

### Screenshots (if appropriate)
 - before 

![shellintpresultbefore](https://cloud.githubusercontent.com/assets/10060731/21585515/60c35a04-d105-11e6-8e68-853ee784e89d.gif)


 - after 

![shellintpresult](https://cloud.githubusercontent.com/assets/10060731/21585516/62142ac8-d105-11e6-8628-1d6eec35daae.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1880

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1833.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1833


commit 718873abafdd319ee5e624a2f6afdab2fcb4592c
Author: AhyoungRyu 
Date:   2017-01-02T06:39:14Z

Fix shell intp streaming output result

commit b90b83bed6747d3b92c26f9b6fad89c53e2787b9
Author: AhyoungRyu 
Date:   2017-01-02T06:39:30Z

Add test for shell inpt timeout property




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...

2017-01-01 Thread astroshim 
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1813
  
@soralee Thank you for reviewing and commenting!!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...

2017-01-01 Thread astroshim 
GitHub user astroshim opened a pull request:

https://github.com/apache/zeppelin/pull/1832

[ZEPPELIN-1884] Prevent NullPointerException when JDBC query.

### What is this PR for?
Sometimes users don't want to set the properties which they don't want to 
care about and `common.max_count` of JDBC interpreter is one of that property.
If it does not set the `common.max_count`, NullPointerException will occur.


### What type of PR is it?
Bug Fix 


### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1884


### How should this be tested?
 - Set properties like as following image and run select query.

![image](https://cloud.githubusercontent.com/assets/3348133/21585284/02c433ee-d072-11e6-8ca1-d120617bb7f1.png)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1884

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1832


commit f1efda772d70d9f0247d07195ab8913050e2339d
Author: astroshim 
Date:   2017-01-02T06:22:49Z

add checking commonkey exists




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1884) NullPointerException when JDBC query

2017-01-01 Thread Shim HyungSung (JIRA) 
Shim HyungSung created ZEPPELIN-1884:


 Summary: NullPointerException when JDBC query 
 Key: ZEPPELIN-1884
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1884
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Shim HyungSung


If "common.max_count" key doesn't exist in JDBC interpreter setting, following 
error occurs.

java.lang.NullPointerException
at 
org.apache.zeppelin.jdbc.JDBCInterpreter.getMaxResult(JDBCInterpreter.java:604)
at org.apache.zeppelin.jdbc.JDBCInterpreter.getResults(JDBCInterpreter.java:411)
at org.apache.zeppelin.jdbc.JDBCInterpreter.executeSql(JDBCInterpreter.java:468)
at org.apache.zeppelin.jdbc.JDBCInterpreter.interpret(JDBCInterpreter.java:537)
at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.interpret(LazyOpenInterpreter.java:94)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:494)
at org.apache.zeppelin.scheduler.Job.run(Job.java:175)
at 
org.apache.zeppelin.scheduler.ParallelScheduler$JobRunner.run(ParallelScheduler.java:162)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)

2017-01-01 Thread 1ambda 
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1824
  
@Leemoonsoo Thanks for review!

Now `mvn clean` will execute `npm run clean` (8baaea2)

```
$ zeppelin-web git:(ZEPPELIN-1850/remove-grunt-clean) mvn clean
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option 
MaxPermSize=1024m; support was removed in8.0
[INFO] Scanning for projects...
[INFO]
[INFO] 

[INFO] Building Zeppelin: web Application 0.7.0-SNAPSHOT
[INFO] 

[INFO]
[INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @ zeppelin-web ---
[INFO] Deleting 
/Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web/target
[INFO]
[INFO] --- frontend-maven-plugin:1.3:npm (npm clean) @ zeppelin-web ---
[INFO] Running 'npm run clean' in 
/Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web
[INFO]
[INFO] > zeppelin-web@0.0.0 clean 
/Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web
[INFO] > rimraf dist && rimraf .tmp
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1831: [ZEPPELIN-1883] Can't import spark submitted pa...

2017-01-01 Thread 1ambda 
GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1831

[ZEPPELIN-1883] Can't import spark submitted packages in PySpark

### What is this PR for?

Fixed importing packages in pyspack requested by `SPARK_SUBMIT_OPTION`

### What type of PR is it?
[Bug Fix]

### Todos

Nothing

### What is the Jira issue?

[ZEPPELIN-1883](https://issues.apache.org/jira/browse/ZEPPELIN-1883)

### How should this be tested?

1. Set `SPARK_HOME` and `SPARK_SUBMIT_OPTION` in `conf/zeppelin-env.sh` like

```sh
export SPARK_HOME="~/github/apache-spark/1.6.2-bin-hadoop2.6"
export SPARK_SUBMIT_OPTIONS="--packages 
com.datastax.spark:spark-cassandra-connector_2.10:1.6.2,TargetHolding:pyspark-cassandra:0.3.5
 --exclude-packages org.slf4j:slf4j-api"
```

2. Test whether submitted packages can be import or not

```
%pyspark

import pyspark_cassandra
```

### Screenshots (if appropriate)

```
import pyspark_cassandra


Traceback (most recent call last):
  File 
"/var/folders/lr/8g9y625n5j39rz6qhkg8s664gn/T/zeppelin_pyspark-5266742863961917074.py",
 line 267, in 
raise Exception(traceback.format_exc())
Exception: Traceback (most recent call last):
  File 
"/var/folders/lr/8g9y625n5j39rz6qhkg8s664gn/T/zeppelin_pyspark-5266742863961917074.py",
 line 265, in 
exec(code)
  File "", line 1, in 
ImportError: No module named pyspark_cassandra
```

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-1883/cant-import-submitted-packages-in-pyspark

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1831


commit c735bd54b1ce712641ae9d2c4b780d954c0e985c
Author: 1ambda <1am...@gmail.com>
Date:   2017-01-02T04:52:40Z

fix: Import spark submit packages in pyspark




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1883) Can't import packages requested by SPARK_SUBMIT_OPTION in pyspark

2017-01-01 Thread Hoon Park (JIRA) 
Hoon Park created ZEPPELIN-1883:
---

 Summary: Can't import packages requested by SPARK_SUBMIT_OPTION in 
pyspark
 Key: ZEPPELIN-1883
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1883
 Project: Zeppelin
  Issue Type: Bug
  Components: pySpark
Reporter: Hoon Park
 Fix For: 0.7.0


Zeppelin pyspark can't import submitted packages by {{SPARK_SUBMIT_OPTION}}. 
For example, 

{code}
// conf/zeppelin-env.sh
...

export SPARK_HOME="~/github/apache-spark/1.6.2-bin-hadoop2.6"
export SPARK_SUBMIT_OPTIONS="--packages 
com.datastax.spark:spark-cassandra-connector_2.10:1.6.2,TargetHolding:pyspark-cassandra:0.3.5
 --exclude-packages org.slf4j:slf4j-api"

...
{code}

And then try import that pyspark cassandra module in zeppelin pyspark 
interpreter

{code}
import pyspark_cassandra


Traceback (most recent call last):
  File 
"/var/folders/lr/8g9y625n5j39rz6qhkg8s664gn/T/zeppelin_pyspark-5266742863961917074.py",
 line 267, in 
raise Exception(traceback.format_exc())
Exception: Traceback (most recent call last):
  File 
"/var/folders/lr/8g9y625n5j39rz6qhkg8s664gn/T/zeppelin_pyspark-5266742863961917074.py",
 line 265, in 
exec(code)
  File "", line 1, in 
ImportError: No module named pyspark_cassandra
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1882) Some chart doesn't work in dynamic form of dropdown list

2017-01-01 Thread Jeff Zhang (JIRA) 
Jeff Zhang created ZEPPELIN-1882:


 Summary: Some chart doesn't work in dynamic form of dropdown list 
 Key: ZEPPELIN-1882
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1882
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Jeff Zhang
 Attachments: Pig Tutorial.gif

Attach the screenshot, not sure whether it relate with dropdown list. It works 
in textbox but doens't work in dropdown list, very weird. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1881) Some chart doesn't work in dynamic form of dropdown list

2017-01-01 Thread Jeff Zhang (JIRA) 
Jeff Zhang created ZEPPELIN-1881:


 Summary: Some chart doesn't work in dynamic form of dropdown list 
 Key: ZEPPELIN-1881
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1881
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Jeff Zhang


Attach the screenshot, not sure whether it relate with dropdown list. It works 
in textbox but doens't work in dropdown list, very weird. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1809: ZEPPELIN-1866. No meaningful exception for pig interpr...

2017-01-01 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1809
  
I think these are flaky test. Because all the failed test are not pig 
related. Changes in this PR is only on pig interpreter.

```
Failed tests: 
  NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760 
expected: but was:
 
Tests run: 148, Failures: 1, Errors: 0, Skipped: 0
```

```
Results :
 
Tests in error: 
  ZeppelinIT.testAngularRunParagraph:315->AbstractZeppelinIT.waitForText:84 
» StaleElementReference
 
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2017-01-01 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1787
  
CI failure doesn't seem related.
```
java.lang.AssertionError: expected: but was:
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.zeppelin.rest.ZeppelinSparkClusterTest.zRunTest(ZeppelinSparkClusterTest.java:347)

```

LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2017-01-01 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1787
  
ah, that's unfortunate. the feedback was it would be inconsistent and 
confusing to have multiple default values for the timeout, instead it is moved 
to the top of the 
[function](https://github.com/apache/spark/pull/15471/files#diff-8ed17b5ecd168e47a2433cc9b3bc5b17R157)
 - but I can see the caller of connectBackend (though not officially supported) 
can be broken by this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1880) Break streaming output functionality of ShellInterpreter

2017-01-01 Thread Shim HyungSung (JIRA) 
Shim HyungSung created ZEPPELIN-1880:


 Summary: Break streaming output functionality of ShellInterpreter
 Key: ZEPPELIN-1880
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1880
 Project: Zeppelin
  Issue Type: Bug
Reporter: Shim HyungSung


Since https://github.com/apache/zeppelin/pull/1087, StreamingOutput 
functionality does not work.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2017-01-01 Thread Leemoonsoo 
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1694
  
After this patch, if i turn off shiro and load any notebook (without click 
permission button)

browser console print 403 forbidden, 

![image](https://cloud.githubusercontent.com/assets/1540981/21582774/b013229c-d01a-11e6-9fb8-e907bf8954a6.png)

And ZeppelinServer prints stack trace
```
WARN [2017-01-01 12:03:26,784] ({qtp106298691-16} 
WebApplicationExceptionMapper.java[toResponse]:73) - 
org.apache.zeppelin.rest.exception.ForbiddenException
at 
org.apache.zeppelin.rest.NotebookRestApi.checkIfUserIsAnon(NotebookRestApi.java:133)
at 
org.apache.zeppelin.rest.NotebookRestApi.getNotePermissions(NotebookRestApi.java:98)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
at 
org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:205)
at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:102)
at 
```

Can we try not print error / warning on loading notebook ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1815: [ZEPPELIN-1722] Modernize visualization/transformation...

2017-01-01 Thread Leemoonsoo 
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1815
  
Addressed comments. 

I don't think style `visualization(el).transform(...).render();` is 
important topic here.
Because this `Visualization` class is intended to be used by developer who 
want to create new visualization. And the developer doesn't need to call either 
`visualization(el).transform(...).render(); ` or `new ;` because instantiation 
of visualization is managed by `result.controller.js`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...

2017-01-01 Thread Leemoonsoo 
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1729
  
LGTM and merge to master if there're no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

2017-01-01 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1830
  
@felixcheung @AhyoungRyu Please help review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1830: ZEPPELIN-1867. Update document for pig interpre...

2017-01-01 Thread zjffdu 
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1830

ZEPPELIN-1867. Update document for pig interpreter and add one sample note

### What is this PR for?
* Minor update for pig interpreter
* Add one sample pig tutorial note which do the same thing as the spark 
tutorial note. 


### What type of PR is it?
[Improvement | Documentation ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1867

### How should this be tested?
Tested manually

### Screenshots (if appropriate)

![image](https://cloud.githubusercontent.com/assets/164491/21581428/d04cb67a-d06c-11e6-85b6-23f006fd6d3a.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1867

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1830


commit af0375162659436fff00b84f9fd83d22878c842a
Author: Jeff Zhang 
Date:   2017-01-01T09:41:34Z

ZEPPELIN-1867. Update document for pig interpreter and add one sample note

commit 2bab4633b1fdc0113e6737ae7ebc3cfee77eaa36
Author: Jeff Zhang 
Date:   2017-01-01T13:47:54Z

Add pig tutorial note




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1829: [DOCS] Remove outdated 'Security Setup' section...

2017-01-01 Thread AhyoungRyu 
GitHub user AhyoungRyu opened a pull request:

https://github.com/apache/zeppelin/pull/1829

[DOCS] Remove outdated 'Security Setup' section in SECURITY-README

### What is this PR for?

[SECURITY-README.md](https://github.com/apache/zeppelin/blob/master/SECURITY-README.md)
 was added by #53 when Shiro auth was implemented for the first time. But I 
think we need to keep "Security Setup" information in one source; [Official 
docs 
website](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/shiroauthentication.html#security-setup)
 and guide ppl to see this official docs page so that `SECURITY-README.md` can 
only contain dev related contents (not step by step setup guide).

### What type of PR is it?
Documentation

### What is the Jira issue?
N/A

### How should this be tested?
Just clicking "View" would be enough I guess :)


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin remove/duplicatedSection

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1829.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1829


commit d908da95a63b7bcf4ff7861afc883552649df7e2
Author: AhyoungRyu 
Date:   2017-01-01T07:50:58Z

Remove outdated 'Security Setup' section in SECURITY-README

commit 3e867acb1d5f18ce6f9a67e35a32933694d2e479
Author: AhyoungRyu 
Date:   2017-01-01T07:51:16Z

Fix wired numbering

commit 8ce33bef3ef5a46e45851769123504421082f57a
Author: AhyoungRyu 
Date:   2017-01-01T08:01:23Z

Remove note sentence




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2017-01-01 Thread tae-jun 
Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1730
  
@AhyoungRyu Finally, it's green!!! Thanks for your care 😄 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1828: [ZEPPELIN-1876] smart psql autocomplition

2017-01-01 Thread sotnich 
GitHub user sotnich opened a pull request:

https://github.com/apache/zeppelin/pull/1828

[ZEPPELIN-1876] smart psql autocomplition

### What is this PR for?
This PR changes autocompletion behaviour in postgresql interpeter.
There are some changes:
* [main change] autocompletion now depends on what are you typing. Now 
there are four types of competion: schema, table, column and keywords. If you 
typing new word then autocompetion suggests only keywords and schema names. If 
you are typing after schema name with point then you get list of tables in that 
schema. Also if you typing a name after point after a table name you will get a 
list of column names of this table.
* autocomption now supports aliases in sql. If you write alias for a table 
you will get a list of columns of an aliased table if you write down the alias 
and a point.
* new option are availble for postgresql interpreter: 
postgresql.completer.schema.filter. It allows filter schema names loaded into 
autocompletion (no more garbage schema names).
* autocompletion now load keywords only in low case (otherwise there are so 
many keywords in a list of autocompletion that it is becomes uncomfortable)

### What type of PR is it?
Improvement

### Todos
* [ ] - sort names in the output of autocompletion
* [ ] - list only schema names if we are typing a schema name (for example 
after keywork FROM)
* [ ] - add description in autocompletion list for schema names - schema, 
for table names - table and so

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1876

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)
https://issues.apache.org/jira/secure/attachment/12845228/auto1.JPG
https://issues.apache.org/jira/secure/attachment/12845229/auto2.JPG
https://issues.apache.org/jira/secure/attachment/12845230/auto3.JPG

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sotnich/zeppelin psql-1876

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1828.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1828


commit c33778f468174535e0345d2b3a64d592f89cdd60
Author: Sotnichenko Sergey 
Date:   2016-12-31T17:33:27Z

Main changes

commit 4e9d4dd65fc27bff6e58fe3ffebc653c116d4815
Author: Sotnichenko Sergey 
Date:   2016-12-31T18:24:01Z

[ZEPPELIN-1876] Main changes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2017-01-01 Thread tae-jun 
GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 3b861ee85b93805ec6298f5d17d88f211ef4b8a3
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit e2b2902f4aa4b6456643ec13105928e3afc409b0
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 77d79499f83923f07f8a2451fdb9f2a0e448528d
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 1d597ee152e62e03aa9645284478507821a315ef
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 710c474c022b010ab5ed8038862dbdbbf44f58e3
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit f40e763f33158b82bc4be1cdb08657a248f12baf
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit d5389c016fc018d2c70125429e00836a8d107dd2
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit 731a2da29c41b8d3602c105bfa5fab3f7b70ef7d
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit b1c459da81d61c131f997150d8644a0f05701c03
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit ab28178a0e818dd1f269969489ec87520ef0e14d
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit ecaed2e5740e8cdd5cec1beecee65b9486a8a2dc
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 7afdc886ac0113f5123ef032fe6847a3d8d2fd65
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2017-01-01 Thread tae-jun 
Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2017-01-01 Thread tae-jun 
Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2017-01-01 Thread tae-jun 
GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 3b861ee85b93805ec6298f5d17d88f211ef4b8a3
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit e2b2902f4aa4b6456643ec13105928e3afc409b0
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 77d79499f83923f07f8a2451fdb9f2a0e448528d
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 1d597ee152e62e03aa9645284478507821a315ef
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 710c474c022b010ab5ed8038862dbdbbf44f58e3
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit f40e763f33158b82bc4be1cdb08657a248f12baf
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit d5389c016fc018d2c70125429e00836a8d107dd2
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit 731a2da29c41b8d3602c105bfa5fab3f7b70ef7d
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit b1c459da81d61c131f997150d8644a0f05701c03
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit ab28178a0e818dd1f269969489ec87520ef0e14d
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit ecaed2e5740e8cdd5cec1beecee65b9486a8a2dc
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 7afdc886ac0113f5123ef032fe6847a3d8d2fd65
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2017-01-01 Thread AhyoungRyu 
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1730
  
1 build failed with below error, but it's irrelevant to this change. 

```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on 
project zeppelin-pig: Execution default-test of goal 
org.apache.maven.plugins:maven-surefire-plugin:2.17:test failed: The forked VM 
terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /home/travis/build/apache/zeppelin/pig && 
/usr/lib/jvm/java-7-oracle/jre/bin/java -Xmx2g -Xms1g -Dfile.encoding=UTF-8 
-jar 
/home/travis/build/apache/zeppelin/pig/target/surefire/surefirebooter300784690996837886.jar
 
/home/travis/build/apache/zeppelin/pig/target/surefire/surefire6525093842604398164tmp
 
/home/travis/build/apache/zeppelin/pig/target/surefire/surefire_327671988278855013716tmp
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, 
please read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the 
command
[ERROR]   mvn  -rf :zeppelin-pig
``` 

So let me merge into master in this time. Thanks for your long long 
patience and effort @tae-jun 🌄


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2017-01-01 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1787
  
@felixcheung The test fail is due to api change in spark 2.1.0. 
SPARK-17919 remove timeout, not sure why. I don't think we need to remove 
it. 
https://github.com/apache/spark/pull/15471/files. @felixcheung I see you 
are the reviewer, you may know the background. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---