[GitHub] zeppelin issue #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-11 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2621 LGTM ---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-10-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2585 Hi, Thanks for rebasing and testing. But this recent PR passed the CI. If you don't mind please re-run few times until successful and check the failure reasons? If we can verify they

[GitHub] zeppelin issue #2620: [MINOR][Code Refactoring] Configuration name change fo...

2017-10-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2620 not yet, it only affects 0.8.0, so won't cause any compatibility break. ---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-10-11 Thread yu74n
Github user yu74n commented on the issue: https://github.com/apache/zeppelin/pull/2585 I rebased and ran test again, but this test is still failed. https://travis-ci.org/yu74n/zeppelin/jobs/286508544 I think probably my PR doesn't affect the test. I ran test several

[GitHub] zeppelin issue #2613: ZEPPELIN-2982. Copy interpreter-setting.json to interp...

2017-10-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2613 @Leemoonsoo parent project must be pom type, but zeppelin-interpreter is jar. So I have to introduce module `interpreter-parent`. Interpreter dev guide is updated in the new commit. ---

[GitHub] zeppelin pull request #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-11 Thread yanboliang
GitHub user yanboliang reopened a pull request: https://github.com/apache/zeppelin/pull/2621 [Minor] Remove hardcoded key in zeppelinhub. ### What is this PR for? Hardcoded seed/key may cause security issue, so remove potential risk. ### What type of PR is it?

[GitHub] zeppelin pull request #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-11 Thread yanboliang
Github user yanboliang closed the pull request at: https://github.com/apache/zeppelin/pull/2621 ---

[GitHub] zeppelin issue #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-11 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/zeppelin/pull/2621 @prabhjyotsingh Please help review. ---

[GitHub] zeppelin pull request #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-11 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/zeppelin/pull/2621 [Minor] Remove hardcoded key in zeppelinhub. ### What is this PR for? Hardcoded key may cause security issue, so remove the potential risk. ### What type of PR is it?

[GitHub] zeppelin issue #2620: [MINOR][Code Refactoring] Configuration name change fo...

2017-10-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2620 did we release this? ---

[GitHub] zeppelin pull request #2596: [ZEPPELIN-2949] Allow custom Spark UI URL

2017-10-11 Thread necosta
Github user necosta closed the pull request at: https://github.com/apache/zeppelin/pull/2596 ---

[GitHub] zeppelin issue #2617: ZEPPELIN-2985: correct grammar in keyboard tooltip

2017-10-11 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2617 Thanks @gef756 for the fix. LGTM ---

[GitHub] zeppelin issue #2613: ZEPPELIN-2982. Copy interpreter-setting.json to interp...

2017-10-11 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2613 I see. Could you also explain little bit about why you decided to make `interpreter-parent` module instead of just add copy plugin to existing common parents `zeppelin-interpreter` ?

[GitHub] zeppelin issue #1783: Zeppelin 727

2017-10-11 Thread PetroKostyuk
Github user PetroKostyuk commented on the issue: https://github.com/apache/zeppelin/pull/1783 As it seems, this pull request is still open, so this feature is not in added to application. I no longer work on zeppelin project, so I don't know whether this feature will get published in

[GitHub] zeppelin issue #1783: Zeppelin 727

2017-10-11 Thread aurely06
Github user aurely06 commented on the issue: https://github.com/apache/zeppelin/pull/1783 Hi, Any update about this request ? The link to paragraph in context is available or not yet ? Thank you ! ---

[GitHub] zeppelin issue #2596: [ZEPPELIN-2949] Allow custom Spark UI URL

2017-10-11 Thread necosta
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2596 Thanks @felixcheung and apologies for the delay on this. Rebased on top of latest master and updated documentation. Can you have another look? Thanks ---

[GitHub] zeppelin pull request #2620: [MINOR][Code Refactoring] Configuration name ch...

2017-10-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2620 ---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-10-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2585 The 3/4 jobs failed. Please rebase this PR based on master. And Could you resolve them? ---

[GitHub] zeppelin issue #2573: [ZEPPELIN-2920] move commonly used error handlers to u...

2017-10-11 Thread 1ambda
=AKIAJRYRXRSVGNKPKO5A/20171011/us-east-1/s3/aws4_request=host=15e71aa2c61cf1ee2f241e91b3d4ab31c47293888f81b865603c6d3171142ad4 ``` [INFO] ** [INFO] *Failures* [INFO

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-10-11 Thread yu74n
Github user yu74n commented on the issue: https://github.com/apache/zeppelin/pull/2585 @1ambda Sure ---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-11 Thread yu74n
GitHub user yu74n reopened a pull request: https://github.com/apache/zeppelin/pull/2585 [ZEPPELIN-2647] Bypass auth logic when a user logins as admin role ### What is this PR for? For administrator, make new admin role that assigned user can see all notebooks. ### What

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-11 Thread yu74n
Github user yu74n closed the pull request at: https://github.com/apache/zeppelin/pull/2585 ---

[GitHub] zeppelin issue #2573: [ZEPPELIN-2920] move commonly used error handlers to u...

2017-10-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2573 rebased since it's quite old ---

[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

2017-10-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2616 Nowadays many browser support password auto-completion. (e.g Chrome, ...) So +1 for this feature. ---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-10-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2585 I wanted to merge now. But cound't find the build history. - https://builds.apache.org/job/zeppelin-pull-request/2960/ @yu74n if you don't mind close and reopen this issue to

[GitHub] zeppelin pull request #2580: [ZEPPELIN-2924] Fix broken javascript source ma...

2017-10-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2580 ---

[GitHub] zeppelin issue #2619: Run all paragraphs sequentially

2017-10-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2619 @namanmishra91 I don't see the current behavior is retained in this PR. Personally I don't think the current behavior needs to be retained. Even we want to keep the current behavior, it should be

[GitHub] zeppelin issue #2617: ZEPPELIN-2985: correct grammar in keyboard tooltip

2017-10-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2617 I tried to search other typo but couldn't find (for viable text, not for css class things). LGTM.

[GitHub] zeppelin issue #2619: Run all paragraphs sequentially

2017-10-11 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2619 @zjffdu Thanks for the feedback. Directly modifying the `persistAndExecuteSingleParagraph` method will lead to the current behaviour getting lost completely. The reason I chose to not

[GitHub] zeppelin issue #2618: [WIP] ZEPPELIN-2986. Add hadoop-aws and hadoop-azure t...

2017-10-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2618 notebook storage is in module zeppelin-zengine. Just found it has jar conflicts with the native azure and s3 storage. Will keep it pending for now. ---

[GitHub] zeppelin issue #2619: Run all paragraphs sequentially

2017-10-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2619 @namanmishra91 I don't mean your PR doesn't do it correctly. I mean you could do it in an easier approach with less code changes. Just modifying `persistAndExecuteSingleParagraph` to make it run

[GitHub] zeppelin issue #2614: Add support for minio storage over s3 api

2017-10-11 Thread dmvk
Github user dmvk commented on the issue: https://github.com/apache/zeppelin/pull/2614 I'll try to implement new storage using official minio sdk https://github.com/minio/minio-java. It seems this patch is still not enough for s3 client to work properly with minio. ---

[GitHub] zeppelin pull request #2478: [ZEPPELIN-2761] - Neo4j Interpreter

2017-10-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2478 ---

[GitHub] zeppelin issue #2478: [ZEPPELIN-2761] - Neo4j Interpreter

2017-10-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2478 merged, thanks! ---

[GitHub] zeppelin issue #2619: Run all paragraphs sequentially

2017-10-11 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2619 @zjffdu > What we need to do it to run it blocking way. The code does exactly that. It might look complicated overall as a lot of code is related to handling and passing

[GitHub] zeppelin issue #2619: Run all paragraphs sequentially

2017-10-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2619 @namanmishra91 Thanks for the contribution. But the implementation is a little complicated to me. I think the easiest implementation is just run paragraphs sequentially in backend. Look at the