[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...

[kjmrknsn]

Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2677
  
I tested that `Command` + `s` was ignored successfully on Mac.


---

[GitHub] zeppelin issue #2682: [ZEPPELIN-3066] Make the welcome header of the homepag...

[kjmrknsn]

Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2682
  
Travis CI status turned to green: 
https://travis-ci.org/kjmrknsn/zeppelin/builds/305087756


---

[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...

[tessbianchi]

Github user tessbianchi commented on the issue:

https://github.com/apache/zeppelin/pull/2677
  
Alright added support for the command key. However, I do not have a mac and 
couldn't test it.

I implemented the second answer on 
[https://stackoverflow.com/questions/3902635/how-does-one-capture-a-macs-command-key-via-javascript](this)
 stackoverflow. 


---

[jira] [Created] (ZEPPELIN-3070) no way to prevent changing Notebook Repos values

[taiho choi (JIRA)]

taiho choi created ZEPPELIN-3070:


 Summary: no way to prevent changing Notebook Repos values 
 Key: ZEPPELIN-3070
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3070
 Project: Zeppelin
  Issue Type: Bug
Reporter: taiho choi


using shiro i want to prevent chaning all settings including notebook repos.
others are working well by uncommenting, 
but the repos values was not.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zeppelin pull request #2680: [ZEPPELIN-3066] Make the welcome header of the ...

[kjmrknsn]

Github user kjmrknsn closed the pull request at:

https://github.com/apache/zeppelin/pull/2680


---

[GitHub] zeppelin issue #2680: [ZEPPELIN-3066] Make the welcome header of the homepag...

[kjmrknsn]

Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2680
  
This PR is replaced with https://github.com/apache/zeppelin/pull/2682.


---

[GitHub] zeppelin issue #2681: [ZEPPELIN-2995] "auto-restart interpreter on cron exec...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2681
  
Thanks @kjmrknsn for adding test!
LGTM and merge to master if no further reviews.


---

[GitHub] zeppelin pull request #2682: [ZEPPELIN-3066] Make the welcome header of the ...

[kjmrknsn]

GitHub user kjmrknsn opened a pull request:

https://github.com/apache/zeppelin/pull/2682

[ZEPPELIN-3066] Make the welcome header of the homepage for non login users 
customizable

### What is this PR for?
Make the welcome header of the homepage for non login users customizable.

In our company's use case, we would like to customize the contents of the 
welcome header of the homepage for non login users so that we can introduce how 
to create an LDAP account to login Zeppelin to them.

### What type of PR is it?
[Improvement]

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3066


### How should this be tested?
* Tested manually.
* I confirmed that the content of the HTML file whose path was set by 
`zeppelin.homescreen.header` was shown on the top of the home screen page.
* https://user-images.githubusercontent.com/31149688/33010922-953cec1a-ce1f-11e7-9aad-b7f953736036.png;>
* I also confirmed that if `zeppelin.homescreen.header` was not set, 
the default contents (`app/home/header.html`) was shown.
* https://user-images.githubusercontent.com/31149688/33010954-b59f5b64-ce1f-11e7-9b1b-481ee9ba207f.png;>

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? Yes. 
`docs/setup/operation/configuration.md` was updated.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjmrknsn/zeppelin ZEPPELIN-3066-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2682.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2682


commit c611526ed3c6d3c618e7435db22c95822f02ffbe
Author: Keiji Yoshida 
Date:   2017-11-21T03:39:59Z

[ZEPPELIN-3066] Make the welcome header of the homepage for non login users 
customizable




---

[GitHub] zeppelin issue #2681: [ZEPPELIN-2995] "auto-restart interpreter on cron exec...

[kjmrknsn]

Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2681
  
@Leemoonsoo The unit test was added to `NotebookTest.java`. Thanks.


---

[GitHub] zeppelin issue #2678: [ZEPPELIN-3063] Notebook loses formatting when importi...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2678
  
Merging this if no more discussion.


---

[GitHub] zeppelin issue #2681: [ZEPPELIN-2995] "auto-restart interpreter on cron exec...

[kjmrknsn]

Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2681
  
@Leemoonsoo I'll try to add a test. Thanks.


---

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on run...

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
thanks for the ping, i'll check the state and update the branch by end of 
the week


---

[jira] [Created] (ZEPPELIN-3069) ask user for username and password if the property is deleted from the interpreter configuration

[Akshay Kotecha Jain (JIRA)]

Akshay Kotecha Jain created ZEPPELIN-3069:
-

 Summary: ask user for username and password if the property is 
deleted from the interpreter configuration
 Key: ZEPPELIN-3069
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3069
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.3
Reporter: Akshay Kotecha Jain


when creating a new interpreter, if the default.user and default.password 
properties are deleted using the 'X' mark in the interpreter configuration 
page, *the values should be requested from the user*. Currently, the values are 
assigned from *[Credential](../setup/security/datasource_authorization.html).*

This assigns the values as follows:
default.user=*zeppelin*
database name=*zeppelin*





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zeppelin issue #2681: [ZEPPELIN-2995] "auto-restart interpreter on cron exec...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2681
  
Thanks @kjmrknsn for the fix. It looks great to me!

If we can add a automated test, like 
[testAutoRestartInterpreterAfterSchedule 
](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java#L405),
 it'll help make sure any future change doesn't break this behavior.

Do you think you can add a test? Let me know if you need help on adding 
test!


---

[GitHub] zeppelin pull request #2673: [ZEPPELIN-3054] Update conf/shiro.ini.template ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2673


---

[jira] [Created] (ZEPPELIN-3068) Html embedded into table grid with angular elements

[Volodymyr Glushak (JIRA)]

Volodymyr Glushak created ZEPPELIN-3068:
---

 Summary: Html embedded into table grid with angular elements
 Key: ZEPPELIN-3068
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3068
 Project: Zeppelin
  Issue Type: Improvement
Affects Versions: 0.7.3
Reporter: Volodymyr Glushak


Table grids supports embedded HTMLs.
{quote}
If table contents start with %html, it is interpreted as an HTML.
{quote}

Unfortunately, it's not possible to use angular features together with embedded 
html (at least it does not work for me).

Example.
I've added column with the button and perform angularBind based on value from 
another column.
I'm checking value in different paragraph but nothing happened.
If I copy code of this button element to %angluar paragraph and press it again 
- variable successfully bind into zookeeper context.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

[vglushak]

Github user vglushak commented on the issue:

https://github.com/apache/zeppelin/pull/2323
  
> Now table renders HTML display in the cells and adjusts row height based 
on the content.

There are some limitations for this feature. img, links works. But when I 
want to place button it just ignore html and display text only.


---

[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.

[kjmrknsn]

Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/1302
  
The bug that "auto-restart interpreter on cron execution" restarts all 
interpreters will be fixed by https://github.com/apache/zeppelin/pull/2681.


---

[GitHub] zeppelin pull request #2681: [ZEPPELIN-2995] "auto-restart interpreter on cr...

[kjmrknsn]

GitHub user kjmrknsn opened a pull request:

https://github.com/apache/zeppelin/pull/2681

[ZEPPELIN-2995] "auto-restart interpreter on cron execution" should restart 
interpreter to specific note, not all interpreters

### What is this PR for?
Make "auto-restart interpreter on cron execution" restart interpreter to 
specific note, not all interpreters.
This issue was reported by 
https://github.com/apache/zeppelin/pull/1302#issuecomment-336521420.

### What type of PR is it?
[Bug Fix]

### Todos

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2995

### How should this be tested?
* Tested Manually.
   * I confirmed that the "auto-restart interpreter on cron execution" 
feature restarted only the interpreters which are specific to the notebook.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjmrknsn/zeppelin ZEPPELIN-2995

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2681


commit f7b528d390f4464e8011d22d9bed60e0ff176a09
Author: Keiji Yoshida 
Date:   2017-11-20T13:54:39Z

[ZEPPELIN-2995] "auto-restart interpreter on cron execution" should restart 
interpreter to specific note, not all interpreters




---

[GitHub] zeppelin pull request #2680: [ZEPPELIN-3066] Make the welcome header of the ...

[kjmrknsn]

GitHub user kjmrknsn opened a pull request:

https://github.com/apache/zeppelin/pull/2680

[ZEPPELIN-3066] Make the welcome header of the homepage for non login users 
customizable

### What is this PR for?
Make the welcome header of the homepage for non login users customizable.

In our company's use case, we would like to customize the contents of the 
welcome header of the homepage for non login users so that we can introduce how 
to create an LDAP account to login Zeppelin to them.

### What type of PR is it?
[Improvement]

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3066


### How should this be tested?
* Tested manually.
* I confirmed that the content of the HTML file whose path was set by 
`zeppelin.homescreen.header` was shown on the top of the home screen page.
* https://user-images.githubusercontent.com/31149688/33010922-953cec1a-ce1f-11e7-9aad-b7f953736036.png;>
* I also confirmed that if `zeppelin.homescreen.header` was not set, 
the default contents (`app/home/header.html`) was shown.
* https://user-images.githubusercontent.com/31149688/33010954-b59f5b64-ce1f-11e7-9b1b-481ee9ba207f.png;>

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? Yes. 
`docs/setup/operation/configuration.md` was updated.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjmrknsn/zeppelin ZEPPELIN-3066

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2680


commit 3bc91488587152041bb2185c36682994a51a582f
Author: Keiji Yoshida 
Date:   2017-11-20T04:58:39Z

[ZEPPELIN-3066] Make the welcome header of the homepage for non login users 
customizable




---

[GitHub] zeppelin issue #2668: ZEPPELIN-3051. Support Interpreter Process Recovery

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2668
  
Currently, there's no api for restarting interpreter process. Restarting 
interpreter setting just terminate interpreter process, and will restart 
interpreter process when user run paragraph. 


---

[GitHub] zeppelin issue #2678: [ZEPPELIN-3063] Notebook loses formatting when importi...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2678
  
Thanks for the review, have made the suggested changes


---

[GitHub] zeppelin pull request #2678: [ZEPPELIN-3063] Notebook loses formatting when ...

[prabhjyotsingh]

Github user prabhjyotsingh closed the pull request at:

https://github.com/apache/zeppelin/pull/2678


---

[GitHub] zeppelin pull request #2678: [ZEPPELIN-3063] Notebook loses formatting when ...

[prabhjyotsingh]

GitHub user prabhjyotsingh reopened a pull request:

https://github.com/apache/zeppelin/pull/2678

[ZEPPELIN-3063] Notebook loses formatting when importing from 0.6.x

### What is this PR for?
Notebook loses formatting (shows table instead of the graph) when importing 
from 0.6.x if the respective paragraph doesn't have result in it.


### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-3063](https://issues.apache.org/jira/browse/ZEPPELIN-3063)

### Screenshots (if appropriate)
Before:

![before](https://user-images.githubusercontent.com/674497/32978117-8d4d581a-cc61-11e7-8b48-af389f4be90d.gif)

After:

![after](https://user-images.githubusercontent.com/674497/32978119-95ca87c4-cc61-11e7-8276-9e1eab8711ef.gif)

### How should this be tested?
* Try importing 
[this](https://issues.apache.org/jira/secure/attachment/12898326/oldnotebook-0.6-clear.json)
 notebook, and then on running this notebook, the second paragraph should 
display BarChart instead of a table.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3063

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2678


commit 1975c74e7758d8a52d3ccc68f098cc5d3f126b74
Author: prabhjyotsingh 
Date:   2017-11-18T07:13:57Z

ZEPPELIN-3063: Notebook loses formatting when importing from 0.6.x

Change-Id: I8132db6e24cfb499a770b5bed4eb475754f0db78

commit 3824eed015cbcb164ef5f3267802f75a174c7d60
Author: Prabhjyot 
Date:   2017-11-19T03:10:11Z

Add comment support for 0.6




---

[GitHub] zeppelin issue #2668: ZEPPELIN-3051. Support Interpreter Process Recovery

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2668
  
Is there a way to restart the interpreter process?





---