[GitHub] zeppelin issue #2802: ZEPPELIN-3236. Make grpc framesize configurable

[Tagar]

Github user Tagar commented on the issue:

https://github.com/apache/zeppelin/pull/2802
  
> ERROR [2018-02-14 10:39:10,922] ({grpc-default-executor-3} 
IPythonClient.java[onError]:138) - Fail to call IPython grpc
> io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: 
io.grpc.netty.NettyClientTransport$3: Frame size 216695976 exceeds maximum: 
4194304.
> at io.grpc.Status.asRuntimeException(Status.java:543)
> at 
io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:395)
> at 
io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:426)
> at 
io.grpc.internal.ClientCallImpl.access$100(ClientCallImpl.java:76)
> at 
io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.close(ClientCallImpl.java:512)
> at 
io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.access$700(ClientCallImpl.java:429)
> at 
io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:544)
> at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:52)
> at 
io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:117)
> at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
>  INFO [2018-02-14 10:39:10,923] ({grpc-default-worker-ELG-1-2} 
AbstractClientStream2.java[inboundDataReceived]:249) - Received data on closed 
stream
>  INFO [2018-02-14 10:39:10,924] ({grpc-default-worker-ELG-1-2} 
AbstractClientStream2.java[inboundDataReceived]:249) - Received data on closed 
stream
>  INFO [2018-02-14 10:39:10,925] ({grpc-default-worker-ELG-1-2} 
AbstractClientStream2.java[inboundDataReceived]:249) - Received data on closed 
stream
> 

@zjffdu that's what I have.. is this helpful? It seems contain full 
exception stack. 


---

Re: [DISCUSS] semicolons in javascript

[Prabhjyot Singh]

Have created a PR 2804 ,
which will force semicolon in JS.

On 17 February 2018 at 19:22, Renjith Kamath 
wrote:

> +1 for adding semicolons, makes the code more readable.
> @prabhjyot we may need to review the whole eslintrc and improve the style
> guidelines.
>
> Thanks & Regards,
> RK
>
> On Sat, Feb 17, 2018 at 12:00 PM, Jongyoul Lee  wrote:
>
> > Hi,
> >
> > I like to this kind of discussion. Currently, we don't have strict rules
> > for developing frontend and it might cause a problem. I hope you could
> > summarize and fix all of these issues.
> >
> > Thanks,
> > JL
> >
> > On Fri, Feb 16, 2018 at 10:02 PM, Prabhjyot Singh <
> > prabhjyotsi...@gmail.com>
> > wrote:
> >
> > > Dear Zeppelin devs,
> > >
> > > In our current implementation of "eslintrc" semicolons disallow, and
> > > generally, there are two schools of thought. The first is that we
> should
> > > treat ASI as if it didn’t exist and always include semicolons manually.
> > The
> > > rationale is that it’s easier to always include semicolons than to try
> to
> > > remember when they are or are not required, and thus decreases the
> > > possibility of introducing an error.
> > >
> > > However, the ASI mechanism can sometimes be tricky to people who are
> > using
> > > semicolons. For example, consider this code:
> > >
> > > *return*
> > > *{*
> > > *name: "ESLint"*
> > > *};*
> > > This may look like a return statement that returns an object literal,
> > > however, the JavaScript engine will interpret this code as:
> > >
> > > *return;*
> > > *{*
> > > *name: "ESLint";*
> > > *}*
> > > Effectively, a semicolon is inserted after the return statement,
> causing
> > > the code below it (a labeled literal inside a block) to be unreachable.
> > > This rule and the no-unreachable rule will protect your code from such
> > > cases.
> > >
> > >
> > > Want to know your opinion on should we change this (eslintrc) to always
> > > allow semicolons, which will make JS less error/accident prone and more
> > > readable.
> > >
> > >
> > > --
> > > Thankx and Regards,
> > >
> > > Prabhjyot Singh
> > >
> >
> >
> >
> > --
> > 이종열, Jongyoul Lee, 李宗烈
> > http://madeng.net
> >
>



-- 
Thankx and Regards,

Prabhjyot Singh

[jira] [Created] (ZEPPELIN-3245) checkstyle/eslintrc for zeppelin-web (JavaScript)

[Prabhjyot Singh (JIRA)]

Prabhjyot Singh created ZEPPELIN-3245:
-

 Summary: checkstyle/eslintrc for zeppelin-web (JavaScript)
 Key: ZEPPELIN-3245
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3245
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Prabhjyot Singh
Assignee: Prabhjyot Singh






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zeppelin pull request #2805: [ZEPPELIN-3240] Zeppelin server fail to start i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2805


---

[GitHub] zeppelin issue #2808: [ZEPPELIN-3243] fix IndexOutOfBoundsException when 'No...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2808
  
LGTM


---

[jira] [Created] (ZEPPELIN-3244) Interpreter Restart from Note Page not working with Per Note Isolation + scoped.

[Andreas Weise (JIRA)]

Andreas Weise created ZEPPELIN-3244:
---

 Summary: Interpreter Restart from Note Page not working with Per 
Note Isolation + scoped.
 Key: ZEPPELIN-3244
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3244
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-zengine
Affects Versions: 0.8.0, 0.9.0
Reporter: Andreas Weise
 Attachments: ZEEPELIN-3244.gif

Restarting of interpreter does not work from note page, when it runs with 
scoped isolation per note.

See screenshot attached.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zeppelin pull request #2808: [ZEPPELIN-3243] fix IndexOutOfBoundsException w...

[weand]

GitHub user weand opened a pull request:

https://github.com/apache/zeppelin/pull/2808

[ZEPPELIN-3243] fix IndexOutOfBoundsException when 'No interpreter is 
binded to this note'

### What is this PR for?
I observed IndexOutOfBoundsException when using zeppelin locally on an 
existing notebook repository and with fresh interpreter.json file.
The default Zeppelin behavior when using existing notebooks is the manual 
binding of the interpreter settings, which works fine. This PR simply avoids 
the IndexOutOfBoundsException.

### What type of PR is it?
Bug Fix

### Todos
-

### What is the Jira issue?

[https://issues.apache.org/jira/browse/ZEPPELIN-3243](https://issues.apache.org/jira/browse/ZEPPELIN-3243)

### How should this be tested?
- manual

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/weand/zeppelin ZEPPELIN-3243

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2808.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2808


commit b97a38eeed89573e64059dc862ab9bc05700ce7d
Author: Andreas Weise 
Date:   2018-02-18T11:55:32Z

ZEPPELIN-3243 fix IndexOutOfBoundsException when 'No interpreter is
binded to this note'




---

[jira] [Created] (ZEPPELIN-3243) No interpreter is binded to this note -> IndexOutOfBoundsException

[Andreas Weise (JIRA)]

Andreas Weise created ZEPPELIN-3243:
---

 Summary: No interpreter is binded to this note -> 
IndexOutOfBoundsException
 Key: ZEPPELIN-3243
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3243
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-zengine
Reporter: Andreas Weise


When for some reason you run a fresh Zeppelin installation on existing notes, 
an IndexOutOfBoundsException is raised.

Also the following message is written to log before the exception: 
_InterpreterFactory.java[getInterpreter]:59) - No interpreter is binded to this 
note_

This log message is sufficient. The exception is misleading and should be fixed.
{noformat}
ERROR [2018-02-18 12:40:23,669] ({qtp300031246-16} 
InterpreterFactory.java[getInterpreter]:59) - No interpreter is binded to this 
note: 2D5X64BP4
ERROR [2018-02-18 12:40:23,669] ({qtp300031246-16} 
NotebookServer.java[onMessage]:366) - Can't handle message: 
{"op":"EDITOR_SETTING","data":{"paragraphId":"20180121-140654_1801623812","magic":"spark"},"principal":"anonymous","ticket":"anonymous","roles":"[]"}
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
at java.util.ArrayList.rangeCheck(ArrayList.java:653)
at java.util.ArrayList.get(ArrayList.java:429)
at 
org.apache.zeppelin.interpreter.InterpreterSettingManager.getDefaultInterpreterSetting(InterpreterSettingManager.java:417)
at 
org.apache.zeppelin.interpreter.InterpreterSettingManager.getEditorSetting(InterpreterSettingManager.java:465)
at 
org.apache.zeppelin.socket.NotebookServer.getEditorSetting(NotebookServer.java:2440)
at org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:348)
at 
org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:59)
at 
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(Jetty{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zeppelin pull request #2806: [ZEPPELIN-3241] fix NPE when restarting Interpr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2806


---

[GitHub] zeppelin pull request #2807: ZEPPELIN-3234. z.show() compatibility with prev...

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2807

ZEPPELIN-3234. z.show() compatibility with previous release

### What is this PR for?
Enhance the ZeppelinContext in IPySparkInterpreter


### What type of PR is it?
[Bug Fix | Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3234

### How should this be tested?
* Unit test is added

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3234

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2807.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2807


commit 39637eea17a52e42853f40a391227a9377eafcde
Author: Jeff Zhang 
Date:   2018-02-15T06:19:00Z

ZEPPELIN-3234. z.show() compatibility with previous release




---