[GitHub] zeppelin issue #2818: ZEPPELIN-3246. Need option for automatically restart t...

2018-03-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2818
  
It would only restart that users livy session. 


---


[GitHub] zeppelin issue #2818: ZEPPELIN-3246. Need option for automatically restart t...

2018-03-05 Thread bikassaha
Github user bikassaha commented on the issue:

https://github.com/apache/zeppelin/pull/2818
  
zeppelin.livy.restart_dead_session - Is this an interpreter level setting? 
Will it start only that users livy session?


---


[GitHub] zeppelin issue #2818: ZEPPELIN-3246. Need option for automatically restart t...

2018-03-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2818
  
For whatever interpreter setting, user can set it via %conf.

When `zeppelin.livy.restart_dead_session` is turned on. dead livy session 
will be restarted automatically.
When it is turned off, proper message will be displayed in frontend, user 
can restart livy interpreter by himself after seeing this message. 




---


[GitHub] zeppelin issue #2818: ZEPPELIN-3246. Need option for automatically restart t...

2018-03-05 Thread bikassaha
Github user bikassaha commented on the issue:

https://github.com/apache/zeppelin/pull/2818
  
Can this be specified on a per notebook basis using the %conf interpreter? 
It may be difficult to turn this on globally because of the various reasons why 
sessions may die.

Would it be better for the error message to ask the user to restart the 
interpreter from the notebook page itself?


---


[GitHub] zeppelin issue #2405: [ZEPPELIN-2640] Roles are not getting honored from shi...

2018-03-05 Thread paramount2u
Github user paramount2u commented on the issue:

https://github.com/apache/zeppelin/pull/2405
  
@prabhjyotsingh thank you for feedback 


---


[GitHub] zeppelin pull request #2838: ZEPPELIN-3277. NotebookServerTest.testMakeSureN...

2018-03-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2838


---


[GitHub] zeppelin pull request #2838: ZEPPELIN-3277. NotebookServerTest.testMakeSureN...

2018-03-05 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2838

ZEPPELIN-3277. 
NotebookServerTest.testMakeSureNoAngularObjectBroadcastToWebsocketWhoFireTheEvent
 fails


### What is this PR for?

Trivial fix for flaky test, see the comment for details. 


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3277

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3277

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2838.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2838


commit 68827d71319b6e3175d7f6021900c0a7b07ac6b9
Author: Jeff Zhang 
Date:   2018-03-05T07:52:14Z

ZEPPELIN-3277. 
NotebookServerTest.testMakeSureNoAngularObjectBroadcastToWebsocketWhoFireTheEvent
 fails




---


[GitHub] zeppelin pull request #2837: ZEPPELIN-3279. [FlakyTest] NotebookTest.testPer...

2018-03-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2837


---


[GitHub] zeppelin pull request #2837: ZEPPELIN-3279. [FlakyTest] NotebookTest.testPer...

2018-03-05 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2837

ZEPPELIN-3279. [FlakyTest] 
NotebookTest.testPerSessionInterpreterCloseOnUnbindInterpreterSetting


### What is this PR for?
The root cause of this flaky test is that hashCode doesn't represent an 
unique id of object. This PR just use IdGenerator for unique id and also 
combine process id. 


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3279

### How should this be tested?
* CI Pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3279

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2837.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2837


commit 063d4eed3f1b0c2b917d223d0c39b5576c0ccdbf
Author: Jeff Zhang 
Date:   2018-03-05T06:38:00Z

ZEPPELIN-3279. [FlakyTest] 
NotebookTest.testPerSessionInterpreterCloseOnUnbindInterpreterSetting




---


[GitHub] zeppelin issue #2405: [ZEPPELIN-2640] Roles are not getting honored from shi...

2018-03-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2405
  
@paramount2u sounds like something to do with your activeDirectory 
configuration not correct, and if you feel issue can be reproduced, please 
create a new JIRA.


---


[GitHub] zeppelin issue #2412: [ZEPPELIN-2641] Change encoding to UTF-8 when sending ...

2018-03-05 Thread big-loser
Github user big-loser commented on the issue:

https://github.com/apache/zeppelin/pull/2412
  
@zjffdu 
Thanks for your reply, our only difference is the python version. I checked 
again to confirm.


---


[GitHub] zeppelin pull request #2808: [ZEPPELIN-3243] fix IndexOutOfBoundsException w...

2018-03-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2808


---


[GitHub] zeppelin pull request #2836: ZEPPELIN-3291. Throw exception instead of retur...

2018-03-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2836


---


[GitHub] zeppelin pull request #2832: ZEPPELIN-3254. Enable one build of zeppelin to ...

2018-03-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2832


---


[GitHub] zeppelin pull request #2836: ZEPPELIN-3291. Throw exception instead of retur...

2018-03-05 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2836

ZEPPELIN-3291. Throw exception instead of return null for 
InterpreterFactory.getInterpreter


### What is this PR for?
Minor code refactoring to throw exception when no interpreter is found


### What type of PR is it?
[Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3291

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3291

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2836


commit bee319ccc069df3a76f27996d5447bf112da15ba
Author: Jeff Zhang 
Date:   2018-03-05T04:58:19Z

ZEPPELIN-3291. Throw exception instead of return null for 
InterpreterFactory.getInterpreter




---


[GitHub] zeppelin issue #2832: ZEPPELIN-3254. Enable one build of zeppelin to work wi...

2018-03-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2832
  
Will merge if no more comments 


---


[GitHub] zeppelin issue #2412: [ZEPPELIN-2641] Change encoding to UTF-8 when sending ...

2018-03-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2412
  
@big-loser It works for me. I am using zeppelin master and livy 0.5, python3
![screen shot 2018-03-06 at 9 23 40 
am](https://user-images.githubusercontent.com/164491/37009053-18b00840-2120-11e8-891a-29a28cd73d70.png)



---


[GitHub] zeppelin issue #2808: [ZEPPELIN-3243] fix IndexOutOfBoundsException when 'No...

2018-03-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2808
  
LGTM


---


[jira] [Created] (ZEPPELIN-3294) Flaky test: LivyInterpreterIT

2018-03-05 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-3294:


 Summary: Flaky test: LivyInterpreterIT
 Key: ZEPPELIN-3294
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3294
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Jeff Zhang


{code:java}

DEBUG [2018-03-05 13:00:52,833] ({main} 
BaseLivyInterpreter.java[callRestAPI]:677) - Call rest api in 
http://travis-job-a63cbdd9-7932-4729-be2e-6acf4d21485b:8998/sessions/4/statements,
 method: POST, jsonData: {
  "code": "cat(a)"
}
DEBUG [2018-03-05 13:00:52,850] ({main} 
BaseLivyInterpreter.java[callRestAPI]:723) - Get response, StatusCode: 201, 
responseBody: 
{"id":2,"code":"cat(a)","state":"available","output":null,"progress":0.0}{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] zeppelin issue #2808: [ZEPPELIN-3243] fix IndexOutOfBoundsException when 'No...

2018-03-05 Thread weand
Github user weand commented on the issue:

https://github.com/apache/zeppelin/pull/2808
  
We did not face any other IndexOutOfBoundException so far. So I would 
propose to merge that first.


---


[jira] [Created] (ZEPPELIN-3293) extraneous lines if data in a column has "\n" character

2018-03-05 Thread Ruslan Dautkhanov (JIRA)
Ruslan Dautkhanov created ZEPPELIN-3293:
---

 Summary: extraneous lines if data in a column has "\n" character
 Key: ZEPPELIN-3293
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3293
 Project: Zeppelin
  Issue Type: Bug
  Components: front-end
Affects Versions: 0.8.0, 0.9.0
Reporter: Ruslan Dautkhanov


|Apache Zeppelin uses angular-ui/ui-grid for data tables visualization.
If data has "\n" characters present, extra table lines are present.
[!https://user-images.githubusercontent.com/3013418/36998541-7e6a4fe8-207a-11e8-8ea2-40ad9d1773cb.png!|https://user-images.githubusercontent.com/3013418/36998541-7e6a4fe8-207a-11e8-8ea2-40ad9d1773cb.png]
Is there is an option to switch this behvior off. We think a better options 
could be: * display "\n" as whitespace;
 * display "\n" as "\n" (backslash, "n" character).

Thanks.|
 
[https://github.com/angular-ui/ui-grid/issues/6589]
 
cc [~prabhjyotsi...@apache.com]
 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...

2018-03-05 Thread Tagar
Github user Tagar commented on the issue:

https://github.com/apache/zeppelin/pull/2835
  
@weand I just logged in https://issues.apache.org/jira/browse/ZEPPELIN-3292 
for data duplication )
I don't think it's related to this PR?


---


[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...

2018-03-05 Thread weand
Github user weand commented on the issue:

https://github.com/apache/zeppelin/pull/2835
  
height issue is solved. thanks.

but now got the bahvior, that results are duplicated:
[https://ibin.co/3trkDDqHas5m.gif](https://ibin.co/3trkDDqHas5m.gif)

and the following is logged into console:
`result.controller.js?55cc:685` 
```
Graph drawing error TypeError: Cannot read property 'core' of undefined
at TableVisualization.refresh (eval at  
(app.bundle.js:1968), :172:26)
at TableVisualization.activate (eval at  
(app.bundle.js:1962), :108:14)
at afterLoaded (eval at  (app.bundle.js:2172), 
:699:31)
at retry (eval at  (app.bundle.js:2172), :235:7)
at angular.js:19374
at completeOutstandingRequest (angular.js:5955)
at angular.js:6234
```


---


[jira] [Created] (ZEPPELIN-3292) angular-ui/ui-grid duplicates rows if "

2018-03-05 Thread Ruslan Dautkhanov (JIRA)
Ruslan Dautkhanov created ZEPPELIN-3292:
---

 Summary: angular-ui/ui-grid duplicates rows if "
 Key: ZEPPELIN-3292
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3292
 Project: Zeppelin
  Issue Type: Bug
Reporter: Ruslan Dautkhanov






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] zeppelin issue #2833: ZEPPELIN-3286. Run All Paragraphs stops if there is a ...

2018-03-05 Thread Tagar
Github user Tagar commented on the issue:

https://github.com/apache/zeppelin/pull/2833
  
thanks Jeff! will validate a bit later today.


---


Re: Unmodifiable interpreter properties

2018-03-05 Thread Karan Sewani
Well


You can take away interpreter editing rights from user altogether.


This feature would be there in zeppelin 0.8.0, for 0.7.3 you can apply 
following patch and build it from source.


https://github.com/apache/zeppelin/pull/2526/files


Best

Karan


From: Jhon Anderson Cardenas Diaz 
Sent: Friday, March 2, 2018 9:51:54 PM
To: dev@zeppelin.apache.org; us...@zeppelin.apache.org
Subject: Unmodifiable interpreter properties

Hi fellow Zeppelin users.

I would like to know if is there a way in zeppelin to set interpreter 
properties that can not be changed by the user from the graphic interface.

An example use case in which this can be useful is if we want that zeppelin 
users can not kill jobs from the spark ui; for this you must modify the 
property "spark.ui.killEnabled" with value FALSE. The problem is that the user 
can change this property from the interpreter screen and enable the feature 
again.

I am wondering if maybe is there some attribute in the properties registered in 
interpreter-setting.json that makes that property readonly (for end user) or 
something like that.

Thank you in advance!.


Embed chart in iFrame

2018-03-05 Thread afancy
Dear All,

I met a permission problem when I embedded a chart into a web page through
iFrame.
It seems that the current implementation only allows the charts that
support anonymous access to be embedded into a web page. It also means that
my notebook should be allowed anonymous access. But, this is not I want.

May I ask if there is any solution that my notebook is not available to the
public, except the charts so that I could embed it into other web pages.

Thanks!!

/afancy


[GitHub] zeppelin issue #2412: [ZEPPELIN-2641] Change encoding to UTF-8 when sending ...

2018-03-05 Thread big-loser
Github user big-loser commented on the issue:

https://github.com/apache/zeppelin/pull/2412
  
@qwemicheal @zjffdu 

Today I clone the main branch and build it successfully.
But I use the livy interpreter, still can not normally display or output 
Chinese.

How do I make Chinese normal display?


![test](https://user-images.githubusercontent.com/10458694/36977851-91760864-20bd-11e8-8e89-300ec8b7893a.PNG)



---


[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...

2018-03-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2835
  
@Tagar This PR fixes 
[ZEPPELIN-3272](https://issues.apache.org/jira/browse/ZEPPELIN-3272) as well, 
can you help review this.


---


[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...

2018-03-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2835
  
@weand  @r-kamath  Can you help review this PR.


---


[GitHub] zeppelin pull request #2835: [ZEPPELIN-3289] Table not using full height aft...

2018-03-05 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2835

[ZEPPELIN-3289] Table not using full height after paragraph height has been 
changed

### What is this PR for?
Changing paragraph height does not work correctly anymore in conjunction 
with table output. Refer screen shot:

![image](https://user-images.githubusercontent.com/674497/36977669-f28c77a2-20a7-11e8-854a-0b6d40973700.png)

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-3289](https://issues.apache.org/jira/browse/ZEPPELIN-3289)
* [ZEPPELIN-3272](https://issues.apache.org/jira/browse/ZEPPELIN-3272)

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3289

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2835.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2835


commit dd6a6d1211d612ab38af7bc279061bfe23430747
Author: Prabhjyot Singh 
Date:   2018-03-05T13:29:19Z

ZEPPELIN-3289: refresh() also updates height

Change-Id: I001421ee174ed2fa06cecfeb845916097fdf1464




---


[GitHub] zeppelin issue #2405: [ZEPPELIN-2640] Roles are not getting honored from shi...

2018-03-05 Thread paramount2u
Github user paramount2u commented on the issue:

https://github.com/apache/zeppelin/pull/2405
  
Hi,

After creating build-0.8.0-SNAPSHOT locally and tested group-role mapping. 
Using the below configurations (shiro.ini file) I see the user mapped no roles 
in the log ("roles":"[]"). @prabhjyotsingh can you please help me with that ?

[main]
activeDirectoryRealm = org.apache.zeppelin.realm.ActiveDirectoryGroupRealm
activeDirectoryRealm.systemUsername = USERNAME
activeDirectoryRealm.systemPassword = PASSWORD
activeDirectoryRealm.principalSuffix = @AD.COMPANY.COM
activeDirectoryRealm.searchBase = dc=AD,dc=COMPANY,dc=COM
activeDirectoryRealm.url = ldap://ad.company.com:389
activeDirectoryRealm.groupRolesMap = "CN=ADGROUP,OU=Service Security 
Group,OU=Service-Units,DC=AD,DC=COMPANY,DC=COM":admin
activeDirectoryRealm.authorizationCachingEnabled = true

securityManager.realm = $activeDirectoryRealm

sessionManager = org.apache.shiro.web.session.mgt.DefaultWebSessionManager
cacheManager = org.apache.shiro.cache.MemoryConstrainedCacheManager
securityManager.cacheManager = $cacheManager
securityManager.sessionManager = $sessionManager
securityManager.sessionManager.globalSessionTimeout = 8640
shiro.loginUrl = /api/login

[rules]
admin = *

[urls]
/api/version = anon
/api/interpreter/** = authc, roles[admin]
/api/configurations/** = authc, roles[admin]
/api/credential/** = authc, roles[admin]
#/** = anon
/** = authc
 


---