[GitHub] zeppelin issue #2915: ZEPPELIN-3391 Incorrect status shown for '%livy2.conf'...

2018-04-11 Thread r-kamath
Github user r-kamath commented on the issue:

https://github.com/apache/zeppelin/pull/2915
  
@zjffdu thanks for the pointer. I didn't check out the tests. My bad!


---


[GitHub] zeppelin issue #2914: [ZEPPELIN-3350] Don't allow set cronExecutionUser

2018-04-11 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2914
  
@weand Do you see any issue when logged out ? 


---


[GitHub] zeppelin issue #2915: ZEPPELIN-3391 Incorrect status shown for '%livy2.conf'...

2018-04-11 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2915
  
Thanks @r-kamath , but I don't think this is the fix. As you can see we 
have unit test to cover this. 
https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/test/java/org/apache/zeppelin/interpreter/ConfInterpreterTest.java#L62

This  should due to something bug else 


---


[jira] [Created] (ZEPPELIN-3401) Deadlock while restarting interpreter

2018-04-11 Thread Harel Ben Attia (JIRA)
Harel Ben Attia created ZEPPELIN-3401:
-

 Summary: Deadlock while restarting interpreter
 Key: ZEPPELIN-3401
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3401
 Project: Zeppelin
  Issue Type: Bug
  Components: Core
Affects Versions: 0.8.0
 Environment: java version "1.8.0_144"
Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)

linux info: 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 
x86_64 x86_64 x86_64 GNU/Linux
Reporter: Harel Ben Attia
 Attachments: jstack.out

After running properly for ~15 days, the zeppelin UI started at some point to 
hang forever when restarting an interpreter. trying to analyze this shows that 
the server is deadlocked. The jstack output is not descriptive enough, because 
running it without -F didn't work, but shows a deadlock between two qtp threads.

The status of the blocked threads seems very similar to ZEPPELIN-1834, with 
many getParagraph/s() calls, but can't really ascertain that it's the same bug, 
especially with the fact that ZEPPELIN-1834 seems to be marked as solved for 
0.7.0.

Only a zeppelin restart solved the issue.

We're running in user-scoped sessions (spark interpreter).

We're running zeppelin-0.8.0-SNAPSHOT from the branch-0.8 branch commit 
714eb963d6b58df88239830ee487fe19613d1911 . Additional commits in that branch 
since then do not seem to be related.

 

Will be glad to provide more info if needed.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] zeppelin issue #2914: [ZEPPELIN-3350] Don't allow set cronExecutionUser

2018-04-11 Thread weand
Github user weand commented on the issue:

https://github.com/apache/zeppelin/pull/2914
  
@zjffdu are you sure this works when logged out? i followed the call stack 
and I'm wondering if there would happen NPE if no AuthenticationInfo is present:
org.apache.zeppelin.notebook.Note.runAll(AuthenticationInfo, boolean)
> org.apache.zeppelin.notebook.Paragraph.execute(boolean) : Line 353
> 
org.apache.zeppelin.notebook.Paragraph.setAuthenticationInfo(AuthenticationInfo)
 : Line 209 << NPE


---


[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

2018-04-11 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue:

https://github.com/apache/zeppelin/pull/2903
  
Oops! I must have messed up somewhere!

I've corrected the style issues now @felixcheung, and the one remaining 
failure appears to be a build script problem unrelated to my code. 

Thanks!


---


[GitHub] zeppelin issue #2915: ZEPPELIN-3391 Incorrect status shown for '%livy2.conf'...

2018-04-11 Thread r-kamath
Github user r-kamath commented on the issue:

https://github.com/apache/zeppelin/pull/2915
  
will merge this if there are no more discussions


---


[GitHub] zeppelin issue #2920: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread mebelousov
Github user mebelousov commented on the issue:

https://github.com/apache/zeppelin/pull/2920
  
@zjffdu 
Another repo and another PR, but the same error
https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/365002216



---


[GitHub] zeppelin pull request #2920: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread mebelousov
Github user mebelousov closed the pull request at:

https://github.com/apache/zeppelin/pull/2920


---


[GitHub] zeppelin pull request #2920: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread mebelousov
GitHub user mebelousov reopened a pull request:

https://github.com/apache/zeppelin/pull/2920

[ZEPPELIN-2679] JDBC. precode for session

### What is this PR for?
We have a precode for interpreter (all interpreters) which executes once 
after start interpreter. With it we can create shared code that will be 
available in the paragraph, create tables in the database and etc.
This precode for jdbc only which executes before run paragraph in same 
session (sql). In this precode we can declare session variables that will be 
available when you run paragraph (any sql which will be executed before the 
paragraph). For example `set application_name='#{user};`
Previous discussion in #2442 

### What type of PR is it?
Feature

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2679

### How should this be tested?
(jdbc interpreter, postgres)
1. set property **default.statementPrecode** `set 
application_name='#{user}';`
2. run paragraph `select current_setting('application_name');`

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-2679

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2920.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2920


commit bd3d80952ca56e709379632318ba1193a17338ae
Author: Tinkoff DWH 
Date:   2017-06-23T11:58:20Z

[ZEPPELIN-2679] jdbc. precode for session

commit ae7a0d63966a1ddbf89292715221d041ecdc2b74
Author: Tinkoff DWH 
Date:   2017-06-26T04:14:11Z

[ZEPPELIN-2679] tests

commit 719d0a2fdf73a478c4475c8147da8d26646933ff
Author: isys.mreshetov 
Date:   2017-06-29T04:35:10Z

ZEPPELIN-2679 docs

commit 7bba0db8ac7f28c7c35798e3292ec0e8dd08fde8
Author: tinkoff-dwh 
Date:   2018-03-13T09:49:56Z

ZEPPELIN-2679 rename session to statement

commit cd0d6ed5dc455bb58d551519732b274121df5198
Author: tinkoff-dwh 
Date:   2018-03-13T11:12:12Z

Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2679

commit 07b41c5110430f3b13ca81088b29fa5eae3d0734
Author: tinkoff-dwh 
Date:   2018-03-13T12:15:49Z

ZEPPELIN-2679 rename test methods

commit f7529cabe9d68202b6c22f5162d527844d48ba4f
Author: tinkoff-dwh 
Date:   2018-03-14T05:28:21Z

Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2679

# Conflicts:
#   jdbc/src/test/java/org/apache/zeppelin/jdbc/JDBCInterpreterTest.java

commit 00aeabf5dcc9b78ce40482ae24aed41da373
Author: tinkoff-dwh 
Date:   2018-03-14T05:37:48Z

ZEPPELIN-2679 fix checkstyle

commit e9d36d2847b3c0246b7242c2d37b1ccd75a262ad
Author: mebelousov 
Date:   2018-04-09T06:49:31Z

Merge remote-tracking branch 'apache/master' into ZEPPELIN-2679

# Conflicts:
#   jdbc/src/test/java/org/apache/zeppelin/jdbc/JDBCInterpreterTest.java

commit 11f89a590eb5e75830056e2692167cfc72c8124e
Author: mebelousov 
Date:   2018-04-09T09:45:56Z

ZEPPELIN-2679 Small fix in docs




---


[GitHub] zeppelin pull request #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread tinkoff-dwh
Github user tinkoff-dwh closed the pull request at:

https://github.com/apache/zeppelin/pull/2442


---


[GitHub] zeppelin pull request #2920: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread mebelousov
GitHub user mebelousov opened a pull request:

https://github.com/apache/zeppelin/pull/2920

[ZEPPELIN-2679] JDBC. precode for session

### What is this PR for?
We have a precode for interpreter (all interpreters) which executes once 
after start interpreter. With it we can create shared code that will be 
available in the paragraph, create tables in the database and etc.
This precode for jdbc only which executes before run paragraph in same 
session (sql). In this precode we can declare session variables that will be 
available when you run paragraph (any sql which will be executed before the 
paragraph). For example `set application_name='#{user};`
Previous discussion in #2442 

### What type of PR is it?
Feature

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2679

### How should this be tested?
(jdbc interpreter, postgres)
1. set property **default.statementPrecode** `set 
application_name='#{user}';`
2. run paragraph `select current_setting('application_name');`

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-2679

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2920.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2920


commit bd3d80952ca56e709379632318ba1193a17338ae
Author: Tinkoff DWH 
Date:   2017-06-23T11:58:20Z

[ZEPPELIN-2679] jdbc. precode for session

commit ae7a0d63966a1ddbf89292715221d041ecdc2b74
Author: Tinkoff DWH 
Date:   2017-06-26T04:14:11Z

[ZEPPELIN-2679] tests

commit 719d0a2fdf73a478c4475c8147da8d26646933ff
Author: isys.mreshetov 
Date:   2017-06-29T04:35:10Z

ZEPPELIN-2679 docs

commit 7bba0db8ac7f28c7c35798e3292ec0e8dd08fde8
Author: tinkoff-dwh 
Date:   2018-03-13T09:49:56Z

ZEPPELIN-2679 rename session to statement

commit cd0d6ed5dc455bb58d551519732b274121df5198
Author: tinkoff-dwh 
Date:   2018-03-13T11:12:12Z

Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2679

commit 07b41c5110430f3b13ca81088b29fa5eae3d0734
Author: tinkoff-dwh 
Date:   2018-03-13T12:15:49Z

ZEPPELIN-2679 rename test methods

commit f7529cabe9d68202b6c22f5162d527844d48ba4f
Author: tinkoff-dwh 
Date:   2018-03-14T05:28:21Z

Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2679

# Conflicts:
#   jdbc/src/test/java/org/apache/zeppelin/jdbc/JDBCInterpreterTest.java

commit 00aeabf5dcc9b78ce40482ae24aed41da373
Author: tinkoff-dwh 
Date:   2018-03-14T05:37:48Z

ZEPPELIN-2679 fix checkstyle

commit e9d36d2847b3c0246b7242c2d37b1ccd75a262ad
Author: mebelousov 
Date:   2018-04-09T06:49:31Z

Merge remote-tracking branch 'apache/master' into ZEPPELIN-2679

# Conflicts:
#   jdbc/src/test/java/org/apache/zeppelin/jdbc/JDBCInterpreterTest.java

commit 11f89a590eb5e75830056e2692167cfc72c8124e
Author: mebelousov 
Date:   2018-04-09T09:45:56Z

ZEPPELIN-2679 Small fix in docs




---


[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2442
  
Could you create another PR to trigger the build ?


---


[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread mebelousov
Github user mebelousov commented on the issue:

https://github.com/apache/zeppelin/pull/2442
  
Cache is clean now. I try to retrigger from both accounts. The result is 
the sameю


---


[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2442
  
ping @tinkoff-dwh @mebelousov 


---


[GitHub] zeppelin issue #2918: [ZEPPELIN-3399] Tests failing with no changes - ShellS...

2018-04-11 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2918
  
@zjffdu 


---


[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

2018-04-11 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2903
  
still have errors on this link 
https://travis-ci.org/sanjaydasgupta/zeppelin/builds/363808230?



---


[GitHub] zeppelin issue #2919: ZEPPELIN-3375: Make PySparkInterpreter extends PythonI...

2018-04-11 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2919
  
@felixcheung @Leemoonsoo Could you help review it ? Thanks


---