[GitHub] zeppelin pull request #3069: ZEPPELIN-3621. Refactor getInterpreterInTheSame...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3069


---

[jira] [Created] (ZEPPELIN-3652) Remove reflection in SparkInterpreter

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3652:


 Summary: Remove reflection in SparkInterpreter
 Key: ZEPPELIN-3652
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3652
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Jeff Zhang


Since we drop support spark before 1.6, it is not necessary to use reflection. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Zeppelin distributed architecture design

[liuxun]

@Jongyoul Lee：
Thank you for your attention.

Indeed, as you said, the `Copycat` project has been closed and has been 
migrated to `https://github.com/atomix/atomix`.

I also considered this issue during development.
The main reason was that it was enough to realize Raft using `Copycat` at the 
time, and it was not considered too long.

Today, I took a look at the documentation of atomix, 
https://atomix.io/docs/latest/user-manual/ 
 , 
which has a lot of features, such as broadcasting messages in the cluster, 
detecting cluster events... ,
From the perspective of zeppelin's long-term development, it is better to use 
atomix.
So, I will switch the Raft protocol algorithm library to atomix, which is not 
difficult to modify.

Struggle for zeppelin!!! :-)


> 在 2018年7月24日，上午9:35，Jongyoul Lee  写道：
> 
> First of all, thank you for your effort and contribution.
> 
> I read it carefully today, and personally, it's a very nice feature and
> idea.
> 
> Let's discuss it and improve more concretely. I also left comments on the
> doc.
> 
> And I have a simple question.
> 
> `Copycat`, which you used to implement it, is deprecated by owner[1] and
> moved under https://github.com/atomix/atomix/. I'm afraid of it. Do you
> have any reason to use this library? It's even SNAPSHOT version.
> 
> Regards,
> JL
> 
> [1]: https://github.com/atomix/copycat
> 
> On Sat, Jul 21, 2018 at 2:07 AM, liuxun  wrote:
> 
>> HI：
>> 
>> In order to more intuitively express the actual use of distributed
>> zeppelin clusters.
>> I updated this design document, starting with the 16th page of the
>> document, adding 2 GIF animations showing the operation record screen of
>> the zeppelin cluster we are using now.
>> https://docs.google.com/document/d/1a8QLSyR3M5AhlG1GIYuDTj6bwazeu
>> VDKCRRBm-Qa3Bw/edit# > 1a8QLSyR3M5AhlG1GIYuDTj6bwazeuVDKCRRBm-Qa3Bw/edit#>
>> 
>> Distributed clustered zeppelin is already in use at our company, and the
>> recorded screens are all real.
>> The first recorded screens GIF shows the following
>> Create a cluster of three zeppelin servers
>> Add 234, 235, 236 to the zeppelin.cluster.addr attribute in
>> zeppelin-site.xml to create a cluster
>> Start these 3 servers at the same time
>> Open the web pages of these 3 servers and prepare for the notebook
>> operation.
>> 
>> 
>> The second recorded screens GIF shows the following
>> Create an interpreter process in the cluster
>> Create a notebook on host234 and execute it, This action will create an
>> interpreter process in the server with free resources in the cluster.
>> You can then continue editing this notebook on host235 and execute it, You
>> can return results immediately without waiting for the time to create an
>> interpreter process.
>> Again, you can continue to edit this notebook on host236. And execute it,
>> you can return results immediately without waiting for the time to create
>> the interpreter process
>> The same notebook will reuse the first created interpreter process, so you
>> can get the execution result immediately on any server.
>> By looking at the background server process, you will find that host234,
>> host235, and host235 use the same interpreter process for the same notebook.
>> 
>> Originally, I wanted to record the interpreter process exception. The
>> cluster re-created the screenshot of the interpreter process in the idle
>> server, but I am too tired now.
>> There is time to record later.
>> 
>> 
>>> 在 2018年7月19日，上午7:36，Ruslan Dautkhanov  写道：
>>> 
>>> Thank you luxun,
>>> 
>>> I left a couple of comments in that google document.
>>> 
>>> --
>>> Ruslan Dautkhanov
>>> 
>>> 
>>> On Tue, Jul 17, 2018 at 11:30 PM liuxun > neliu...@163.com>> wrote:
>>> hi，Ruslan Dautkhanov
>>> 
>>> Thank you very much for your question. according to your advice, I added
>> 3 schematics to illustrate.
>>> 1. Distributed Zeppelin Deployment architecture diagram.
>>> 2. Distributed zeppelin Server fault tolerance diagram.
>>> 3. Distributed zeppelin Server & intp process fault tolerance diagram.
>>> 
>>> 
>>> The email attachment exceeded the size limit, so I reorganized the
>> document and updated it with Google Docs.
>>> https://docs.google.com/document/d/1a8QLSyR3M5AhlG1GIYuDTj6bwazeu
>> VDKCRRBm-Qa3Bw/edit?usp=sharing > 1a8QLSyR3M5AhlG1GIYuDTj6bwazeuVDKCRRBm-Qa3Bw/edit?usp=sharing>
>>> 
>>> 
 在 2018年7月18日，下午1:03，liuxun mailto:neliu...@163.com>>
>> 写道：
 
 hi，Ruslan Dautkhanov
 
 Thank you very much for your question. according to your advice, I
>> added 3 schematics to illustrate.
 1. Zeppelin Cluster architecture diagram.
 2. Distributed zeppelin Server fault tolerance diagram.
 3. Distributed zeppelin Server & intp process fault tolerance diagram.
 
 Later, I will merge the schematic into the system design document.
 
 
 
 
 
 
 
 
 
 
 
 
> 

[jira] [Created] (ZEPPELIN-3651) Umbrella of Integrate Apache Arrow

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3651:


 Summary: Umbrella of Integrate Apache Arrow
 Key: ZEPPELIN-3651
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3651
 Project: Zeppelin
  Issue Type: New Feature
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zeppelin pull request #3091: ZEPPELIN-3643. Put Shiro related thing in one p...

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/3091

ZEPPELIN-3643. Put Shiro related thing in one place

### What is this PR for?
Move all shiro related thing in one place


### What type of PR is it?
[Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3643

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3643

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3091.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3091


commit 5e12e94c394810d87e61308568b70b3bd32137b4
Author: Jeff Zhang 
Date:   2018-07-20T09:10:52Z

ZEPPELIN-3643. Put Shiro related thing in one place




---

[GitHub] zeppelin pull request #3085: [MINOR] Fix classpath issue in interpreter.sh

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3085


---

[GitHub] zeppelin issue #3090: [Zeppelin-3645] Add LSP Protocol completion support

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3090
  
@oxygen311 I can not install it. Let me know if there any other dependency 
I need to install

```
➜  zeppelin pr/3090 ✗ pip install pyls
Collecting pyls
  Using cached 
https://files.pythonhosted.org/packages/de/b7/5a056c2cac8fd19c905ae7451c2a60b9195531959c3770a49d6be4d905e3/pyls-0.1.3.zip
Complete output from command python setup.py egg_info:
Downloading 
http://pypi.python.org/packages/source/d/distribute/distribute-0.6.14.tar.gz
Traceback (most recent call last):
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup_utils/distribute_setup.py",
 line 143, in use_setuptools
raise ImportError
ImportError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "", line 1, in 
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup.py",
 line 31, in 
main()
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup.py",
 line 11, in main
distribute_setup.use_setuptools()
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup_utils/distribute_setup.py",
 line 145, in use_setuptools
return _do_download(version, download_base, to_dir, download_delay)
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup_utils/distribute_setup.py",
 line 124, in _do_download
to_dir, download_delay)
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup_utils/distribute_setup.py",
 line 193, in download_setuptools
src = urlopen(url)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
223, in urlopen
return opener.open(url, data, timeout)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
532, in open
response = meth(req, response)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
642, in http_response
'http', request, response, code, msg, hdrs)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
570, in error
return self._call_chain(*args)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
504, in _call_chain
result = func(*args)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
650, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: SSL is required


Command "python setup.py egg_info" failed with error code 1 in 
/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/
```


---

[GitHub] zeppelin issue #3090: [Zeppelin-3645] Add LSP Protocol completion support

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3090
  
@oxygen311 I can not install it. Let me know if there any other dependency 
I need to install

```
➜  zeppelin pr/3090 ✗ pip install pyls
Collecting pyls
  Using cached 
https://files.pythonhosted.org/packages/de/b7/5a056c2cac8fd19c905ae7451c2a60b9195531959c3770a49d6be4d905e3/pyls-0.1.3.zip
Complete output from command python setup.py egg_info:
Downloading 
http://pypi.python.org/packages/source/d/distribute/distribute-0.6.14.tar.gz
Traceback (most recent call last):
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup_utils/distribute_setup.py",
 line 143, in use_setuptools
raise ImportError
ImportError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "", line 1, in 
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup.py",
 line 31, in 
main()
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup.py",
 line 11, in main
distribute_setup.use_setuptools()
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup_utils/distribute_setup.py",
 line 145, in use_setuptools
return _do_download(version, download_base, to_dir, download_delay)
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup_utils/distribute_setup.py",
 line 124, in _do_download
to_dir, download_delay)
  File 
"/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/setup_utils/distribute_setup.py",
 line 193, in download_setuptools
src = urlopen(url)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
223, in urlopen
return opener.open(url, data, timeout)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
532, in open
response = meth(req, response)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
642, in http_response
'http', request, response, code, msg, hdrs)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
570, in error
return self._call_chain(*args)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
504, in _call_chain
result = func(*args)
  File "/Users/jzhang/anaconda3/lib/python3.6/urllib/request.py", line 
650, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: SSL is required


Command "python setup.py egg_info" failed with error code 1 in 
/private/var/folders/dp/hmchg5dd3vbcvds26q91spdwgp/T/pip-install-7veml3im/pyls/
```


---

Re: Zeppelin distributed architecture design

[Jongyoul Lee]

First of all, thank you for your effort and contribution.

I read it carefully today, and personally, it's a very nice feature and
idea.

Let's discuss it and improve more concretely. I also left comments on the
doc.

And I have a simple question.

`Copycat`, which you used to implement it, is deprecated by owner[1] and
moved under https://github.com/atomix/atomix/. I'm afraid of it. Do you
have any reason to use this library? It's even SNAPSHOT version.

Regards,
JL

[1]: https://github.com/atomix/copycat

On Sat, Jul 21, 2018 at 2:07 AM, liuxun  wrote:

> HI：
>
> In order to more intuitively express the actual use of distributed
> zeppelin clusters.
> I updated this design document, starting with the 16th page of the
> document, adding 2 GIF animations showing the operation record screen of
> the zeppelin cluster we are using now.
> https://docs.google.com/document/d/1a8QLSyR3M5AhlG1GIYuDTj6bwazeu
> VDKCRRBm-Qa3Bw/edit#  1a8QLSyR3M5AhlG1GIYuDTj6bwazeuVDKCRRBm-Qa3Bw/edit#>
>
> Distributed clustered zeppelin is already in use at our company, and the
> recorded screens are all real.
> The first recorded screens GIF shows the following
> Create a cluster of three zeppelin servers
> Add 234, 235, 236 to the zeppelin.cluster.addr attribute in
> zeppelin-site.xml to create a cluster
> Start these 3 servers at the same time
> Open the web pages of these 3 servers and prepare for the notebook
> operation.
>
>
> The second recorded screens GIF shows the following
> Create an interpreter process in the cluster
> Create a notebook on host234 and execute it, This action will create an
> interpreter process in the server with free resources in the cluster.
> You can then continue editing this notebook on host235 and execute it, You
> can return results immediately without waiting for the time to create an
> interpreter process.
> Again, you can continue to edit this notebook on host236. And execute it,
> you can return results immediately without waiting for the time to create
> the interpreter process
> The same notebook will reuse the first created interpreter process, so you
> can get the execution result immediately on any server.
> By looking at the background server process, you will find that host234,
> host235, and host235 use the same interpreter process for the same notebook.
>
> Originally, I wanted to record the interpreter process exception. The
> cluster re-created the screenshot of the interpreter process in the idle
> server, but I am too tired now.
> There is time to record later.
>
>
> > 在 2018年7月19日，上午7:36，Ruslan Dautkhanov  写道：
> >
> > Thank you luxun,
> >
> > I left a couple of comments in that google document.
> >
> > --
> > Ruslan Dautkhanov
> >
> >
> > On Tue, Jul 17, 2018 at 11:30 PM liuxun  neliu...@163.com>> wrote:
> > hi，Ruslan Dautkhanov
> >
> > Thank you very much for your question. according to your advice, I added
> 3 schematics to illustrate.
> > 1. Distributed Zeppelin Deployment architecture diagram.
> > 2. Distributed zeppelin Server fault tolerance diagram.
> > 3. Distributed zeppelin Server & intp process fault tolerance diagram.
> >
> >
> > The email attachment exceeded the size limit, so I reorganized the
> document and updated it with Google Docs.
> > https://docs.google.com/document/d/1a8QLSyR3M5AhlG1GIYuDTj6bwazeu
> VDKCRRBm-Qa3Bw/edit?usp=sharing  1a8QLSyR3M5AhlG1GIYuDTj6bwazeuVDKCRRBm-Qa3Bw/edit?usp=sharing>
> >
> >
> >> 在 2018年7月18日，下午1:03，liuxun mailto:neliu...@163.com>>
> 写道：
> >>
> >> hi，Ruslan Dautkhanov
> >>
> >> Thank you very much for your question. according to your advice, I
> added 3 schematics to illustrate.
> >> 1. Zeppelin Cluster architecture diagram.
> >> 2. Distributed zeppelin Server fault tolerance diagram.
> >> 3. Distributed zeppelin Server & intp process fault tolerance diagram.
> >>
> >> Later, I will merge the schematic into the system design document.
> >>
> >> 
> >>
> >>
> >> 
> >>
> >>
> >>
> >> 
> >>
> >>
> >>
> >>> 在 2018年7月18日，上午1:16，Ruslan Dautkhanov  dautkha...@gmail.com>> 写道：
> >>>
> >>> Nice.
> >>>
> >>> Thanks for sharing.
> >>>
> >>> Can you explain how are users routed into a particular zeppelin server
> >>> instance? I've seen nginx on top of them, but I don't think the
> document
> >>> covers details? If one zeppelin server goes down or unhealthy, is nginx
> >>> supposed to detect (if so, how?) that and reroute users to a survived
> >>> instance?
> >>>
> >>> Thanks,
> >>> Ruslan Dautkhanov
> >>>
> >>>
> >>> On Tue, Jul 17, 2018 at 2:46 AM liuxun  neliu...@163.com>> wrote:
> >>>
>  hi:
> 
>  Our company installed and deployed a lot of zeppelin for data
> analysis.
>  The single server version of zeppelin could not meet our application
>  scenarios, so we transformed zeppelin into a clustered service that
>  supports distributed deployment, Have a unified entrance, high
>  availability, and High server resource usage.  the email 

[GitHub] zeppelin issue #3074: [ZEPPELIN-3610] Cluster Raft module design

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3074
  
Yes, AFAIK, there's no way to connect delete branch and PR again. you need 
to make a new PR. :-)


---

[GitHub] zeppelin issue #3074: [ZEPPELIN-3610] Cluster Raft module design

[liuxunorg]

Github user liuxunorg commented on the issue:

https://github.com/apache/zeppelin/pull/3074
  
@jongyoul very sorry, I executed the wrong git command, Rebuilt the 
`liuxunorg:ZEPPELIN-3610` branch, Causes this pull to automatically close. I 
can't reopen this pull now. `Liuxunorg:ZEPPELIN-3610` branch was rebuilt, It 
may not be useful to reopen this pull.

Am I requesting a pull again?


---

[GitHub] zeppelin issue #3057: [ZEPPELIN-3582] Add type data to result of query from ...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3057
  
Got it. I wonder the status of this PR


---

[GitHub] zeppelin issue #3057: [ZEPPELIN-3582] Add type data to result of query from ...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3057
  
Sorry, I need go through it again today. 


---

[GitHub] zeppelin issue #3074: [ZEPPELIN-3610] Cluster Raft module design

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3074
  
Deleted?


---

[GitHub] zeppelin issue #3078: [ZEPPELIN-3628] HTML anchor links on paragraph don't w...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3078
  
You need to enable travis for testing this PR. Unfortunately, it only 
supports user id's travis. Can you handle it?


---

[GitHub] zeppelin pull request #3089: [ZEPPELIN-3593] Add an option to use disk while...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3089


---

[GitHub] zeppelin issue #3057: [ZEPPELIN-3582] Add type data to result of query from ...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3057
  
It seems to be ready to merge. 


---

[GitHub] zeppelin issue #3066: [ZEPPELIN-3618] ZeppelinContext methods z.run and z.ru...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3066
  
Your branch is not configured travis. Please enable travis for your branch.


---

[GitHub] zeppelin issue #3066: [ZEPPELIN-3618] ZeppelinContext methods z.run and z.ru...

[egorklimov]

Github user egorklimov commented on the issue:

https://github.com/apache/zeppelin/pull/3066
  
@felixcheung I added `TException` and now it seems to be ok, thank you.

* Zeppelin log for z.run("WrongParagraphId") and z.runNote("WrongNoteId"):
```
ERROR [2018-07-23 13:24:18,768] ({pool-5-thread-1} 
ProcessFunction.java[process]:41) - Internal error processing runParagraphs
org.apache.thrift.TException: java.io.IOException: Not existed paragraphId: 
WrongParagraphId
ERROR [2018-07-23 12:48:04,178] ({pool-5-thread-1} 
ProcessFunction.java[process]:41) - Internal error processing runParagraphs
org.apache.thrift.TException: java.io.IOException: Not existed noteId: 
WrongNoteId
```
* Interpreter log:
```
 WARN [2018-07-23 12:45:48,940] ({pool-2-thread-2} 
RemoteInterpreterEventClient.java[runParagraphs]:259) - Fail to runParagraphs: 
RunParagraphsEvent(noteId:2DK772RCQ, paragraphIds:[WrongParagraphId], 
paragraphIndices:[], curParagraphId:20180713-113847_1219368691)
org.apache.thrift.TApplicationException: Internal error processing 
runParagraphs
 WARN [2018-07-23 12:48:04,179] ({pool-2-thread-4} 
RemoteInterpreterEventClient.java[runParagraphs]:259) - Fail to runParagraphs: 
RunParagraphsEvent(noteId:WrongNoteId, paragraphIds:[], paragraphIndices:[], 
curParagraphId:20180713-113959_745574920)
org.apache.thrift.TApplicationException: Internal error processing 
runParagraphs
```
Also it would be nice if we add error message in paragraph output, but I 
didn't find out how to do it.


---

[GitHub] zeppelin issue #3066: [ZEPPELIN-3618] ZeppelinContext methods z.run and z.ru...

[egorklimov]

Github user egorklimov commented on the issue:

https://github.com/apache/zeppelin/pull/3066
  
@jongyoul result is unfortunately the same 
https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/407075673


---

[GitHub] zeppelin issue #3090: [Zeppelin-3645] Add LSP Protocol completion support

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3090
  
Could you add instruction in python.md ? Otherwise it is hard for users to 
know how to enable this feature except you. 


---

[GitHub] zeppelin issue #3090: [Zeppelin-3645] Add LSP Protocol completion support

[oxygen311]

Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3090
  
Now this feature is enabled only in python interpreter. So you can specify 
`zeppelin.python.lspHost` and `zeppelin.python.lspPort` properties and use it.
Server is a separate process. I have been using 
[python-language-server](https://github.com/palantir/python-language-server). 
But there are much more [server 
implementations](https://microsoft.github.io/language-server-protocol/implementors/servers/)
 that can be used with any language.


---

[GitHub] zeppelin issue #3090: [Zeppelin-3645] Add LSP Protocol completion support

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3090
  
Is there any document of how to use this ? Like how to configure and start 
the LSP server


---

[GitHub] zeppelin pull request #3079: ZEPPELIN-3635. Drop support for spark before 1....

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3079


---

[GitHub] zeppelin pull request #3090: [Zeppelin-3645] Add LSP Protocol completion sup...

[oxygen311]

GitHub user oxygen311 opened a pull request:

https://github.com/apache/zeppelin/pull/3090

[Zeppelin-3645] Add LSP Protocol completion support

### What is this PR for?
Add support of request autocomplete with LSP Protocol through TCP.

### What type of PR is it?
Feature

### What is the Jira issue?

[ZEPPELIN-3645](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3645?filter=allopenissues)

### Demo
![peek 2018-07-23 
14-40](https://user-images.githubusercontent.com/16215034/43074811-3a8b3a00-8e87-11e8-8333-c2d678e61557.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3645

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3090.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3090


commit 299fc9a68509395903c2e7dd37a1b011909b1e15
Author: oxygen311 
Date:   2018-07-20T16:07:10Z

Add basic support of LSP Protocol

commit f0066adb379afaf4ee442f4c4e6bef9ae7ec9473
Author: oxygen311 
Date:   2018-07-23T09:20:43Z

Fix variable name




---

[GitHub] zeppelin issue #3074: [ZEPPELIN-3610] Cluster Raft module design

[liuxunorg]

Github user liuxunorg commented on the issue:

https://github.com/apache/zeppelin/pull/3074
  
CI pass. https://travis-ci.org/liuxunorg/zeppelin/builds/407058117


---

[GitHub] zeppelin issue #3066: [ZEPPELIN-3618] ZeppelinContext methods z.run and z.ru...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3066
  
@egorklimov You could make CI gree if you rebased from the current master


---

[GitHub] zeppelin issue #3089: [ZEPPELIN-3593] Add an option to use disk while indexi...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3089
  
LGTM


---

[GitHub] zeppelin issue #3089: [ZEPPELIN-3593] Add an option to use disk while indexi...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3089
  
Ready to review


---

[GitHub] zeppelin pull request #3089: [ZEPPELIN-3593] Add option to use disk while in...

[jongyoul]

GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/3089

[ZEPPELIN-3593] Add option to use disk while indexing notes for search

### What is this PR for?
Adding a new option to enable using disk while running search service


### What type of PR is it?
[Improvement]

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3593

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-3593

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3089.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3089


commit f818accd921806c11d19f16d16506f8a414c5eb3
Author: Jongyoul Lee 
Date:   2018-07-09T05:54:33Z

Replace `RamDirectory` to `MMapDirectory` provided by Lucene

commit 605e9ab2980c6401172f5a62656886fad56b52cc
Author: Jongyoul Lee 
Date:   2018-07-09T06:13:12Z

Add deletion logic for the temporary directory

commit b5aa5dfb6feb42e12153c1796be0b055ce1850f7
Author: Jongyoul Lee 
Date:   2018-07-09T23:42:15Z

Set a default temporary directory to `java.io.tmpdir`
Clean up javadoc

commit 3676c41fd9c001c3e3f2fcd8de3ed917ffc406e3
Author: Jongyoul Lee 
Date:   2018-07-11T02:29:57Z

Add `RamDirectory` to use search service in case where disk is not available

commit 6f445b7886c86e842e3f5062c44a48db6279116f
Author: Jongyoul Lee 
Date:   2018-07-11T04:15:04Z

Add a logic to check if directoryPath is null or not

commit d63a60ad37b0eeff217fd213ab6471c232f07504
Author: Jongyoul Lee 
Date:   2018-07-23T06:10:18Z

Add option to enable to use disk index feature

commit 9179b4aee943dac9810a793a53a153f203879db9
Author: Jongyoul Lee 
Date:   2018-07-23T06:25:17Z

Change exception type from IOException to RuntimeException

commit 4e61070fd1cda4305010e8c5880ad5c15f122800
Author: Jongyoul Lee 
Date:   2018-07-23T06:37:13Z

Remove `throws` signature




---

[GitHub] zeppelin pull request #3055: ZEPPELIN-3587. Interpret paragarph text as whol...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3055


---

[GitHub] zeppelin issue #3074: [ZEPPELIN-3610] Cluster Raft module design

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3074
  
@liuxunorg Could you do rebase and retrigger the travis ? If CI pass, I 
will create new branch for you, then you can work on the new branch. 


---

[GitHub] zeppelin pull request #3080: ZEPPELIN-3566. Add imageWidth as paragraph leve...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3080


---

[GitHub] zeppelin pull request #3083: ZEPPELIN-3637. Allow custom spark UI url for ne...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3083


---

[GitHub] zeppelin issue #3074: [ZEPPELIN-3610] Cluster Raft module design

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3074
  
Got it. I hope not to spend much time merging this feature into the master
branch after finishing implementations.

On Mon, Jul 23, 2018 at 3:22 PM, Jeff Zhang 
wrote:

> @jongyoul  This is for the zeppelin HA
> feature which will involve many PRs. Here's the pros and cons of creating
> new branch.
> Pros.
>
>1. Move fast of implementing this feature
>2. Keep the master branch stable.
>3. Interested users can try this feature earlier.
>4. This feature branch will become much stable before merging into
>master branch.
>
> Cons.
>
>1. Merging into master will take a lot time.
>
> That's why I think creating new branch for this feature is necessary.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net



---

[GitHub] zeppelin issue #3074: [ZEPPELIN-3610] Cluster Raft module design

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3074
  
@jongyoul This is for the zeppelin HA feature which will involve many PRs. 
Here's the pros and cons of creating new branch.
Pros.
1. Move fast of implementing this feature
2. Keep the master branch stable. 
3. Interested users can try this feature earlier. 
4. This feature branch will become much stable before merging into master 
branch. 

Cons.
1. Merging into master will take a lot time.

That's why I think creating new branch for this feature is necessary. 


---

[GitHub] zeppelin issue #3077: [ZEPPELIN-3631] Increase the maven-shade-plugin versio...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3077
  
Can you rebase your PRs from the latest master branch? We have fixed CI and 
you might get green.


---

[GitHub] zeppelin issue #3001: [ZEPPELIN-3524] Replace the Amazon json libs with org....

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3001
  
Sorry for the late reply. As you mentioned, Zeppelin already has two or 
more json dependencies at the same time, but I don't think it's good and we can 
fix it when we can do and have a chance. How about fixing it in this time?


---

[GitHub] zeppelin issue #3074: [ZEPPELIN-3610] Cluster Raft module design

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3074
  
BTW, it looks hard to maintain a new branch for a new feature. we already
use github's PR and we can test it by pulling PR with dev/test_pr

WDYT?


On Mon, Jul 23, 2018 at 2:56 PM, Jeff Zhang 
wrote:

> It make sense @liuxunorg  , I will create a
> new branch for this feature.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net



---