[GitHub] [zeppelin] florpor opened a new pull request #3363: [ZEPPELIN-4144] After refresh the revision tools are sometimes hidden

2019-05-13 Thread GitBox
florpor opened a new pull request #3363: [ZEPPELIN-4144] After refresh the 
revision tools are sometimes hidden
URL: https://github.com/apache/zeppelin/pull/3363
 
 
   ### What is this PR for?
   Fixes issue where after refreshing a note's page the revision controls in 
the navigation bar are hidden since listConfigurations is only requested in the 
navbar controller after a loginSuccess broadcast.
   This currently works sometimes because another controller (note-import) 
sends a listConfigurations request when it is loaded and navbar controller is 
sometimes loaded by the time the response arrives, but I can reproduce it 
easily using Firefox (gif attached to Jira issue).
   
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   
   ### What is the Jira issue?
   
[https://issues.apache.org/jira/browse/ZEPPELIN-4144](https://issues.apache.org/jira/browse/ZEPPELIN-4144)
   
   ### How should this be tested?
   Added unit and e2e tests to make sure listConfigurations is called and 
controls are visible.
   Seems to me like the issue is easier to reproduce using Firefox. Was able to 
do so using the official 0.8.1 docker image.
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zeppelin] zjffdu commented on issue #3362: [ZEPPELIN-4159] Fixed ZeppelinIT#testAngularDisplay() failure

2019-05-13 Thread GitBox
zjffdu commented on issue #3362: [ZEPPELIN-4159] Fixed 
ZeppelinIT#testAngularDisplay() failure
URL: https://github.com/apache/zeppelin/pull/3362#issuecomment-492080337
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zeppelin] liuxunorg commented on issue #3362: [ZEPPELIN-4159] Fixed ZeppelinIT#testAngularDisplay() failure

2019-05-13 Thread GitBox
liuxunorg commented on issue #3362: [ZEPPELIN-4159] Fixed 
ZeppelinIT#testAngularDisplay() failure
URL: https://github.com/apache/zeppelin/pull/3362#issuecomment-492075663
 
 
   @zjffdu, @felixcheung  , [CI 
pass](https://travis-ci.org/liuxunorg/zeppelin/builds/532093683), Please help 
me review code, Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zeppelin] liuxunorg opened a new pull request #3362: [ZEPPELIN-4159] Fixed ZeppelinIT#testAngularDisplay() failure

2019-05-13 Thread GitBox
liuxunorg opened a new pull request #3362: [ZEPPELIN-4159] Fixed 
ZeppelinIT#testAngularDisplay() failure
URL: https://github.com/apache/zeppelin/pull/3362
 
 
   ### What is this PR for?
   1. setTextOfParagraph(1, "println(\"%angular BindingTest_{{myVar}}_\")");
   2. driver.findElement(By.xpath(getParagraphXPath(1) + 
"//div[@id=\"angularTestButton\"]")).click();
   
   ```
   org.openqa.selenium.NoSuchElementException: Unable to locate element: 
{"method":"xpath","selector":"(//div[@ng-controller=\"ParagraphCtrl\"])[1]//div[@id=\"angularTestButton\"]"}
   Command duration or timeout: 0 milliseconds
   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
   at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
   at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
   at 
org.openqa.selenium.remote.ErrorHandler.createThrowable(ErrorHandler.java:214)
   at 
org.openqa.selenium.remote.ErrorHandler.throwIfResponseFailed(ErrorHandler.java:166)
   at 
org.openqa.selenium.remote.http.JsonHttpResponseCodec.reconstructValue(JsonHttpResponseCodec.java:40)
   at 
org.openqa.selenium.remote.http.AbstractHttpResponseCodec.decode(AbstractHttpResponseCodec.java:80)
   at 
org.openqa.selenium.remote.http.AbstractHttpResponseCodec.decode(AbstractHttpResponseCodec.java:44)
   at 
org.openqa.selenium.remote.HttpCommandExecutor.execute(HttpCommandExecutor.java:164)
   at 
org.openqa.selenium.remote.service.DriverCommandExecutor.execute(DriverCommandExecutor.java:83)
   at 
org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:601)
   at 
org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:371)
   at 
org.openqa.selenium.remote.RemoteWebDriver.findElementByXPath(RemoteWebDriver.java:473)
   at org.openqa.selenium.By$ByXPath.findElement(By.java:361)
   at 
org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:363)
   at 
org.apache.zeppelin.integration.ZeppelinIT.testAngularDisplay(ZeppelinIT.java:117)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:498)
   at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
   at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
   at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
   at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
   at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
   at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
   at org.junit.rules.Verifier$1.evaluate(Verifier.java:35)
   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
   at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
   at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
   at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
   at 
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
   at 
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
   at 
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
   at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
   Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate 
element: 
{"method":"xpath","selector":"(//div[@ng-controller=\"ParagraphCtrl\"])[1]//div[@id=\"angularTestButton\"]"}
   ```
   
   
   ### What type of PR is it?
   [Bug Fix]
   
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4159
   
   ### How should this be tested?
   * [CI pass](https://travis-ci.org/liuxunorg/zeppelin/builds/532093683)
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? NO
   * Is there breaking changes for older versions? NO
   * Does this needs documentation? NO
   


This is an automated message from the Apache Git 

[GitHub] [zeppelin] zjffdu opened a new pull request #3361: ZEPPELIN-4153. Move zeppelin-interpreter-api jar out of interpreter jar

2019-05-13 Thread GitBox
zjffdu opened a new pull request #3361: ZEPPELIN-4153. Move 
zeppelin-interpreter-api jar out of interpreter jar
URL: https://github.com/apache/zeppelin/pull/3361
 
 
   ### What is this PR for?
   This PR is to move zeppelin-interpreter-api jar out of interpreter jar, and 
put it under folder ${ZEPPELIN_HOME}/interpreter which is shared between all 
interpreters.
   
   
   ### What type of PR is it?
   [Improvement]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4153
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (ZEPPELIN-4159) Fixed ZeppelinIT#testAngularDisplay() failure

2019-05-13 Thread Xun Liu (JIRA)
Xun Liu created ZEPPELIN-4159:
-

 Summary: Fixed ZeppelinIT#testAngularDisplay() failure
 Key: ZEPPELIN-4159
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4159
 Project: Zeppelin
  Issue Type: Bug
Reporter: Xun Liu
Assignee: Xun Liu


1. println 

 
{code:java}
setTextOfParagraph(1, "println(\"%angular BindingTest_{{myVar}}_\")");
{code}
2. click
{code:java}
driver.findElement(By.xpath(getParagraphXPath(1) + 
"//div[@id=\"angularTestButton\"]")).click();
{code}
ERROR org.apache.zeppelin.AbstractZeppelinIT:132 - Exception in ZeppelinIT 
while testAngularDisplay

 
{code:java}
org.openqa.selenium.NoSuchElementException: Unable to locate element: 
{"method":"xpath","selector":"(//div[@ng-controller=\"ParagraphCtrl\"])[1]//div[@id=\"angularTestButton\"]"}
Command duration or timeout: 0 milliseconds
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at 
org.openqa.selenium.remote.ErrorHandler.createThrowable(ErrorHandler.java:214)
at 
org.openqa.selenium.remote.ErrorHandler.throwIfResponseFailed(ErrorHandler.java:166)
at 
org.openqa.selenium.remote.http.JsonHttpResponseCodec.reconstructValue(JsonHttpResponseCodec.java:40)
at 
org.openqa.selenium.remote.http.AbstractHttpResponseCodec.decode(AbstractHttpResponseCodec.java:80)
at 
org.openqa.selenium.remote.http.AbstractHttpResponseCodec.decode(AbstractHttpResponseCodec.java:44)
at 
org.openqa.selenium.remote.HttpCommandExecutor.execute(HttpCommandExecutor.java:164)
at 
org.openqa.selenium.remote.service.DriverCommandExecutor.execute(DriverCommandExecutor.java:83)
at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:601)
at 
org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:371)
at 
org.openqa.selenium.remote.RemoteWebDriver.findElementByXPath(RemoteWebDriver.java:473)
at org.openqa.selenium.By$ByXPath.findElement(By.java:361)
at 
org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:363)
at 
org.apache.zeppelin.integration.ZeppelinIT.testAngularDisplay(ZeppelinIT.java:117)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.Verifier$1.evaluate(Verifier.java:35)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at 
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at 
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
at 
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate 
element: 
{"method":"xpath","selector":"(//div[@ng-controller=\"ParagraphCtrl\"])[1]//div[@id=\"angularTestButton\"]"}

{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZEPPELIN-4158) Enable impersonation by default for shell interpreter

2019-05-13 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-4158:


 Summary: Enable impersonation by default for shell interpreter
 Key: ZEPPELIN-4158
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4158
 Project: Zeppelin
  Issue Type: Improvement
Affects Versions: 0.8.1, 0.9.0
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZEPPELIN-4157) Zeppelin context variables management improvements

2019-05-13 Thread zhixia dai (JIRA)
zhixia dai created ZEPPELIN-4157:


 Summary: Zeppelin context variables management improvements
 Key: ZEPPELIN-4157
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4157
 Project: Zeppelin
  Issue Type: Improvement
Reporter: zhixia dai
Assignee: zhixia dai






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [zeppelin] dbanda commented on issue #3315: Update twittr maven to HTTPS [ZEPPELIN-4156]

2019-05-13 Thread GitBox
dbanda commented on issue #3315: Update twittr maven to HTTPS [ZEPPELIN-4156]
URL: https://github.com/apache/zeppelin/pull/3315#issuecomment-491924996
 
 
   > ping @dbanda Could you address the comments ?
   
   Addressed. Added the Jira and updated PR title


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (ZEPPELIN-4156) Some packages cannot be downloaded form twttr mavnen

2019-05-13 Thread Dalitso Banda (JIRA)
Dalitso Banda created ZEPPELIN-4156:
---

 Summary: Some packages cannot be downloaded form twttr mavnen
 Key: ZEPPELIN-4156
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4156
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-interpreter
Reporter: Dalitso Banda


SBT fails to resolve dependencies from twittr maven. The HTTP is now redirected 
to HTTPS.
see [sbt/sbt#3670|https://github.com/sbt/sbt/issues/3670]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZEPPELIN-4155) Unable get available HostAddress in multi-NIC environment

2019-05-13 Thread Xun Liu (JIRA)
Xun Liu created ZEPPELIN-4155:
-

 Summary: Unable get available HostAddress in multi-NIC environment
 Key: ZEPPELIN-4155
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4155
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-interpreter
Reporter: Xun Liu
Assignee: Xun Liu
 Fix For: 0.9.0


1. Multiple NetworkCard will be configured on some servers.
2. In the docker container environment, A container will also generate multiple 
virtual NetworkCard.

{color:#FF}RemoteInterpreterUtils#findAvailableHostAddress(){color} 
sometimes can't get the correct network card information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [zeppelin] asfgit closed pull request #3348: changed-readme-for-python-interpreter-for-apache-zeppelin

2019-05-13 Thread GitBox
asfgit closed pull request #3348: 
changed-readme-for-python-interpreter-for-apache-zeppelin
URL: https://github.com/apache/zeppelin/pull/3348
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zeppelin] zjffdu commented on issue #3315: update twittr maven to HTTPS

2019-05-13 Thread GitBox
zjffdu commented on issue #3315: update twittr maven to HTTPS
URL: https://github.com/apache/zeppelin/pull/3315#issuecomment-491829926
 
 
   ping @dbanda Could you address the comments ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zeppelin] zjffdu commented on issue #3348: changed-readme-for-python-interpreter-for-apache-zeppelin

2019-05-13 Thread GitBox
zjffdu commented on issue #3348: 
changed-readme-for-python-interpreter-for-apache-zeppelin
URL: https://github.com/apache/zeppelin/pull/3348#issuecomment-491829180
 
 
   Thanks @d3adp007 , merging


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zeppelin] zjffdu opened a new pull request #3360: [ZEPPELIN-4152]. Use spark 2.2 as the default profile

2019-05-13 Thread GitBox
zjffdu opened a new pull request #3360: [ZEPPELIN-4152]. Use spark 2.2 as the 
default profile
URL: https://github.com/apache/zeppelin/pull/3360
 
 
   ### What is this PR for?
   Trivial PR to use spark 2.2 as the default profile so that the default build 
command can pass
   
   ```
   mvn clean package -DskipTests
   ```
   
   
   ### What type of PR is it?
   [ Improvement ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4152
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services