[GitHub] [zeppelin] zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

[GitBox]

zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get 
available HostAddress in multi-NIC environment
URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284523852
 
 

 ##
 File path: 
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterUtils.java
 ##
 @@ -93,22 +97,53 @@ public static TServerSocket createTServerSocket(String 
portRange)
 throw new IOException("No available port in the portRange: " + portRange);
   }
 
+  // 1) Multiple NetworkCard will be configured on some servers
+  // 2) In the docker container environment, A container will also generate 
multiple virtual NetworkCard
 
 Review comment:
   Could you add java doc to explain the logic ?
   To me, it seems to involves 2 steps:
   1. find all available networkcards
   2. loo all the neetworkcards, and use the first non-loopback ip address.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

[GitBox]

zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get 
available HostAddress in multi-NIC environment
URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284523852
 
 

 ##
 File path: 
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterUtils.java
 ##
 @@ -93,22 +97,53 @@ public static TServerSocket createTServerSocket(String 
portRange)
 throw new IOException("No available port in the portRange: " + portRange);
   }
 
+  // 1) Multiple NetworkCard will be configured on some servers
+  // 2) In the docker container environment, A container will also generate 
multiple virtual NetworkCard
 
 Review comment:
   Could you add java doc to explain the logic ?
   To me, it seems to involves 2 steps:
   1. find all available networkcards
   2. loo all the neetworkcards, and use the first non-loop ip address.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

[GitBox]

zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get 
available HostAddress in multi-NIC environment
URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284523852
 
 

 ##
 File path: 
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterUtils.java
 ##
 @@ -93,22 +97,53 @@ public static TServerSocket createTServerSocket(String 
portRange)
 throw new IOException("No available port in the portRange: " + portRange);
   }
 
+  // 1) Multiple NetworkCard will be configured on some servers
+  // 2) In the docker container environment, A container will also generate 
multiple virtual NetworkCard
 
 Review comment:
   Could you add java doc to explain the logic ?
   To me, it seems to involves 2 steps:
   1. find all available networkcards
   2. loop all the neetworkcards, and use the first non-loopback ip address.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

[GitBox]

zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get 
available HostAddress in multi-NIC environment
URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284523456
 
 

 ##
 File path: 
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterUtils.java
 ##
 @@ -93,22 +97,53 @@ public static TServerSocket createTServerSocket(String 
portRange)
 throw new IOException("No available port in the portRange: " + portRange);
   }
 
+  // 1) Multiple NetworkCard will be configured on some servers
+  // 2) In the docker container environment, A container will also generate 
multiple virtual NetworkCard
   public static String findAvailableHostAddress() throws UnknownHostException, 
SocketException {
-InetAddress address = InetAddress.getLocalHost();
-if (address.isLoopbackAddress()) {
-  for (NetworkInterface networkInterface : Collections
-  .list(NetworkInterface.getNetworkInterfaces())) {
-if (!networkInterface.isLoopback()) {
-  for (InterfaceAddress interfaceAddress : 
networkInterface.getInterfaceAddresses()) {
-InetAddress a = interfaceAddress.getAddress();
-if (a instanceof Inet4Address) {
-  return a.getHostAddress();
-}
+List netlist = new ArrayList();
+
+// Get all the network cards in the current environment
+Enumeration netInterfaces = NetworkInterface.getNetworkInterfaces();
+while (netInterfaces.hasMoreElements()) {
+  NetworkInterface networkInterface = 
(NetworkInterface)netInterfaces.nextElement();
+  LOGGER.info("networkInterface = " + networkInterface.toString());
 
 Review comment:
   -> LOGGER.debug


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

[GitBox]

zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get 
available HostAddress in multi-NIC environment
URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284523426
 
 

 ##
 File path: 
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterUtils.java
 ##
 @@ -93,22 +97,53 @@ public static TServerSocket createTServerSocket(String 
portRange)
 throw new IOException("No available port in the portRange: " + portRange);
   }
 
+  // 1) Multiple NetworkCard will be configured on some servers
+  // 2) In the docker container environment, A container will also generate 
multiple virtual NetworkCard
   public static String findAvailableHostAddress() throws UnknownHostException, 
SocketException {
-InetAddress address = InetAddress.getLocalHost();
-if (address.isLoopbackAddress()) {
-  for (NetworkInterface networkInterface : Collections
-  .list(NetworkInterface.getNetworkInterfaces())) {
-if (!networkInterface.isLoopback()) {
-  for (InterfaceAddress interfaceAddress : 
networkInterface.getInterfaceAddresses()) {
-InetAddress a = interfaceAddress.getAddress();
-if (a instanceof Inet4Address) {
-  return a.getHostAddress();
-}
+List netlist = new ArrayList();
+
+// Get all the network cards in the current environment
+Enumeration netInterfaces = NetworkInterface.getNetworkInterfaces();
+while (netInterfaces.hasMoreElements()) {
+  NetworkInterface networkInterface = 
(NetworkInterface)netInterfaces.nextElement();
+  LOGGER.info("networkInterface = " + networkInterface.toString());
+  if (networkInterface.isLoopback()) {
+// Filter lo network card
+continue;
+  }
+  // When all the network cards are obtained by the above method,
+  // The order obtained is the reverse of the order of the NICs
+  // seen in the server with the ifconfig command.
+  // Therefore, when you want to traverse from the first NIC,
+  // Need to reverse the elements in Enumeration
+  netlist.add(0, networkInterface);
+}
+
+for (NetworkInterface list:netlist) {
+  Enumeration enumInetAddress = list.getInetAddresses();
+
+  while (enumInetAddress.hasMoreElements()) {
+InetAddress ip = (InetAddress) enumInetAddress.nextElement();
+LOGGER.info("ip = " + ip.toString());
 
 Review comment:
   -> LOGGER.debug 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] liuxunorg commented on issue #3203: [ZEPPELIN-3626] Cluster server and client module

[GitBox]

liuxunorg commented on issue #3203: [ZEPPELIN-3626] Cluster server and client 
module
URL: https://github.com/apache/zeppelin/pull/3203#issuecomment-492885349
 
 
   This feature has been running in our company for 2 years and there is no 
problem.
   Will merge if no more comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] liuxunorg commented on issue #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show

[GitBox]

liuxunorg commented on issue #3365: [ZEPPELIN-4160] Fixed Move this note to 
trash icon always show
URL: https://github.com/apache/zeppelin/pull/3365#issuecomment-492884302
 
 
   > can you explain the change from `[0]` to `[1]`?
   
   @felixcheung , This is because of the problem caused by this 
[ZEPPELIN-2619](https://github.com/apache/zeppelin/commit/085efeb646f3a95b39bf555b5b04551119e3c0b9).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show

[GitBox]

liuxunorg commented on a change in pull request #3365: [ZEPPELIN-4160] Fixed 
Move this note to trash icon always show
URL: https://github.com/apache/zeppelin/pull/3365#discussion_r284510848
 
 

 ##
 File path: zeppelin-web/src/app/notebook/notebook.controller.js
 ##
 @@ -237,7 +237,8 @@ function NotebookCtrl($scope, $route, $routeParams, 
$location, $rootScope,
   };
 
   $scope.isTrash = function(note) {
-return note ? note.name.split('/')[0] === TRASH_FOLDER_ID : false;
+console.log('note.path = ' + note.path);
 
 Review comment:
   ok.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] liuxunorg commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

[GitBox]

liuxunorg commented on issue #3359: [ZEPPELIN-4131] Refactoring shell 
interpreter
URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492882297
 
 
   @Tagar , this new shell interpreter support `Kerberos auto refresh`, but not 
support `interpolations`.
   
   I think either use this new interpreter with the `%sh.terminal` keyword? 
What do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] Tagar commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

[GitBox]

Tagar commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter
URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492824721
 
 
   As part of Zeppelin notes we have static %sh paragraphs (non-interactive) 
with 
   or without variable embeddings (variable interpolations ) like described in 
   
https://zeppelin.apache.org/docs/0.8.1/interpreter/shell.html#object-interpolation
 
   
   Would this new implementation keep that possible? (without typing in a 
command each time)
   
   I totally agree it's a very cool feature, but we may need to preserve old 
good `%sh` interpreter
   if this new approach takes some of its functionality away. 
   
   Thoughts?
   
   Thank you @liuxunorg 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] Leemoonsoo commented on issue #3363: [ZEPPELIN-4144] After refresh the revision tools are sometimes hidden

[GitBox]

Leemoonsoo commented on issue #3363: [ZEPPELIN-4144] After refresh the revision 
tools are sometimes hidden
URL: https://github.com/apache/zeppelin/pull/3363#issuecomment-492770214
 
 
   Thanks @florpor for the contribution!
   Could you check message from Jenkins and try setup travis, and make CI test 
pass?
   
   ```
   Looks like travis-ci is not configured for your fork.
   Please setup by swich on 'zeppelin' repository at 
https://travis-ci.org/profile and travis-ci.
   And then make sure 'Build branch updates' option is enabled in the settings 
https://travis-ci.org/florpor/zeppelin/settings.
   
   To trigger CI after setup, you will need ammend your last commit with
   git commit --amend
   git push your-remote HEAD --force
   
   See 
http://zeppelin.apache.org/contribution/contributions.html#continuous-integration.
   Build step 'Execute shell' marked build as failure
   Putting comment on the pull request
   Finished: FAILURE
   ```
   
   Let me know if you need any help setting up CI.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] felixcheung commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

[GitBox]

felixcheung commented on a change in pull request #3364: [ZEPPELIN-4155] Unable 
get available HostAddress in multi-NIC environment
URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284328179
 
 

 ##
 File path: 
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterUtils.java
 ##
 @@ -93,22 +97,53 @@ public static TServerSocket createTServerSocket(String 
portRange)
 throw new IOException("No available port in the portRange: " + portRange);
   }
 
+  // 1) Multiple NetworkCard will be configured on some servers
+  // 2) In the docker container environment, A container will also generate 
multiple virtual NetworkCard
   public static String findAvailableHostAddress() throws UnknownHostException, 
SocketException {
-InetAddress address = InetAddress.getLocalHost();
-if (address.isLoopbackAddress()) {
-  for (NetworkInterface networkInterface : Collections
-  .list(NetworkInterface.getNetworkInterfaces())) {
-if (!networkInterface.isLoopback()) {
-  for (InterfaceAddress interfaceAddress : 
networkInterface.getInterfaceAddresses()) {
-InetAddress a = interfaceAddress.getAddress();
-if (a instanceof Inet4Address) {
-  return a.getHostAddress();
-}
+List netlist = new ArrayList();
+
+// Get all the network cards in the current environment
+Enumeration netInterfaces = NetworkInterface.getNetworkInterfaces();
+while (netInterfaces.hasMoreElements()) {
+  NetworkInterface networkInterface = 
(NetworkInterface)netInterfaces.nextElement();
+  LOGGER.info("networkInterface = " + networkInterface.toString());
+  if (networkInterface.isLoopback()) {
+// Filter lo network card
+continue;
+  }
+  // When all the network cards are obtained by the above method,
+  // The order obtained is the reverse of the order of the NICs
+  // seen in the server with the ifconfig command.
+  // Therefore, when you want to traverse from the first NIC,
+  // Need to reverse the elements in Enumeration
+  netlist.add(0, networkInterface);
+}
+
+for (NetworkInterface list:netlist) {
+  Enumeration enumInetAddress = list.getInetAddresses();
+
+  while (enumInetAddress.hasMoreElements()) {
+InetAddress ip = (InetAddress) enumInetAddress.nextElement();
+LOGGER.info("ip = " + ip.toString());
+if (!ip.isLoopbackAddress()) {
+  if (ip.getHostAddress().equalsIgnoreCase("127.0.0.1")){
 
 Review comment:
   isn't `isLoopbackAddress` enough?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] felixcheung commented on a change in pull request #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show

[GitBox]

felixcheung commented on a change in pull request #3365: [ZEPPELIN-4160] Fixed 
Move this note to trash icon always show
URL: https://github.com/apache/zeppelin/pull/3365#discussion_r284327576
 
 

 ##
 File path: zeppelin-web/src/app/notebook/notebook.controller.js
 ##
 @@ -237,7 +237,8 @@ function NotebookCtrl($scope, $route, $routeParams, 
$location, $rootScope,
   };
 
   $scope.isTrash = function(note) {
-return note ? note.name.split('/')[0] === TRASH_FOLDER_ID : false;
+console.log('note.path = ' + note.path);
 
 Review comment:
   remove this before merging?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] liuxunorg commented on issue #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show

[GitBox]

liuxunorg commented on issue #3365: [ZEPPELIN-4160] Fixed Move this note to 
trash icon always show
URL: https://github.com/apache/zeppelin/pull/3365#issuecomment-492710080
 
 
   @zjffdu , Please help me review code. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] liuxunorg commented on issue #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

[GitBox]

liuxunorg commented on issue #3364: [ZEPPELIN-4155] Unable get available 
HostAddress in multi-NIC environment
URL: https://github.com/apache/zeppelin/pull/3364#issuecomment-492710247
 
 
   @zjffdu , Please help me review code. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] liuxunorg opened a new pull request #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show

[GitBox]

liuxunorg opened a new pull request #3365: [ZEPPELIN-4160] Fixed Move this note 
to trash icon always show
URL: https://github.com/apache/zeppelin/pull/3365
 
 
   ### What is this PR for?
   when the note moved to trash, the note should show 'Remove this note 
permanently', it does not work correctly after clicked again, more ~Trash 
folder will be created
   
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4160
   
   ### How should this be tested?
   * [CI pass](https://travis-ci.org/liuxunorg/zeppelin/builds/532764123)
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? NO
   * Is there breaking changes for older versions? NO
   * Does this needs documentation? NO
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] liuxunorg commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

[GitBox]

liuxunorg commented on issue #3359: [ZEPPELIN-4131] Refactoring shell 
interpreter
URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492696041
 
 
   # The function is exactly the same as the terminal emulator
   ## curl + tar ScreenRecord
   
![shell-curl-tar](https://user-images.githubusercontent.com/3677382/57786530-34efa180-7766-11e9-9d91-520743ca0d60.gif)
   
   ## python + gcc ScreenRecord
   
![shell-python-gcc](https://user-images.githubusercontent.com/3677382/57786554-420c9080-7766-11e9-86dd-8c3bc82dc858.gif)
   
   ## call script ScreenRecord
   
![shll-script](https://user-images.githubusercontent.com/3677382/57786572-4df85280-7766-11e9-96a0-83e9a70307d7.gif)
   
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

[GitBox]

FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell 
interpreter
URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492659189
 
 
   We are using %sh pretty much exactly like @Leemoonsoo described it above. I 
think this is a really cool feature, but I don't think it should replace the 
%sh magic, but rather get its own, new, magic (as @Tagar suggested above). 
`%terminal` or `%shell` perhaps?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3360: [ZEPPELIN-4152]. Use spark 2.2 as the default profile

[GitBox]

zjffdu commented on issue #3360: [ZEPPELIN-4152]. Use spark 2.2 as the default 
profile
URL: https://github.com/apache/zeppelin/pull/3360#issuecomment-492656521
 
 
   Unfortunately, spark 2.3 doesn't support scala 2.10 which is default 
profile. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] Leemoonsoo commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

[GitBox]

Leemoonsoo commented on issue #3359: [ZEPPELIN-4131] Refactoring shell 
interpreter
URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492652747
 
 
   I can think a use case, such as
   
   ```
   %sh
   # download some data
   curl -O http://
   
   # extract
   tar -xzf 
   ```
   
   ```
   %python
   
   # load downloaded data
   df = pd.read_csv("...")
   ...
   ```
   
   This case, %sh interpreter may better have a script to run, rather than 
expecting interactive user input.
   Is this new %sh interpreter implementation capable of doing this as well?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (ZEPPELIN-4161) Add travis job for default build

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-4161:


 Summary: Add travis job for default build
 Key: ZEPPELIN-4161
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4161
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Jeff Zhang


Some user hit issues when building zeppelin master via the default command, we 
should make sure it works by adding it in travis

 

```

mvn clean package -DskipTests

```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

I have refactored the shell interpreter, welcome comments

[Xun Liu]

Hi Folks,

The current shell interpreter functionality is simple. 
Execute a command, Session does not record the status after executing the 
command, You can only enter all the commands in one paragraph. There is no way 
to explore on a command-by-command basis. Now the shell interpreter can't view 
files with the vi command, etc. 

So I Refactoring Shell Interpreter.


Design document : 
https://docs.google.com/document/d/1-XUkXY06cMtEUBxVHVyqQPkyCkv2BjYhAQj-W1CBxNI/edit
 

JIRA Issus: https://issues.apache.org/jira/browse/ZEPPELIN-4131 

PR : https://github.com/apache/zeppelin/pull/3359 


welcome comments, :-)