[GitHub] [zeppelin] zjffdu commented on issue #3738: [ZEPPELIN-4758] Additional cleanup for Java 8 support

2020-04-21 Thread GitBox
zjffdu commented on issue #3738: URL: https://github.com/apache/zeppelin/pull/3738#issuecomment-617473751 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] zjffdu commented on issue #3721: [Zeppelin 4731] Ability to exclude fields from being saved in Note files

2020-04-21 Thread GitBox
zjffdu commented on issue #3721: URL: https://github.com/apache/zeppelin/pull/3721#issuecomment-617465044 ping @Muhammad-ms This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zeppelin] zjffdu commented on issue #3741: [ZEPPELIN-4759] Paragraph refreshing make the other paragraph shaking

2020-04-21 Thread GitBox
zjffdu commented on issue #3741: URL: https://github.com/apache/zeppelin/pull/3741#issuecomment-617218608 @epugh This is only to fix the issue happens in flink interpreter where I refresh paragraph when new data is coming from flink stream. I don't think it would fix the collaboration

[GitHub] [zeppelin] epugh commented on issue #3741: [ZEPPELIN-4759] Paragraph refreshing make the other paragraph shaking

2020-04-21 Thread GitBox
epugh commented on issue #3741: URL: https://github.com/apache/zeppelin/pull/3741#issuecomment-617190277 This is a great fix, I find it very disjointing when I edit a notebook with someone else, and the repainting of the screen when they make a change on their end is very jarring!

[GitHub] [zeppelin] Reamer opened a new pull request #3744: [ZEPPELIN-4768] Correct a typo in isUserImpersonateForSparkInterpreter

2020-04-21 Thread GitBox
Reamer opened a new pull request #3744: URL: https://github.com/apache/zeppelin/pull/3744 ### What is this PR for? Small typo fix ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is the Jira issue? *

[jira] [Created] (ZEPPELIN-4768) Fix typo introduced in ZEPPELIN-4722

2020-04-21 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-4768: Summary: Fix typo introduced in ZEPPELIN-4722 Key: ZEPPELIN-4768 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4768 Project: Zeppelin Issue

[GitHub] [zeppelin] zjffdu opened a new pull request #3743: [ZEPPELIN-4742]. Don't include minus sign in paragraph id

2020-04-21 Thread GitBox
zjffdu opened a new pull request #3743: URL: https://github.com/apache/zeppelin/pull/3743 ### What is this PR for? Trivial PR which just remove minus sign in paragraph id. ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the

[jira] [Created] (ZEPPELIN-4767) Add more flink tutorial notes

2020-04-21 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-4767: Summary: Add more flink tutorial notes Key: ZEPPELIN-4767 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4767 Project: Zeppelin Issue Type: Improvement

[GitHub] [zeppelin] zjffdu commented on issue #3717: [ZEPPELIN-4717]. Support savepoint for insert statement and non-sql paragraph

2020-04-21 Thread GitBox
zjffdu commented on issue #3717: URL: https://github.com/apache/zeppelin/pull/3717#issuecomment-617000201 > > @alexott Any more comments ? > > No - I think that it could be merged... Thanks,will merge it soon

[GitHub] [zeppelin] alexott commented on issue #3717: [ZEPPELIN-4717]. Support savepoint for insert statement and non-sql paragraph

2020-04-21 Thread GitBox
alexott commented on issue #3717: URL: https://github.com/apache/zeppelin/pull/3717#issuecomment-616995687 > @alexott Any more comments ? No - I think that it could be merged... This is an automated message from the

[GitHub] [zeppelin] zjffdu commented on issue #3717: [ZEPPELIN-4717]. Support savepoint for insert statement and non-sql paragraph

2020-04-21 Thread GitBox
zjffdu commented on issue #3717: URL: https://github.com/apache/zeppelin/pull/3717#issuecomment-616989521 @alexott Any more comments ? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] alexott commented on a change in pull request #3738: [ZEPPELIN-4758] Additional cleanup for Java 8 support

2020-04-21 Thread GitBox
alexott commented on a change in pull request #3738: URL: https://github.com/apache/zeppelin/pull/3738#discussion_r411901708 ## File path: .travis.yml ## @@ -170,7 +170,7 @@ before_install: - gitlog=$(git log $TRAVIS_COMMIT_RANGE 2>/dev/null) || gitlog="" -

[GitHub] [zeppelin] alexott commented on a change in pull request #3738: [ZEPPELIN-4758] Additional cleanup for Java 8 support

2020-04-21 Thread GitBox
alexott commented on a change in pull request #3738: URL: https://github.com/apache/zeppelin/pull/3738#discussion_r411901497 ## File path: bin/common.sh ## @@ -62,6 +62,20 @@ fi ZEPPELIN_CLASSPATH+=":${ZEPPELIN_CONF_DIR}" +function check_java_version() { +