Yeap.
I just merged it with Github's "Squash and Merge" button. I also wonder
which is better but I feel like both are ok but the disadvantage of Github
button is that we couldn't cherry-pick to another branch automatically.
I talked to Jeff about the same issue and we concluded both would be
zjffdu opened a new pull request, #4344:
URL: https://github.com/apache/zeppelin/pull/4344
### What is this PR for?
Currently, there's one `spark-scala-parent` module which is shared by
multiple scala module. This can reduce code duplication, but bring difficulties
for developing
Jeff Zhang created ZEPPELIN-5708:
Summary: Support to use limit as local property of jdbc interpreter
Key: ZEPPELIN-5708
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5708
Project: Zeppelin
huage1994 commented on PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#issuecomment-1088649402
> Just one last little comment. Everything else LGTM. I am not able to test
this function, but I think @huage1994 has done a lot of testing.
Done. Thanks you for the
Nathan KIENLEN created ZEPPELIN-5707:
Summary: [C*] Interpreter throw exceptions
Key: ZEPPELIN-5707
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5707
Project: Zeppelin
Issue Type:
Reamer commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842661376
##
docs/setup/storage/storage.md:
##
@@ -454,6 +454,12 @@ And you should configure oss related properties in file
**zeppelin-site.xml**.
Access key secret for your
huage1994 commented on PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#issuecomment-1088513918
> Please insert the license header into `MockStorageOperator.java` and
`RemoteStorageOperator.java`.:
I did forget. License header has been added.
--
This is an
huage1994 commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842599337
##
zeppelin-plugins/notebookrepo/oss/src/test/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepoTest.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
huage1994 commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842599337
##
zeppelin-plugins/notebookrepo/oss/src/test/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepoTest.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
Reamer opened a new pull request, #4343:
URL: https://github.com/apache/zeppelin/pull/4343
### What is this PR for?
This PR adds the license headers.
### What type of PR is it?
- Bug Fix
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5706
Philipp Dallig created ZEPPELIN-5706:
Summary: Missing license header
Key: ZEPPELIN-5706
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5706
Project: Zeppelin
Issue Type: Bug
Reamer commented on PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#issuecomment-1088465016
Please insert the license header into `MockStorageOperator.java` and
`RemoteStorageOperator.java`.
--
This is an automated message from the Apache Git Service.
To respond to the
Reamer commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842550583
##
zeppelin-plugins/notebookrepo/oss/src/test/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepoTest.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
Reamer commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842542327
##
zeppelin-plugins/notebookrepo/oss/src/main/java/org/apache/zeppelin/notebook/repo/storage/OSSOperator.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache
huage1994 commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842507608
##
zeppelin-plugins/notebookrepo/oss/src/test/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepoTest.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
huage1994 commented on PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#issuecomment-1088415263
Hi @Reamer and @zjffdu .
Your reviews is so valuable to me.
And I have corrected my code.
--
This is an automated message from the Apache Git Service.
To respond to
huage1994 commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842507608
##
zeppelin-plugins/notebookrepo/oss/src/test/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepoTest.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
zjffdu commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842483596
##
zeppelin-plugins/notebookrepo/oss/src/main/java/org/apache/zeppelin/notebook/repo/storage/OSSOperator.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache
zjffdu commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842482006
##
zeppelin-plugins/notebookrepo/oss/src/main/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepo.java:
##
@@ -63,144 +53,130 @@ public void
dependabot[bot] opened a new pull request, #4342:
URL: https://github.com/apache/zeppelin/pull/4342
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.9.10.8
to 2.12.6.1.
Commits
See full diff in https://github.com/FasterXML/jackson/commits;>compare view
dependabot[bot] opened a new pull request, #4340:
URL: https://github.com/apache/zeppelin/pull/4340
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.10.5.1
to 2.12.6.1.
Commits
See full diff in https://github.com/FasterXML/jackson/commits;>compare view
dependabot[bot] opened a new pull request, #4341:
URL: https://github.com/apache/zeppelin/pull/4341
Bumps jackson-databind from 2.10.5.1 to 2.12.6.1.
[![Dependabot compatibility
asfgit closed pull request #4333: [ZEPPELIN-5027] upgrade jackson to avoid cve
URL: https://github.com/apache/zeppelin/pull/4333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Reamer commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842451911
##
zeppelin-plugins/notebookrepo/oss/src/test/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepoTest.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
24 matches
Mail list logo
