GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1875
[ZEPPELIN-1926] Remove grunt googlefonts task
### What is this PR for?
There is no reason to download fonts files whenever we build.
- Google font doesn't change frequ
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1876
[ZEPPELIN-1927] Remove useless function wrapping in all js files
### What is this PR for?
Removed useless function wrappings to move toward `import`, `export`
syntax. This PR will not
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1875
@Leemoonsoo Thanks for detailed explanation. I will take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1875
@jongyoul small amount of :)
if you want to reduce time for `npm install`, you can use `yarn install`
instead of. It will decrease 20~50 secs.
And https://github.com/apache/zeppelin
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1868
@Leemoonsoo Thanks for review!
If https://github.com/apache/zeppelin/pull/1874 is merged soon, I can
rewrite the whole `conda env *` commands based on #1874
since current
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1877
I faced the same problem too. Thanks for fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1875
@Leemoonsoo I moved all font-related licenses from `bin_license` to
`/LICENSE`
Aldo remove rat exclusion in `zeppeiln-web/pom.xml` for `google-fonts.css`
because it is managed by us now
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1842
Let me review this PR. I wil comment again :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1761
@felixcheung Thanks for review.
Previously, we discussed about separating images in
[ZEPPEILN-1711](https://issues.apache.org/jira/browse/ZEPPELIN-1711)
IMO, having 1 image which
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1876
@Leemoonsoo
I'v just rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1868
@Leemoonsoo now `python.conda` support other `env *` commands :)
https://cloud.githubusercontent.com/assets/4968473/21827211/0130cd40-d7ce-11e6-8925-4757c6a2d6fc.png";>
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1831
@zjffdu I'v just fixed not to extend PYTHONPATH using submitted packages
only in yarn-client
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1831
**For reviewers**
Fixed to use `spark.jars` instead of `classpath`.
- classpath doesn't include submitted jars at this moment (i could get 7
days ago, but not now)
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1887
[ZEPPELIN-1940] most of eslint rules are NOT applied at all
### What is this PR for?
**Most fixes are about applying lint rules. It's automatically fixed using
`eslint --fix` co
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1875
@felixcheung
I think it's ok since all LICENSEs will be merged into a single file
-
https://github.com/apache/zeppelin/blob/master/dev/create_release.sh#L93-#L96
---
If
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1900
I hit the same issue! Thanks for fixing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1905
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1902
great Contribution for elasticsearch interpreter! This PR helps us to
support ES 5.0 easily!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1902
@bbonnin ð
@jongyoul I will take a look more deeply :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1940
[ZEPPELIN-2008] Introduce Spell
### What is this PR for?
Implemented **Spell** to Helium categories. *Technically, it's the frontend
interpreter* runs on browser not ba
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1598
@jaspinderdineout Hi :)
Zeppelin doesn't support es 5.0 currently as i know.
I will close this PR. This issue can be easily handled after #1902.
---
If your project is set up f
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1598
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1902
Works well as described.
- tested on elasticsearch 2.4.4 (transport, http) and 5.0.0 (http only)
- code looks nice. well abstracted client classes is shipped with some
tests
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1955
[ZEPPELIN-2025] Cleanup R Tutorial
### What is this PR for?
1. Remove useless paragraphs in R tutorial
2. Prettify layout
I attached screenshots for comparison. See the
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1955
@minahlee Thanks for review!
I updated notebook layout and it looks like
## Large Size
 **Couldn't make Spell as display system
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1955
[ZEPPELIN-2025] Cleanup R Tutorial
### What is this PR for?
1. Remove useless paragraphs in R tutorial
2. Prettify layout
I attached screenshots for comparison. See the
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1955
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1940
finally, CI is green. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1892
Sorry for late reply. I will review and comment ASAP @soralee
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1935
@AhyoungRyu You are welcome. I will review soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1935
@AhyoungRyu Thanks for great contribution. This PR increase the number of
helium package users significantly.
I would like to comment about the design of `helium.json`. Basically, It&#
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1952
@Leemoonsoo Nice to have abstracted table structure inside zeppelin. It
enable us many things even i just glanced at.
I will take look deeply and comment soon.
---
If your project is
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1935
Tested and works well :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1892
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1975
I think we can use only 1 `div` element instead of appending `div` for
streaming output by replacing it's contents (`html()`).
---
If your project is set up for it, you can reply to this
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1982
[ZEPPELIN-2069] Helium Package Configuration
### What is this PR for?
Supporting helium package configurations. I attached screenshots.
Implementation details.
In
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1982
@AhyoungRyu I totally agree! Now we have basic things, thus we need docs
for it. I will work it on https://issues.apache.org/jira/browse/ZEPPELIN-2070
---
If your project is set up for it, you
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1982
[ZEPPELIN-2069] Helium Package Configuration
### What is this PR for?
Supporting helium package configurations. I attached screenshots.
Implementation details.
In
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1952
Sorry for late reply. I was taking a look also recent resource related
commit to understand fully.
1. This PR is well abstracted and shipped with enough unit test.
2. And easy to
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1982
[ZEPPELIN-2069] Helium Package Configuration
### What is this PR for?
Supporting helium package configurations. I attached screenshots.
Implementation details.
In
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1989
Hi @qinchaofeng. I think you pushed different branch. Could you check again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1994
[MINOR] Replace angular inject with ngInject
### What is this PR for?
Replaced angular inject with ngInject to reduce duplication and keep
simple. There is no reason to use angular
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1995
[ZEPPELIN-2086] Move zeppelin-web related test files into src/ for
efficiency
### What is this PR for?
Since we are using a separated test directory,
- it's uncomfortab
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1998
[ZEPPELIN-2070][DOCS] Create Docs for Spell
### What is this PR for?
Docs for Spell which was added by #1940
### What type of PR is it?
[Documentation]
### Todos
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1994
[MINOR] Replace angular inject with ngInject
### What is this PR for?
Replaced angular inject with ngInject to reduce duplication and keep
simple. There is no reason to use angular
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1994
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1995
[ZEPPELIN-2086] Move zeppelin-web related test files into src/ for
efficiency
### What is this PR for?
Since we are using a separated test directory,
- it's uncomfortab
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2000
Hi @soralee :)
I would like to suggest using `'ngInject'l` instead of `$inject =
['$location'];` as like https://github.com/apache/zeppelin/pull/1994
>
htt
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
FYI - https://github.com/eirslett/frontend-maven-plugin/issues/562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2000
Looks nice :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1997
Tested and works as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1995
[ZEPPELIN-2086] Move zeppelin-web related test files into src/ for
efficiency
### What is this PR for?
Since we are using a separated test directory,
- it's uncomfortab
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1994
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1994
[MINOR] Replace angular inject with ngInject
### What is this PR for?
Replaced angular inject with ngInject to reduce duplication and keep
simple. There is no reason to use angular
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1991
@AhyoungRyu thanks for review. CI failed but irrelavent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1998
Resolved @soralee's comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1995
[ZEPPELIN-2086] Move zeppelin-web related test files into src/ for
efficiency
### What is this PR for?
Since we are using a separated test directory,
- it's uncomfortab
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2006
[ZEPPELIN-2099] Add NPM link for helium pkgs published in npm
### What is this PR for?
Add NPM link for helium pkgs published in npm while coloring grey for local
packages to distinguish
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2006
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2006
[ZEPPELIN-2099] Add NPM link for helium pkgs published in npm
### What is this PR for?
Add NPM link for helium pkgs published in npm while coloring grey for local
packages to
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2006
[ZEPPELIN-2099] Add NPM link for helium pkgs published in npm
### What is this PR for?
Add NPM link for helium pkgs published in npm while coloring grey for local
packages to
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2006
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1995
[ZEPPELIN-2086] Move zeppelin-web related test files into src/ for
efficiency
### What is this PR for?
Since we are using a separated test directory,
- it's uncomfortab
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2006
@AhyoungRyu Thanks for review. I'v changed the condition for checking local
package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1998
@AhyoungRyu Thanks for review. I'v just addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2006
Or are there other ways to figure out local package? instead of `return
pkg.artifact && !pkg.artifact.includes('@');`
---
If your project is set up for it, you can reply to t
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1995
[ZEPPELIN-2086] Move zeppelin-web related test files into src/ for
efficiency
### What is this PR for?
Since we are using a separated test directory,
- it's uncomfortab
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
@DmytroShkvyra
If you want to use node modules in terminal, you have to install them
globally. (e.g `$ yarn install`)
But in case of grunt (and karma so on..), we don't ne
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1991
@AhyoungRyu Passed selenium tests.
- https://travis-ci.org/apache/zeppelin/builds/200883455
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1991
@felixcheung Fixed. (`font-size: 12`)
---
If your project is set up for it
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2006
Thanks for reply! Then, use this logic to distinguish them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2006
@Leemoonsoo Someday
- what about black?
- we might use labels such as `local` and `online` for helium packages.
---
If your project is set up for it, you can reply to this email and
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
@DmytroShkvyra That's cool. You are trying to modify something without
understanding. Anyway, We have 2 problems.
1. local development
- you must install yarn if you want t
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2016
[ZEPPELIN-2105] yarn installed by frontend-maven-plugin causes build
failure (BUG)
### What is this PR for?
yarn installed by frontend-maven-plugin causes build failure **when there
is
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
@DmytroShkvyra Please read and try #2016
### Details
- yarn installed by frontend-maven-plugin can't run commands described in
scripts tag (package.json)
- but npm is ab
301 - 400 of 1324 matches
Mail list logo
