[GitHub] [zeppelin] huage1994 commented on pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

2022-09-19 Thread GitBox
huage1994 commented on PR #4392: URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1251031730 > Sorry for the late response @huage1994 , PR LGTM, trigger the CI again and wait for its result before merge Thanks! -- This is an automated message from the Apache Git Servi

[GitHub] [zeppelin] jongyoul commented on pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5

2022-09-19 Thread GitBox
jongyoul commented on PR #4321: URL: https://github.com/apache/zeppelin/pull/4321#issuecomment-1250823146 >I suspect the checkstyle plugin. This plugin produces a lot of the Maven warnings at the beginning. I've been wanting to fix this for a long time, but haven't gotten around to it ye

[GitHub] [zeppelin] Reamer commented on pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5

2022-09-19 Thread GitBox
Reamer commented on PR #4321: URL: https://github.com/apache/zeppelin/pull/4321#issuecomment-1250660568 I suspect the checkstyle plugin. This plugin produces a lot of the Maven warnings at the beginning. I've been wanting to fix this for a long time, but haven't gotten around to it yet.

[GitHub] [zeppelin] dependabot[bot] closed pull request #4399: Bump commons-configuration2 from 2.7 to 2.8.0

2022-09-18 Thread GitBox
dependabot[bot] closed pull request #4399: Bump commons-configuration2 from 2.7 to 2.8.0 URL: https://github.com/apache/zeppelin/pull/4399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4399: Bump commons-configuration2 from 2.7 to 2.8.0

2022-09-18 Thread GitBox
dependabot[bot] commented on PR #4399: URL: https://github.com/apache/zeppelin/pull/4399#issuecomment-1250626877 Looks like org.apache.commons:commons-configuration2 is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [zeppelin] Reamer commented on pull request #4399: Bump commons-configuration2 from 2.7 to 2.8.0

2022-09-18 Thread GitBox
Reamer commented on PR #4399: URL: https://github.com/apache/zeppelin/pull/4399#issuecomment-1250626552 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [zeppelin] zjffdu commented on pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

2022-09-18 Thread GitBox
zjffdu commented on PR #4392: URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1250220039 Sorry for the late response @huage1994 , PR LGTM, trigger the CI again and wait for its result before merge -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [zeppelin] zjffdu commented on pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5

2022-09-18 Thread GitBox
zjffdu commented on PR #4321: URL: https://github.com/apache/zeppelin/pull/4321#issuecomment-1250219661 Not sure what is the root cause, maybe you can try upgrade surefire plugin to 3.x @huage1994 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [zeppelin] huage1994 commented on pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5

2022-09-17 Thread GitBox
huage1994 commented on PR #4321: URL: https://github.com/apache/zeppelin/pull/4321#issuecomment-1250100116 When I upgrade junit 4 to junit 5 #4279 , Frontend CI job would block at downloading dependency when `mvn install` the module `k8s-standard`, but it is ok to `mvn package` this module

[GitHub] [zeppelin] PrimWILL commented on pull request #4465: [ZEPPELIN-5206] JDK 11 Support

2022-09-17 Thread GitBox
PrimWILL commented on PR #4465: URL: https://github.com/apache/zeppelin/pull/4465#issuecomment-1250051299 > I've cleaned up a bit in Jira, please adjust your Jira issue. I checked it and changed Jira issue number to 5206. > I have also played around a bit with JDK 11. Maybe this

[GitHub] [zeppelin] huage1994 commented on pull request #4459: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-09-16 Thread GitBox
huage1994 commented on PR #4459: URL: https://github.com/apache/zeppelin/pull/4459#issuecomment-1249612266 Maybe I didn't write clear about the following description, which may mislead you. Actually PR #4279 is not related to this PR in terms of content. But this PR would help to solve

[GitHub] [zeppelin] huage1994 commented on pull request #4459: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-09-16 Thread GitBox
huage1994 commented on PR #4459: URL: https://github.com/apache/zeppelin/pull/4459#issuecomment-1249597925 > Currently, the compilation of the plugins is quite fast. Where did you notice that it takes a long time? Source: Hi @Reamer, I never thought `mvn package zeppelin-plugins` wou

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4399: Bump commons-configuration2 from 2.7 to 2.8.0

2022-09-16 Thread GitBox
dependabot[bot] commented on PR #4399: URL: https://github.com/apache/zeppelin/pull/4399#issuecomment-1249584078 Sorry, only users with push access can use that command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [zeppelin] huage1994 commented on pull request #4399: Bump commons-configuration2 from 2.7 to 2.8.0

2022-09-16 Thread GitBox
huage1994 commented on PR #4399: URL: https://github.com/apache/zeppelin/pull/4399#issuecomment-1249584047 @dependabot close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4399: Bump commons-configuration2 from 2.7 to 2.8.0

2022-09-16 Thread GitBox
dependabot[bot] commented on PR #4399: URL: https://github.com/apache/zeppelin/pull/4399#issuecomment-1249583037 Sorry, only users with push access can use that command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [zeppelin] huage1994 commented on pull request #4399: Bump commons-configuration2 from 2.7 to 2.8.0

2022-09-16 Thread GitBox
huage1994 commented on PR #4399: URL: https://github.com/apache/zeppelin/pull/4399#issuecomment-1249583019 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [zeppelin] Reamer commented on pull request #4465: [ZEPPELIN-5821] Upgrade java 11

2022-09-15 Thread GitBox
Reamer commented on PR #4465: URL: https://github.com/apache/zeppelin/pull/4465#issuecomment-1248975254 I have also played around a bit with JDK 11. Maybe this will help you. https://github.com/Reamer/zeppelin/tree/jdk11 -- This is an automated message from the Apache Git Service. To resp

[GitHub] [zeppelin] Reamer commented on pull request #4465: [ZEPPELIN-5821] Upgrade java 11

2022-09-15 Thread GitBox
Reamer commented on PR #4465: URL: https://github.com/apache/zeppelin/pull/4465#issuecomment-1248970569 Hello and thank you for working on this important task. I've cleaned up a bit in Jira, please adjust your Jira issue. -- This is an automated message from the Apache Git Service. To res

[GitHub] [zeppelin] PrimWILL opened a new pull request, #4465: [ZEPPELIN-5821] Upgrade java 11

2022-09-15 Thread GitBox
PrimWILL opened a new pull request, #4465: URL: https://github.com/apache/zeppelin/pull/4465 ### What is this PR for? Upgrade java version to 11. Recently, lots of newest languages and framework decide not to support JDK 8. This is a draft PR. If you build Zeppelin using $ ./m

[GitHub] [zeppelin] Reamer commented on pull request #4459: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-09-15 Thread GitBox
Reamer commented on PR #4459: URL: https://github.com/apache/zeppelin/pull/4459#issuecomment-1248158107 Currently, the compilation of the plugins is quite fast. Where did you notice that it takes a long time? Source: https://github.com/apache/zeppelin/actions/runs/3059081927/jobs/4936042

[GitHub] [zeppelin] Reamer merged pull request #4445: [ZEPPELIN-5800] upgrade version of apache commons configuration2 to 2.8

2022-09-15 Thread GitBox
Reamer merged PR #4445: URL: https://github.com/apache/zeppelin/pull/4445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] Reamer merged pull request #4464: [ZEPPELIN-5819] Update to newer geoip jar

2022-09-15 Thread GitBox
Reamer merged PR #4464: URL: https://github.com/apache/zeppelin/pull/4464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] Reamer commented on pull request #4464: [ZEPPELIN-5819] Update to newer geoip jar

2022-09-15 Thread GitBox
Reamer commented on PR #4464: URL: https://github.com/apache/zeppelin/pull/4464#issuecomment-1247794089 Only livy CI is broken, but that will be fixed in https://github.com/apache/zeppelin/pull/4441 -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [zeppelin] Reamer opened a new pull request, #4464: [ZEPPELIN-5819] Update to newer geoip jar

2022-09-14 Thread GitBox
Reamer opened a new pull request, #4464: URL: https://github.com/apache/zeppelin/pull/4464 ### What is this PR for? Unfortunately, the main reason of the error could not be found. I have cleared the GitHub CI cache, unfortunately the problem was still present. Following comment is v

[GitHub] [zeppelin] huage1994 commented on pull request #4463: [ZEPPELIN-5493] Remove prefix in jdbc interpreter

2022-09-14 Thread GitBox
huage1994 commented on PR #4463: URL: https://github.com/apache/zeppelin/pull/4463#issuecomment-1246482194 > BTW, don't it have a doc as well? Thanks @jongyoul for reminding! I found the [hive related doc](https://zeppelin.apache.org/docs/0.10.1/interpreter/jdbc.html#apache-hive

[GitHub] [zeppelin] Reamer merged pull request #4462: [ZEPPELIN-5816] [MINOR] [JDBC] JDBCInterpreterTest.testMultiTenant_* improvement

2022-09-13 Thread GitBox
Reamer merged PR #4462: URL: https://github.com/apache/zeppelin/pull/4462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] jongyoul commented on pull request #4463: [ZEPPELIN-5493] Remove prefix in jdbc interpreter

2022-09-13 Thread GitBox
jongyoul commented on PR #4463: URL: https://github.com/apache/zeppelin/pull/4463#issuecomment-1246278555 BTW, don't it have a doc as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [zeppelin] huage1994 commented on pull request #4462: [ZEPPELIN-5816] [MINOR] [JDBC] JDBCInterpreterTest.testMultiTenant_* improvement

2022-09-13 Thread GitBox
huage1994 commented on PR #4462: URL: https://github.com/apache/zeppelin/pull/4462#issuecomment-1246176952 > So if I understand the unit tests correctly, the following asserts only test the properties and not the successful connection. Correct? > > https://github.com/apache/zeppe

[GitHub] [zeppelin] Reamer commented on pull request #4462: [ZEPPELIN-5816] [MINOR] [JDBC] JDBCInterpreterTest.testMultiTenant_* improvement

2022-09-13 Thread GitBox
Reamer commented on PR #4462: URL: https://github.com/apache/zeppelin/pull/4462#issuecomment-1245507867 So if I understand the unit tests correctly, the following asserts only test the properties and not the successful connection. Correct? https://github.com/apache/zeppelin/blob/bbe46d73

[GitHub] [zeppelin] Reamer commented on pull request #4399: Bump commons-configuration2 from 2.7 to 2.8.0

2022-09-13 Thread GitBox
Reamer commented on PR #4399: URL: https://github.com/apache/zeppelin/pull/4399#issuecomment-1245121402 > Do you have any good Idea? Unfortunately not. > Or is there any way to modify the code of this PR? I am not aware of any possibility. -- This is an automated messa

[GitHub] [zeppelin] huage1994 commented on pull request #4445: [ZEPPELIN-5800] upgrade version of apache commons configuration2 to 2.8

2022-09-13 Thread GitBox
huage1994 commented on PR #4445: URL: https://github.com/apache/zeppelin/pull/4445#issuecomment-1245038260 I found the dependabot has no ability to change the LICENSE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [zeppelin] huage1994 commented on pull request #4462: [ZEPPELIN-5816] [MINOR] [JDBC] JDBCInterpreterTest.testMultiTenant_* improvement

2022-09-12 Thread GitBox
huage1994 commented on PR #4462: URL: https://github.com/apache/zeppelin/pull/4462#issuecomment-1244832988 > Did you find out why the tests run successfully even without users? 😄 Sure. By default there is a user named '' with the password '' in the h2 database with admin privile

[GitHub] [zeppelin] Reamer merged pull request #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client

2022-09-12 Thread GitBox
Reamer merged PR #4455: URL: https://github.com/apache/zeppelin/pull/4455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] Reamer commented on pull request #4462: [ZEPPELIN-5816] [MINOR] [JDBC] JDBCInterpreterTest.testMultiTenant_* improvement

2022-09-12 Thread GitBox
Reamer commented on PR #4462: URL: https://github.com/apache/zeppelin/pull/4462#issuecomment-1243314576 Did you find out why the tests run successfully even without users? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4463: Remove prefix in jdbc interpreter

2022-09-10 Thread GitBox
huage1994 commented on code in PR #4463: URL: https://github.com/apache/zeppelin/pull/4463#discussion_r967616600 ## jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java: ## @@ -31,49 +26,33 @@ import org.apache.hadoop.security.UserGroupInformation; import org.apach

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4463: Remove prefix in jdbc interpreter

2022-09-09 Thread GitBox
jongyoul commented on code in PR #4463: URL: https://github.com/apache/zeppelin/pull/4463#discussion_r966977403 ## jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java: ## @@ -31,49 +26,33 @@ import org.apache.hadoop.security.UserGroupInformation; import org.apache

[GitHub] [zeppelin] huage1994 opened a new pull request, #4463: Remove prefix in jdbc interpreter

2022-09-09 Thread GitBox
huage1994 opened a new pull request, #4463: URL: https://github.com/apache/zeppelin/pull/4463 ### What is this PR for? Currently, zeppelin allow user to run multiple kinds of sql in one interpreter, e.g. ``` %jdbc(db=mysql) %jdbc(db=hive){code} ```   But this would make

[GitHub] [zeppelin] huage1994 opened a new pull request, #4462: [MINOR] [JDBC] JDBCInterpreterTest.testMultiTenant_* improvement

2022-09-09 Thread GitBox
huage1994 opened a new pull request, #4462: URL: https://github.com/apache/zeppelin/pull/4462 ### What is this PR for? Now In test cases `JDBCInterpreterTest.testMultiTenant_1` and `JDBCInterpreterTest.testMultiTenant_1`, the jdbc interpreter would try to connect h2 databases with 3 non-

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4461: Bump jszip from 3.2.2 to 3.10.1 in /zeppelin-web-angular

2022-09-08 Thread GitBox
dependabot[bot] opened a new pull request, #4461: URL: https://github.com/apache/zeppelin/pull/4461 Bumps [jszip](https://github.com/Stuk/jszip) from 3.2.2 to 3.10.1. Changelog Sourced from https://github.com/Stuk/jszip/blob/main/CHANGES.md";>jszip's changelog. v3.10.1 2022-

[GitHub] [zeppelin] Geetha7891 commented on pull request #4400: ZEPPELIN-3527. replace log4j with reload4j

2022-09-08 Thread GitBox
Geetha7891 commented on PR #4400: URL: https://github.com/apache/zeppelin/pull/4400#issuecomment-1240681386 @Samrat002 Thanks a lot for your support. Let me try to work on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zeppelin] jongyoul commented on pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-09-08 Thread GitBox
jongyoul commented on PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#issuecomment-1240443759 > What do you think about including hk2 on in the zeppelin-zengine module? I, totally, agree with you. It would be better to adopt it but to do it, we might need effort to do it.

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client

2022-09-07 Thread GitBox
Reamer commented on code in PR #4455: URL: https://github.com/apache/zeppelin/pull/4455#discussion_r965550469 ## zeppelin-jupyter-interpreter/src/main/java/org/apache/zeppelin/jupyter/PythonPackagePredicate.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4460: Bump jszip from 3.1.5 to 3.10.1 in /zeppelin-web

2022-09-07 Thread GitBox
dependabot[bot] opened a new pull request, #4460: URL: https://github.com/apache/zeppelin/pull/4460 Bumps [jszip](https://github.com/Stuk/jszip) from 3.1.5 to 3.10.1. Changelog Sourced from https://github.com/Stuk/jszip/blob/main/CHANGES.md";>jszip's changelog. v3.10.1 2022-

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client

2022-09-07 Thread GitBox
zjffdu commented on code in PR #4455: URL: https://github.com/apache/zeppelin/pull/4455#discussion_r964932667 ## zeppelin-jupyter-interpreter/src/main/java/org/apache/zeppelin/jupyter/PythonPackagePredicate.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [zeppelin] Reamer commented on pull request #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client

2022-09-07 Thread GitBox
Reamer commented on PR #4455: URL: https://github.com/apache/zeppelin/pull/4455#issuecomment-1239443337 Yes you are probably right. I wrote this bugfix without rebuilding the existing verification to fix the bug quickly. If you want to rewrite the part, feel free to do so. -- This is a

[GitHub] [zeppelin] huage1994 opened a new pull request, #4459: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-09-07 Thread GitBox
huage1994 opened a new pull request, #4459: URL: https://github.com/apache/zeppelin/pull/4459 ### What is this PR for? This PR is to improve a some step in Frontend CI jobs. There are two command in this step in file `frontend.yml` as follow: https://github.com/apache/zeppe

[GitHub] [zeppelin] jongyoul commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

2022-09-06 Thread GitBox
jongyoul commented on PR #4458: URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1237937747 @proceane You will find detailed information on why CI fails in logs. E.g. ``` Dependency convergence error for commons-net:commons-net:3.8.0 paths to dependency are: +-org.

[GitHub] [zeppelin] jongyoul commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

2022-09-06 Thread GitBox
jongyoul commented on PR #4458: URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1237901721 @proceane You'd better change the status of this PR from `open` to `draft` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [zeppelin] jongyoul merged pull request #4453: [ZEPPELIN-5804] support python 3.10

2022-09-06 Thread GitBox
jongyoul merged PR #4453: URL: https://github.com/apache/zeppelin/pull/4453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[GitHub] [zeppelin] zjffdu commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

2022-09-06 Thread GitBox
zjffdu commented on PR #4458: URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1237807031 @proceane CI is failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [zeppelin] PrimWILL commented on pull request #4453: [ZEPPELIN-5804] support python 3.10

2022-09-06 Thread GitBox
PrimWILL commented on PR #4453: URL: https://github.com/apache/zeppelin/pull/4453#issuecomment-1237774028 > Then I'll register related issue in jira. You can see the issue in [here](https://issues.apache.org/jira/browse/ZEPPELIN-5814). -- This is an automated message from the A

[GitHub] [zeppelin] PrimWILL commented on pull request #4453: [ZEPPELIN-5804] support python 3.10

2022-09-05 Thread GitBox
PrimWILL commented on PR #4453: URL: https://github.com/apache/zeppelin/pull/4453#issuecomment-1237695966 > Sooner or later we should also test with Python 3.10 in the CI setup. But this can be done in a separate pull request. Got it. Then I'll register related issue in jira. -- T

[GitHub] [zeppelin] proceane opened a new pull request, #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

2022-09-05 Thread GitBox
proceane opened a new pull request, #4458: URL: https://github.com/apache/zeppelin/pull/4458 ### What is this PR for? This is the task of adding a spring boot dependency to switch JaxRs and Jersey to Spring. ### What type of PR is it? Improvement ### Todos * [x] - Add

[GitHub] [zeppelin] ebuildy closed pull request #4457: fix(livy): tests dist URL

2022-09-05 Thread GitBox
ebuildy closed pull request #4457: fix(livy): tests dist URL URL: https://github.com/apache/zeppelin/pull/4457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [zeppelin] Reamer commented on pull request #4453: [ZEPPELIN-5804] support python 3.10

2022-09-05 Thread GitBox
Reamer commented on PR #4453: URL: https://github.com/apache/zeppelin/pull/4453#issuecomment-1236869045 > Do I have to add more python tests for 3.10 in CI? Sooner or later we should also test with Python 3.10 in the CI setup. But this can be done in a separate pull request. -- Thi

[GitHub] [zeppelin] soicem commented on pull request #4441: [ZEPPELIN-4871] Fix livy interpreter 0.7.1 donwload link

2022-09-05 Thread GitBox
soicem commented on PR #4441: URL: https://github.com/apache/zeppelin/pull/4441#issuecomment-1236849199 @jongyoul I'll try one more time. thank you ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zeppelin] zlosim commented on a diff in pull request #4398: [ZEPPELIN-5760] fix passing configs to spark in k8s

2022-09-05 Thread GitBox
zlosim commented on code in PR #4398: URL: https://github.com/apache/zeppelin/pull/4398#discussion_r962573264 ## zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcess.java: ## @@ -403,28 +420,35 @@ boolean isSpa

[GitHub] [zeppelin] zlosim commented on a diff in pull request #4398: [ZEPPELIN-5760] fix passing configs to spark in k8s

2022-09-05 Thread GitBox
zlosim commented on code in PR #4398: URL: https://github.com/apache/zeppelin/pull/4398#discussion_r962569551 ## zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcess.java: ## @@ -403,28 +420,35 @@ boolean isSpa

[GitHub] [zeppelin] jongyoul commented on pull request #4453: [ZEPPELIN-5804] support python 3.10

2022-09-04 Thread GitBox
jongyoul commented on PR #4453: URL: https://github.com/apache/zeppelin/pull/4453#issuecomment-1236508920 I'll merge it if there's no further discussion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [zeppelin] jongyoul commented on pull request #4441: [ZEPPELIN-4871] Fix livy interpreter 0.7.1 donwload link

2022-09-04 Thread GitBox
jongyoul commented on PR #4441: URL: https://github.com/apache/zeppelin/pull/4441#issuecomment-1236508761 @soicem Concerning the error, did you download and set env for Livy in your local machine? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [zeppelin] jongyoul commented on pull request #4457: fix(livy): tests dist URL

2022-09-04 Thread GitBox
jongyoul commented on PR #4457: URL: https://github.com/apache/zeppelin/pull/4457#issuecomment-1236508180 It is duplicated with #4441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] ebuildy opened a new pull request, #4457: fix(livy): tests dist URL

2022-09-04 Thread GitBox
ebuildy opened a new pull request, #4457: URL: https://github.com/apache/zeppelin/pull/4457 ### What is this PR for? Livy dist download URL has changed a little bit, this PR fix it. ### What type of PR is it? Bug Fix -- This is an automated message from the Apache

[GitHub] [zeppelin] jaegwonseo closed pull request #4456: Add custom labels to k8s interpreter

2022-09-04 Thread GitBox
jaegwonseo closed pull request #4456: Add custom labels to k8s interpreter URL: https://github.com/apache/zeppelin/pull/4456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [zeppelin] jaegwonseo commented on pull request #4456: Add custom labels to k8s interpreter

2022-09-04 Thread GitBox
jaegwonseo commented on PR #4456: URL: https://github.com/apache/zeppelin/pull/4456#issuecomment-1236325017 > I am against the MR, because today it is about labels, tomorrow in annotations and the day after tomorrow about additional initContainers. Please adjust your Jinja2 template. This c

[GitHub] [zeppelin] ebuildy commented on pull request #4456: Add custom labels to k8s interpreter

2022-09-02 Thread GitBox
ebuildy commented on PR #4456: URL: https://github.com/apache/zeppelin/pull/4456#issuecomment-1235690039 Templating is very powerfull, you can use jinja conditionnal tags to have some labels for a particular interpreter etc... -- This is an automated message from the Apache Git Service. T

[GitHub] [zeppelin] ebuildy commented on pull request #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client

2022-09-02 Thread GitBox
ebuildy commented on PR #4455: URL: https://github.com/apache/zeppelin/pull/4455#issuecomment-1235688109 This kind of code, very related to the environnement, should be moved from java to a shell or python script. So this make easy to override and maitain it without recompiling all th

[GitHub] [zeppelin] Reamer commented on pull request #4456: Add custom labels to k8s interpreter

2022-09-02 Thread GitBox
Reamer commented on PR #4456: URL: https://github.com/apache/zeppelin/pull/4456#issuecomment-1235386873 I am against the MR, because today it is about labels, tomorrow in annotations and the day after tomorrow about additional initContainers. Please adjust your Jinja2 template. This can be

[GitHub] [zeppelin] huage1994 commented on pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

2022-09-01 Thread GitBox
huage1994 commented on PR #4392: URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1235004458 The CI is passed in my own forked repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] PrimWILL commented on pull request #4453: [ZEPPELIN-5804] support python 3.10

2022-09-01 Thread GitBox
PrimWILL commented on PR #4453: URL: https://github.com/apache/zeppelin/pull/4453#issuecomment-1234928316 > I think this should be tested via CI. In CI, this already passed python 3.7 and python 3.8 tests . Do I have to add more python tests for 3.10 in CI? -- This is an automated

[GitHub] [zeppelin] Reamer commented on pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-09-01 Thread GitBox
Reamer commented on PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#issuecomment-1234466448 @jongyoul I've been thinking about this approach for a while, and I think I wanted to use the pf4j library to compensate for the lack of hk2 in zeppelin-zengine. What do you think abo

[GitHub] [zeppelin] zkytech commented on pull request #4443: [ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

2022-09-01 Thread GitBox
zkytech commented on PR #4443: URL: https://github.com/apache/zeppelin/pull/4443#issuecomment-1234411489 > @zkytech Have you resolved the issue in the above comment ?[#4443 (comment)](https://github.com/apache/zeppelin/pull/4443#issuecomment-1214710538) Yes, It has been fixed in this comm

[GitHub] [zeppelin] zjffdu commented on pull request #4443: [ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

2022-09-01 Thread GitBox
zjffdu commented on PR #4443: URL: https://github.com/apache/zeppelin/pull/4443#issuecomment-1234380900 @zkytech Have you resolved the issue in the above comment ?https://github.com/apache/zeppelin/pull/4443#issuecomment-1214710538 -- This is an automated message from the Apache Git Servi

[GitHub] [zeppelin] zkytech commented on pull request #4443: [ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

2022-09-01 Thread GitBox
zkytech commented on PR #4443: URL: https://github.com/apache/zeppelin/pull/4443#issuecomment-1234367294 > ping @zkytech What should I do next? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [zeppelin] jaegwonseo commented on pull request #4456: Add custom labels to k8s interpreter

2022-09-01 Thread GitBox
jaegwonseo commented on PR #4456: URL: https://github.com/apache/zeppelin/pull/4456#issuecomment-1234366331 In order to deploy with different settings to n k8s clusters, different zeppelin-site.xml files are mounted and used for each cluster. If Jinja template also needs to be created

[GitHub] [zeppelin] Reamer commented on pull request #4456: Add custom labels to k8s interpreter

2022-09-01 Thread GitBox
Reamer commented on PR #4456: URL: https://github.com/apache/zeppelin/pull/4456#issuecomment-1234344984 What prevents you from including your own labels in your Jinja template? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4398: [ZEPPELIN-5760] fix passing configs to spark in k8s

2022-09-01 Thread GitBox
Reamer commented on code in PR #4398: URL: https://github.com/apache/zeppelin/pull/4398#discussion_r960708753 ## zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcess.java: ## @@ -403,28 +420,35 @@ boolean isSpa

[GitHub] [zeppelin] Reamer commented on pull request #4453: [ZEPPELIN-5804] support python 3.10

2022-09-01 Thread GitBox
Reamer commented on PR #4453: URL: https://github.com/apache/zeppelin/pull/4453#issuecomment-1234330964 I think this should be tested via CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [zeppelin] jaegwonseo opened a new pull request, #4456: Add custom labels to k8s interpreter

2022-09-01 Thread GitBox
jaegwonseo opened a new pull request, #4456: URL: https://github.com/apache/zeppelin/pull/4456 ### What type of PR is it? to run interpreter on eks fargate, add custom labels to k8s interpreter ### How should this be tested? add zeppelin.k8s.interpreter.customLabels to zeppelin-

[GitHub] [zeppelin] Reamer opened a new pull request, #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client

2022-09-01 Thread GitBox
Reamer opened a new pull request, #4455: URL: https://github.com/apache/zeppelin/pull/4455 ### What is this PR for? This pull request changes the Python dependency check minimally to get high flexibility for the package check. ### What type of PR is it? - Bug Fix ### What

[GitHub] [zeppelin] jongyoul merged pull request #4454: Remove useless pom file `pom-groovy-only.xml` in `zeppelin-groovy`

2022-08-31 Thread GitBox
jongyoul merged PR #4454: URL: https://github.com/apache/zeppelin/pull/4454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[GitHub] [zeppelin] zjffdu commented on pull request #4443: [ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

2022-08-31 Thread GitBox
zjffdu commented on PR #4443: URL: https://github.com/apache/zeppelin/pull/4443#issuecomment-1233038882 ping @zkytech -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [zeppelin] zjffdu commented on pull request #4454: Remove useless pom file `pom-groovy-only.xml` in `zeppelin-groovy`

2022-08-31 Thread GitBox
zjffdu commented on PR #4454: URL: https://github.com/apache/zeppelin/pull/4454#issuecomment-1233036518 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [zeppelin] huage1994 opened a new pull request, #4454: Remove useless pom file `pom-groovy-only.xml` in `zeppelin-groovy`

2022-08-31 Thread GitBox
huage1994 opened a new pull request, #4454: URL: https://github.com/apache/zeppelin/pull/4454 ### What is this PR for? Remove useless pom file `pom-groovy-only.xml` in `zeppelin-groovy` ### What type of PR is it? Improvement ### Todos * [ ] - Task ##

[GitHub] [zeppelin] jongyoul commented on pull request #4441: [ZEPPELIN-4871] Fix livy interpreter 0.7.1 donwload link

2022-08-29 Thread GitBox
jongyoul commented on PR #4441: URL: https://github.com/apache/zeppelin/pull/4441#issuecomment-123024 @zjffdu Could you please answer the question? I think we need to set up some Livy environment to test it. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [zeppelin] soicem commented on pull request #4441: [ZEPPELIN-4871] Fix livy interpreter 0.7.1 donwload link

2022-08-28 Thread GitBox
soicem commented on PR #4441: URL: https://github.com/apache/zeppelin/pull/4441#issuecomment-1229478898 Hello @jongyoul. sorry for late. I want to add a programmatic interpreter of livy 0.7.1 by referring to existing code. So, I tried to run the existing test code(LivyInterpreterIT.

[GitHub] [zeppelin] PrimWILL opened a new pull request, #4453: [ZEPPELIN-5804] support python 3.10

2022-08-27 Thread GitBox
PrimWILL opened a new pull request, #4453: URL: https://github.com/apache/zeppelin/pull/4453 ### What is this PR for? Change py4j version (0.10.7 -> 0.10.9.7) in python interpreter directory to support python 3.10 ### What type of PR is it? Improvement ### Todos * [ ]

[GitHub] [zeppelin] soicem commented on pull request #4441: [ZEPPELIN-4871] Fix livy interpreter 0.7.1 donwload link

2022-08-27 Thread GitBox
soicem commented on PR #4441: URL: https://github.com/apache/zeppelin/pull/4441#issuecomment-1229208569 I'm writing the test code. After that, i will request a code review ! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zeppelin] maziyarpanahi commented on pull request #4439: [ZEPPELIN-5191] Fix the wrong Docker image name in zeppelin-server.yaml

2022-08-26 Thread GitBox
maziyarpanahi commented on PR #4439: URL: https://github.com/apache/zeppelin/pull/4439#issuecomment-1228200468 > Hello @maziyarpanahi > > Zeppelin is quite complex and I agree that the documentation is not very useful. > > On the whole, I would like to get rid of the apache/zep

[GitHub] [zeppelin] Reamer commented on pull request #4439: [ZEPPELIN-5191] Fix the wrong Docker image name in zeppelin-server.yaml

2022-08-26 Thread GitBox
Reamer commented on PR #4439: URL: https://github.com/apache/zeppelin/pull/4439#issuecomment-1228170509 Hello @maziyarpanahi Zeppelin is quite complex and I agree that the documentation is not very useful. On the whole, I would like to get rid of the apache/zeppelin docker imag

[GitHub] [zeppelin] maziyarpanahi commented on pull request #4439: [ZEPPELIN-5191] Fix the wrong Docker image name in zeppelin-server.yaml

2022-08-25 Thread GitBox
maziyarpanahi commented on PR #4439: URL: https://github.com/apache/zeppelin/pull/4439#issuecomment-1228110762 > @maziyarpanahi Hello, BTW what is this? > > ``` > curl -s -O https://raw.githubusercontent.com/apache/zeppelin/master/k8s/zeppelin-server.yaml > ``` Apologies,

[GitHub] [zeppelin] jongyoul commented on pull request #4439: [ZEPPELIN-5191] Fix the wrong Docker image name in zeppelin-server.yaml

2022-08-25 Thread GitBox
jongyoul commented on PR #4439: URL: https://github.com/apache/zeppelin/pull/4439#issuecomment-1227910257 @maziyarpanahi Hello, BTW what is this? ``` curl -s -O https://raw.githubusercontent.com/apache/zeppelin/master/k8s/zeppelin-server.yaml ``` -- This is an automated message f

[GitHub] [zeppelin] soicem commented on pull request #4441: [ZEPPELIN-4871] Fix livy interpreter 0.7.1 donwload link

2022-08-25 Thread GitBox
soicem commented on PR #4441: URL: https://github.com/apache/zeppelin/pull/4441#issuecomment-1227184511 @jongyoul I will verify your feedback on this weekend! thank you for the notification :) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] jongyoul commented on pull request #4441: [ZEPPELIN-4871] Fix livy interpreter 0.7.1 donwload link

2022-08-25 Thread GitBox
jongyoul commented on PR #4441: URL: https://github.com/apache/zeppelin/pull/4441#issuecomment-1227178870 @soicem ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [zeppelin] dependabot[bot] commented on pull request #3507: Bump ffi from 1.9.3 to 1.11.1 in /docs

2022-08-25 Thread GitBox
dependabot[bot] commented on PR #3507: URL: https://github.com/apache/zeppelin/pull/3507#issuecomment-1226977287 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.

[GitHub] [zeppelin] jongyoul merged pull request #4440: Bump postgresql from 42.3.3 to 42.4.1 in /jdbc

2022-08-25 Thread GitBox
jongyoul merged PR #4440: URL: https://github.com/apache/zeppelin/pull/4440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[GitHub] [zeppelin] jongyoul merged pull request #4384: Bump xercesImpl from 2.11.0.SP5 to 2.12.2 in /jdbc

2022-08-25 Thread GitBox
jongyoul merged PR #4384: URL: https://github.com/apache/zeppelin/pull/4384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[GitHub] [zeppelin] jongyoul merged pull request #4372: Bump gson from 2.8.6 to 2.8.9 in /bigquery

2022-08-25 Thread GitBox
jongyoul merged PR #4372: URL: https://github.com/apache/zeppelin/pull/4372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[GitHub] [zeppelin] jongyoul closed pull request #3277: [ZEPPELIN-2881] Fix OIDC logout

2022-08-25 Thread GitBox
jongyoul closed pull request #3277: [ZEPPELIN-2881] Fix OIDC logout URL: https://github.com/apache/zeppelin/pull/3277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [zeppelin] jongyoul commented on pull request #3277: [ZEPPELIN-2881] Fix OIDC logout

2022-08-25 Thread GitBox
jongyoul commented on PR #3277: URL: https://github.com/apache/zeppelin/pull/3277#issuecomment-1226970081 Thank you for your interest but it's quite an old PR so please make another PR if it's still a problem. I'll review it eagerly if you make a new one. Thank you for your interest. --

[GitHub] [zeppelin] jongyoul closed pull request #2900: Alluxio

2022-08-25 Thread GitBox
jongyoul closed pull request #2900: Alluxio URL: https://github.com/apache/zeppelin/pull/2900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

<    1   2   3   4   5   6   7   8   9   10   >