zjffdu commented on pull request #4096:
URL: https://github.com/apache/zeppelin/pull/4096#issuecomment-822128444
Will merge it soon so that it won't block other PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
zjffdu opened a new pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/contri
asfgit closed pull request #4096:
URL: https://github.com/apache/zeppelin/pull/4096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zjffdu opened a new pull request #4098:
URL: https://github.com/apache/zeppelin/pull/4098
### What is this PR for?
This PR is to support yarn application mode of flink interpreter. In yarn
application mode, flink interpreter is running in JM. Integration test is
added.
### W
cuspymd commented on a change in pull request #4098:
URL: https://github.com/apache/zeppelin/pull/4098#discussion_r615706250
##
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/ExecRemoteInterpreterProcess.java
##
@@ -215,6 +215,14 @@ public voi
zjffdu commented on a change in pull request #4098:
URL: https://github.com/apache/zeppelin/pull/4098#discussion_r615960200
##
File path:
flink/flink1.12-shims/src/main/java/org/apache/zeppelin/flink/Flink112Shims.java
##
@@ -173,13 +173,26 @@ public Object createCatalogManage
zjffdu commented on a change in pull request #4098:
URL: https://github.com/apache/zeppelin/pull/4098#discussion_r615960950
##
File path:
flink/interpreter/src/main/java/org/apache/zeppelin/flink/YarnApplicationExecutionEnvironment.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to
zjffdu commented on a change in pull request #4098:
URL: https://github.com/apache/zeppelin/pull/4098#discussion_r615960950
##
File path:
flink/interpreter/src/main/java/org/apache/zeppelin/flink/YarnApplicationExecutionEnvironment.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to
cuspymd commented on a change in pull request #4098:
URL: https://github.com/apache/zeppelin/pull/4098#discussion_r616012945
##
File path:
zeppelin-plugins/launcher/flink/src/main/java/org/apache/zeppelin/interpreter/launcher/FlinkInterpreterLauncher.java
##
@@ -55,6 +64,65 @@
zjffdu commented on pull request #4090:
URL: https://github.com/apache/zeppelin/pull/4090#issuecomment-822924848
LGTM, thanks @cuspymd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
asfgit closed pull request #4094:
URL: https://github.com/apache/zeppelin/pull/4094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
asfgit closed pull request #4091:
URL: https://github.com/apache/zeppelin/pull/4091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
asfgit closed pull request #4090:
URL: https://github.com/apache/zeppelin/pull/4090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
dannycranmer commented on pull request #4092:
URL: https://github.com/apache/zeppelin/pull/4092#issuecomment-823047051
@Reamer/@cuspymd what are the next steps to get this merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
zjffdu commented on a change in pull request #4098:
URL: https://github.com/apache/zeppelin/pull/4098#discussion_r616455596
##
File path:
zeppelin-plugins/launcher/flink/src/main/java/org/apache/zeppelin/interpreter/launcher/FlinkInterpreterLauncher.java
##
@@ -55,6 +64,65 @@
zjffdu commented on pull request #4088:
URL: https://github.com/apache/zeppelin/pull/4088#issuecomment-823132762
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zjffdu commented on a change in pull request #4080:
URL: https://github.com/apache/zeppelin/pull/4080#discussion_r616518254
##
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/ExecRemoteInterpreterProcess.java
##
@@ -175,6 +177,7 @@ public void
zjffdu commented on pull request #4079:
URL: https://github.com/apache/zeppelin/pull/4079#issuecomment-823135046
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zjffdu commented on pull request #4095:
URL: https://github.com/apache/zeppelin/pull/4095#issuecomment-823147992
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For q
asfgit closed pull request #4095:
URL: https://github.com/apache/zeppelin/pull/4095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
Reamer commented on pull request #4080:
URL: https://github.com/apache/zeppelin/pull/4080#issuecomment-823231757
testConnectExistOnlineIntpProcess(org.apache.zeppelin.interpreter.launcher.ClusterInterpreterLauncherTest)`
fails twice in CI.
--
This is an automated message from the Apac
cuspymd commented on a change in pull request #4098:
URL: https://github.com/apache/zeppelin/pull/4098#discussion_r616792488
##
File path: docs/interpreter/flink.md
##
@@ -266,6 +266,7 @@ Flink in Zeppelin supports 3 execution modes
(`flink.execution.mode`):
* Local
* Remote
cuspymd commented on a change in pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#discussion_r616816582
##
File path:
zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnRemoteInterpreterProcess.java
##
@@ -242,13 +244
zjffdu commented on a change in pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#discussion_r616830363
##
File path:
zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnRemoteInterpreterProcess.java
##
@@ -316,6 +344,2
zjffdu commented on a change in pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#discussion_r616830110
##
File path:
zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnRemoteInterpreterProcess.java
##
@@ -242,13 +244,
zjffdu commented on a change in pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#discussion_r616831897
##
File path:
zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnRemoteInterpreterProcess.java
##
@@ -266,6 +270,3
Jiabao-Sun opened a new pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099
### What is this PR for?
Add flink.udf.packages configuration to support udf jars in maven repository.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZE
Reamer commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-824057131
I think this is also a great feature for the K8s launcher. Unfortunately, I
don't see any way to manipulate files before launching, like you did with YARN.
Any ideas how we can
cuspymd commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r617569641
##
File path: docs/interpreter/flink.md
##
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are
not listed in the tabl
Jiabao-Sun commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r617670254
##
File path: docs/interpreter/flink.md
##
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are
not listed in the tabl
cuspymd commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r618062546
##
File path: docs/interpreter/flink.md
##
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are
not listed in the tabl
zjffdu commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r618073216
##
File path: docs/interpreter/flink.md
##
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are
not listed in the tabl
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-824535028
@Reamer Regarding your experience, would building conda env into docker
image works for users ?
User can use a base docker image with lots of common used python packages
for
zjffdu commented on pull request #4092:
URL: https://github.com/apache/zeppelin/pull/4092#issuecomment-824535580
@dannycranmer Could you rebase and retrigger the CI ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
zjffdu commented on a change in pull request #4098:
URL: https://github.com/apache/zeppelin/pull/4098#discussion_r618078514
##
File path: docs/interpreter/flink.md
##
@@ -266,6 +266,7 @@ Flink in Zeppelin supports 3 execution modes
(`flink.execution.mode`):
* Local
* Remote
asfgit closed pull request #4088:
URL: https://github.com/apache/zeppelin/pull/4088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
asfgit closed pull request #4079:
URL: https://github.com/apache/zeppelin/pull/4079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
Jiabao-Sun commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r617670254
##
File path: docs/interpreter/flink.md
##
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are
not listed in the tabl
Jiabao-Sun commented on a change in pull request #4099:
URL: https://github.com/apache/zeppelin/pull/4099#discussion_r618104488
##
File path: docs/interpreter/flink.md
##
@@ -155,6 +155,16 @@ You can also add and set other flink properties which are
not listed in the tabl
Reamer commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-824591596
> Regarding your experience, would building conda env into docker image
works for users ?
It works, but it's not as flexible as your approach with YARN. At the moment
it'
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-824601359
@Reamer Actually the approach here also apply for pyspark interpreter, I
have verified that
--
This is an automated message from the Apache Git Service.
To respond to the mes
zjffdu edited a comment on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-824601359
@Reamer Actually the approach here also apply for pyspark interpreter but
with different setting, I have verified that
--
This is an automated message from the Apache
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-824603467
> Updates of the image with a changed Python version and libraries are not
really possible because you don't know which other notebooks might be broken
afterwards.
I mean
zjffdu edited a comment on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-824603467
> Updates of the image with a changed Python version and libraries are not
really possible because you don't know which other notebooks might be broken
afterwards.
zjffdu edited a comment on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-824603467
> Updates of the image with a changed Python version and libraries are not
really possible because you don't know which other notebooks might be broken
afterwards.
dannycranmer commented on pull request #4092:
URL: https://github.com/apache/zeppelin/pull/4092#issuecomment-824641631
@zjffdu done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
Reamer commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-824736245
> I mean allowing user to choose different image for their notes.
Customizing image won't be a frequent operation IIUC
Maintaining different Zeppelin interpreter images is
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-825324712
> > I mean allowing user to choose different image for their notes.
Customizing image won't be a frequent operation IIUC
>
> Maintaining different Zeppelin interpreter ima
Reamer commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-825479159
> Although the image size may look a little big, the physical size or
downloading size would be the same of using the current python interpreter
image and then download the pyth
Reamer edited a comment on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-825479159
> Although the image size may look a little big, the physical size or
downloading size would be the same of using the current python interpreter
image and then download t
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-825500280
Thanks @Reamer `spark.archives` seems to be able to work both in yarn and
k8s, let me try this.
--
This is an automated message from the Apache Git Service.
To respond to the
cuspymd opened a new pull request #4100:
URL: https://github.com/apache/zeppelin/pull/4100
### What is this PR for?
Fix Inaccurate markdowns and typos in documentations
Improve code highlight
### What type of PR is it?
[Documentation]
### What is the Jira issue?
* h
zjffdu commented on pull request #4100:
URL: https://github.com/apache/zeppelin/pull/4100#issuecomment-826212878
Thanks @cuspymd LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-826297779
@Reamer `spark.archives` works, but it is only available after spark 3.1,
and I think it is better to put conda env in cloud storage and then specify it
via `spark.archives` (be
asfgit closed pull request #4100:
URL: https://github.com/apache/zeppelin/pull/4100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zjffdu commented on pull request #4092:
URL: https://github.com/apache/zeppelin/pull/4092#issuecomment-826334395
Thanks @dannycranmer will merge it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
asfgit closed pull request #4092:
URL: https://github.com/apache/zeppelin/pull/4092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zjffdu commented on pull request #4100:
URL: https://github.com/apache/zeppelin/pull/4100#issuecomment-826212878
Thanks @cuspymd LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-826297779
@Reamer `spark.archives` works, but it is only available after spark 3.1,
and I think it is better to put conda env in cloud storage and then specify it
via `spark.archives` (be
asfgit closed pull request #4092:
URL: https://github.com/apache/zeppelin/pull/4092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zjffdu commented on pull request #4092:
URL: https://github.com/apache/zeppelin/pull/4092#issuecomment-826334395
Thanks @dannycranmer will merge it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
asfgit closed pull request #4100:
URL: https://github.com/apache/zeppelin/pull/4100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
cuspymd opened a new pull request #4101:
URL: https://github.com/apache/zeppelin/pull/4101
### What is this PR for?
Apply syntax highlight for sample JSON in REST API documents
### What type of PR is it?
[Documentation]
### What is the Jira issue?
* https://iss
zjffdu commented on pull request #4101:
URL: https://github.com/apache/zeppelin/pull/4101#issuecomment-827480209
Looks like some tests are failed due to network issue, could you trigger the
CI again ? @cuspymd
--
This is an automated message from the Apache Git Service.
To respond to th
cuspymd commented on pull request #4101:
URL: https://github.com/apache/zeppelin/pull/4101#issuecomment-827506425
>
>
> Looks like some tests are failed due to network issue, could you trigger
the CI again ? @cuspymd
How can I re-trigger
>
>
> Looks like some
cuspymd edited a comment on pull request #4101:
URL: https://github.com/apache/zeppelin/pull/4101#issuecomment-827506425
>
>
> Looks like some tests are failed due to network issue, could you trigger
the CI again ? @cuspymd
How can I re-trigger the CI?
--
This is an au
asm0dey opened a new pull request #4102:
URL: https://github.com/apache/zeppelin/pull/4102
### What is this PR for?
If a user is passing an invalid argument to zeppelin.sh it freezes in an
infinite loop. This small change changes this behavior and outputs usage
information instead o
zjffdu commented on pull request #4101:
URL: https://github.com/apache/zeppelin/pull/4101#issuecomment-827708684
@cuspymd Do a force push can trigger the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
cuspymd commented on a change in pull request #4102:
URL: https://github.com/apache/zeppelin/pull/4102#discussion_r621336880
##
File path: bin/zeppelin.sh
##
@@ -68,6 +68,9 @@ do
-h)
usage
;;
+*)
+usage
+;;
Review comment:
It c
asm0dey commented on a change in pull request #4102:
URL: https://github.com/apache/zeppelin/pull/4102#discussion_r621457080
##
File path: bin/zeppelin.sh
##
@@ -68,6 +68,9 @@ do
-h)
usage
;;
+*)
+usage
+;;
Review comment:
Agre
Reamer commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-827815927
You are right, putting the Conda environment in a cloud storage will be the
best option. Do you have any idea what possibilities for integration
`spark.archives` supports? Local
Reamer edited a comment on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-827815927
You are right, putting the Conda environment in a cloud storage will be the
best option. Do you have any idea what possibilities for integration
`spark.archives` supports
cuspymd commented on a change in pull request #4102:
URL: https://github.com/apache/zeppelin/pull/4102#discussion_r621830856
##
File path: bin/zeppelin.sh
##
@@ -68,6 +68,9 @@ do
-h)
usage
;;
+*)
+usage
+;;
Review comment:
It w
asm0dey commented on a change in pull request #4102:
URL: https://github.com/apache/zeppelin/pull/4102#discussion_r621856348
##
File path: bin/zeppelin.sh
##
@@ -68,6 +68,9 @@ do
-h)
usage
;;
+*)
+usage
+;;
Review comment:
Done
Reamer commented on pull request #4102:
URL: https://github.com/apache/zeppelin/pull/4102#issuecomment-828371207
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For q
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-829880959
@Reamer The checks are unexpectedly failing. Could you please help with
this, along with the code review? Thank you.
--
This is an automated message from the Apache Git S
cuspymd opened a new pull request #4103:
URL: https://github.com/apache/zeppelin/pull/4103
### What is this PR for?
Fix broken links and typos in document
### What type of PR is it?
[Documentation]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEP
zjffdu commented on pull request #4103:
URL: https://github.com/apache/zeppelin/pull/4103#issuecomment-830637047
Thanks @cuspymd LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
zjffdu commented on pull request #4098:
URL: https://github.com/apache/zeppelin/pull/4098#issuecomment-830637778
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-830638631
For spark interpreter, we can leverage `spark.archives` to download and
setup conda environment in both driver(spark interpreter) and executor. But for
python interpreter, I don
zjffdu opened a new pull request #4104:
URL: https://github.com/apache/zeppelin/pull/4104
### What is this PR for?
Currently, we have to change log4j.properties to get more output from script
`interpreter.sh` in log4j output for diagnose. This PR is to add one trick: as
long as the
zjffdu opened a new pull request #4105:
URL: https://github.com/apache/zeppelin/pull/4105
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/contri
asfgit closed pull request #4098:
URL: https://github.com/apache/zeppelin/pull/4098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zjffdu opened a new pull request #4106:
URL: https://github.com/apache/zeppelin/pull/4106
### What is this PR for?
The root cause in `commons.vfs2`, upgrading `commons.vfs2` can fix this
issue.
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
###
asfgit closed pull request #4103:
URL: https://github.com/apache/zeppelin/pull/4103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
asfgit closed pull request #4101:
URL: https://github.com/apache/zeppelin/pull/4101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
cuspymd commented on a change in pull request #4104:
URL: https://github.com/apache/zeppelin/pull/4104#discussion_r625012234
##
File path: bin/interpreter.sh
##
@@ -296,5 +296,6 @@ else
fi
# Don't remove this echo, it is for diagnose, this line of output will be
redirected
Reamer opened a new pull request #4107:
URL: https://github.com/apache/zeppelin/pull/4107
### What is this PR for?
This PR updates the K8s Java library and fixes the failing k8s unit tests.
### What type of PR is it?
- Hot Fix
### What is the Jira issue?
* https:/
Reamer commented on pull request #4107:
URL: https://github.com/apache/zeppelin/pull/4107#issuecomment-831308764
As this is a CI blocker, I will merge the PullRequest on Wednesday
05.05.2021 if no further comments are received.
--
This is an automated message from the Apache Git Service.
Reamer commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-831313150
CI is currently broken.
Please rebase after #4107 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Reamer commented on pull request #4107:
URL: https://github.com/apache/zeppelin/pull/4107#issuecomment-831342927
The following PR should fix the https API problem with JDK8.
https://github.com/fabric8io/kubernetes-client/issues/3038
--
This is an automated message from the Apache Git Ser
Reamer commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-831361414
You are right, for the pyspark zeppelin interpreter we should use
`spark.archives` to enable the python (conda) environment.
For the python zeppelin interpreter we should use
zjffdu commented on pull request #4107:
URL: https://github.com/apache/zeppelin/pull/4107#issuecomment-831364590
The tests still fail, although they seems not related, but I haven't seen
these failed tests before, so it would be better to run the CI again to verify
whether these are flaky
Leemoonsoo commented on pull request #4105:
URL: https://github.com/apache/zeppelin/pull/4105#issuecomment-831608311
Thank @zjffdu for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
asm0dey commented on pull request #4102:
URL: https://github.com/apache/zeppelin/pull/4102#issuecomment-831690656
@Reamer @cuspymd what else should I do for this to be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
Reamer commented on pull request #4107:
URL: https://github.com/apache/zeppelin/pull/4107#issuecomment-831741655
> The tests still fail, although they seems not related, but I haven't seen
these failed tests before, so it would be better to run the CI again to verify
whether these are flak
Reamer commented on pull request #4102:
URL: https://github.com/apache/zeppelin/pull/4102#issuecomment-831743101
> @Reamer @cuspymd what else should I do for this to be merged?
We should test your changes by CI. I think your changes won't break anything.
--
This is an automated mes
Reamer edited a comment on pull request #4102:
URL: https://github.com/apache/zeppelin/pull/4102#issuecomment-831743101
> @Reamer @cuspymd what else should I do for this to be merged?
We should test your changes by CI. I think your changes won't break anything.
At the moment our CI
zjffdu commented on pull request #4107:
URL: https://github.com/apache/zeppelin/pull/4107#issuecomment-831762654
Thanks @Reamer LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
asm0dey commented on pull request #4102:
URL: https://github.com/apache/zeppelin/pull/4102#issuecomment-831770543
Perfect, just checking :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
101 - 200 of 8406 matches
Mail list logo
