Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/827#issuecomment-221025863
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user felixcheung opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/914
[WIP] test - please ignore
### What is this PR for?
Testing another PR in Travis
### What type of PR is it?
### Todos
### What is the Jira issue
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/903#issuecomment-221467057
@mfelgamal thank you for your contributions. As you can see we started a PR
on Livy interpreter about a month and a half ago, and it has recently been
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221467292
thanks, looks like Selenium tests have been busted by a merged code change.
thanks for opening ZEPPELIN-876.
---
If your project is set up for it, you
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/908#issuecomment-221467549
cool - should we have some sort of access control for this later? loading a
jar by POST request on a server seems rather open ;)
---
If your project is
Github user felixcheung closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/914
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/868#issuecomment-221470332
ok, with the same code changes everything passes except selenium, which is
a known test issue.
https://travis-ci.org/apache/incubator-zeppelin/builds
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-221789778
cool - should we have the info in documentation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/944
@mfelgamal could you please close the PR #903?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/747
it looks like error with NPM?
```
[ERROR] npm ERR! Linux 3.13.0-40-generic
[ERROR] npm ERR! argv
"/home/travis/build/apache/incubator-zeppelin/zeppelin-web/node
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
what's our guideline on what is experimental?
should that be added to
https://zeppelin.incubator.apache.org/docs/0.6.0-incubating-SNAPSHOT/rest-api/rest-interpreter.html?
-
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/924
It's not too bad since it is mostly whitespace changes. @doanduyhai could
you review the cassandra changes?
---
If your project is set up for it, you can reply to this emai
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/942
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/941
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/946
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/928
IMHO extending the scala interpreter is preferred instead of creating
another interpreter (%spark.mahout suggestion) since it is very similar..
---
If your project is set up for it
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
sounds good, but how does a contributor/developer decides whether something
new should be annotated as "Experimental" or "ZeppelinApi"?
---
If your project is se
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/868
Can you check the log file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
Agreed. I think the model used in Spark is that if an API is:
- new
- expecting (significant) discussions/changes in this or the next minor
release
Then it should be
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/957
WIP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/958
thanks! we should probably look into download/network errors too.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/928
Then perhaps it should be a separate one (eg. %mahout)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/917
Hmm... I'm not sure sure we should move to jdk8 completely by default -
there are some interpreters that only runs with jdk7 last time we checked.
Similarly for Scala 2.1, but t
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/928
how would we support different languages in this case? for instance, Apache
Spark can be in Java/Scala/Python/R, Apache Flink can be in Java/Scala/Python,
H2O can be in Java/Python/R
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/921
in the screenshots, what does "interpreter is not set" mean?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/966
LGTM
btw, this is getting fragile - would be great if interpreter can have an
extension mechanism to control what it is mapping to on the js side.
---
If your project is set up
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/970
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
but latest is generally older than the unreleased snapshot build?
for instance, https://zeppelin.incubator.apache.org/docs/latest/ now points
to 0.5.6 release doc, not 0.6.0
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/947
minor question, looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/746
finished my pass on this.
+1 on other's comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
Right. This is good. I was not sure about the redirect comment above but I
didn't really have a better sol
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/980
From what I see, we should still be able to use most of the existing code.
Could you elaborate more on how bad it would be to support Spark 1.x and 2.x in
the same interpreter code?
---
If
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/966
right, I think that can be added to interpreterSettings and checked on the
frontend similar to this:
https://github.com/apache/zeppelin/blob/09bc8a36a437a2a37736449e330a7594c89f495d
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/988
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/965
should this check for both `/` and `\` then for windows?
https://github.com/apache/zeppelin/pull/965/files#diff-bcbdda87aa29314ed459e8212067e313R528
---
If your project is set up for it
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/868
Are folks still having problems with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/980
+1 on all of that. I think we could work together on a proposal to see what
is the best way to go forward.
I think we are way overdue on separating "programming languages" (and
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/868
That was MapR though, you probably want something like this for CDH:
```
mvn clean package -DskipTests -Pspark-1.6 -Phadoop-2.6
-Dspark.version=1.6.0-cdh5.7.0 -Dhadoop.version=2.6.0
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1011
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1012
Nice! Can this be generalized to not just jdbc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1021
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1017
something like this might help:
https://git-scm.com/book/en/v2/Git-Branching-Rebasing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1016
I don't want to side track this... is it a bit pre-mature to move to 0.7.0
instead of, say, 0.6.1?
---
If your project is set up for it, you can reply to this email and have your
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1019
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1023
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1016
ok, thanks for clarification. It's a bit different from our release process
(ie. 0.5.5, 0.5.6) before, but I like this better.
---
If your project is set up for it, you can reply to
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1033
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/966
That was only to map the list of interpreter to the language though.
To figure out which interpreter is active in the interpreter right now we
have regex to match "%something&qu
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1037
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1039
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1040
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1051
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/868
Hey Ben, are you building Zeppelin with jdk 8 though, I think they have to
match your running environment, ideally. I thought we are still having problem
with it in the project.
As
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1119
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1124
I think this is a good improvement - left a comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1115
looks good, I'm not exactly follow though - does one switch from building
with spark-dependencies to without, with a build profile commandline, or this
is permanently removing
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1130
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1134
LGTM seems like CI passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1138
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1030
PR template does have the JIRA link ask? I thought not every contributor in
JIRA can change "assign" or "fix version" and it's up to the admin resolving
the JIRA t
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1141
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1138
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1147
looks good! minor suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/868
From the email discussions seem like you are through with the error above.
This "ClassNotFoundException" would seem like some sort of mismatch on the
Spark side.
Unfortunately I
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1163
If each interpreter has a separate settings for Kerberos, eg.
shell.keytab.location, would it be harder to manage?
---
If your project is set up for it, you can reply to this email and have
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1185
+1 for 404 - maybe useful but could be a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1184
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1183
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1163
I think getting impersonation is an important next step that could come
after.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1251
shouldn't we only change scala version to Spark 2.0.0? I think earlier
spark releases have limited support for scala 2.11.
---
If your project is set up for it, you can reply to this
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1249
looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1249
could you add tests for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1236
is it a bit of an information disclosure security issue though, that we
should all user name when someone type the first character?
---
If your project is set up for it, you can reply to
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1236
I'm ok with it - maybe open a JIRA to track role-based access control on
user names?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1255
could you update the title of this PR and JIRA ZEPPELIN-1258, if we are
changing how we would approach this?
---
If your project is set up for it, you can reply to this email and have your
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1269
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1294
This seems to overlap with PR #1264?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1291
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1284
great improvement - would it be better if the tag matches the interpreter
name - it could be `%spark1` `%spark2` for example?
---
If your project is set up for it, you can reply to this
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1299
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1294
I think it'd be great if you update the PR title and PR description. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1255
how about "Add Spark packages support to Livy interpreter"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1284
hmm, shouldn't we match the group name? that's what the user type though
(eg. `%spark1`) and auto complete is to help with the user when she's typing?
---
If your project i
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1310
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1316
It would probably be a good idea to have a click-through terms of service.
Should we also display the zeppelin version?
---
If your project is set up for it, you can reply to this email
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1314
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1318
It's hard to say - I think one approach would be latest (spark 2.0 & Hadoop
2.7); another approach would be the most popular ones
---
If your project is set up for it, you can
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1322
shouldn't interpreter process be impersonating the user logging onto the
web front end?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1318
cool. hadoop versions in distributions:
CDH: 2.6.0
HDP/Azure: 2.7.1
EMR: 2.7.2
GCP Dataproc: 2.7.2
---
If your project is set up for it, you can reply to this email and have
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1314
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1321
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1329
could you please update this PR and the JIRA to say `python` interpreter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1324
looks good. could you close/open this PR to trigger CI tests again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1326
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1324
seems like this has introduced some incompatibilities:
could you take a long at the test failures?
```
02:10:52,553 ERROR
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1255
There is a test failure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1255
That's a fair point.
I'll merge if there is no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1331
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1318
Looks like some of the Hadoop jars are 2.2 instead of 2.7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
1 - 100 of 806 matches
Mail list logo
