Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/2084
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jongyoul reopened a pull request:
https://github.com/apache/zeppelin/pull/2084
[HOTFIX][ZEPPELIN-2178] Prevent from cleaning output in Personalized mode
### What is this PR for?
Fixing empty output issue while using personalized mode.
### What type of PR
Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/2084
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1283
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1348
@felixcheung Yeah, @kavinkumarks already did it, thus I also am OK to
include it. CI failure is not related to this PR. LGTM
---
If your project is set up for it, you can reply to this email
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
Concerning those modes, AFAIK, before Zeppelin 0.6.0, Zeppelin has only
`shared` mode, but most of users want to run a interpreter with their own,
Zeppelin add two modes called `scoped
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1396
Thanks! I'll look into it. btw, don't you have any problem when you were
testing mysql?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
@corneadoug I summarize all of unique combination. I think 'Per user' is
the first criteria and 'Per note' is the second priority. And I also have a
question. Can front-end know if shiro
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1379
@passionke Can you tell me your jira id?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1380
@Leemoonsoo I've misunderstood your comment. LGTM. Merging if there's no
more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1379
@passionke Sorry for the late reply. Thanks for the comment. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1390
@echarles I've looked around your PR. I think your PR makes Zeppelin
support separate users within a same instance. I have two questions regarding
current behaviour. The first is about
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1399
Done or WIP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1406
Good! I like it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1380
@Leemoonsoo I'll look into it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
It looks looks like a browser cache issue. Can you clean cache and try it
again?
On Friday, 2 September 2016, Jeff Zhang <notificati...@github.com> wrote:
> @jongyo
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
About the first comment you should set `scoped` or `isolated`, not
`shared`. And growth of complexity is to remain backward compatibility. I
also agree that interpreter setting become too
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
Thus my idea to handle issues about multi-tenancy is dealt with separately
and then will combine them together after finishing them. How about it?
---
If your project is set up for it, you can
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
This is because small changes are easy to review and intuitive, thus I
always try to make my PR as small as I can.
---
If your project is set up for it, you can reply to this email and have
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1390
AFAIK, this issue is already assigned @khalidhuseynov, and he is in
progress. @khalidhuseynov Can you share your status?
---
If your project is set up for it, you can reply to this email
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1360
Addressed upgrade.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1385
`ZeppelinConfiguration` has a factory method, thus you don't have to pass
it by parameter and you can use `ZeppelinConfiguration.create()`
---
If your project is set up for it, you can reply
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
@Leemoonsoo I've fixed it. Check it please. This is because remoteProcess
doesn't destroy correctly.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1348
@AhyoungRyu Could you please merge this PR?
[This](https://cwiki.apache.org/confluence/display/ZEPPELIN/Committer+Guide)
will help you
---
If your project is set up for it, you can reply
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1380
@prabhjyotsingh Thanks. @Leemoonsoo Could you please test it or tell me the
step you tested?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1382
LGTM. Merging if there's no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@astroshim @minahlee Can you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1379
I have a question. Is it OK not to close `baos` explicitly in multi user
environments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/746
I've glanced at this PR. I think this PR never break current behaviour and
codes looks good. If it doesn't have more issues, it's enough to merge this PR.
---
If your project is set up
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1473
@doanduyhai Can you commit this PR? I think it's good starting point. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1464
I think this PR contains wrong changes like JDBC*. Is it correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@AhyoungRyu Thanks for your effort. LGTM. But I think it would be better to
support non-interactive mode for running the server because some of users
launches Zeppelin as a start-up service
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1473
@doanduyhai Do you try to do it via
https://cwiki.apache.org/confluence/display/ZEPPELIN/Committer+Guide ? AFAIK,
there's no more step except creating account.
---
If your project is set up
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1483
How about removing Spark 1.1.* and 1.2.* in Zeppelin's support list? It's
too old and even Apache Spark removes their download URL in their official web.
---
If your project is set up
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1487
[WIP] [ZEPPELIN-1520] Test with the local mode of Apache Spark
### What is this PR for?
Simplify travis test to reduce usage of resources
### What type of PR is it?
[Improvement
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1458
@spektom I agree with you not to add zeppelin-env.* because it depends on
Live only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1485
I've tested your branch, but it occurs another error. Could you please
check it?
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-dependency-plugin:2.8:copy
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1487
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1482
It looks like lens issue only. Can you change the title of this PR and Jira
issue? Concerning the change, LGTM. Thanks for the contribution.
---
If your project is set up for it, you can reply
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1487
Merging if there's no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1487
@zjffdu I've missed remove some scripts in `testing`. I'll fix it.
Concerning the modes, in an early stage of Spark, there're some different
behaviours of different modes, thus we need to test
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1435
Thanks Jeff, this patch fixes my mistake correctly. LGTM. If CI passes,
I'll merge it asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
@corneadoug Done. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
@corneadoug I'm fixing some conflicts during rebasing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1336
@corneadoug Can you review this PR first? @nazgul33 and you seem to resolve
same issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1262
@kavinkumarks So sorry for the late reply. I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1353
@prabhjyotsingh Sorry for the late reply but I don't think it's not
reviewed and I don't think your change is not proper. Could you revert it?
Zeppelin doesn't have any hadoop-related
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1360
Finished rebase. Ci failure is unrelated. Merging if there's no more
discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1375
I think it would be a potential error but do you have any experience where
it occurs error on that line?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai Could you please specify the title of this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1372
I think it's enough for my purpose. Thanks. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jongyoul reopened a pull request:
https://github.com/apache/zeppelin/pull/1265
[ZEPPELIN-1210] Run interpreter per user
### What is this PR for?
Enabling each user to run same interpreter.
### What type of PR is it?
[Improvement]
### What
Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/1265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1348
@kavinkumarks Thanks for the removing the method, but personally, I think
we should handle it with another PR. @felixcheung What do you think of it? It
looks irrelevant.
---
If your project
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1353
I think your changed is that we already discussed before. `provided` is
mandatory, and check the method those SparkInterpreter does. How about it? And
some changes are going with another PR
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1315
@rconline I know what you focus on and try to solve the problem. I,
actually, cannot accept whether your solution is perfect or not, but I agree
the problem you told. Thanks for the explaining
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1315
@rconline It's not clear for me. Do you tell me that users store their
Hive, Hbase passwords in HDFS? Or does this support reading `jceks` from HDFS?
In your description, this PR
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1301
Merging if there's no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1301
@bzz Yes, what you mentioned is related to #1339 which will make a change
to build custom Spark.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1360
@bzz @Leemoonsoo Thanks, I don't know the proper location to describe the
changes actually. I'll also update upgrade.md. And about changing a behaviour
of JDBC, in case of `%jdbc(mysql)`, I
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1467
Can you answer my question?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1477
Thanks for the contribution. I'll start review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1477
I've no preference about adding some properties in a paragraph but you need
to update docs for that feature in details.
---
If your project is set up for it, you can reply to this email
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1467
I've left my review in four days ago. But I misunderstood new Github's
review system. I left my comment again as a singe comment. Can you see it?
---
If your project is set up for it, you can
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
@cloverhearts Thank you!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
CI become green and @cloverhearts tested allmost cases. Merging if there's
no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1520
@kavinkumarks Backend codes looks good to me. @corneadoug Could you please
look into it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1520
WIP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1511
@LantaoJin Can you edit your description following the guide?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1551
Thank for the contribution. I like this kind of contribution to make code
clean. LGTM. I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1302
Can you add consideration for the multi-tenancy? If Shiro is enabled,
current implementation will disable all of users' interpreters
---
If your project is set up for it, you can reply
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1550
Thanks for the contribution. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1540
It looks good to hide editor on md. And I'm not good at ui, but in case of
angular, I think it's better to hide it, too.
---
If your project is set up for it, you can reply to this email
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1479
@hayssams Do you have any clue that you mentioned? I don't know why two
different jars while building Zeppelin.
---
If your project is set up for it, you can reply to this email and have your
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1265
Thank you @cloverhearts for the UI work. Can you share your screenshot for
this feature? It can help everyone understand your awesome work!!
---
If your project is set up for it, you can reply
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1479
@hayssams AFAIK, those hadoop-* have a lot of dependencies by themselves
and it's possible to make a problem like version mismatch even in case that we
don't use that feature. What do you think
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1524
@khalidhuseynov If we already have own our notes, removing whole directory
also removes our own. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1548
Can you change the title of this PR including jira issue number and title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1548
Thanks for the contribution. I left a comment and please check it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1556
Merging if there's no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1540
How about making editOnDblClick false by default?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1547
I think you'd better push another commit in #1544. I think that would be
better process to handle issue. Can you do that?
---
If your project is set up for it, you can reply to this email
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1542
Thanks for the fixing typo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1467
LGTM. Merging there's no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1522
I think this PR tries to make less change for the dealing with that
problem. Actually the most right way changes a lot including backend. it also
can break backward compatibility.
---
If your
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@Leemoonsoo As we discussed before, the first version of personalized mode
is to avoid changing note simultaneously while two user see a same note. I
think this version fits it. one user want
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@Leemoonsoo Yes, I haven't check the front-side. I'll fix it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@Leemoonsoo I've not tested the graph. If you mean a dynamic change of
graph, I'll check it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1614
@cloverhearts Can you see the error of this PR? I think it's irrelevant but
want to check it double.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1614
Sorry for the delay. LGTM, merging if there's no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@cloverhearts @1ambda Can you help me? :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1660
[WIP][ZEPPELIN-1594] Personalized mode
### What is this PR for?
Support personalized mode in multi user environments.
### What type of PR is it?
[Feature]
### Todos
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1513
@nazgul33 I've heard your team used LDAP. Can you adopt and test this PR in
your team?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1513
@gss2002 Hi, Thanks for the contribution. This PR actually has no problem
itself or no breaking current behavior. So LGTM. But I'm just curious about the
use case. Do you know the case to use
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@djKooks Hi, Is there any issue for installing `xmllint`? I found it in Mac
and Linux but I'm not sure if it exists in all of linux and mac. Do you have
any idea?
---
If your project is set
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1578
@minahlee I've fixed what you mentioned.
Merging if there's no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1585
LGTM. We will simplify registration mechanism by deprecating a old way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1578
ZEPPELIN-1599 Remove support on some old versions of Spark.
### What is this PR for?
removing support on old versions of Spark including testing and building
them.
### What
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1578
@AhyoungRyu Can you take a look into it briefly? I didn't change your part
to avoid conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1578
@zjffdu Good catch up, but I think if users use Spark 1.3 with SPARK_HOME,
we'd better support it. If we change the minimum version of Spark to 1.4 in
`SparkVersion`, user cannot use spark 1.3
401 - 500 of 1414 matches
Mail list logo
