[GitHub] zeppelin issue #1421: [ZEPPELIN-1422][zeppelin-interpreter] fix InterpreterP...

2016-09-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1421 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...

2016-09-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1426 Here is before and after of this PR that I observe, and I see these 2 changes - now it does not stream output, i.e. it waits for the entire paragraph execution to be finished

[GitHub] zeppelin pull request #1428: [ZEPPELIN-1439] Support for running multiple ve...

2016-09-14 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1428 [ZEPPELIN-1439] Support for running multiple version of spark ### What is this PR for? Zeppelin to have support for running multiple version of spark. Currently it's limit

[GitHub] zeppelin pull request #1428: [ZEPPELIN-1439] Support for running multiple ve...

2016-09-14 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/1428 [ZEPPELIN-1439] Support for running multiple version of spark ### What is this PR for? Zeppelin to have support for running multiple version of spark. Currently it's limit

[GitHub] zeppelin pull request #1428: [ZEPPELIN-1439] Support for running multiple ve...

2016-09-14 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1428: [ZEPPELIN-1439] Support for running multiple ve...

2016-09-14 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1428: [ZEPPELIN-1439] Support for running multiple version o...

2016-09-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1428 @Leemoonsoo totally missed it. That looks and works awesome! I'll close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] zeppelin pull request #:

2016-09-15 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/zeppelin/commit/21a084b170b29dee0f2d57aae22b00c785ef0c8e#commitcomment-19049191 In zeppelin-web/src/app/interpreter/interpreter.controller.js: In zeppelin-web/src/app/interpreter

[GitHub] zeppelin pull request #:

2016-09-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/zeppelin/commit/21a084b170b29dee0f2d57aae22b00c785ef0c8e#commitcomment-19051094 In zeppelin-web/src/app/interpreter/interpreter.controller.js: In zeppelin-web/src/app/interpreter

[GitHub] zeppelin issue #1432: [HOT FIX][ZEPPELIN-1144] Fix compilation errors in Not...

2016-09-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1432 Tested on local, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1437: ZEPPELIN-1454: Wrong property value on interpre...

2016-09-19 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1437 ZEPPELIN-1454: Wrong property value on interpreter page ### What is this PR for? If for some reason (for example permission issue in file system) while saving interpreter setting, UI

[GitHub] zeppelin issue #1438: [ZEPPELIN-1458] Fix compiling error on branch-0.6

2016-09-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1438 @minahlee diff of InterpreterFactory.java looks different than https://github.com/apache/zeppelin/pull/1333/files#diff-53b87ca4f9616e88837a1b0dd050c01aR995 --- If your project is set up

[GitHub] zeppelin issue #1438: [ZEPPELIN-1458] Fix compiling error on branch-0.6

2016-09-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1438 Rest tried, compiled, build. Tested with spark and jdbc interpreter, both works normally. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1438: [ZEPPELIN-1458] Fix compiling error on branch-0.6

2016-09-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1438 Got it, thanks for the explanation. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1437: ZEPPELIN-1454: Wrong property value on interpreter pag...

2016-09-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1437 @randerzander can you explain a bit more, how do you think this is related. As scope of this PR is only limited to interpreter property being saved (or fail to save) on file system

[GitHub] zeppelin pull request #1437: ZEPPELIN-1454: Wrong property value on interpre...

2016-09-19 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/1437 ZEPPELIN-1454: Wrong property value on interpreter page ### What is this PR for? If for some reason (for example permission issue in file system) while saving interpreter setting

[GitHub] zeppelin pull request #1437: ZEPPELIN-1454: Wrong property value on interpre...

2016-09-19 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1442: ZEPPELIN-1459: Zeppelin JDBC URL properties man...

2016-09-20 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1442 ZEPPELIN-1459: Zeppelin JDBC URL properties mangled ### What is this PR for? While creating connection `DriverManager.getConnection(url, properties);` for JDBC interpreter, phoenix

[GitHub] zeppelin pull request #1444: ZEPPELIN-1456: Flaky Test: AuthenticationIT

2016-09-20 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1444 ZEPPELIN-1456: Flaky Test: AuthenticationIT ### What is this PR for? This started happening after ZEPPELIN-1144, https://github.com/apache/zeppelin/pull/1330. This test

[GitHub] zeppelin issue #1444: ZEPPELIN-1456: Flaky Test: AuthenticationIT

2016-09-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1444 Thank you @corneadoug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1437: ZEPPELIN-1454: Wrong property value on interpreter pag...

2016-09-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1437 Will merge this in both master and 0.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1442: ZEPPELIN-1459: Zeppelin JDBC URL properties mangled

2016-09-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1442 Thank you @randerzander, will merge this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1450: ZEPPELIN-1473. It is not necessary to create SQLContex...

2016-09-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1450 Tested with latest version of LIVY, works as expected. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1449: [MINOR][DOC] Change Markdown class name from Markdown ...

2016-09-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1449 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1450: ZEPPELIN-1473. It is not necessary to create SQLContex...

2016-09-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1450 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #1454: ZEPPELIN-1483

2016-09-23 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1454 ZEPPELIN-1483 ### What is this PR for? Zeppelin home page list notebooks doesn't show notebook with group permission ### What type of PR is it? [Bu

[GitHub] zeppelin issue #1454: [ZEPPELIN-1483] Zeppelin home page list notebooks does...

2016-09-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1454 Ready for review. CI fails for #7346.9 with; which is unrelated ``` - should provide onclick method *** FAILED ***  The code passed to eventually never

[GitHub] zeppelin issue #1454: [ZEPPELIN-1483] Zeppelin home page list notebooks does...

2016-09-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1454 Thank you @corneadoug, have fixed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...

2016-09-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1429 Tested, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1454: [ZEPPELIN-1483] Zeppelin home page list notebooks does...

2016-09-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1454 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...

2016-09-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1429 @r-kamath do you want to try and merge this ? [This](https://cwiki.apache.org/confluence/display/ZEPPELIN/Committer+Guide) will help you. --- If your project is set up for it, you

[GitHub] zeppelin issue #1483: [ZEPPELIN-1509] Run certain SparkInterpreter tests onl...

2016-10-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1483 nice ! LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1489: ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be m...

2016-10-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1489 Tested on local, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 I too share same thought as @felixcheung, if we can avoid jar's, can we use `org.mockito.Mock` instead ? --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 Any thought about using `org.mockito.Mock`; example https://github.com/apache/zeppelin/blob/master/python/src/test/java/org/apache/zeppelin/python/PythonInterpreterTest.java#L78 ? --- If

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 What I mean to say was, lets mock these till the time we get livy's jar from public repo, how do you think about that ? --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 Yes, that part I agree, it cannot be tested without jar, `org.mockito.Mock` will always mock. @Leemoonsoo @jongyoul @felixcheung any thought about checking in jar(s) ? --- If

[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...

2016-10-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1426 Also, can you update the doc as well. Rest LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...

2016-10-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1426 Will merge this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1509: [Zeppelin-1540] fix note url input placeholder

2016-10-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1509 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1502: [gh-pages] Separate "Supported Interpreters" table fro...

2016-10-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1502 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 Otherwise yes, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 I just tried it on my local; so basically it skips all the test cases. ``` WARN [2016-10-20 18:17:05,017] ({main} LivyIntegrationTest.java[checkPreCondition]:66) - livy

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-10-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1322 Closing this, will open a new one with merge of https://github.com/apache/zeppelin/pull/1265. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin pull request #1322: [ZEPPELIN-1320] Run zeppelin interpreter proces...

2016-10-23 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1554: [ZEPPELIN-1320] Run zeppelin interpreter proces...

2016-10-23 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1554 [ZEPPELIN-1320] Run zeppelin interpreter process as web front end user Have recreated this from https://github.com/apache/zeppelin/pull/1322 ### What is this PR for

[GitHub] zeppelin issue #1554: [WIP] [ZEPPELIN-1320] Run zeppelin interpreter process...

2016-10-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1554 know issue: restart on interpreter does not work as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1559: [ZEPPELIN-1461] Doesn't display "description" value in...

2016-10-27 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1559 Tested on local LGTM. +1 for adding more test cases! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1514: ZEPPELIN-1516. NPE LivySparkSQLInterpreter thrown with...

2016-10-31 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1514 Does this happens only for livy.sql, or can it happen to others as well ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1514: ZEPPELIN-1516. NPE LivySparkSQLInterpreter thrown with...

2016-10-31 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1514 Sure, got it. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1585: ZEPPELIN-1606. Add interpreter option to interpreter-s...

2016-11-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1585 LGTM, I like this idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1583 Nice! LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1584: [gh-pages] Add ignite version info to supported interp...

2016-11-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1584 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1593: ZEPPELIN-1613. PerUser scoped mode doesn't work

2016-11-03 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1593 Thanks for creating this issue, this wasn't working for me either. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1554: [WIP] [ZEPPELIN-1320] Run zeppelin interpreter process...

2016-11-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1554 Sure let me check, I think it could be possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1554: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-11-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1554 Updated screen shot, ready for review. @Leemoonsoo I'll try to take care of "PAM authentication" in a different PR. --- If your project is set up for it, you ca

[GitHub] zeppelin issue #1619: [ZEPPELIN-1647] Save roles and use for broadcasting no...

2016-11-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1619 Tried on local, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin pull request #1554: [ZEPPELIN-1320] Run zeppelin interpreter proces...

2016-11-16 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/1554 [ZEPPELIN-1320] Run zeppelin interpreter process as web front end user Have recreated this from https://github.com/apache/zeppelin/pull/1322 ### What is this PR for? While

[GitHub] zeppelin pull request #1554: [ZEPPELIN-1320] Run zeppelin interpreter proces...

2016-11-16 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-11-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1322 @zjffdu Yes, you are right, with SPARK_HOME/SPARK_SUBMIT it doesn't work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] zeppelin pull request #1672: ZEPPELIN-1701: User impersonation not work with...

2016-11-22 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1672 ZEPPELIN-1701: User impersonation not work with SPARK_HOME set. ### What is this PR for? User impersonation of front end user does not work with SPARK_HOME set. ### What type

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-11-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1672 can you try `chmod 777 /Users/jzhang/github/zeppelin/logs/zeppelin-interpreter-spark-jzhang-jzhangMBPr.local.log` --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-11-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1672 I assumed this log file should have group permission to log into this file. What do you recommend ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-11-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1672 I think that should be fine; ``` ... ZEPPELIN_INTP_CLASSPATH+=":${HADOOP_CONF_DIR}" ... CLASSPATH+=":${ZEPPELIN

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-11-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1672 I see your point, let me check that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1676: [ZEPPELIN-1705] Exclude unnecessary source file when c...

2016-11-24 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1676 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...

2016-11-24 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1673 LGTM! It significant improvement. mvn package -pl zeppelin-web ``` [INFO] [INFO] BUILD SUCCESS

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-11-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1672 @zjffdu Here is what I've done - https://github.com/apache/zeppelin/pull/1672/files#diff-8d3bd42a5de342ebad38e1d113d9f75cR195 `source "${ZEPPELIN_CONF_DIR}

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-11-27 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1672 This is ready for review, have checked this in few flavours of linux, and it was working as expected. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-11-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1694 Haven't tried it yet, but IMO we should have a check at backned for the same (both API and websocket). --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-11-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1672 @zjffdu did you try it again, as this is working for me, or if you can let me know your environment I can try on the same. --- If your project is set up for it, you can reply to this

[GitHub] zeppelin pull request #1672: ZEPPELIN-1701: User impersonation not work with...

2016-11-28 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1672: ZEPPELIN-1701: User impersonation not work with...

2016-11-28 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/1672 ZEPPELIN-1701: User impersonation not work with SPARK_HOME set. ### What is this PR for? User impersonation of front end user does not work with SPARK_HOME set. ### What

[GitHub] zeppelin pull request #1698: Downloading dependency/changing version for an ...

2016-11-28 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1698 Downloading dependency/changing version for an interpreter results in error sometimes ### What is this PR for? At times on downloading dependency/changing version for an interpreter

[GitHub] zeppelin issue #1698: Downloading dependency/changing version for an interpr...

2016-11-29 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1698 Will merge this, if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-11-29 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1672 @Leemoonsoo resolved conflict. Thank you for the quick fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-11-30 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1672 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-12-01 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1672 Thank you for the verification. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1724: [ZEPPELIN-1674] save barchart, areachart option

2016-12-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1724 Tested, it works as expected. Should we have the same for scatterchart, and piechart as well ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1719: [ZEPPELIN-965] missing lastExecuteTime function

2016-12-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1719 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1724: [ZEPPELIN-1674] save barchart, areachart option

2016-12-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1724 Sure, was thinking about that as well. LGTM :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1719: [ZEPPELIN-965] missing lastExecuteTime function

2016-12-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1719 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...

2016-12-15 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1767 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1751 Just a minor recommendation, rest LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1751 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1784: [ZEPPELIN-1840] Allow fully qualified username when pr...

2016-12-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1784 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin pull request #1790: InterpreterFactory.createOrGetInterpreterList f...

2016-12-21 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1790 InterpreterFactory.createOrGetInterpreterList fails when interpreter mode is "perUser": "scoped" ### What is this PR for? When trying to add a paragraph, whose de

[GitHub] zeppelin issue #1789: [MINOR] Optimize watchers of paragraph results

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1789 Thanks for the contribution, one minor issue: Before: https://cloud.githubusercontent.com/assets/674497/21419733/7b477450-c84f-11e6-9f06-9623585b6402.png";>

[GitHub] zeppelin issue #1790: [ZEPPELIN-1845] InterpreterFactory.createOrGetInterpre...

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1790 CI Green, ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1777: [ZEPPELIN-1831] Fix paragraph control dropdown alignme...

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1777 @marchpig can you resolve conflicting file ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1785: [ZEPPELIN-1833] Fix bug in ClientFactory.destroyObject...

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1785 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin pull request #1797: [ZEPPELIN-1854] make Per User mode in interpret...

2016-12-22 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1797 [ZEPPELIN-1854] make Per User mode in interpreter setting visible even if there is no role assigned to a user ### What is this PR for? There can be a case where user may have enabled

[GitHub] zeppelin issue #1792: Change gitignore for font files

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1792 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1797: [ZEPPELIN-1854] make Per User mode in interpreter sett...

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1797 @jongyoul can you help review this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1798: ZEPPELIN-1853. Add README for livy interpreter

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1798 +1 for having more doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1694 Tested, works as expectation. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1797: [ZEPPELIN-1854] make Per User mode in interpreter sett...

2016-12-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1797 Sure ` ticket.principal` sounds good to me. I'll do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] zeppelin issue #1784: [ZEPPELIN-1840] Allow fully qualified username when pr...

2016-12-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1784 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1790: [ZEPPELIN-1845] InterpreterFactory.createOrGetInterpre...

2016-12-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1790 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1796: [WIP] ZEPPELIN-1852. Use multiple InterpreterResult fo...

2016-12-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1796 Any specific reason you want to change `livy.create.session.timeout` ? You may want to update this https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/livy.html doc as well

<    1   2   3   4   5   6   7   8   9   10   >