[GitHub] [zeppelin] zhugezifang opened a new pull request, #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang opened a new pull request, #4591: URL: https://github.com/apache/zeppelin/pull/4591 ### What is this PR for? This pull request fix the bug of download csv data error ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1526879184 > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [zeppelin] zhugezifang closed pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang closed pull request #4591: [ZEPPELIN-5898]fix:down csv data error URL: https://github.com/apache/zeppelin/pull/4591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1526872815 > I do not understand the fix. Could you please explain it. let we look the example of https://issues.apache.org/jira/browse/ZEPPELIN-5898 when i query the result in

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1526884790 > I do not understand the fix. Could you please explain it. excuce me,the is a webchat group or other group of zeppelin,we can discuss it more timely。 and i want to add

[GitHub] [zeppelin] Reamer commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
Reamer commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527196813 > @Reamer hi,i also want to add this feature into zeppelin,and could I get your support? Of course. I was able to reproduce the problem and understood the problem. Your change

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527114539 > I don't think it's a specific JSON problem, but rather a delimiter problem. The CSV is broken because in the JSON example there is a `,` in the text field and this is also used as

[GitHub] [zeppelin] Reamer commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
Reamer commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527049901 I don't think it's a specific JSON problem, but rather a delimiter problem. The CSV is broken because in the JSON example there is a `,` in the text field and this is also used as a

[GitHub] [zeppelin] Reamer commented on pull request #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-04-28 Thread via GitHub
Reamer commented on PR #4590: URL: https://github.com/apache/zeppelin/pull/4590#issuecomment-1527052137 Need a review. I have tested this function in my environment and it does what it is supposed to. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-04-28 Thread via GitHub
huage1994 commented on code in PR #4590: URL: https://github.com/apache/zeppelin/pull/4590#discussion_r1180017995 ## zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java: ## @@ -162,6 +162,14 @@ public void testLruCache() throws IOException {

[GitHub] [zeppelin] Reamer commented on pull request #4592: [ZEPPELIN-5905] Use wildcard generic for job and remove generic for JobListener

2023-04-28 Thread via GitHub
Reamer commented on PR #4592: URL: https://github.com/apache/zeppelin/pull/4592#issuecomment-1527107097 This PR is dependent on #4582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] Reamer opened a new pull request, #4592: [ZEPPELIN-5905] Use wildcard generic for job and remove generic for JobListener

2023-04-28 Thread via GitHub
Reamer opened a new pull request, #4592: URL: https://github.com/apache/zeppelin/pull/4592 ### What is this PR for? This PR uses generics for the job class. I have not managed to use the generics for the JobListener class everywhere, so for simplicity I have removed the generic. The

[GitHub] [zeppelin] huage1994 commented on pull request #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-04-28 Thread via GitHub
huage1994 commented on PR #4590: URL: https://github.com/apache/zeppelin/pull/4590#issuecomment-1527113642 The changes look very good. I just have a minor code suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527116417 > > I do not understand the fix. Could you please explain it. > > excuce me,there is a webchat group or other group of zeppelin,we can discuss it more timely。 > > and i

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-04-28 Thread via GitHub
Reamer commented on code in PR #4590: URL: https://github.com/apache/zeppelin/pull/4590#discussion_r1180032048 ## zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java: ## @@ -162,6 +162,14 @@ public void testLruCache() throws IOException {

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-25 Thread via GitHub
huage1994 commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1176305796 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { //

[GitHub] [zeppelin] zjffdu commented on pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-25 Thread via GitHub
zjffdu commented on PR #4589: URL: https://github.com/apache/zeppelin/pull/4589#issuecomment-1521652049 Thanks for the contribution @zhugezifang , could you update the PR description? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-25 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1176399171 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { //

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-25 Thread via GitHub
huage1994 commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1176305796 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { //

[GitHub] [zeppelin] xiaomin0322 commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-25 Thread via GitHub
xiaomin0322 commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1522705230 > Could you please improve your description of the pull request. Have a look at #4568 for a good example. Adjusted -- This is an automated message from the Apache Git

[GitHub] [zeppelin] huage1994 commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-26 Thread via GitHub
huage1994 commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1523131644 LGTM Would be merged if no more comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-26 Thread via GitHub
huage1994 commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1177624768 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { //

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-04-26 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1523121562 This PR would be ready for review after #4582 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] xiaomin0322 commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-26 Thread via GitHub
xiaomin0322 commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1523168683 > LGTM Would be merged if no more comment. 华哥合吧,嘿嘿 !@huage1994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] huage1994 merged pull request #4572: [MINOR] Update doc for flink 1.16

2023-04-26 Thread via GitHub
huage1994 merged PR #4572: URL: https://github.com/apache/zeppelin/pull/4572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] zhugezifang commented on a diff in pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-26 Thread via GitHub
zhugezifang commented on code in PR #4589: URL: https://github.com/apache/zeppelin/pull/4589#discussion_r1177928181 ## zeppelin-web/src/app/notebook/paragraph/result/result.controller.js: ## @@ -895,6 +895,9 @@ function ResultCtrl($scope, $rootScope, $route, $window,

[GitHub] [zeppelin] zhugezifang commented on pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-26 Thread via GitHub
zhugezifang commented on PR #4589: URL: https://github.com/apache/zeppelin/pull/4589#issuecomment-1523472252 > Thanks for the contribution @zhugezifang , could you update the PR description? ok thanks, i updated it -- This is an automated message from the Apache Git Service. To

[GitHub] [zeppelin] zhugezifang closed pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-26 Thread via GitHub
zhugezifang closed pull request #4589: [ZEPPELIN-5898]fix:down csv data error URL: https://github.com/apache/zeppelin/pull/4589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] zhugezifang closed pull request #4588: [ZEPPELIN-5898]fix:down csv data error

2023-04-24 Thread via GitHub
zhugezifang closed pull request #4588: [ZEPPELIN-5898]fix:down csv data error URL: https://github.com/apache/zeppelin/pull/4588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] xiaomin0322 commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-25 Thread via GitHub
xiaomin0322 commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1521444700 > @xiaomin0322 Could you update the jira title to be more specific? `Dev zeppelin client bug` is too vague. Something like `NPE in ParagraphResult when getting progress from

[GitHub] [zeppelin] Reamer commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-25 Thread via GitHub
Reamer commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1521464643 Could you please improve your description of the pull request. Have a look at #4568 for a good example. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] Reamer commented on pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0

2023-04-25 Thread via GitHub
Reamer commented on PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#issuecomment-1521465572 ping @akishichinibu Any JUnit tests to add? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-25 Thread via GitHub
Reamer commented on code in PR #4589: URL: https://github.com/apache/zeppelin/pull/4589#discussion_r1176204154 ## zeppelin-web/src/app/notebook/paragraph/result/result.controller.js: ## @@ -895,6 +895,9 @@ function ResultCtrl($scope, $rootScope, $route, $window, $routeParams,

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4586: [ZEPPELIN-5902] Support Spark 3.4

2023-04-25 Thread via GitHub
Reamer commented on code in PR #4586: URL: https://github.com/apache/zeppelin/pull/4586#discussion_r1176200080 ## spark/interpreter/pom.xml: ## @@ -518,6 +518,20 @@ + + spark-3.4 + +true Review Comment: Only one Spark Profile should have

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-04-18 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1512627023 There still seems to be a problem. I'm working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-04-18 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1512535026 > Hi @huage1994, I have opened [huage1994#2](https://github.com/huage1994/zeppelin/pull/2). These changes should ensure that the tests go through. I have also removed

[GitHub] [zeppelin] Reamer commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-04-14 Thread via GitHub
Reamer commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1508203655 Hi @huage1994, I have opened https://github.com/huage1994/zeppelin/pull/2. These changes should ensure that the tests go through. I have also removed `mockito-junit-jupiter`. This

[GitHub] [zeppelin] jongyoul commented on pull request #4593: [ZEPPELIN-5898]fix:download csv data error

2023-04-29 Thread via GitHub
jongyoul commented on PR #4593: URL: https://github.com/apache/zeppelin/pull/4593#issuecomment-1528737189 Thank you for the contribution, especially in frontend part :-) We are looking forward to your continuous contributions. -- This is an automated message from the Apache Git Service.

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527297261 > > @Reamer hi,i also want to add this feature into zeppelin,and could I get your support? > > Of course. I was able to reproduce the problem and understood the problem. Your

[GitHub] [zeppelin] Reamer merged pull request #4593: [ZEPPELIN-5898]fix:download csv data error

2023-05-02 Thread via GitHub
Reamer merged PR #4593: URL: https://github.com/apache/zeppelin/pull/4593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer merged pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-05-02 Thread via GitHub
Reamer merged PR #4582: URL: https://github.com/apache/zeppelin/pull/4582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer merged pull request #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-05-02 Thread via GitHub
Reamer merged PR #4590: URL: https://github.com/apache/zeppelin/pull/4590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-05-02 Thread via GitHub
Reamer commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1530969486 @huage1994 Please rebase your current branch. I merged #4582 right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zeppelin] Reamer opened a new pull request, #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer opened a new pull request, #4582: URL: https://github.com/apache/zeppelin/pull/4582 ### What is this PR for? This PR changes the RemoteScheduler The main change is the executor of the RemoteScheduler. It's now a separate FIFO Executor (one Thread). As a result, jobs are now

[GitHub] [zeppelin] huage1994 commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-23 Thread via GitHub
huage1994 commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1518980665 Thanks @Reamer so much for fixing the failed test case ! It's a great job. It's weird that the `RemoteSchedulerTest` runs well under Junit 4, Do you know why? -- This is

[GitHub] [zeppelin] zjffdu closed pull request #4577: #1 [READ. ME]

2023-03-29 Thread via GitHub
zjffdu closed pull request #4577: #1 [READ. ME] URL: https://github.com/apache/zeppelin/pull/4577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] xiaomin0322 opened a new pull request, #4579: Dev zeppelin client bug

2023-03-31 Thread via GitHub
xiaomin0322 opened a new pull request, #4579: URL: https://github.com/apache/zeppelin/pull/4579 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide -

[GitHub] [zeppelin] Reamer commented on pull request #4578: [ZEPPELIN-5891] Method contains useless variables

2023-04-03 Thread via GitHub
Reamer commented on PR #4578: URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1494169052 Very strange, we want to clone the metadata. How does the code work without a source NoteId? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] NicolasGong commented on pull request #4578: [ZEPPELIN-5891] Method contains useless variables

2023-04-03 Thread via GitHub
NicolasGong commented on PR #4578: URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1495285576 > Very strange, we want to clone the metadata. How does the code work without a source NoteId? I think this method is to put the new NoteId and AuthenticationInfo into the

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4578: [ZEPPELIN-5891] Method contains useless variables

2023-04-06 Thread via GitHub
Reamer commented on code in PR #4578: URL: https://github.com/apache/zeppelin/pull/4578#discussion_r1159526125 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/AuthorizationService.java: ## @@ -93,12 +93,7 @@ public void createNoteAuth(String noteId,

[GitHub] [zeppelin] Reamer merged pull request #4576: Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /neo4j

2023-04-06 Thread via GitHub
Reamer merged PR #4576: URL: https://github.com/apache/zeppelin/pull/4576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on pull request #4579: Dev zeppelin client bug

2023-04-06 Thread via GitHub
Reamer commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1498753398 Open a Jira ticket and get your PullRequest into shape. The source code is also indented incorrectly. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] Reamer opened a new pull request, #4580: [ZEPPELIN-5855] remove more powermock usages to support junit5

2023-04-06 Thread via GitHub
Reamer opened a new pull request, #4580: URL: https://github.com/apache/zeppelin/pull/4580 ### What is this PR for? This PR removes the use of Powermock in further tests. ### What type of PR is it? - Refactoring ### What is the Jira issue? *

[GitHub] [zeppelin] xiaomin0322 commented on pull request #4579: [ZEPPELIN-5893] Dev zeppelin client bug

2023-04-08 Thread via GitHub
xiaomin0322 commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1501041328 I have updated the jira link, the address is: https://issues.apache.org/jira/browse/ZEPPELIN-5893, please attention -- This is an automated message from the Apache Git Service. To

[GitHub] [zeppelin] Reamer commented on pull request #4580: [ZEPPELIN-5855] remove more powermock usages to support junit5

2023-04-09 Thread via GitHub
Reamer commented on PR #4580: URL: https://github.com/apache/zeppelin/pull/4580#issuecomment-1501121841 I need a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [zeppelin] NicolasGong commented on pull request #4578: [ZEPPELIN-5891] Method contains useless variables

2023-04-09 Thread via GitHub
NicolasGong commented on PR #4578: URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1501294629 Some checks were not successful,but i don't know why. These errors do not appear to be related to this commit。 -- This is an automated message from the Apache Git Service. To

[GitHub] [zeppelin] Reamer merged pull request #4578: [ZEPPELIN-5891] Method contains useless variables

2023-04-11 Thread via GitHub
Reamer merged PR #4578: URL: https://github.com/apache/zeppelin/pull/4578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4580: [ZEPPELIN-5855] remove more powermock usages to support junit5

2023-04-11 Thread via GitHub
huage1994 commented on code in PR #4580: URL: https://github.com/apache/zeppelin/pull/4580#discussion_r1161640522 ## alluxio/src/test/java/org/apache/zeppelin/alluxio/AlluxioInterpreterTest.java: ## @@ -46,26 +42,32 @@ import org.apache.zeppelin.interpreter.InterpreterResult;

[GitHub] [zeppelin] jongyoul commented on pull request #4571: Bump minimist, mkdirp, karma, handlebars and protractor in /zeppelin-web-angular

2023-04-10 Thread via GitHub
jongyoul commented on PR #4571: URL: https://github.com/apache/zeppelin/pull/4571#issuecomment-1501930681 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #3496: [ZEPPELIN-4407] Add the ability to copy/paste result table

2023-04-10 Thread via GitHub
jongyoul commented on code in PR #3496: URL: https://github.com/apache/zeppelin/pull/3496#discussion_r1161802621 ## zeppelin-web/src/app/notebook/paragraph/result/result-chart-selector.html: ## @@ -88,8 +88,10 @@ Toggle Dropdown -CSV -TSV +Copy as TSV +

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4580: [ZEPPELIN-5855] remove more powermock usages to support junit5

2023-04-12 Thread via GitHub
Reamer commented on code in PR #4580: URL: https://github.com/apache/zeppelin/pull/4580#discussion_r1163956686 ## alluxio/src/test/java/org/apache/zeppelin/alluxio/AlluxioInterpreterTest.java: ## @@ -46,26 +42,32 @@ import org.apache.zeppelin.interpreter.InterpreterResult;

[GitHub] [zeppelin] NicolasGong commented on a diff in pull request #4578: [ZEPPELIN-5891] Method contains useless variables

2023-04-06 Thread via GitHub
NicolasGong commented on code in PR #4578: URL: https://github.com/apache/zeppelin/pull/4578#discussion_r1160369614 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/AuthorizationService.java: ## @@ -93,12 +93,7 @@ public void createNoteAuth(String noteId,

[GitHub] [zeppelin] Reamer commented on pull request #4578: [ZEPPELIN-5891] Method contains useless variables

2023-04-04 Thread via GitHub
Reamer commented on PR #4578: URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1495667645 I think we can delete the `cloneNoteMeta` method completely and replace it with `createNoteAuth`. In my opinion, the original rights should not be transferred from the old Note to

[GitHub] [zeppelin] NicolasGong opened a new pull request, #4578: Method contains useless variables

2023-03-31 Thread via GitHub
NicolasGong opened a new pull request, #4578: URL: https://github.com/apache/zeppelin/pull/4578 ### What is this PR for? Method contains useless variables ### What type of PR is it? Improvement ### What is the Jira issue? * [ZEPPELIN-5891] -- This is an

[GitHub] [zeppelin] NicolasGong commented on pull request #4578: [ZEPPELIN-5891] Method contains useless variables

2023-04-05 Thread via GitHub
NicolasGong commented on PR #4578: URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1498391860 I agree with you and resubmitted the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4576: Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /neo4j

2023-03-29 Thread via GitHub
dependabot[bot] opened a new pull request, #4576: URL: https://github.com/apache/zeppelin/pull/4576 Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.12.6.1 to 2.12.7.1. Commits See full diff in https://github.com/FasterXML/jackson/commits;>compare view

[GitHub] [zeppelin] jongyoul merged pull request #4543: Bump jettison from 1.4.0 to 1.5.2

2023-02-05 Thread via GitHub
jongyoul merged PR #4543: URL: https://github.com/apache/zeppelin/pull/4543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] zjffdu commented on pull request #4558: [ZEPPELIN-5846] Remove support flink 1.12

2023-02-05 Thread via GitHub
zjffdu commented on PR #4558: URL: https://github.com/apache/zeppelin/pull/4558#issuecomment-1418377416 CI is passed, will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zeppelin] jongyoul merged pull request #4558: [ZEPPELIN-5846] Remove support flink 1.12

2023-02-05 Thread via GitHub
jongyoul merged PR #4558: URL: https://github.com/apache/zeppelin/pull/4558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4496: Bump flink.hadoop.version from 2.7.7 to 3.1.1.7.2.15.0-147 in /flink/flink-scala-parent

2023-02-05 Thread via GitHub
dependabot[bot] commented on PR #4496: URL: https://github.com/apache/zeppelin/pull/4496#issuecomment-1418588323 Looks like these dependencies are no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] dependabot[bot] closed pull request #4496: Bump flink.hadoop.version from 2.7.7 to 3.1.1.7.2.15.0-147 in /flink/flink-scala-parent

2023-02-05 Thread via GitHub
dependabot[bot] closed pull request #4496: Bump flink.hadoop.version from 2.7.7 to 3.1.1.7.2.15.0-147 in /flink/flink-scala-parent URL: https://github.com/apache/zeppelin/pull/4496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zeppelin] qinbo12 opened a new pull request, #4563: Solve the concurrency clone note

2023-02-10 Thread via GitHub
qinbo12 opened a new pull request, #4563: URL: https://github.com/apache/zeppelin/pull/4563 This pull request migrates solve the concurrency problem caused by multiple concurrent calls to note clone. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4564: Bump cacheable-request and ng-packagr in /zeppelin-web-angular

2023-02-11 Thread via GitHub
dependabot[bot] opened a new pull request, #4564: URL: https://github.com/apache/zeppelin/pull/4564 Removes [cacheable-request](https://github.com/jaredwray/cacheable-request). It's no longer used after updating ancestor dependency [ng-packagr](https://github.com/ng-packagr/ng-packagr).

[GitHub] [zeppelin] Reamer opened a new pull request, #4562: [ZEPPELIN-5880] Credentials roles

2023-02-07 Thread via GitHub
Reamer opened a new pull request, #4562: URL: https://github.com/apache/zeppelin/pull/4562 ### What is this PR for? This PR implements the sharing of credentials between users and groups. Due to additional information in the credential file, the structure has been changed. There

[GitHub] [zeppelin] zjffdu opened a new pull request, #4561: [HOTFIX] Fix CI failure due to sqlalchemy api change

2023-02-03 Thread via GitHub
zjffdu opened a new pull request, #4561: URL: https://github.com/apache/zeppelin/pull/4561 ### What is this PR for? Recently CI is failed due to sqlalchemy api change. This PR enforce the sqlalchemy version to make the CI pass. ### What type of PR is it? Hot Fix

[GitHub] [zeppelin] zjffdu commented on pull request #4561: [HOTFIX] Fix CI failure due to sqlalchemy api change

2023-02-04 Thread via GitHub
zjffdu commented on PR #4561: URL: https://github.com/apache/zeppelin/pull/4561#issuecomment-1416721203 CI is passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [zeppelin] zjffdu merged pull request #4561: [HOTFIX] Fix CI failure due to sqlalchemy api change

2023-02-04 Thread via GitHub
zjffdu merged PR #4561: URL: https://github.com/apache/zeppelin/pull/4561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] cometta commented on pull request #4388: [ZEPPELIN-5755] Support Spark 3.3

2023-02-14 Thread via GitHub
cometta commented on PR #4388: URL: https://github.com/apache/zeppelin/pull/4388#issuecomment-1430827058 will the official release of zeppelin with 3.3 support available soon? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zeppelin] ottok92 commented on pull request #4565: Reflect ZEPPELIN-5352 changes in docs

2023-02-15 Thread via GitHub
ottok92 commented on PR #4565: URL: https://github.com/apache/zeppelin/pull/4565#issuecomment-1431234117 @zjffdu not yet but I will try it over the next couple of days and let you know if I find any issue  -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4560: Bump http-cache-semantics and @angular/cli in /zeppelin-web-angular

2023-02-02 Thread via GitHub
dependabot[bot] opened a new pull request, #4560: URL: https://github.com/apache/zeppelin/pull/4560 Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) to 4.1.1 and updates ancestor dependency [@angular/cli](https://github.com/angular/angular-cli). These

[GitHub] [zeppelin] Reamer opened a new pull request, #4559: [ZEPPELIN-5879] Migrate Zeppelin Plugins to JUnit5

2023-02-01 Thread via GitHub
Reamer opened a new pull request, #4559: URL: https://github.com/apache/zeppelin/pull/4559 ### What is this PR for? This pull request migrates the JUnit 4 tests to Junit 5 tests. ### What type of PR is it? Refactoring ### What is the Jira issue?

[GitHub] [zeppelin] jongyoul merged pull request #4519: [ZEPPELIN-5855] Refactor docker plugin and remove powermock

2023-02-01 Thread via GitHub
jongyoul merged PR #4519: URL: https://github.com/apache/zeppelin/pull/4519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] canhtran commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-02-12 Thread via GitHub
canhtran commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1427370649 I'm rebuilding from source for flink 1.16.0 but there aren't any `Flink interpreter` after the build. There is only `flink-cmd interpreter`. Please let me know if there is anything

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-02-12 Thread via GitHub
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1427386135 @canhtran How did you build Zeppelin? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] canhtran commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-02-13 Thread via GitHub
canhtran commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1428335587 @zjffdu Hi Zeff, thanks for the reply I followed the link here https://zeppelin.apache.org/docs/latest/setup/basics/how_to_build.html. 1. Clone the latest source of zeppelin 2.

[GitHub] [zeppelin] ottok92 opened a new pull request, #4565: Reflect ZEPPELIN-5352 changes in docs

2023-02-14 Thread via GitHub
ottok92 opened a new pull request, #4565: URL: https://github.com/apache/zeppelin/pull/4565 ### What is this PR for? https://issues.apache.org/jira/browse/ZEPPELIN-5352 Changes made to add support for Flink in k8s mode were not reflected in the interpreter documentation.

[GitHub] [zeppelin] zjffdu commented on pull request #4565: Reflect ZEPPELIN-5352 changes in docs

2023-02-14 Thread via GitHub
zjffdu commented on PR #4565: URL: https://github.com/apache/zeppelin/pull/4565#issuecomment-1429642372 Thanks for the contribution, BTW, have you even tried run flink on k8s in Zeppelin? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zeppelin] Reamer commented on pull request #4593: [ZEPPELIN-5898]fix:download csv data error

2023-04-28 Thread via GitHub
Reamer commented on PR #4593: URL: https://github.com/apache/zeppelin/pull/4593#issuecomment-1527517415 Thank you for your participation. I am looking forward to your PullRequest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] zhugezifang opened a new pull request, #4593: [ZEPPELIN-5898]fix:download csv data error

2023-04-28 Thread via GitHub
zhugezifang opened a new pull request, #4593: URL: https://github.com/apache/zeppelin/pull/4593 ### What is this PR for? This pull request fix the bug of download csv data error ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is

[GitHub] [zeppelin] zhugezifang closed pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
zhugezifang closed pull request #4591: [ZEPPELIN-5898]fix:down csv data error URL: https://github.com/apache/zeppelin/pull/4591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] zhugezifang commented on pull request #4593: [ZEPPELIN-5898]fix:download csv data error

2023-04-28 Thread via GitHub
zhugezifang commented on PR #4593: URL: https://github.com/apache/zeppelin/pull/4593#issuecomment-1527513402 > LGTM thanks, and i also want to add the feature of sql-debug to zeppelin ,it is a brief description in https://issues.apache.org/jira/browse/ZEPPELIN-5896 --

[GitHub] [zeppelin] huage1994 merged pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-05-03 Thread via GitHub
huage1994 merged PR #4579: URL: https://github.com/apache/zeppelin/pull/4579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-05-04 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1534337348 > @huage1994 Please rebase your current branch. I merged #4582 right now. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] Reamer commented on pull request #4508: Bump ivy from 2.4.0 to 2.5.1 in /flink/flink-scala-parent

2023-06-14 Thread via GitHub
Reamer commented on PR #4508: URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1591104853 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] Reamer commented on pull request #4481: Bump shiro-core from 1.9.1 to 1.10.0

2023-06-14 Thread via GitHub
Reamer commented on PR #4481: URL: https://github.com/apache/zeppelin/pull/4481#issuecomment-1591100262 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] Reamer commented on pull request #4481: Bump shiro-core from 1.9.1 to 1.10.0

2023-06-14 Thread via GitHub
Reamer commented on PR #4481: URL: https://github.com/apache/zeppelin/pull/4481#issuecomment-1591103950 > Hi, Can this PR be reviewed? Let's see what the CI results are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4615: Bump guava from 24.1.1-jre to 32.0.0-jre in /shell

2023-06-14 Thread via GitHub
dependabot[bot] opened a new pull request, #4615: URL: https://github.com/apache/zeppelin/pull/4615 Bumps [guava](https://github.com/google/guava) from 24.1.1-jre to 32.0.0-jre. Release notes Sourced from https://github.com/google/guava/releases;>guava's releases. 32.0.0

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4614: Bump guava from 24.1.1-jre to 32.0.0-jre in /bigquery

2023-06-14 Thread via GitHub
dependabot[bot] opened a new pull request, #4614: URL: https://github.com/apache/zeppelin/pull/4614 Bumps [guava](https://github.com/google/guava) from 24.1.1-jre to 32.0.0-jre. Release notes Sourced from https://github.com/google/guava/releases;>guava's releases. 32.0.0

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4473: Bump guava from 24.1.1-jre to 29.0-jre in /shell

2023-06-14 Thread via GitHub
dependabot[bot] commented on PR #4473: URL: https://github.com/apache/zeppelin/pull/4473#issuecomment-1592067168 Superseded by #4615. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] dependabot[bot] closed pull request #4473: Bump guava from 24.1.1-jre to 29.0-jre in /shell

2023-06-14 Thread via GitHub
dependabot[bot] closed pull request #4473: Bump guava from 24.1.1-jre to 29.0-jre in /shell URL: https://github.com/apache/zeppelin/pull/4473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

<    1   2   3   4   >