[jira] [Created] (ZEPPELIN-1591) PhantomJS failing on Mac OS Sierra
CORNEAU Damien created ZEPPELIN-1591: Summary: PhantomJS failing on Mac OS Sierra Key: ZEPPELIN-1591 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1591 Project: Zeppelin Issue Type: Bug Reporter: CORNEAU Damien Priority: Critical Fix For: 0.7.0 For people that updated their Mac OS to Sierra, there is an issue with PhantomJS: https://github.com/karma-runner/karma-phantomjs-launcher/issues/138 In our case, it would be impossible to build without -DskipTests flag. After a local test, changing version of: karma-phantomjs-launcher to ~1.0.2 solves that issue, however it should also be tested on other OSes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1510) Zeppelin-Web Good Practices #5 - ng-if vs ng-show
CORNEAU Damien created ZEPPELIN-1510: Summary: Zeppelin-Web Good Practices #5 - ng-if vs ng-show Key: ZEPPELIN-1510 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1510 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Assignee: CORNEAU Damien This Good Practice Guide will focus on the difference between ng-if and ng-show and which cases are the best to use them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1496) Apply Zeppelin-Web Good Practice guide #1 to the code
CORNEAU Damien created ZEPPELIN-1496: Summary: Apply Zeppelin-Web Good Practice guide #1 to the code Key: ZEPPELIN-1496 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1496 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Assignee: CORNEAU Damien This is some refactoring of zeppelin-web angular modules, to apply the IIFE as stated in the Good Practice Guide #1 (https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1495) Zeppelin-Web Good Practices #4 - Using ng-bind
CORNEAU Damien created ZEPPELIN-1495:
Summary: Zeppelin-Web Good Practices #4 - Using ng-bind
Key: ZEPPELIN-1495
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1495
Project: Zeppelin
Issue Type: Improvement
Reporter: CORNEAU Damien
Assignee: CORNEAU Damien
This Good Practive Guide will focus on using ng-bind instead of the {{}}
syntax, to have a performance boost.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1462) Zeppelin-Web Good Practices #3 - How to write a controller
CORNEAU Damien created ZEPPELIN-1462: Summary: Zeppelin-Web Good Practices #3 - How to write a controller Key: ZEPPELIN-1462 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1462 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Assignee: CORNEAU Damien This Good Practice Guide will focus on how to write a controller following the controller as vm concept, and how to provide a nice separation of the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1415) Zeppelin-Web Good Practices #2 - Event Dispatching
CORNEAU Damien created ZEPPELIN-1415: Summary: Zeppelin-Web Good Practices #2 - Event Dispatching Key: ZEPPELIN-1415 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1415 Project: Zeppelin Issue Type: Task Reporter: CORNEAU Damien Assignee: CORNEAU Damien This Good Practice Guide will focus on how to handle the event dispatching correctly in the app ($broadcast, $emit, $on) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1414) Remove Contributing Markdown file from project source code
CORNEAU Damien created ZEPPELIN-1414: Summary: Remove Contributing Markdown file from project source code Key: ZEPPELIN-1414 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1414 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Assignee: CORNEAU Damien Fix For: 0.6.2 Following https://github.com/apache/zeppelin/pull/1356, we move the contribution documentation to the website. We now can remove the contributing files from the repository, and add proper links to that documentation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1359) Re-order Zeppelin-web karma.conf
CORNEAU Damien created ZEPPELIN-1359: Summary: Re-order Zeppelin-web karma.conf Key: ZEPPELIN-1359 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1359 Project: Zeppelin Issue Type: Bug Reporter: CORNEAU Damien Assignee: CORNEAU Damien Priority: Minor If you do a build from a clean repository, karma-conf will be modified to re-shuffled alphabetically (like it is supposed to be) the order of the dependencies. Since it isn't a code modification we want after build, we should change the un-ordered dependency and commit it to the source code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1346) Add contributing instructions to the website
CORNEAU Damien created ZEPPELIN-1346: Summary: Add contributing instructions to the website Key: ZEPPELIN-1346 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1346 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Assignee: CORNEAU Damien This issue is to move some of the contributions instructions to the website, and extend it to add more code specific good practices and advices. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1310) Remove angular debug classes
CORNEAU Damien created ZEPPELIN-1310: Summary: Remove angular debug classes Key: ZEPPELIN-1310 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1310 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Assignee: CORNEAU Damien Following: https://code.angularjs.org/1.5.5/docs/guide/production Removing the debug classes added by angular to the html should bring some performances improvements. Instead of complicated the build by adding it only in production, this will be activated all the time. Since some developer might need it, we will document the easy console activation in our contributing doc -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1290) Refactor Navbar Controller to keep the controllerAs with vm structure
CORNEAU Damien created ZEPPELIN-1290: Summary: Refactor Navbar Controller to keep the controllerAs with vm structure Key: ZEPPELIN-1290 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1290 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Assignee: CORNEAU Damien The original Navbar Controller was changed to apply the controllerAs with vm structure. But It was modified and isn't properly done anymore. Changing it would allow us to keep one good example of how to make a controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1276) Notebook Name input is not disappearing anymore
CORNEAU Damien created ZEPPELIN-1276: Summary: Notebook Name input is not disappearing anymore Key: ZEPPELIN-1276 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1276 Project: Zeppelin Issue Type: Bug Reporter: CORNEAU Damien Assignee: CORNEAU Damien When you edit the Notebook Title, the Input is not going away after Enter, ESC or click outside. It seems to be related to the change from ng-show -> ng-if in this PR: https://github.com/apache/zeppelin/pull/1180 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1183) Remove the use of $windows.location for redirection
CORNEAU Damien created ZEPPELIN-1183: Summary: Remove the use of $windows.location for redirection Key: ZEPPELIN-1183 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1183 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Assignee: CORNEAU Damien Fix For: 0.7.0 There is a few call to $windows.location to redirect the user to a different page. However we already have a native service that we are using in the app to take care of that: $location. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1167) Refactoring - Group $scope.$on functions at the bottom of controllers
CORNEAU Damien created ZEPPELIN-1167: Summary: Refactoring - Group $scope.$on functions at the bottom of controllers Key: ZEPPELIN-1167 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1167 Project: Zeppelin Issue Type: Improvement Components: front-end Reporter: CORNEAU Damien Assignee: CORNEAU Damien Priority: Minor Fix For: 0.7.0 This issue is a small refactoring of the zeppelin-web controllers. This group all the $scope.$on functions together at the end of the controllers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1166) Missing Jquery-ui CSS
CORNEAU Damien created ZEPPELIN-1166: Summary: Missing Jquery-ui CSS Key: ZEPPELIN-1166 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1166 Project: Zeppelin Issue Type: Bug Reporter: CORNEAU Damien Assignee: CORNEAU Damien Fix For: 0.7.0 There is a missing jquery-ui css message in the console. It seems that the name of that file changed from one version to another. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1113) Paragraph is saving the colWidth when value didn't change
CORNEAU Damien created ZEPPELIN-1113: Summary: Paragraph is saving the colWidth when value didn't change Key: ZEPPELIN-1113 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1113 Project: Zeppelin Issue Type: Improvement Affects Versions: 0.5.6, 0.6.0 Reporter: CORNEAU Damien Assignee: CORNEAU Damien Priority: Minor Fix For: 0.6.1 If you use the shortcut or resize handle to make a paragraph colWidth bigger even though it's already at its maximum, we still send a WS event to save the config. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1095) Inconsistencies in the way TEXT result is sent when running a paragraph
CORNEAU Damien created ZEPPELIN-1095: Summary: Inconsistencies in the way TEXT result is sent when running a paragraph Key: ZEPPELIN-1095 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1095 Project: Zeppelin Issue Type: Bug Reporter: CORNEAU Damien Fix For: 0.6.1 While reviewing: https://github.com/apache/zeppelin/pull/1104 I ran a few tests, with a proper `resultRefreshed` value: `!angular.equals(data.paragraph.result, $scope.paragraph.result);`. I found out that the interpreters do not send back the TEXT type result the same way, making it difficult to use the resultRefreshed value to not re-render the same results. # In Short * Spark is sending 'PARAGRAPH_UPDATE_OUTPUT' before any 'PARAGRAPH_APPEND_OUTPUT', Fkink and Python (at least) do not. * Flink and Python (at least) are not sending their data inside a 'PARAGRAPH_APPEND_OUTPUT' event. * We receive 2 'PARAGRAPH_APPEND_OUTPUT' event with no data, after all the valid 'PARAGRAPH_APPEND_OUTPUT' were received (even for Flink and Python) # Possible actions * Don't use `resultRefreshed` for the TEXT type results. * Don't use `resultRefreshed` for the TEXT type results, and fix the inconsistencies. * Fix the inconsistencies and implement a new PARAGRAPH_ENDSTREAMING_OUTPUT event -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1089) Add Eslint
CORNEAU Damien created ZEPPELIN-1089: Summary: Add Eslint Key: ZEPPELIN-1089 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1089 Project: Zeppelin Issue Type: Sub-task Reporter: CORNEAU Damien Assignee: CORNEAU Damien Replace Jshint and add Eslint. JSCS could be added on the side if it isn't merged inside Eslint yet -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1088) Add Htmlhint
CORNEAU Damien created ZEPPELIN-1088: Summary: Add Htmlhint Key: ZEPPELIN-1088 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1088 Project: Zeppelin Issue Type: Sub-task Reporter: CORNEAU Damien Assignee: CORNEAU Damien Priority: Minor Add Html hint to check closing tags, indentation etc.. inside of the .html files -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1087) Improving Front-End code quality with better build tools
CORNEAU Damien created ZEPPELIN-1087: Summary: Improving Front-End code quality with better build tools Key: ZEPPELIN-1087 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1087 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Assignee: CORNEAU Damien We currently are using jshint only to force code rules on Zeppelin-web, However jshint is limited and we need a bit more than that. Instead of using Github diff to spot issues like trailing spaces, indent etc... it would be better to have the build taking care of it. Here is a list of the subtasks: * Add Eslint for (Jshint and Jscs) * Add Htmlhint (To check closing tags, indent etc...) * Taking care of Trailing spaces and tabs in the whole app -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1016) Remove Zeppelin-web deprecated dependencies warnings
CORNEAU Damien created ZEPPELIN-1016: Summary: Remove Zeppelin-web deprecated dependencies warnings Key: ZEPPELIN-1016 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1016 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Priority: Minor When building zeppelin-web from clean repo, we have a few warnings shown as [ERROR] from some dependencies. You can see those if you build inside zeppelin-web directory using `mvn clean package -DskipTests`: ``` [ERROR] npm WARN deprecated lodash@1.0.2: lodash@<3.0.0 is no longer maintained. Upgrade to lodash@^4.0.0. [ERROR] npm WARN deprecated graceful-fs@2.0.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree. [ERROR] npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree. [ERROR] npm WARN deprecated graceful-fs@3.0.8: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree. [ERROR] npm WARN deprecated CSSselect@0.7.0: the module is now available as 'css-select' [ERROR] npm WARN deprecated CSSwhat@0.4.7: the module is now available as 'css-what' ``` -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-1010) Improve Grid System based on Device size
CORNEAU Damien created ZEPPELIN-1010: Summary: Improve Grid System based on Device size Key: ZEPPELIN-1010 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1010 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Assignee: CORNEAU Damien The current paragraph grid has these specs: * Paragraphs can have between 1 and 12 as grid value. * Paragraphs are switched to 12 when width is < 992px After playing with the window size, some improvements can be made: * Deprecate grid size 1 and 2, and transform them into minimum value: 3 (Since paragraph that small are not practical in any window size) * Have a better paragraph grid size than 12 in case of tablet ( 768px > < 992px). 6 for paragraph of grid between (3 and 7 included), 12 for paragraphs of grid between (8 and 12) * Maybe more transformation of grid ratio between the main sizes (768, 992, 1200) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZEPPELIN-975) Move the Download Data button outside the paragraph settings
CORNEAU Damien created ZEPPELIN-975: --- Summary: Move the Download Data button outside the paragraph settings Key: ZEPPELIN-975 URL: https://issues.apache.org/jira/browse/ZEPPELIN-975 Project: Zeppelin Issue Type: Improvement Reporter: CORNEAU Damien Assignee: CORNEAU Damien Following PR https://github.com/apache/incubator-zeppelin/pull/714 We are moving the feature outside the paragraph settings -- This message was sent by Atlassian JIRA (v6.3.4#6332)
