Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3240
Would be great to cut 0.9 release with this and all other great
improvements that are currently only available in master. So more folks can
take leverage of those features, and provide feedback
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3145
@Leemoonsoo please help reviewing this
I personally think that color palette of selected paragraphs can be better
something else, but functionally it's a great improvement to core Zeppelin
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3113
cc @zjffdu @Leemoonsoo @prabhjyotsingh can you please merge this?
Thank you.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3199
Thanks @zjffdu !
Would be nice to have documentation as a reference on how to setup Kerberos
realm for Zeppelin authentication. Or at least documentation that it's
supported with perhaps
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3150
Thanks
On Tue, Aug 21, 2018 at 7:17 PM Jeff Zhang wrote:
> Will merge if no more comments
>
> â
> You are receiving this because you were mentioned.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3150
Yep, what I meant are fields like
"dateCreated": "2018-07-12 13:53:34.479",
"dateStarted": "2018-07-23 16:27:18.751",
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3150
Can this be an option? Perhaps that's on by default to make it compatible
with current Zeppelin release.
Our users find it useful to compare paragraph runtimes and who ran it from
last time
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3045
Can you guys please have a look at
https://issues.apache.org/jira/browse/ZEPPELIN-3719 in case if this change
caused that problem ?
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2923
Can you guys please have a look at
https://issues.apache.org/jira/browse/ZEPPELIN-3719 in case if this change
caused that problem ?
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3103
As discussed in https://github.com/apache/zeppelin/pull/3059 it seems a
good idea to have a **default interpreter group** set globally, and **default
interpreter set at note level**. What do you
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3059
@jongyoul I like the idea of having a default interpreter (and not a
default interpreter group ) **per note**.
+1
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3103
Thanks @zjffdu - that's a great improvement as ordering wasn't used in
zeppelin.
Would it be possible to introduce a similar knob to choose a default
interpreter, not just default interpreter
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3084
that makes sense. thanks @khalidhuseynov
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3103
@zjffdu, do I understand correctly that `zeppelin.interpreter.default`
would choose default interpreter, and not just interpreter group?
If so, it would also resolve
https://issues.apache.org
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3101
FYI. That download button will be removed by
https://github.com/apache/zeppelin/pull/3013
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3090
Very interesting improvements. Thanks for working on this.
Shouldn't LSP server be embedded into Python / PySpark interpreter itself
and not be a separate process?
This would address both
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3099
If there is a very long "folder/subfolder1/subfolder" part, wouldn't this
change always to
display only "folder/subfolder1/subfolder..." and not a notebook name?
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3074
Just out of curiosity, why Raft Protocol? Have you considered alternatives,
for example, Zookeeper could do here, I guess. I think what the design document
is missing is some sort of pros and cons
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3084
Would be nice to check freeze output for tornado version.
tornado 5.x is broken for Zeppelin.
https://issues.apache.org/jira/browse/ZEPPELIN-3505
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3047
wow. that's pretty serious issue. thanks for fixing this. LGTM.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3044
Thanks @zjffdu - that looks good to me. What about {username} instead of
{name} ?
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3044
> We could do that but it depends on the farischeduler.xml that user
specified. If user didn't specify the user name as pool name in
fairscheduler.xml, then it doesn't make sense to
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3044
I meant Zeppelin would set `spark.scheduler.pool` to username of the user
that was used to authenticate into Zeppelin.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3044
Would it be possible to set `spark.scheduler.pool` to authenticated user
name as well,
as described in https://issues.apache.org/jira/browse/ZEPPELIN-3334
I think it's a much better default
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3013
my 2 cents: 1. yes. 2,3. yes. except that `grid-ui` doesn't have native
`tsv` export, right? I thought `grid-ui` only allows to export as `csv` and as
`xlsx`, is this correct? If it is, we might
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3013
@sanjaydasgupta I agree with what you're saying
but what I was suggesting is just hook up **old button** to **ui-grid**
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Was thinking of another solution.. is it possible to *move* grid-ui's
- Export all/visible data as csv/xls
four options to that old Download menu?
So grid-ui would only have
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3000
> The orphaned file will not be automatically overwritten later because
File.createTempFile(...) will always attempt to create a new filename that is
unused in the directory.
That ma
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2952
We were using PR this in prod for a couple of weeks. Works great.
Left one additional comment based on users feedback.
"Select a paragraph" tooltip change to "Add
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2978
@sanjaydasgupta, `writeFile` in `FileSystemStorage` drops file first, and
then renames temp file.
It's not an atomic write, and also leaves a chance to loosing file that is
being written
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2601
> I believe one could remove old button "Download Data as CSV".
filed https://issues.apache.org/jira/browse/ZEPPELIN-3511 to remove old
export csv/tsv
This idea was
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2971
Thanks @prabhjyotsingh - filed
https://issues.apache.org/jira/browse/ZEPPELIN-3511 to consider removing old
export csv/tsv which is broken in some other ways (like when data has double
quotes
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2978
@sanjaydasgupta
> do you recommend similar treatment for FileSystemConfigStorage also?
yep, HDFS although is not a posix filesystem, but renaming a file is still
implemen
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2952
thank you @Savalek
@zjffdu would it be possible to merge this to master? (and not to 0.8)
thanks!
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2978
What's difference between LocalConfigStorage and FileSystemConfigStorage?
I don't know Zeppelin internals that well.
Wonder if this has to be fixed FileSystemConfigStorage.java as well
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2945
got it, thanks @zjffdu
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2979
works as expected.
thanks for quick turnaround!
LGTM.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
When I build Zeppelin, I see in maven build log
> [INFO] Including org.apache.thrift:libthrift:jar:0.9.3 in the shaded jar.
> [INFO] Including org.apache.thrift:libfb303:jar
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2945
@zjffdu, is it possible to commit this into the 0.8 branch? thanks.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2978
Thanks @sanjaydasgupta. I will give this a try today.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2979
Thanks @zjffdu - I will test this today.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2971
Got it @prabhjyotsingh - thanks.
So there are two separate ways to export data now - [1] is the newer way
and [2] is the older way.
What's advantage of having two export options
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2963
@sameer79 I refreshed my Zeppelin to latest master snapshot.
Can't reproduce any longer the issue I specified on the screenshot above.
Please disregard my earlier comment.
LGTM
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2976
LGTM
Verified manually - this patch fixes the issue.
Thanks a lot @prabhjyotsingh
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
thanks @prabhjyotsingh
bumping up 0.9.3 seems a good idea to me, but I'd like somebody else to
review this too.
my 2 cents - It might be also good to shade Thrift to avoid future
conflicts
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@prabhjyotsingh yes, seems that way.
It might be more specific for Cloudera or more generic.
I know that Cloudera packages CDH with a specific version of Thrift.
It used to be 0.9.2
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2971
How to activate XLS/XLSX download option?
It doesn't show up for me with this PR applied.
![image](https://user-images.githubusercontent.com/3013418/40377041-1e9353ec-5dad-11e8-92a5
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2976
thanks for prompt response @prabhjyotsingh
I will give this a try today.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@felixcheung as an example, I've seen NoSuchMethodError exceptions like one
below when working with Spark interpreter reading Hive tables and Thrift
version had a version mismatch .. so it may
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2971
Could you please also have a look at
https://issues.apache.org/jira/browse/ZEPPELIN-3478
CSV/TSV exports seem to be broken too.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2974
I think it's a great idea to add something like this to also show status if
an interpreter is running.
so show a green icon if interpreter is running/ or had been restarted
successfully
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
checked a few newer CDH 5 versions and they're packaged with 0.9.3.
older CDH 5 version come with 0.9.2.
CDH 6 will be shipped with 0.9.3 too.
my two cents: +1 from me.
thanks.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2963
@sameer79 I was using latest Zeppelin from master snapshot. Chrome browser.
Can you reproduce the same sorting issue for strings?
Here's the code I used:
```python
%pyspark
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2963
Thanks for fixing this - I just had a chance to test and confirm it fixes
number sorting.
PR title reads "Number sorting issue", but code change seems tries to
address String and Da
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2945
This PR fixes the issue I described in
https://github.com/apache/zeppelin/pull/2760#issuecomment-386148566
Now the git/versioning subpanel is back!
Thanks.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2760
I wonder if https://github.com/apache/zeppelin/pull/2945 fixes issue I
described in my earlier comment.
cc @cvaliente @myuwono
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2760
@zjffdu, just updated to master, and noticed versioning toolbar is
missing...
I think it's because of this PR.
We have
`zeppelin.notebook.storage
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2742
@necosta thanks for this great feature. It makes a lot of sense for
Zeppelin instance shared with different set of users. Would it be possible to
do this interpreter settings authorization for LDAP
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2923
I was thinking we should also lower-case usernames that are stored in
`notebook-authorization.json`, when doing authorization. Otherwise users
wouldn't be able to see their own notebooks when
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2923
Great idea.. I had a similar jira
https://issues.apache.org/jira/browse/ZEPPELIN-2886
Thanks!
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2894
Thanks @zjffdu
cc @prabhjyotsingh - you were saying in [a comment for
ZEPPELIN-3292](https://issues.apache.org/jira/browse/ZEPPELIN-3292?focusedCommentId=16387420
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2834
@zjffdu, @felixcheung would be exciting to have this feature be part of the
0.8.0 release.
Since there is a way to maintain backward compatibility, it seems to be a
low hanging fruit
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2834
@zjffdu Great idea on paragraph-level properties! There are so many
possible uses for this feature like ones you explained below.
For interpolation I think there should be a way to do
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2834
What happens when a notebook had code {something} and "something" doesn't
exist as a 'z' variable?
Would it be possible to review that comment I left earlier in
https://
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2684
Just noticed this.. I think it's a great feature!
In Jupyter we can also select multiple paragraphs.
Although it is made more seamless.. I believe you could Ctrl+click anywhere
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2782
I think it's a good improvement. As an example, Databricks spark notebooks
also have paragraph numbering across whole notebook.
Thanks.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2833
Tested manually - this patch fixes issue described in ZEPPELIN-3286
Thank you @zjffdu
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2835
@weand I just logged in https://issues.apache.org/jira/browse/ZEPPELIN-3292
for data duplication )
I don't think it's related to this PR?
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2833
thanks Jeff! will validate a bit later today.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2817
@SleepyThread - great feature!
Building on @felixcheung's comment, it would be good if Snapshot feature
would use org.apache.zeppelin.notebook.repo.GitNotebookRepo to store a
snapshot
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2822
Manually tested. Works as expected.
This PR fixes:
- Spark job progress bar
- ability to cancel as spark job from paragraph
- Spark Driver web UI link.
Thanks a lot
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2822
thank you @zjffdu - I will give this a try today
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2812
One way to fix
[ZEPPELIN-3253](https://issues.apache.org/jira/browse/ZEPPELIN-3253?focusedCommentId=16373706=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16373706
Github user Tagar closed the pull request at:
https://github.com/apache/zeppelin/pull/2812
---
GitHub user Tagar opened a pull request:
https://github.com/apache/zeppelin/pull/2812
disable tab completion
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2624
This commit seems broke Tab to indent text behavior.
https://issues.apache.org/jira/browse/ZEPPELIN-3253
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2809
I think as a nice side effect, this PR also fixes
https://issues.apache.org/jira/browse/ZEPPELIN-3238 - see comments there
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2323
Great improvement.
Submitted https://issues.apache.org/jira/browse/ZEPPELIN-3251 to consider
showing rows/columns lazily on scrolling events as otherwise ui-grid has a
significant overhead
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2649
Would be great to have this functionality part of core Zeppelin.
Any plans to move this PR forward? Thanks!
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2802
@zjffdu I just verified this new commit and it works great.
Glad to see exceptions in ipython backend are now being captured correctly.
I wasn't able to actually test frame size problem
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2802
LGTM
thanks a lot @zjffdu
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2810
Verified manually. Works as expected. Thanks a lot @zjffdu
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2782
I think a low-hanging fruit here might be if Zeppelin would treat paragraph
titles as mark down code?
So if you added leading `#` it would mean a high-level section of the
notebook, `##` would
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2802
thank you @zjffdu - I will check this today.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2810
thanks @zjffdu! will give this a try today.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2808
I think I've seen this behavior too. Thanks for fixing this.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2802
> ERROR [2018-02-14 10:39:10,922] ({grpc-default-executor-3}
IPythonClient.java[onError]:138) - Fail to call IPython grpc
> io.grpc.StatusRuntimeException: RESOURCE_EXH
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2805
Are those kind of properties mix in interpreter could happen because of
Zeppelin upgrade?
I.e. old properties and new properties mix?
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2802
@zjffdu I don't have a reproducible case yet. This error hasn't been very
consistent for me so it might be also a side effect of another problem. That's
why I asked above if we could capture
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2802
1) My main point was that this exception should be thrown to the user, so
he or she has a chance to increase this limit. Currently if it breaks, only way
to find out about this limitation
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2802
Thanks for the heads up, yep I figured out that I have to tune up
zeppelin.ipython.grpc.framesize to a large number.
I looked over the PR. Two quick suggestions
1) Would it be possible
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2782
Since we migrated from Jupyter to Zeppelin, I miss a lot floating ToC menu
Jupyter extension.
Super useful for larger notebooks - navigation becomes very transparent.
http://jupyter
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2790
Manually tested master with this PR when using CDH 5.12 and it solves NPE
issue when starting Spark interpreter.
Thanks @zjffdu !
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2744
Do you mean compile without option like
> -Dhadoop.version=2.6.0-cdh5.12.1
?
It compiles fine but I was getting runtime errors (like some non-existent
method etc). Ca
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2744
This commit broke build for CDH (maven convergence error on dependencies).
Should there be a automated test to check if a commit breaks compatibility
with Cloudera distro of Hadoop?
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2723
thank you @zjffdu
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2555
FYI
This Zeppelin issue will be worked around in Sparkling Water in following
PR - https://github.com/h2oai/h2o-3/pull/1705
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2555
Found this works around the issue on Python 2.. will test more.
```
import sys
sys.stdout.isatty = lambda : False
sys.stdout.encoding = None
```
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2555
@sctincman Did you find a workaround for this issue ? Thanks
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2631
One last thing - from user experience it would be convenient to know when
their interpreters timed out.
Something like a popup or just some sort of a graphical flag would do, I
guess
1 - 100 of 124 matches
Mail list logo
