[GitHub] zeppelin issue #1858: [ZEPPELIN-1229] Clear browser cache with version hasht...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1858 @astroshim still some missing in the $routeProvider. Otherwise I just want to point out that the original goal of the cache buster is to add a hash in the file name so that it is different when the code is built with changes, however by using the method of this PR the cache for the html will be broken every time we refresh the page. Was there any attempt to do it differently? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang still the same test failing but asking for different value this time... ``` Failed tests: SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result: Expected: "age\nÃÆââââ‰â¬ÅÃâü\njob\nÃÆââââ‰â¬ÅÃâü\nmarital\nÃÆââââ‰â¬ÅÃâü\neducation\nÃÆââââ‰â¬ÅÃâü\nbalance\nÃÆââââ‰â¬ÅÃâü\n30 unemployed married primary 1787" but: was "age\nââ¼\njob\nââ¼\nmarital\nââ¼\neducation\nââ¼\nbalance\nââ¼\n30 unemployed married primary 1787" Tests run: 16, Failures: 1, Errors: 0, Skipped: 0 ``` I will see how we can change this test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang Sorry I just updated to Sierra and am having a few issues. From the log it seems there is some broken front-end tests (probably due to a rebase) You should be able to run it locally in zeppelin-web folder with `./grunt test` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1510: [ZEPPELIN-675] "No data available" in invalid graph ty...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1510 @snaveenp Could you tell me your JIRA id? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1510: [ZEPPELIN-675] "No data available" in invalid graph ty...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1510 Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 Current failure is really weird, can you try launching the CI again (close/re-open PR)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1510: [ZEPPELIN-675] "No data available" in invalid graph ty...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1510 Tested, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1510: [ZEPPELIN-675] "No data available" in invalid graph ty...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1510 @snaveenp Thanks, let me do a quick test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 Also there is still the selenium test error: ``` Failed tests: SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result: Expected: "age\nâââ¬âü\njob\nâââ¬âü\nmarital\nâââ¬âü\neducation\nâââ¬âü\nbalance\nâââ¬âü\n30 unemployed married primary 1787" but: was "age\nââ¼\njob\nââ¼\nmarital\nââ¼\neducation\nââ¼\nbalance\nââ¼\n30 unemployed married primary 1787" ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang Sorry that it takes so long, you will need to rebase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 Not really, there is no issue with the feature, the test itself is a bit weird because it transform to text whatever it find: https://github.com/apache/zeppelin/blob/b8755ebb25ad793daa6873acc2e00b8d69588188/zeppelin-server/src/test/java/org/apache/zeppelin/integration/SparkParagraphIT.java#L189 Just need to change the expected value by adding that: `\nââ¼` instead of `\n` in between the header column I guess --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang The button we introduced in this PR, is breaking another test. Although the test looks funny, let's fix the expected result too ``` Failed tests: SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result: Expected: "age\njob\nmarital\neducation\nbalance\n30 unemployed married primary 1787" but: was "age\nââ¼\njob\nââ¼\nmarital\nââ¼\neducation\nââ¼\nbalance\nââ¼\n30 unemployed married primary 1787" ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang Have to fix a test, need to change the expected result in that test from `1,787` to `1787` ``` Failed tests: SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result: Expected: "age\njob\nmarital\neducation\nbalance\n30 unemployed married primary 1,787" but: was "age\nââ¼\njob\nââ¼\nmarital\nââ¼\neducation\nââ¼\nbalance\nââ¼\n30 unemployed married primary 1787" Tests run: 15, Failures: 1, Errors: 0, Skipped: 0 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang Selenium failure should now be fixed on Master, can you rebase? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1363: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1363 @Peilin-Yang Actually it's a bit hard for me to help since I can't rebase for you (Don't have the rights on your branch), but I can see that it is a pretty messy conflict you got. For the Rebase process, you need to do a: ``` git fetch apache-github git rebase apache-github/master ``` (apache-github being a remote for this official repo) At the first round of conflicts on `paragraph.controller.js`, I would advise to copy paste the file from master, and replace your local file with conflict with it. Then to copy paste the changes of your first commit into it (you can see the first commit diff [Here](https://github.com/apache/zeppelin/pull/1492/commits/b92e92ff8821a58c47d7510818ec518414499c83)) After that first round, the other conflicts should be easier --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1492: Refactor/handsontable service
GitHub user corneadoug opened a pull request: https://github.com/apache/zeppelin/pull/1492 Refactor/handsontable service Test PR to help rebase You can merge this pull request into a Git repository by running: $ git pull https://github.com/corneadoug/incubator-zeppelin Refactor/HandsontableService Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1492.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1492 commit b92e92ff8821a58c47d7510818ec518414499c83 Author: Peilin Yang <peil...@twitter.com> Date: 2016-08-25T17:06:23Z add text/numeric conversion support to table display commit 972cbe2304306e0f844107373ce38b5f90d33c30 Author: Peilin Yang <yangpei...@gmail.com> Date: 2016-09-10T20:58:55Z rebase merge commit 7976585849fb09d7a5de66c9b2074f8fc3aa7b4b Author: Peilin Yang <yangpei...@gmail.com> Date: 2016-09-12T16:41:20Z add validator for the columns commit 33f34168ef76fff8952fb0e1ba81ae02e82c67cd Author: Peilin Yang <yangpei...@gmail.com> Date: 2016-09-12T16:43:58Z commit commit f6fde09f471f5c03d3b4918f46f1f4f43fe0b4fc Author: Peilin Yang <yangpei...@gmail.com> Date: 2016-09-12T16:44:04Z Merge branch 'master' into ypeilin/table_num_cell_format commit d088fc2e22c217d06fd93ef85c90d60ff482ff80 Author: Peilin Yang <yangpei...@gmail.com> Date: 2016-09-12T17:23:50Z change the format of numeric column commit ba7112b33588320d5c5645bb909b7bc2c274f96d Author: Peilin Yang <yangpei...@gmail.com> Date: 2016-09-22T11:26:56Z Merge branch 'master' into ypeilin/table_num_cell_format commit 40f0a276fb346f81b9cc7d75a4e5ee974e938c03 Author: Peilin Yang <yangpei...@gmail.com> Date: 2016-09-22T15:44:21Z fix the bug: data type lost when switching between tables and charts. commit caeffa9268af6a30d754336b372690444e698850 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-10-04T09:01:21Z Move HandsonTable functions to a Service commit 4e9b1f306a7ac71d12cb70a78c4ace7bf29ad101 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-10-05T07:02:34Z Resort column after type change commit 82770b20dc3783564f1bfbc02e4e904032ae0ca7 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-10-05T07:50:57Z Small refactoring --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1461: [MINOR] Rearrange the contents in "About Zeppelin"
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1461 Go for it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1441: [ ZEPPELIN-967 ] Implement search bar in job manager
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1441 @cloverhearts Just tested and checked the code. Overall same feedbacks as @AhyoungRyu Filtering system The one you used seems a bit too complicated (also the filter should have been in a new file). Since it is also slow, using the same method used in interpreter search would be better. Filtering input Try to reuse the same as the interpreter search, it should have the proper font and keep the same style between pages. Interpreter dropdown filtering I would remove this feature mainly because it only works with the default interpreter. Maybe also remove the default interpreter written on each job? No results Current message is: `Data does not exist`, `No Job found` would be better Possible future work that could use a Jira issue * Removing the legend (ready, finished, abort etc...), that info is already on each dot. * Make Interpreter and Job page top part fixed, so that we can search even while scrolling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1461: [MINOR] Rearrange the contents in "About Zeppelin"
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1461 @AhyoungRyu Rebasing from master should fix the CI issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1461: [MINOR] Rearrange the contents in "About Zeppelin"
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1461 @AhyoungRyu Tested, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1491: Fix version of cachebust
GitHub user corneadoug reopened a pull request: https://github.com/apache/zeppelin/pull/1491 Fix version of cachebust ### What is this PR for? A dependency update of grunt-cache-bust is breaking the build. https://github.com/hollandben/grunt-cache-bust/issues/204 So fixing the dependency version ### What type of PR is it? Hot Fix ### Screenshot (before) ![screen shot 2016-10-06 at 12 22 40 pm](https://cloud.githubusercontent.com/assets/710411/19139450/bcad1494-8bbf-11e6-8b22-b9344055e876.png) ### How should this be tested? Clean your repo, and do mvn package in zeppelin-web ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/corneadoug/incubator-zeppelin fix/cacheBust Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1491.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1491 commit 81e26a5f508b5e389d0cc5d102d0083f81d3f1dc Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-10-06T02:56:34Z Fix version of cachebust --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1363: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1363 @Peilin-Yang Yes, you will need to rebase first though --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #133: [ZEPPELIN-127] Fix issue raised by ZEPPELIN-127 related...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/133 @doanduyhai Thanks, since it wasn't in the description, I didn't know @Leemoonsoo Can I merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practic...
Github user corneadoug closed the pull request at: https://github.com/apache/zeppelin/pull/1469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practic...
GitHub user corneadoug reopened a pull request: https://github.com/apache/zeppelin/pull/1469 [Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code ### What is this PR for? This is some refactoring of zeppelin-web to apply the IIFE as stated in the Good Practice Guide #1 (https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html) ### What type of PR is it? Refactoring ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1496 ### How should this be tested? Run The webapp, and go around the page, things should work like usual. But overall, just need to check that there is no type or parameter mismatch during the refactoring process (controller to controller, params in $inject etc...) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1496 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1469.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1469 commit 91d6e8d843760eea5953f3815b40e8757ecba02f Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-27T08:43:34Z Add IIFE to app.controller.js commit c5a3f541a51da23fbaed5abc68f4ca806cebe49b Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-27T08:48:36Z Move use strict outside IFFE commit 9b4c043b634e3770856416ec52e47edd6f03d0d4 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-27T08:59:03Z Add congiguration.controller.js commit ab47378358a66c7e41055aa36efb6dc2cd4720dd Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T05:36:38Z Refactor for IIFE credential, home and interpreter controller commit 309347e76d667f5cd370df61e3600b63828127b3 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:02:12Z IIFE refactoring of job page commit 50003726c2b68bc562365944d397403ea3346166 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:18:37Z Finish refactoring of App commit a33fb6347ce58c9472dbb588b1c0981e93d48da0 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:35:46Z Refactor components service and factory commit a58705d8a18e9e1444afbd1f9030d79ae0998a43 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:55:27Z Refactor components directives commit d3758bc5f41da94b12a0757b07df7ea4e4ae0e8a Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T08:56:28Z refactor components controllers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #777: D3 Plotting change and Allow custom location for interp...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/777 @michrawson Could you split this PR in two? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1478: [ZEPPELIN-1514] Make atom, rss, sitemap file not to be...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1478 CI failure is irrelevant. Tested, Merging it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1445 @meenakshisekar I can't find you with this username --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1445 @meenakshisekar Can you tell me your JIRA username? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1445 Ci failure is irrelevant, Merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1445 @meenakshisekar Could you fix the indent issue? I want to merge #1469 but since its refactoring job, it would need to be rebased after yours --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #544: [WIP] Multi-Language UI for ZeppelinWebApp
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/544 @djKooks Not sure it would make a difference. In the way it is implemented, each language already have its own .js file. And inside, the translations are set as an object/json format. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1433 @astroshim CI failure is irrelevant @Leemoonsoo any feedback? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1464 Well the problem here is that there is really nothing you can do, you are not going to change your Notebook name, or somebody else notebook name because both name are the same --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #47: Zeppelin 26
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/47 @cfmcgrady Is this PR still relevant? Otherwise I will close it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1474: Change path to tutorial images
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1474 Want to merge this fast, since it is a Hotfix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1474: Change path to tutorial images
GitHub user corneadoug opened a pull request: https://github.com/apache/zeppelin/pull/1474 Change path to tutorial images ### What is this PR for? Fixing the image path of the tutorial made in #418 ### What type of PR is it? Hot Fix ### What is the Jira issue? None, just a Hotfix ### How should this be tested? Build, move into full website, you should see the images ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/corneadoug/incubator-zeppelin fix/FlinkTutorialImg Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1474.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1474 commit cabd8df2025783c46819a396d18d3361de360923 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-30T03:05:18Z Change path to tutorial images --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1445 @meenakshisekar There is an indent error breaking the build, can you fix it? Then, merging this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1430 CI is green LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1464 @rajarajan-g How do you handle if another user with same notebook name decides to gives you read ability on his notebook? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1429 @r-kamath If you have trouble merging, tell me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1445 Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #418: [DOCS] Zeppelin Flink Spark tutorial
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/418 Awesome, Merging it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practic...
GitHub user corneadoug reopened a pull request: https://github.com/apache/zeppelin/pull/1469 [Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code ### What is this PR for? This is some refactoring of zeppelin-web to apply the IIFE as stated in the Good Practice Guide #1 (https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html) ### What type of PR is it? Refactoring ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1496 ### How should this be tested? Run The webapp, and go around the page, things should work like usual. But overall, just need to check that there is no type or parameter mismatch during the refactoring process (controller to controller, params in $inject etc...) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1496 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1469.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1469 commit 5080b8de464303cc812e2ed771b7a67c017b9c7f Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-27T08:43:34Z Add IIFE to app.controller.js commit 21a591eed164436189569a7ccc9a683b60ca65cc Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-27T08:48:36Z Move use strict outside IFFE commit be8f24c80652c1d9cbcee24bf31198518da9d016 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-27T08:59:03Z Add congiguration.controller.js commit 268477bd12bae7fbcd106869d4d39960f1699485 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T05:36:38Z Refactor for IIFE credential, home and interpreter controller commit 14dd6ccf026be31c1734ca53c9cea47c05fd07ef Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:02:12Z IIFE refactoring of job page commit e9f38fc69f05b8ece3c5c2bc48f1dd35214351d3 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:18:37Z Finish refactoring of App commit eb82887f8aa3ce47d53c816960a9bdaf52ede482 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:35:46Z Refactor components service and factory commit 76662ff1b6e4dc20e0383978a4deedb766e12af3 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:55:27Z Refactor components directives commit 9e8fec04b71b0436dc8be1836753ca878f1e4d0d Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T08:56:28Z refactor components controllers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practic...
Github user corneadoug closed the pull request at: https://github.com/apache/zeppelin/pull/1469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1469 Ready for review. Re-triggering the CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1445 Tested using ``` %sh echo -e "%table name\tval\nhello\thello\you\"good\nhello2\theelow,world" ``` LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practic...
GitHub user corneadoug opened a pull request: https://github.com/apache/zeppelin/pull/1469 [Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code ### What is this PR for? This is some refactoring of zeppelin-web to apply the IIFE as stated in the Good Practice Guide #1 (https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html) ### What type of PR is it? Refactoring ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1496 ### How should this be tested? Run The webapp, and go around the page, things should work like usual. But overall, just need to check that there is no type or parameter mismatch during the refactoring process (controller to controller, params in $inject etc...) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1496 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1469.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1469 commit b7b94b5ff3f87a535e3521f7551fd035e46744bf Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-27T08:43:34Z Add IIFE to app.controller.js commit f179474f1482c8ca89f52511608c9c90db39efa0 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-27T08:48:36Z Move use strict outside IFFE commit b946304b72395554165c95551d2b56784d431199 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-27T08:59:03Z Add congiguration.controller.js commit bf4462c1f11a3994fa73022c976eccdab5e6a068 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T05:36:38Z Refactor for IIFE credential, home and interpreter controller commit 66dd14debfb5a86d1906a7616b21c9c86c5fa4f2 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:02:12Z IIFE refactoring of job page commit 56b2103bc8e902f5ec1c6b4bfa8070f4963ecbbd Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:18:37Z Finish refactoring of App commit e7dcc2e9201bc9abfeb957c44b054ada085c72b6 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:35:46Z Refactor components service and factory commit b45d0fa270dda72006297a0a4077b40a672d0cc0 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T07:55:27Z Refactor components directives commit 3964e26663feee016ea0b50faa3e1c8c9490ea35 Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-28T08:56:28Z refactor components controllers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #133: [ZEPPELIN-127] Fix issue raised by ZEPPELIN-127 related...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/133 @doanduyhai Then can you create a Jira issue for it and maybe update the PR description? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #884: Note Permission: If userName does not exist in the shir...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/884 @wind0727 Any plan on taking care of this PR? I think it would need a new one, based on a special branch instead of your master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #560: Add finish alert with blinking tab title
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/560 @Stefan9149 Any plan on trying to finish this PR? Or should we just close it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #418: [DOCS] Zeppelin Flink Spark tutorial
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/418 @rawkintrevo Lets remove the `incubator` from URLs, rebase, then merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #409: Allow the spark app name to be configurable
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/409 @craigching Is this PR still needed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #389: ZEPPELIN-385 Read-only mode for zeppelin notebooks, for...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/389 @babokim Going around old PRs, Is it still needed considering the efforts for user authentication, and notebook acl restrictions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #338: ZEPPELIN-335: Apache Pig interpreter
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/338 @abajwa-hw I'm going around old PRs, any plan on finishing this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #336: Add bullet graph support
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/336 Going around old PRs. As stated before, we had issues with version 1.8.1, and have no plan on upgrading. In case newer versions don't have issues we can create a Jira issue to upgrade. I will be closing this PR if there is no other discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #320: ZEPPELIN-289: User can now enter custom expressions in ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/320 @rolmovel If this PRs is still needed, can we try to rebase it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #318: Save all repos, and not just the first two
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/318 @khalidhuseynov Is this still an issue with our current implementation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #299: a Js Intepreter, based on Nashorn
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/299 @leonardofoderaro I'm going around old PRs, Any plan on finishing this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #273: ZEPPELIN-277: Set the (TAB) key as an auto-completion s...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/273 @tzolov Should we close this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #291: Zeppelin-275: Add SpringXD Stream and Job Interpreters
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/291 @tzolov @bzz Do we want to rebase and try to merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #264: ZEPPELIN-270 added env varibles for pyspark's correct f...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/264 @riverajo @felixcheung @Leemoonsoo Any changes to be done here? Is this documentation change still needed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #252: Add ability to truncate displayed results while exporti...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/252 @azeloo Any plan on finishing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #246: ZEPPELIN-256 Self diagnosis spark configuration
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/246 @Leemoonsoo Any plan on finishing this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #234: ZEPPELIN-234
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/234 @guptarajat Hi, any plan on finishing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #228: Restart spark interpreter when the spark context has sh...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/228 @akhiluanandh I'm going around old PRs. Any plan on continuing that one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #86: Initial support for CassandraSQLContext for %sql queries
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/86 @bbromhead @jongyoul @Leemoonsoo any more feedback on changes needed on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #197: Update SparkInterpreter.java
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/197 We don't usually add to old branch if there is no more releases. It seems the PR branch doesn't exist anymore. Closing this PR is there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #193: ZEPPELIN-211: Add Geode Interpreter remote completer
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/193 @tzolov I'm going around old PRs, What is the status of this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #139: Move ZeppelinContext code to Scala
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/139 @doanduyhai I'm going around old PRs, What should we do about that one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #133: [ZEPPELIN-127] Fix issue raised by ZEPPELIN-127 related...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/133 @doanduyhai Do we have the still the need of that PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #152: ZEPPELIN-157: Adding Map Visualization for Zeppelin
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/152 @Madhuka Let's close this one since you opened another one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #132: ZEPPELIN-142 add SparkSqlCompleter
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/132 @nevillelyh I'm going around old PRs, is there any news on this issue? Or do you want to close it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #125: [WIP] Automated test with Yarn cluster for Spark integr...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/125 @Leemoonsoo Do we want to keep this PR, or should we close it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #72: [ZEPPELIN-9]: Provide Spark profiles for older 1.2.x and...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/72 If there is no more discussions, I will close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1463: [ZEPPELIN-1495] Add Good Practice #4
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1463 @AhyoungRyu Nice catch, I also escaped those in Good Practice #3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1463: [ZEPPELIN-1495] Add Good Practice #4
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1463 :) Merging it then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1463: [ZEPPELIN-1495] Add Good Practice #4
GitHub user corneadoug opened a pull request: https://github.com/apache/zeppelin/pull/1463 [ZEPPELIN-1495] Add Good Practice #4 ### What is this PR for? This Good Practice Guide promotes the usage of `ng-bind` instead of the classic `{{}}` syntax, to have a performance boost. ### What type of PR is it? Documentation ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1495 ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1495 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1463.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1463 commit c420d8ad34ee670ce215105c5516ac9d3ad0748c Author: Damien CORNEAU <cornead...@gmail.com> Date: 2016-09-27T06:04:46Z Add Good Practice #4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1408 Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #262: ZEPPELIN-268 : Adding Data Validation Feature and Test ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/262 @Madhuka Should we close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #576: ZEPPELIN-539 RemoteInterpreter Heartbeat (WIP)
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/576 @HeartSaVioR It's been quite some time, should we close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #704: Update NVD3 library for supporting new features.
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/704 @camilosampedro There is still no plan on upgrading nvd3 for now, can we close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #819: Fix compilation issues on branch 0.5.6 by backporting f...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/819 @jersub Can we close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1176: [Zeppelin 1165 : improve] Paragraph dynamic relationsh...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1176 @cloverhearts If I understand, the plan is to open a new PR for this feature? Can it be closed then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1230: [ZEPPELIN-606] Add a button to explicitly save a noteb...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1230 @rerngvit If any more arguments for this feature, I'd love to hear it, otherwise we would better close it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1324: Update AWS S3 library to avoid old Jackson
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1324 @iasandcb Do you want to continue it later when you have some time, or just close this PR? Otherwise you can also create a JIRA issue, and somebody can pick up the issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1323: [HOTFIX] Add logins authentication for hdfs file inter...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1323 @cloverhearts @jongyoul Any way to try this one out? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1324: Update AWS S3 library to avoid old Jackson
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1324 @iasandcb any update on this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1357: ZEPPELIN-1364: Return only the ran paragraph details f...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1357 @vipul1409 Can you rebase this PR? I will run a few tests to see if all the paragraph updates are handled here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1375: [ZEPPELIN-1171] Only retrieve resources if client is s...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1375 @lresende @jongyoul Any news on this issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1429 @r-kamath Could you just rebase once more? I will make a final check after --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1445 @meenakshisekar Could you take care of that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1408 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1430 @vensant it would be better to properly catch the error in the back-end and send it to the front --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1429 Except for the folder issue that @AhyoungRyu reported, I found another bug where the number do not increment: * Make a clone * Go back to the original note * Make another clone, the number is still 1 even though 1 already exist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1290 @mwkang Just tested quickly, I will have to run more test to check the behavior in general. There is some refactoring needed, I left some comments. Otherwise, a more global question, do we want to change the current default behavior of run? I would understand about adding another CTRL + ENTER shortcut to do something else. But what we are doing here is a breaking change to how Zeppelin use to behave. And there is also a lot of other way to run a paragraph, where we will need to decide how they react to that change too: * Click on paragraph run button * Click on run all paragraph button * CTRL + enter shortcut * SHIFT + enter shortcut * $on('runParagraph') * Angular display system runParagraph --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1408 @kavinkumarks This look like a good start, but is it the only case we wan't to handle here? Maybe it's because of the way we test this PR, but if I change the system notebook permission to read only (chmod 444), I can't run it, but everything I do is still there after page refresh. If I restart zeppelin-server, the notebook isn't there anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1431 Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1430 @vensant I don't really get why the error is being triggered this way. We are talking about the file size, but we show the error when the Websocket connection is cut. One example is to go on that import window, and to stop Zeppelin-server --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1290 @mwkang If you rebase again, the Error 2. Should be fixed. Error 1. should just be a random one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---