[GitHub] zeppelin issue #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete.

2018-10-10 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2972 Hi @anirbanch ! I have adopted PR to branch 0.8 and have created patch (can be founded in linked JIRA issue). You can apply patch and build jars. On your risks you can

[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...

2018-09-18 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu No, I didn't see the popup with error explanation for user. I have tested a lot with Russian symbols. Seems that Zeppelin works fine. Thank you

[GitHub] zeppelin issue #3179: [ZEPPELIN-3773] - add check permission on write.

2018-09-18 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3179 @Savalek You're right. I fix my shiro.ini. But I still see a huge amount of background queries (up to 100 per second) connected with Helium. I can reproduce the issue

[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...

2018-09-17 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu, I'm back 1. I get IOException if folder name equals to "..". The same need for name "." (single dot). 1. Try to create 2 notes with the same path

[GitHub] zeppelin pull request #3172: ZEPPELIN-3687. Fix IndexError in spark.pyspark ...

2018-09-13 Thread mebelousov
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/3172 ---

[GitHub] zeppelin issue #3179: [ZEPPELIN-3773] - add check permission on write.

2018-09-13 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3179 @Savalek I see an infinite number of GET request like http://localhost:8080/api/helium/suggest/2DMKVSPYC/20180807-154514_2063688624 with response "401 Unauthorized" is case if

[GitHub] zeppelin issue #3028: [ZEPPELIN-3549] Add to shiro.ini authorization for not...

2018-09-13 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3028 Will merge? ---

[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...

2018-09-11 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu - In note tree plus sing near folder must create note in this folder not at root. - It's seems double dots as folder name is still not fixed. - Can we avoid CR/LF chars

[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...

2018-09-11 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu * Now usual note has tooltip "Move this note to trash" on trash button. Trashed note has tooltip "Remove this note permanently". * Trashed note must

[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...

2018-09-10 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu - Need change the behavior for button "Move note to Trash" for notes in Trash: - * Need show another tooltip - * And delete note, but not add another "~Tras

[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...

2018-09-09 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu - note can't be cloned - need to deny folder name as ".." (double dot), because of after restart note will be in another folder - note with only one empty paragra

[GitHub] zeppelin issue #3172: ZEPPELIN-3687. Fix IndexError in spark.pyspark with em...

2018-09-07 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3172 @zjffdu it's really need to duplicate unit test from python interpreter? ---

[GitHub] zeppelin pull request #3172: ZEPPELIN-3687. Fix IndexError in spark.pyspark ...

2018-09-07 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3172 ZEPPELIN-3687. Fix IndexError in spark.pyspark with empty input (branch-0.8) ### What is this PR for? #3115 fix only python interpreter. For master branch is OK because spark.pyspark

[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in [Title].zpln instead of [N...

2018-09-03 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu I had a little test. - Create note with name "Folder/Name 1" - It was saved on disc correctly. - Try to edit note name: folder path is absent. ---

[GitHub] zeppelin issue #3141: Adding CSP header

2018-08-30 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3141 @atomicpages thank you! How CSP header works simultaneously with X-Frame-Option? What if I want to allow content in iframes from more than one server? ---

[GitHub] zeppelin issue #3147: [ZEPPELIN-3726] Fix NPE for resourceList function "get...

2018-08-16 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3147 CI is green https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/416710567 ---

[GitHub] zeppelin pull request #3147: [ZEPPELIN-3726] Fix NPE for resourceList functi...

2018-08-16 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3147 [ZEPPELIN-3726] Fix NPE for resourceList function "getAllResourcesExcept". ### What is this PR for? Trivial fix for e

[GitHub] zeppelin pull request #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete...

2018-08-16 Thread mebelousov
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2972 ---

[GitHub] zeppelin issue #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete.

2018-08-16 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2972 Will revert when anyone could test this PR. ---

[GitHub] zeppelin issue #3118: [zeppelin-3693] Option to toggle chart settings of par...

2018-08-10 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3118 @saravsars I'm not sure that your feature will merge. How about to introduce new display mode? ---

[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions

2018-08-07 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3107 @felixcheung could you point out good place for code that will be helpful after the migration to new version? ---

[GitHub] zeppelin pull request #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in...

2018-08-06 Thread mebelousov
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/3081 ---

[GitHub] zeppelin issue #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in visual...

2018-08-06 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3081 Will try to revert with tests. ---

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3092 Seems this PR broke build for scala 2.11 After execution of ` ./dev/change_scala_version.sh 2.11` I have got error ``` [ERROR] Failed to execute goal on project zeppelin-beam

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

2018-08-02 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3065 @zjffdu Our team do not use actively ResourcePool. We only plan to use. ---

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

2018-07-31 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3065 @zjffdu First version with ResourcePool was released a month ago (thanks to you ;) ) Now is good moment to decide future limitations. ---

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

2018-07-31 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3065 @zjffdu WDYT? ---

[GitHub] zeppelin issue #3098: ZEPPELIN-3664

2018-07-27 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3098 @fsteinle our team use authorization with parameter `activeDirectoryRealm.principalSuffix = @company.com` Thus email is not necessary. Could it possible to use mailNickName

[GitHub] zeppelin issue #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in visual...

2018-07-27 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3081 @jongyoul I also haven't good idea to write small and useful test. It's possible to rewrite copyStringToClipboard as pass to function the column number and then put in clipboard column name

[GitHub] zeppelin issue #3090: [ZEPPELIN-3645] Add LSP Protocol completion support

2018-07-27 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3090 @felixcheung I agree that support of LSP in Zeppelin is unmature idea. Share please undesired cases with open ip and port. ---

[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page

2018-07-18 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3035 @felixcheung Links are still broken in 0.9.0 and 0.8 docs. Could you check the reason? ---

[GitHub] zeppelin pull request #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in...

2018-07-18 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3081 ZEPPELIN-3575. Add 'Copy Column Name' button in visualization table ### What is this PR for? Add button to drop-down list in visualization table to copy column name. I know that column

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

2018-07-12 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3065 @zjffdu Nice! How about adding to ResourcePool only if resourceName specified in paragraph properties? ---

[GitHub] zeppelin issue #2848: [Zeppelin-3307] - Improved shared browsing/editing for...

2018-07-06 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2848 @jongyoul I see next usecase. 10 users open the note, put client ID in dynamic form, refresh note, get and process data result. In this case getting of default note view is OK

[GitHub] zeppelin issue #2848: [Zeppelin-3307] - Improved shared browsing/editing for...

2018-07-06 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2848 @jongyoul As I understand personal mode allows users run paragraphs and have different views and different results due user chosen values in dynamic forms. I'm against the removal

[GitHub] zeppelin issue #2733: [ZEPPELIN-3175] Set ExecutorFactory 65536 in Scheduler...

2018-07-05 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2733 Hmm... It seems PR is actual for branch-0.8. I propose to wait somebody with this bug and then fix source code. ---

[GitHub] zeppelin issue #2708: [Zeppelin-3095] Fix UI when all paragraphs executing s...

2018-07-04 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2708 @jongyoul status is ready to merge to master =) I hope I will merge this PR to our fork of branch-0.8 and will confirm that works fine. This needs 1-2 months. ---

[GitHub] zeppelin pull request #3050: ZEPPELIN-3581. Add "type": "textarea" to "defau...

2018-07-03 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3050 ZEPPELIN-3581. Add "type": "textarea" to "default.statementPrecode" in interpreter-setting.json ### What is this PR for? Fix "interpreter

[GitHub] zeppelin pull request #3048: [Docs] Update java version to 1.8

2018-07-03 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3048 [Docs] Update java version to 1.8 ### What is this PR for? This continues https://github.com/apache/zeppelin/pull/3029 (ZEPPELIN-621 - Bump Java version to Java 8) ### What type

[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page

2018-07-02 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3035 @felixcheung done ---

[GitHub] zeppelin issue #3024: [ZEPPELIN-3545] save all tables to ResourcePool

2018-06-25 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3024 @zjffdu I support adding only selected table results to Resource Pool. As paragraph can have multiple results than I propose to add result level properties. ---

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3039 @zjffdu great powerful feature! When the parameters will be a lot, it will be not easy to find and write the parameter name. I wish it would be more user-friendly with drop-down panel

[GitHub] zeppelin issue #3024: [ZEPPELIN-3545] save all tables to ResourcePool

2018-06-20 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3024 @zjffdu thank you about ResourcePool impoving. Share please your vision how it would be. For example, a paragraph has 5 table results. How user will define which of them would be added

[GitHub] zeppelin pull request #3035: [ZEPPELIN-3553] Fix URLs for "Notebook Permissi...

2018-06-19 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3035 [ZEPPELIN-3553] Fix URLs for "Notebook Permission" and "Shiro Authentic… ### What is this PR for? On page Setup > Multi-user Support http://zeppelin.apache.org/docs/0.

[GitHub] zeppelin issue #3027: [ZEPPELIN-2605] Import notebook has 1MB size limit but...

2018-06-19 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3027 @sanjaydasgupta thank you! LGTM ---

[GitHub] zeppelin pull request #3028: [ZEPPELIN-3549] Add to shiro.ini authorization ...

2018-06-18 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3028 [ZEPPELIN-3549] Add to shiro.ini authorization for notebook-repositories ### What is this PR for? Small improvement that users cannot change notebook repositories by default

[GitHub] zeppelin issue #3003: [ZEPPELIN-3526] Zeppelin auth mechanisms (LDAP or pass...

2018-06-05 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3003 @prabhjyotsingh I think it's good to document only one way for authentification. What do you think about it? ---

[GitHub] zeppelin issue #2996: ZEPPELIN-3521 Dynamic note form overlaps with paragrap...

2018-06-04 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2996 LGTM ---

[GitHub] zeppelin issue #2982: [ZEPPELIN-3492] The paragraph's table does not scroll ...

2018-06-04 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2982 I have tested. LGTM ---

[GitHub] zeppelin issue #2987: ZEPPELIN-3502 Make notebook dynamic forms title editab...

2018-05-30 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2987 @r-kamath I have tested. It's nice feature for global dynamic form. Thank you! ---

[GitHub] zeppelin pull request #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete...

2018-05-17 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2972 ZEPPELIN-3379. Refactoring of JDBC autocomplete. ### What is this PR for? Current implementation of autocomplete allows only completion in `schema.table.column` scenario. Such scenario

[GitHub] zeppelin pull request #2970: ZEPPELIN-3379 Refactoring of JDBC autocomplete.

2018-05-17 Thread mebelousov
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2970 ---

[GitHub] zeppelin pull request #2970: ZEPPELIN-3379 Refactoring of JDBC autocomplete.

2018-05-16 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2970 ZEPPELIN-3379 Refactoring of JDBC autocomplete. ### What is this PR for? Current implementation of autocomplete allows only completion in `schema.table.column` scenario. Such scenario

[GitHub] zeppelin issue #2930: ZEPPELIN-3414. branch-0.8 - download py4j from main re...

2018-04-23 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2930 Jeff, you are right. Need rework. ---

[GitHub] zeppelin pull request #2930: ZEPPELIN-3414. branch-0.8 - download py4j from ...

2018-04-23 Thread mebelousov
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2930 ---

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

2018-04-22 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 @weand Thank you! Some addition to 2. Over time user may not belong to group. At first we could store cronExecutingRoles and in future it's to be good to check groups on the fly. ---

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

2018-04-19 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 @zjffdu This is your solution ;) I have tested your branch. Do we have uniform opinion that running document as the group is not good? ---

[GitHub] zeppelin pull request #2930: ZEPPELIN-3414. branch-0.8 - download py4j from ...

2018-04-18 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2930 ZEPPELIN-3414. branch-0.8 - download py4j from main repo ### What is this PR for? Now py4j-0.9.2 is downloaded from "pypi.python.org". Seems that "pypi.python.org&quo

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

2018-04-18 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 @weand cronExecutionUser is set to the user who set the cron string inside the note. @zjffdu I define groups in shiro.ini. The user sets groupname in owner field. Then the note runs

[GitHub] zeppelin issue #2848: [Zeppelin-3307] - Improved shared browsing/editing for...

2018-04-17 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2848 Zeppelin has websockets and two users can view a note simultaneously, but there is a bug. - Open the note in two tabs. - Write anything in first tab for second. - Wait for 10

[GitHub] zeppelin pull request #2907: ZEPPELIN-3347 Fix "PYTHONPATH" for spark.pyspar...

2018-04-17 Thread mebelousov
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2907 ---

[GitHub] zeppelin issue #2615: [ZEPPELIN-1999][IMPROVEMENT] refactoring replacement c...

2018-04-17 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2615 @zjffdu replaceContext happens every call of jobRun() in RemoteInterpreterServer.java ---

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

2018-04-17 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 @zjffdu I have checked with group as owner. This is ok. Why do you think that use of owner is more secure than cronExecutingUser? ---

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

2018-04-17 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 Groups can be note owners. As I see `AuthenticationInfo` is not valid for internal shiro groups. How can I find the user which scheduled note? ---

[GitHub] zeppelin issue #2920: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2920 @zjffdu Another repo and another PR, but the same error https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/365002216 ---

[GitHub] zeppelin pull request #2920: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread mebelousov
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2920 ---

[GitHub] zeppelin pull request #2920: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread mebelousov
GitHub user mebelousov reopened a pull request: https://github.com/apache/zeppelin/pull/2920 [ZEPPELIN-2679] JDBC. precode for session ### What is this PR for? We have a precode for interpreter (all interpreters) which executes once after start interpreter. With it we can

[GitHub] zeppelin pull request #2920: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2920 [ZEPPELIN-2679] JDBC. precode for session ### What is this PR for? We have a precode for interpreter (all interpreters) which executes once after start interpreter. With it we can create

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 Cache is clean now. I try to retrigger from both accounts. The result is the sameю ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-10 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu I have retriggered several times. Travis fails with the same error on all jobs. ---

[GitHub] zeppelin pull request #2907: ZEPPELIN-3347 Fix "PYTHONPATH" for spark.pyspar...

2018-04-03 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2907 ZEPPELIN-3347 Fix "PYTHONPATH" for spark.pyspark in branch-0.8 ### What is this PR for? Use system PYTHONPATH in spark.pyspark interpreter, if PYTHONPATH already exists in e

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-03 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu hooks are user defined code. We want to have opportunity to log the user sessions, to bind queries to notes. It can be possible only by force execution of special query before

[GitHub] zeppelin pull request #2896: ZEPPELIN-3347. Fix "PYTHONPATH" for spark.pyspa...

2018-04-02 Thread mebelousov
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2896 ---

[GitHub] zeppelin issue #2896: ZEPPELIN-3347. Fix "PYTHONPATH" for spark.pyspark

2018-04-02 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2896 @zjffdu has closed this issue in #2901 ---

[GitHub] zeppelin pull request #2896: ZEPPELIN-3347. Fix "PYTHONPATH" for spark.pyspa...

2018-03-27 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2896 ZEPPELIN-3347. Fix "PYTHONPATH" for spark.pyspark ### What is this PR for? Use system PYTHONPATH in spark.pyspark interpreter, if PYTHONPATH already exists in environment

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-03-26 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu The hooks as pre-code were discussed [previously ](https://github.com/apache/zeppelin/pull/2096#issuecomment-284220634) We want precode execute before pre-hook for easy finding

[GitHub] zeppelin pull request #2876: ZEPPELIN-3344. Revert comments in queries in JD...

2018-03-20 Thread mebelousov
GitHub user mebelousov reopened a pull request: https://github.com/apache/zeppelin/pull/2876 ZEPPELIN-3344. Revert comments in queries in JDBC interpreter ### What is this PR for? The original purpose of https://github.com/apache/zeppelin/pull/2158 was correct processing

[GitHub] zeppelin pull request #2876: ZEPPELIN-3344. Revert comments in queries in JD...

2018-03-20 Thread mebelousov
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2876 ---

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-03-20 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2716 @woowahan-jaehoon thank you! Perhaps #2780 will delete all unused pid files and you can add the port to the pid filename. ---

[GitHub] zeppelin issue #2852: [ZEPPELIN-3264] Notebook Snapshot feature.

2018-03-19 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2852 Will the git storage allow to delete older snapshots? I see the scenario: every day create new snapshot and delete the oldest snapshot. ---

[GitHub] zeppelin pull request #2876: ZEPPELIN-3344. Revert comments in queries in JD...

2018-03-16 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2876 ZEPPELIN-3344. Revert comments in queries in JDBC interpreter ### What is this PR for? The original purpose of https://github.com/apache/zeppelin/pull/2158 was correct processing

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-03-13 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu, you are right, sessionPrecode is renamed to statementPrecode. Since 0.8.0 I will recommend to run JDBC interpreter per note in isolated mode due to Interpreter Lifecycle

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-03-13 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu @felixcheung Every day our users run about 1000 queries in the Greenplum (open source Postgres-based DB). There is great need for binding the query to the user

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-02-28 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2716 @woowahan-jaehoon , could you test `nohup` instead of `eval`? ---

[GitHub] zeppelin issue #2821: [ZEPPELIN-3271] Option for disabling scheduler

2018-02-27 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2821 It's sufficient to have only `zeppelin.notebook.cron.folders`. If this parameter is set to `*` - scheduling can be in all folders. If `System/*, Testing/*` - only in those folders. Thus

[GitHub] zeppelin issue #2821: [ZEPPELIN-3271] Option for disabling scheduler

2018-02-27 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2821 @prabhjyotsingh , I dreamed about this feature: [dev mailing list](https://lists.apache.org/thread.html/eb13b9dbd4a57c5e1e93297d7bde012e7f975bd2a0eb2a2a18c2d0ce@)! Now I think it would

[GitHub] zeppelin issue #2817: [ZEPPELIN-3264] Notebook Snapshot feature.

2018-02-26 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2817 @SleepyThread thank you! This is a nice feature. If the PR will be approved it would be great to have next functionality: - limit the number of snapshots and/or life time

[GitHub] zeppelin issue #2782: [ZEPPELIN-2729] Paragraph numbering

2018-02-21 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2782 I would prefer that the paragraph title is always added to the ToC as high-level section. ---

[GitHub] zeppelin issue #2801: ZEPPELIN-3159. Fixed Checkstyle errors and warnings in...

2018-02-20 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2801 Let's merge this. ---

[GitHub] zeppelin issue #2804: [DISCUSS] semicolons in javascript

2018-02-15 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2804 @prabhjyotsingh it's great that one of PMC file such PR. A lot of tests show that JS works faster without syntax warnings. :+1: ---

[GitHub] zeppelin pull request #2752: [ZEPPELIN-3195] Remove the limit on the number ...

2018-02-13 Thread mebelousov
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2752 ---

[GitHub] zeppelin issue #2752: [ZEPPELIN-3195] Remove the limit on the number of run ...

2018-02-13 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2752 @zjffdu @felixcheung What will we do with this bug? ---

[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-13 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2794 Our team uses AD. I have tested. Seems that it works good. ---

[GitHub] zeppelin issue #2782: [ZEPPELIN-2729] Paragraph numbering

2018-02-12 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2782 @Tagar there is "zeppelin-toc-spell" in the Helium packages. Now it supports only headers inside markdown interpreter. It will be good to bring new functions to "zep

[GitHub] zeppelin issue #2782: [ZEPPELIN-2729] Paragraph numbering

2018-02-10 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2782 @timovwb I also thought about good way to point on the right paragraph. How about to add new item in drop-down paragraph menu (like "Link this paragraph") that wil

[GitHub] zeppelin issue #2780: [ZEPPELIN-3215] Fix to remove pid of interpreter when ...

2018-02-08 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2780 @woowahan-jaehoon , thank you! Can we remove `rm -f "${ZEPPELIN_PID}"` from "shutdown_hook"? ---

[GitHub] zeppelin issue #2752: [ZEPPELIN-3195] Remove the limit on the number of run ...

2018-02-02 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2752 I renewed docs: remove old "ZEPPELIN_INTERPRETERS" and added ZEPPELIN_INTERPRETER_MAX_POOL_SIZE. The default value for ZEPPELIN_INTERPRETER_MAX_POOL_SIZE remains 10. ---

[GitHub] zeppelin issue #2752: [ZEPPELIN-3195] Remove the limit on the number of run ...

2018-02-01 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2752 @felixcheung Where I could document about ZEPPELIN_INTERPRETER_MAX_POOL_SIZE? There is no such cases in documentation. Also I cannot imagine than Zeppelin administrator will go

[GitHub] zeppelin issue #2752: [ZEPPELIN-3195] Remove the limit on the number of run ...

2018-01-30 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2752 It's not easy to understand that "ZEPPELIN_INTERPRETER_MAX_POOL_SIZE" affects the number of paragraphs executed at cron. I would be glad if nobody will meet this bug and no need

[GitHub] zeppelin pull request #2752: [ZEPPELIN-3195] Remove the limit on the number ...

2018-01-30 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2752 [ZEPPELIN-3195] Remove the limit on the number of run paragraphs at cron ### What is this PR for? Increase interpreter pool size for unlimit the number of paragraph that run at cron

  1   2   >