[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...

2016-10-24 Thread mwkang
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1350: [ZEPPELIN-1351]Paragraph status should be ERROR...

2016-10-24 Thread mwkang
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...

2016-10-24 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 I am not sure what is my next step. And this PR was created very long time ago. So enviroment changed before. I think other contributor can resolve better than me. So I closed this PR. Thanks

[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...

2016-10-24 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1350 I am not sure what is my next step. And this PR was created very long time ago. So enviroment changed before. I think other contributor can resolve better than me. So I closed this PR. Thanks

[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...

2016-10-15 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1350 Can anyone help this PR? I don't know the next step. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...

2016-09-24 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1350 @Leemoonsoo When paragraph received a SIGTERM, Job result code is INCOMPLETE. Before When Job result code is INCOMPLETE, Status is FINISHED. I think in this situation user can not realize

[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...

2016-09-22 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 @corneadoug Thanks for your comment. I rebased my branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...

2016-09-17 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1350 I added test. Please review PR, thanks for your consideration. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...

2016-09-17 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 There are 2 errors. 1. `ZeppelinSparkClusterTest.zRunTest:204 expected: but was:` does not reproduce. 2. `AuthenticationIT.testGroupPermission:179->AbstractZeppelinIT.pollingWait

[GitHub] zeppelin issue #1330: [ZEPPELIN-1144]Zeppelin home page should only list not...

2016-09-17 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1330 I'm sorry for no-reply long time. my plate was full. I will finish other 2 PRs and then If ZEPPELIN-1437 and ZEPPELIN-1438 are status is unresolved, I will try to resolve

[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...

2016-08-22 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1350 @felixcheung Okay! I will add unit test. Thanks for your comment! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #1350: [ZEPPELIN-1351]Paragraph status should be ERROR...

2016-08-20 Thread mwkang
GitHub user mwkang opened a pull request: https://github.com/apache/zeppelin/pull/1350 [ZEPPELIN-1351]Paragraph status should be ERROR if Paragraph is terminated with SIGTERM ### What is this PR for? When Paragraph received a SIGTERM. ExitValue: 143, Status of the paragraph

[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...

2016-08-20 Thread mwkang
GitHub user mwkang reopened a pull request: https://github.com/apache/zeppelin/pull/1290 [ZEPPELIN-708]shift positions automatically to the next cell ### What is this PR for? * Add and modify shortcut function * Shift + Enter: Run paragraph, move focus to next * Ctrl

[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...

2016-08-20 Thread mwkang
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1290: [WIP][ZEPPELIN-708]shift positions autom...

2016-08-20 Thread mwkang
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1290: [WIP][ZEPPELIN-708]shift positions automaticall...

2016-08-20 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 CI Fail msg is `[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.25:npm (npm install) on project zeppelin-web: Failed to run task: 'npm install --color=false' failed

[GitHub] zeppelin pull request #1290: [WIP][ZEPPELIN-708]shift positions autom...

2016-08-20 Thread mwkang
GitHub user mwkang reopened a pull request: https://github.com/apache/zeppelin/pull/1290 [WIP][ZEPPELIN-708]shift positions automatically to the next cell ### What is this PR for? * Add and modify shortcut function * Shift + Enter: Run paragraph, move focus to next

[GitHub] zeppelin issue #1330: [ZEPPELIN-1144]Zeppelin home page should only list not...

2016-08-20 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1330 @bzz https://github.com/apache/zeppelin/pull/1330#issuecomment-239997747 It did not reproduce in local. Can you check this? --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-08-20 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 ping @bzz --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1330: [ZEPPELIN-1144]Zeppelin home page should only list not...

2016-08-16 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1330 @bzz I will check it. Thanks for review. When I fix CI, I'll mention you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1330: [ZEPPELIN-1144]Zeppelin home page should only list not...

2016-08-15 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1330 CI error ``` Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 76.102 sec - in org.apache.zeppelin.integration.SparkParagraphIT Results : Tests in error

[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...

2016-08-12 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 I remove `angular.element('#' + focusedParagraph + '_paragraphColumn_main').scope().goToLineEnd()`, When paragraph runs. Because each ace editor keeps cursor position. So.. user enter

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-08-12 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz I think This PR have some trouble merging to master. Because When bzz leave comment, I also leave comment immediately. So bot did not recognize this PR. Could you mind if you check

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-08-11 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz Thanks for your review. I rebase on to master and force push. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...

2016-08-10 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 I am not sure. But I think it is persist error. ``` Failed tests: ParallelSchedulerTest.testRun:63 expected: but was: ``` Anyway.. @Leemoonsoo I change code that it does

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-08-10 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz No, It does not persists every time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-08-09 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 > If you re-trigger CI more (close this PR) - does the same issue persists every time? I'm not sure if it persists. I will re-tigger after fix the issue. --- If your project is set

[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...

2016-08-08 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 I am not sure it is related with this PR. When I run it, it passed. ``` Failed tests: ParallelSchedulerTest.testRun:63 expected: but was: ``` --- If your project is set up

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-08-08 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 I am not sure this error is related with this issue. ``` Failed tests: ZeppelinSparkClusterTest.zRunTest:204 expected: but was: ``` --- If your project is set up for it, you can

[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...

2016-08-08 Thread mwkang
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-08-08 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 re-trigger CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...

2016-08-08 Thread mwkang
GitHub user mwkang reopened a pull request: https://github.com/apache/zeppelin/pull/1290 [ZEPPELIN-708]shift positions automatically to the next cell ### What is this PR for? Add and modify shortcut function * Shift + Enter: Run paragraph, move focus to next * Ctrl

[GitHub] zeppelin pull request #1248: [ZEPPELIN-1069]Ignore implicit interpreter when...

2016-08-08 Thread mwkang
GitHub user mwkang reopened a pull request: https://github.com/apache/zeppelin/pull/1248 [ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name ### What is this PR for? Ignore implicit interpreter when user enter wrong interpreter name linked

[GitHub] zeppelin pull request #1248: [ZEPPELIN-1069]Ignore implicit interpreter when...

2016-08-08 Thread mwkang
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...

2016-08-08 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 I handle that unnecessary persisted in note.json. I find some problem. While new paragraph is added in runParagraph, focus is not end of line. It ignore space character

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-08-08 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @jongyoul Sorry, I missed it. I will check. I appreciate your review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...

2016-08-05 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 Could you mind if I am going to resolve that consider running paragraph is successful on new issue? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...

2016-08-05 Thread mwkang
GitHub user mwkang opened a pull request: https://github.com/apache/zeppelin/pull/1290 [ZEPPELIN-708]shift positions automatically to the next cell ### What is this PR for? Add and modify shortcut function * Shift + Enter: Run paragraph, move focus to next * Ctrl + Enter

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-08-02 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 I refactor method name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-08-01 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @jongyoul Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1248: [ZEPPELIN-1069]Ignore implicit interpreter when...

2016-07-29 Thread mwkang
GitHub user mwkang opened a pull request: https://github.com/apache/zeppelin/pull/1248 [ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name ### What is this PR for? Ignore implicit interpreter when user enter wrong interpreter name linked

[GitHub] zeppelin issue #1113: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-07-29 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1113 @AhyoungRyu Thanks for your advice. Next time, I will try to do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1113: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-07-07 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1113 This PR is temporarily closed, While I refactor my codes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1113: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-07-02 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1113 @jongyoul Sure, I will do that. I have a question. Is it okay that wrong interpreter is ignored in [here](https://github.com/apache/zeppelin/pull/1113/files#diff

[GitHub] zeppelin pull request #1113: [ZEPPELIN-1069]Ignore implicit interpreter when...

2016-07-02 Thread mwkang
GitHub user mwkang opened a pull request: https://github.com/apache/zeppelin/pull/1113 [ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name ### What is this PR for? Ignore implicit interpreter when user enter wrong interpreter name linked

[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...

2016-06-20 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 Wow thanks for your patience. This PR is a long period and lots of comments. I'll keep on trying my best. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...

2016-06-20 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 - [ ] https://travis-ci.org/apache/zeppelin/jobs/138874097 `ZeppelinSparkClusterTest.sparkRTest:90` - [ ] https://travis-ci.org/apache/zeppelin/jobs/138874103 ``` Tests run: 3

[GitHub] zeppelin pull request #806: [ZEPPELIN-707]Automatically adds %.* of previous...

2016-06-20 Thread mwkang
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/806 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...

2016-06-20 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 I reopened this PR. But I think I have to fix some test case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...

2016-06-19 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 @jongyoul If user enter wrong name, I ignore that name. Is it okay? Or do I try to figure similar name out ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...

2016-06-16 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 I am not sure that this test case is you expected --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...

2016-06-10 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 Okay. I am going to fix it. I show real interpreter name instead of '%..' @jongyoul I think about single responsibility. But if you have thought it is redundant, I will change code

[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...

2016-06-09 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 @corneadoug I fix whole issue. Can you check my code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin issue #904: [ZEPPELIN-835]Don't persist authentication in...

2016-06-09 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/incubator-zeppelin/pull/904 Oh.. I closed JIRA issue. I am so sorry that I act at my discretion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin issue #904: [ZEPPELIN-835]Don't persist authentication in...

2016-06-09 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/incubator-zeppelin/pull/904 Related PR: https://github.com/apache/incubator-zeppelin/pull/860 Related Issue: https://issues.apache.org/jira/browse/ZEPPELIN-828 --- If your project is set up for it, you can reply

[GitHub] incubator-zeppelin pull request #904: [ZEPPELIN-835]Don't persist authentica...

2016-06-09 Thread mwkang
Github user mwkang closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/904 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-zeppelin issue #904: [ZEPPELIN-835]Don't persist authentication in...

2016-06-09 Thread mwkang
Github user mwkang commented on the issue: https://github.com/apache/incubator-zeppelin/pull/904 While I rebase this PR, I found this issue was been resolved [AuthenticationInfo in master]. So I closed PR. [AuthenticationInfo in master]: https://github.com/apache

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-707]Automatically adds ...

2016-05-30 Thread mwkang
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-222479738 - [ ] When you create a new notebook, the interpreter is listed as: %... Any way to get the default interpreter from back-end and insert it instead

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-24 Thread mwkang
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221245539 I made 2 issue for failing CI. [ZEPPELIN-876](https://issues.apache.org/jira/browse/ZEPPELIN-876), [ZEPPELIN-877](https://issues.apache.org/jira/browse

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-23 Thread mwkang
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221146929 @Leemoonsoo Part of Ci are failed. Because.. [ERROR] Failed to execute goal on project zeppelin-zrinterpreter: Could not resolve dependencies

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-23 Thread mwkang
GitHub user mwkang reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/904 [ZEPPELIN-835]Don't persist authentication info into note.json ### What is this PR for? Don't persist authentication info into note.json ### What type of PR is it? Bug

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-23 Thread mwkang
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221143687 Of course. I close the PR and re-open to re-trigger the ci. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-23 Thread mwkang
Github user mwkang closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/904 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so