[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2016-08-17 Thread mwpenny
Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
@corneadoug When I test it without the CSS, the tiles still load but 
they're not positioned properly (they extend outside of the paragraph).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2016-08-17 Thread mwpenny
Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
@karup1990 This is very strange. I cannot reproduce the issue using the 
same browser version and your network doesn't seem to be the problem since it 
is working for you in Safari.

The only other thing I can think of is a browser setting or extension 
interfering somehow. Try running Chrome with the `--disable-extensions` 
argument. If that doesn't work, try creating a new Chrome user profile and 
using that temporarily.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2016-08-17 Thread mwpenny
Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
@karup1990 Can you send a screenshot of the map? If you look at the network 
requests in your browser's developer tools, are the requests to the ArcGIS 
servers successful (i.e., retrieval of the map JavaScript and CSS)? Here's a 
screenshot of what happens when I load the map (I'm using Firefox):

![resload](https://cloud.githubusercontent.com/assets/9356790/17742603/afcf633a-646e-11e6-9162-fa1aa399d904.png)

Also check to make sure the map tile requests are succeeding. Screenshot 
from my browser:

![tileload](https://cloud.githubusercontent.com/assets/9356790/17742634/d480a37e-646e-11e6-9f08-6076652458ca.png)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2016-08-12 Thread mwpenny
Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
@corneadoug The CSS and JavaScript come from the same server. The CSS is 
timing out for you but not the JS? Or is the CSS just loading late?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2016-08-11 Thread mwpenny
Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
@corneadoug I'm all to familiar with that magic when trying to reproduce 
bugs ;)

I've made the changes.

* __Small popup:__ The side and bottom margins of the popup are present due 
to yesterday's changes (differentiating the white of the popup from the white 
of the paragraph) and the extra-large top margin is from Esri's CSS. After 
decreasing the top margin the popup is still very cluttered but a bit more 
usable.

![zeppelin13](https://cloud.githubusercontent.com/assets/9356790/17601232/0d439994-5fd5-11e6-89fa-bd8fbb64d960.png)
Even with some extra CSS styling, I just don't think there's enough space 
to display the popup nicely in a paragraph that small. Other graph modes have a 
similar problem which users are likely already accustomed to:

![zeppelin14](https://cloud.githubusercontent.com/assets/9356790/17601551/b36a6ff4-5fd6-11e6-99af-858f4eb72347.png)



* __Internet error message:__ I went with a look similar to the other graph 
modes:

![zeppelin12](https://cloud.githubusercontent.com/assets/9356790/17600368/2353e076-5fd1-11e6-8d29-20ca4001c169.png)

* __Lazy loading:__ Similar to the way esriLoader loads the map JavaScript, 
the CSS is now lazy loaded the first time it is needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2016-08-10 Thread mwpenny
Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
@corneadoug Good to hear!

The padding makes bottom-docked popups look a lot more clean.

![zeppelin10](https://cloud.githubusercontent.com/assets/9356790/17554453/dd5f6f48-5ed8-11e6-80b8-fb36e5baf8d5.png)

Good catch on the hidden popup header (before/after).

![zeppelin11](https://cloud.githubusercontent.com/assets/9356790/17555993/b043fee6-5edf-11e6-9edf-82cfb400b455.png)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2016-08-03 Thread mwpenny
Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
I have made the changes/fixes you mentioned and rebased with master. I can 
create the PR for the documentation after this is merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2016-07-29 Thread mwpenny
Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
@corneadoug Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2016-07-22 Thread mwpenny
Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
I've added basemap selection (see screenshot)

![zeppelin09](https://cloud.githubusercontent.com/assets/9356790/17068608/dff2330c-501f-11e6-83cc-fefe2b429211.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2016-07-21 Thread mwpenny
Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
@corneadoug, The Esri angular module is used to download and lazy load the 
JS API and require its various classes. These classes are then used to display 
the dynamically downloaded map tiles and render the different map layers (i.e., 
basemap + pin layer).

The angular module was developed by Esri and released under the Apache 2.0 
license. They state on their website that ["The JavaScript API [downloaded by 
the angular module] is hosted by Esri and is available for free 
use"](https://developers.arcgis.com/javascript/3/jshelp/intro_accessapi.html).

Esri also has a public Apache 2.0-licensed repo of samples 
([Esri/quickstart-map-js](https://github.com/Esri/quickstart-map-js)) which use 
the API.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---