[GitHub] zeppelin pull request #3168: [ZEPPELIN-3753] Fix indent with TAB

2018-08-31 Thread oxygen311 
GitHub user oxygen311 opened a pull request:

https://github.com/apache/zeppelin/pull/3168

[ZEPPELIN-3753] Fix indent with TAB

### What is this PR for?
Now when you select multiline text and press TAB, text replaces with "\t" 
char.
With this PR text just shift right if TAB have been pressed.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
 
[ZEPPELIN-3753](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3753)

### How should this be tested?
* First time? Setup Travis CI as described on 
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed 
behavior
* Outline any manual steps to test the PR here.

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-18011

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3168


commit 941b832d1f104d41743ea572d17851a294fdebe1
Author: oxygen311 
Date:   2018-08-29T14:33:51Z

Fix indent with TAB




---

[GitHub] zeppelin pull request #3057: [ZEPPELIN-3582] Add type data to result of quer...

2018-08-28 Thread oxygen311 
Github user oxygen311 closed the pull request at:

https://github.com/apache/zeppelin/pull/3057


---

[GitHub] zeppelin pull request #3064: [ZEPPELIN-3596] Saving resources from pool to S...

2018-08-28 Thread oxygen311 
Github user oxygen311 closed the pull request at:

https://github.com/apache/zeppelin/pull/3064


---

[GitHub] zeppelin pull request #3117: [ZEPPELIN-3691] Scheduled note continues to wor...

2018-08-21 Thread oxygen311 
Github user oxygen311 closed the pull request at:

https://github.com/apache/zeppelin/pull/3117


---

[GitHub] zeppelin pull request #3117: [ZEPPELIN-3691] Scheduled note continues to wor...

2018-08-21 Thread oxygen311 
GitHub user oxygen311 reopened a pull request:

https://github.com/apache/zeppelin/pull/3117

[ZEPPELIN-3691] Scheduled note continues to work in the trash

### What is this PR for?
Fix bug with scheduled note working in the trash.

How to repeat bug:
1. Make scheduled note with cron;
2. Move it to trash;
3. Restart zeppelin.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-3691](https://issues.apache.org/jira/browse/ZEPPELIN-3691)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17950

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3117


commit b3e7d0c995c4c6cac868c7267e75b598203f3216
Author: oxygen311 
Date:   2018-08-08T14:15:25Z

Check is note in trash in `refreshCron`

commit 27f92e29f0fd3d1de92261f950a1a6ec48b62f19
Author: oxygen311 
Date:   2018-08-16T12:20:42Z

Add test for cron note in trash

commit 074613701fd436224ea276777057cd072a11b4bd
Author: oxygen311 
Date:   2018-08-20T11:12:14Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
DW-17950-cronTrash

# Conflicts:
#   
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java




---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-21 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3117
  
@zjffdu 
Sorry, you are right. Fixed


---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-20 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3117
  
@zjffdu 
Looks like it's some bug with dependencies in master: `[ERROR] SLF4J: Class 
path contains multiple SLF4J bindings.`


---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-20 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3117
  
@zjffdu resolved


---

[GitHub] zeppelin issue #3137: [ZEPPELIN-3709] Add releaseResource parameter to Cron ...

2018-08-17 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3137
  
@jongyoul Yes


---

[GitHub] zeppelin issue #3137: [ZEPPELIN-3709] Add releaseResource parameter to Cron ...

2018-08-17 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3137
  
@jongyoul 
You can find usage in 
[docs](https://zeppelin.apache.org/docs/0.8.0/usage/other_features/cron_scheduler.html#after-execution-stop-the-interpreter).


---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-17 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3117
  
@zjffdu 
[Current Travis 
build](https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/416851939)


---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-16 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3117
  
@zjffdu 
Added


---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-15 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3117
  
@zjffdu 
So, I moved this check to `refreshCron()` method


---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-15 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3117
  
@felixcheung 
I have amended commit for checking is note in trash.


---

[GitHub] zeppelin pull request #3139: [ZEPPELIN-3712] Add `maxConnLifetime` parameter...

2018-08-14 Thread oxygen311 
GitHub user oxygen311 opened a pull request:

https://github.com/apache/zeppelin/pull/3139

[ZEPPELIN-3712] Add `maxConnLifetime` parameter to JDBC Interpreter

### What is this PR for?
This parameter is necessary in that case:
1) Zeppelin open connection and keep it in pool;
2) Database close this connection after some time of inactivity;
3) User get an error and necessity to restart interpreter.
 
The default value of this parameter is `-1` which means the connection has 
an infinite lifetime.

### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-3712](https://issues.apache.org/jira/browse/ZEPPELIN-3712)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17882

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3139


commit ca3734dc775b3850e2c74792b90f6e222f06c1d8
Author: oxygen311 
Date:   2018-08-14T11:39:14Z

Add `maxConnLifetime` property




---

[GitHub] zeppelin pull request #3138: [ZEPPELIN-3710] Add to the SAP documentation li...

2018-08-14 Thread oxygen311 
GitHub user oxygen311 opened a pull request:

https://github.com/apache/zeppelin/pull/3138

[ZEPPELIN-3710] Add to the SAP documentation limit and distinct description

### What is this PR for?
Add to the SAP documentation `limit` and `distinct` keywords description

### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-3710](https://issues.apache.org/jira/browse/ZEPPELIN-3710)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Updated

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3710

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3138


commit 5747bd4ea57215160a5f2527ce946b26114ef182
Author: oxygen311 
Date:   2018-08-14T10:03:50Z

Add SAP Docs




---

[GitHub] zeppelin pull request #3137: [ZEPPELIN-3709] Add releaseResource parameter t...

2018-08-14 Thread oxygen311 
GitHub user oxygen311 opened a pull request:

https://github.com/apache/zeppelin/pull/3137

[ZEPPELIN-3709] Add releaseResource parameter to Cron REST API

### What is this PR for?
Add `releaseResource` parameter to Cron REST API `Post` and `Get` methods.

### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-3709](https://issues.apache.org/jira/browse/ZEPPELIN-3709)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, updated

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17903

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3137


commit dd872f93892de1b2f54626d470385400112453bf
Author: oxygen311 
Date:   2018-08-13T16:36:39Z

Add `releaseResource` param to cron api methods




---

[GitHub] zeppelin issue #3115: [ZEPPELIN-3687] Fix IndexError in python interpreter w...

2018-08-13 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3115
  
@zjffdu @felixcheung 
Travis tests fixed


---

[GitHub] zeppelin pull request #3115: [ZEPPELIN-3687] Fix IndexError in python interp...

2018-08-13 Thread oxygen311 
Github user oxygen311 closed the pull request at:

https://github.com/apache/zeppelin/pull/3115


---

[GitHub] zeppelin pull request #3115: [ZEPPELIN-3687] Fix IndexError in python interp...

2018-08-13 Thread oxygen311 
GitHub user oxygen311 reopened a pull request:

https://github.com/apache/zeppelin/pull/3115

[ZEPPELIN-3687] Fix IndexError in python interpreter with empty input

### What is this PR for?
If input of python or pyspark interpreter is empty (contains only 
comments), it will fail with `IndexError` from `zeppelin_python.py`.

### What type of PR is it?
Bug Fix

### What is the Jira issue?

[ZEPPELIN-3687](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3687)

### Screenshots
## Before:
![screen-shot-2018-08-05-at-23 29 
34](https://user-images.githubusercontent.com/16215034/43775282-d1274caa-9a54-11e8-9c6c-3b882f96cf7e.jpg)
![screen-shot-2018-08-07-at-11 48 
10](https://user-images.githubusercontent.com/16215034/43775285-d385ad2a-9a54-11e8-9a14-aa0080cc5824.jpg)

## After:
![screen-shot-2018-08-07-at-15 11 
452](https://user-images.githubusercontent.com/16215034/43775306-e17acf28-9a54-11e8-8378-9b6a8b1c817c.jpg)
![screen-shot-2018-08-07-at-15 11 
45](https://user-images.githubusercontent.com/16215034/43775313-e51f81c8-9a54-11e8-829f-d2aba1cc9613.jpg)


### Questions:
* Does the licenses files need update? No 
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17854

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3115


commit 5d0fdd296af23f0a6fd34101615f281f184d3a94
Author: oxygen311 
Date:   2018-08-06T13:48:08Z

Fix IndexError in python interpreter

commit ad8d07f5e58b94f1a780ec27cdf0c8d40e936af4
Author: Alexey 
Date:   2018-08-08T10:25:51Z

Add test for empty input

commit 54004b09864d913766bb21db38eb6ca716cdd8f6
Author: oxygen311 
Date:   2018-08-08T10:35:54Z

Fix tests




---

[GitHub] zeppelin pull request #3117: [ZEPPELIN-3691] Scheduled note continues to wor...

2018-08-08 Thread oxygen311 
GitHub user oxygen311 opened a pull request:

https://github.com/apache/zeppelin/pull/3117

[ZEPPELIN-3691] Scheduled note continues to work in the trash

### What is this PR for?
Fix bug with scheduled note working in the trash.

How to repeat bug:
1. Make scheduled note with cron;
2. Move it to trash;
3. Restart zeppelin.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-3691](https://issues.apache.org/jira/browse/ZEPPELIN-3691)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17950

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3117


commit be0525f09d25e6b407ac95305c2cae50ae25fe3e
Author: oxygen311 
Date:   2018-08-08T14:15:25Z

Remove cron config from note in `removeCron`




---

[GitHub] zeppelin issue #3115: [ZEPPELIN-3687] Fix IndexError in python interpreter w...

2018-08-08 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3115
  
@zjffdu Done


---

[GitHub] zeppelin pull request #3115: Fix IndexError in python interpreter with empty...

2018-08-07 Thread oxygen311 
GitHub user oxygen311 opened a pull request:

https://github.com/apache/zeppelin/pull/3115

Fix IndexError in python interpreter with empty input

### What is this PR for?
If input of python or pyspark interpreter is empty (contains only 
comments), it will fail with `IndexError` from `zeppelin_python.py`.

### What type of PR is it?
Bug Fix

### What is the Jira issue?

[ZEPPELIN-3687](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3687?filter=addedrecently)

### Screenshots
## Before:
![screen-shot-2018-08-05-at-23 29 
34](https://user-images.githubusercontent.com/16215034/43775282-d1274caa-9a54-11e8-9c6c-3b882f96cf7e.jpg)
![screen-shot-2018-08-07-at-11 48 
10](https://user-images.githubusercontent.com/16215034/43775285-d385ad2a-9a54-11e8-9a14-aa0080cc5824.jpg)

## After:
![screen-shot-2018-08-07-at-15 11 
452](https://user-images.githubusercontent.com/16215034/43775306-e17acf28-9a54-11e8-8378-9b6a8b1c817c.jpg)
![screen-shot-2018-08-07-at-15 11 
45](https://user-images.githubusercontent.com/16215034/43775313-e51f81c8-9a54-11e8-829f-d2aba1cc9613.jpg)


### Questions:
* Does the licenses files need update? No 
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17854

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3115


commit 5d0fdd296af23f0a6fd34101615f281f184d3a94
Author: oxygen311 
Date:   2018-08-06T13:48:08Z

Fix IndexError in python interpreter




---

[GitHub] zeppelin pull request #3106: [ZEPPELIN-3677] SAP Interpreter improvement

2018-08-01 Thread oxygen311 
GitHub user oxygen311 opened a pull request:

https://github.com/apache/zeppelin/pull/3106

[ZEPPELIN-3677] SAP Interpreter improvement

### What is this PR for?
Improvements:
- An empty result processing, message about no data will be shown;
- Dimension's attributes auto complete and processing;
- Property `universe.queryTimeout` for socket and connection timeouts;
- Interpolation support and property for it;
- `completionSupport` flag fix;
- Support of `distinct` keyword (written after `select`);
- Support of `limit %d` keyword (written in the end of query);
- Add concurrency support, relevant properties are 
`universe.concurrent.use` and `universe.concurrent.maxConnection`;
- `;` is adding to the end of query if it has not it.

### What type of PR is it?
Improvement

### What is the Jira issue?

[ZEPPELIN-3677](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3677?filter=allopenissues)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this need documentation? Updated


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17701

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3106


commit d28b8217ff8f851f8f632023d702a95cf27cb8ec
Author: oxygen311 
Date:   2018-07-30T11:40:47Z

Change flag in interpreter settings

commit 86c97895913effef15cf08022589eb6957f101e5
Author: oxygen311 
Date:   2018-07-31T08:20:22Z

Add attribute info to `UniverseNodeInfo` list

commit 443d0afaf6fbebe58df4168cfe834d7deb748acf
Author: oxygen311 
Date:   2018-07-31T09:09:13Z

Att attributes to auto complete

commit 4c29d104c495005a82c8f60445c363a2dc2f1998
Author: oxygen311 
Date:   2018-07-31T09:31:21Z

Add `universe.connectTimeout` and `universe.socketTimeout` properties

commit f15b9594236ff974723f232c12c8dd250d3b49e0
Author: oxygen311 
Date:   2018-07-31T09:39:45Z

Shows message if result is empty

commit 48bb5ee01ffa0b7988d7e6c9eebd4cca0b80ad4c
Author: oxygen311 
Date:   2018-07-31T09:47:40Z

Add properties to `interpreter-setting.json`

commit 832d38cabba16ad10e4183d966b6e9beec8ba34c
Author: oxygen311 
Date:   2018-07-31T10:02:43Z

One property against two

commit d5edcd44e51908aa4f7bba193fe8ac7322175e62
Author: oxygen311 
Date:   2018-07-31T11:05:25Z

Add Object Interpolation

commit bfc5556820a00a841760cc63b5f34d6e773b2924
Author: oxygen311 
Date:   2018-07-31T11:54:43Z

Add concurrent mode to universe interpreter

commit 7e4e4a5e0c8a16aa42cf67d39773048304391776
Author: oxygen311 
Date:   2018-08-01T10:22:26Z

Add `distinct` and `limit` keywords support

commit 5668ad37603f0e538c27af5d63b92cea563a0c0c
Author: oxygen311 
Date:   2018-08-01T12:12:09Z

Add distinct support if only one object in select block




---

[GitHub] zeppelin pull request #3090: [ZEPPELIN-3645] Add LSP Protocol completion sup...

2018-07-27 Thread oxygen311 
Github user oxygen311 closed the pull request at:

https://github.com/apache/zeppelin/pull/3090


---

[GitHub] zeppelin issue #3090: [ZEPPELIN-3645] Add LSP Protocol completion support

2018-07-27 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3090
  
Solution must be improved to use by real users.


---

[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...

2018-07-26 Thread oxygen311 
GitHub user oxygen311 reopened a pull request:

https://github.com/apache/zeppelin/pull/3093

[ZEPPELIN-3655] Add missing roles information to api/notebook/job/ method

### What is this PR for?
Fix bugs with private access interpreter launched with REST by adding 
missing roles information to `AuthenticationInfo`.

### What type of PR is it?
Bug Fix

### What is the Jira issue?

[ZEPPELIN-3655](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3655)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3655

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3093.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3093


commit 182dadcbd3dd000e8d01fc33fe8f0d152fd3450c
Author: oxygen311 
Date:   2018-07-24T13:40:38Z

Fix roles info

commit 04442840e84329981e5a115679e3511a5e96319c
Author: oxygen311 
Date:   2018-07-26T08:54:08Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-3655

# Conflicts:
#   
zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java

commit 407b1041b53d2f7ccaa814dd049a55ed95b0c354
Author: oxygen311 
Date:   2018-07-26T08:54:28Z

Change

commit aa51ca36814f8ab6e8fba169a95062e4e1916877
Author: oxygen311 
Date:   2018-07-26T11:16:23Z

Add roles info to run paragraph method




---

[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...

2018-07-26 Thread oxygen311 
Github user oxygen311 closed the pull request at:

https://github.com/apache/zeppelin/pull/3093


---

[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...

2018-07-26 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3093
  
@zjffdu 
Also this bug may occur in run paragraph methods, it's also fixed now.
Other methods don't miss role info because they don't need to pass it 
farther. And `checkIfUserCanWrite` and `checkIfUserCanWrite` which is used in 
most rest api calls are take into roles information.


---

[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...

2018-07-26 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3093
  
@zjffdu done


---

[GitHub] zeppelin issue #3090: [ZEPPELIN-3645] Add LSP Protocol completion support

2018-07-25 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3090
  
1. LSP is usable and powerful solution:
- LSP can understand imports in the start of paragraph;
- We can use already made solution for every language and don't write new 
one;
- LSP server contains much more information than we process now. 
E.g. it's able to show documentation of a method, reformat code, find 
references etc.

2-3. Now every paragraph is isolated, so `a` will not be shown.
It's made because in current implementation we can not keep connection to 
the server (because a lot of JVMs).
But maybe someone has better architecture ideas how to connect zeppelin to 
LSP.



---

[GitHub] zeppelin issue #3090: [ZEPPELIN-3645] Add LSP Protocol completion support

2018-07-25 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3090
  
@zjffdu 
If LSP has no complete for `sc.`, iPython complete will be shown.
LSP does not support sessions, but it can keep connection.


---

[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...

2018-07-25 Thread oxygen311 
Github user oxygen311 closed the pull request at:

https://github.com/apache/zeppelin/pull/3093


---

[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...

2018-07-25 Thread oxygen311 
GitHub user oxygen311 reopened a pull request:

https://github.com/apache/zeppelin/pull/3093

[ZEPPELIN-3655] Add missing roles information to api/notebook/job/ method

### What is this PR for?
Fix bugs with private access interpreter launched with REST by adding 
missing roles information to `AuthenticationInfo`.

### What type of PR is it?
Bug Fix

### What is the Jira issue?

[ZEPPELIN-3655](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3655)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3655

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3093.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3093


commit 182dadcbd3dd000e8d01fc33fe8f0d152fd3450c
Author: oxygen311 
Date:   2018-07-24T13:40:38Z

Fix roles info




---

[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...

2018-07-24 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3093
  
It's don't easy to check this bug with a unit test. Even in Paragraph is 
not running because of  "user has no permission for interpreter" response in 
rest api would be "OK"


---

[GitHub] zeppelin issue #3090: [Zeppelin-3645] Add LSP Protocol completion support

2018-07-24 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3090
  
@felixcheung 
I have added property `zeppelin.python.useLsp` which is disabled by 
default. It does not seem unsecured for me now. We also can specify host and 
port by ourselves with `zeppelin.python.lspHost` and `zeppelin.python.lspPort` 
properties.


---

[GitHub] zeppelin issue #3090: [Zeppelin-3645] Add LSP Protocol completion support

2018-07-24 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3090
  
@zjffdu 
Sorry, correct line is `pip install python-language-server`, i will fix it.


---

[GitHub] zeppelin issue #3090: [Zeppelin-3645] Add LSP Protocol completion support

2018-07-23 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3090
  
Now this feature is enabled only in python interpreter. So you can specify 
`zeppelin.python.lspHost` and `zeppelin.python.lspPort` properties and use it.
Server is a separate process. I have been using 
[python-language-server](https://github.com/palantir/python-language-server). 
But there are much more [server 
implementations](https://microsoft.github.io/language-server-protocol/implementors/servers/)
 that can be used with any language.


---

[GitHub] zeppelin pull request #3090: [Zeppelin-3645] Add LSP Protocol completion sup...

2018-07-23 Thread oxygen311 
GitHub user oxygen311 opened a pull request:

https://github.com/apache/zeppelin/pull/3090

[Zeppelin-3645] Add LSP Protocol completion support

### What is this PR for?
Add support of request autocomplete with LSP Protocol through TCP.

### What type of PR is it?
Feature

### What is the Jira issue?

[ZEPPELIN-3645](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3645?filter=allopenissues)

### Demo
![peek 2018-07-23 
14-40](https://user-images.githubusercontent.com/16215034/43074811-3a8b3a00-8e87-11e8-8333-c2d678e61557.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3645

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3090.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3090


commit 299fc9a68509395903c2e7dd37a1b011909b1e15
Author: oxygen311 
Date:   2018-07-20T16:07:10Z

Add basic support of LSP Protocol

commit f0066adb379afaf4ee442f4c4e6bef9ae7ec9473
Author: oxygen311 
Date:   2018-07-23T09:20:43Z

Fix variable name




---

[GitHub] zeppelin issue #3049: [ZEPPELIN-3580] Adds rename note method to rest api

2018-07-19 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3049
  
@jongyoul Done


---

[GitHub] zeppelin issue #3064: [ZEPPELIN-3596] Saving resources from pool to SQL

2018-07-17 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3064
  
Scenario: get a list of client IDs from one source (flat file, base, SAP), 
send the list to the database and perform complex analytics with it.
The data in the database is large and there is no way to pull everything 
into Python to run the analytics inside the Python.


---

[GitHub] zeppelin pull request #3057: [ZEPPELIN-3582] Add type data to result of quer...

2018-07-17 Thread oxygen311 
GitHub user oxygen311 reopened a pull request:

https://github.com/apache/zeppelin/pull/3057

[ZEPPELIN-3582] Add type data to result of query from SQL

### What is this PR for?
JDBCInterpreter knows type information for every SQL Query. We could save 
this info to pool and use it.
There are three types of table column:
- Number;
- String;
- Date.

### What type of PR is it?
Improvement

### What is the Jira issue?
[Zeppelin 
3582](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3582)

### Screenshots
![screenshot from 2018-07-06 
18-20-29](https://user-images.githubusercontent.com/16215034/42387208-51009482-814a-11e8-9bc9-bff8b2664f39.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3582

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3057.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3057


commit 5cd8d6d2b1bb2ea795824b0706b3b9bb4af1868f
Author: oxygen311 
Date:   2018-07-05T08:11:48Z

Extend InterpreterResultMessage for holds it's results type information

commit 86c76a9b76ffabb3874c365929fb1df88c92de4b
Author: oxygen311 
Date:   2018-07-05T09:18:12Z

Added the ability for JDBCInterpreter to export types of it's data

commit 235b27a3360060ea44485c6135b53dad459dc6a0
Author: oxygen311 
Date:   2018-07-05T09:45:53Z

Fix %table issue for passing tests (%table don't actually exists in result 
msg string and must be dropped)

commit 50141d2f2af20bea8d33ee6b5b6eec7996a394ae
Author: oxygen311 
Date:   2018-07-05T10:39:02Z

Add tests for column type information

commit 15212e811177b0679157b3a0bca48622911dfef4
Author: oxygen311 
Date:   2018-07-05T11:25:18Z

Add type info information to resource pool

commit 1f055f35740d83325ed788698881aed010458caf
Author: oxygen311 
Date:   2018-07-06T10:12:51Z

Add class for message column type information.

commit def58011c9b76425244b0b6251c694902d82ac7c
Author: oxygen311 
Date:   2018-07-06T11:33:47Z

Add new class JDBCUtils with JDBCInterpreter's static methods

commit 018c3319ec5c6c60afe14dfb3d92a44689aa9af0
Author: oxygen311 
Date:   2018-07-06T12:12:31Z

Fix tests

commit b1511214d638630b71ce7dc816c13a534b8e27c5
Author: oxygen311 
Date:   2018-07-09T08:47:43Z

Add new class JDBCUtils with JDBCInterpreter's static methods

commit fe75ae677e0f63e51d2340fcacb3f40d17371bf1
Author: oxygen311 
Date:   2018-07-09T08:47:43Z

Fix `InterpreterResultMessage` constructor

commit 36632cb0af29e08a44804c5187109a8c35f5a776
Author: oxygen311 
Date:   2018-07-09T08:54:12Z

Merge remote-tracking branch 'tinkoff/ZEPPELIN-3582' into ZEPPELIN-3582

commit 12f86927ff2e38da76b3533db0f0ac24d17cfede
Author: oxygen311 
Date:   2018-07-09T09:07:20Z

Store only `List` in `InterpreterResultMessage`

commit 4b1abd1e51915d4e1b2aa9ad135396e7201df751
Author: oxygen311 
Date:   2018-07-13T10:12:21Z

Add finally block in tests

commit 14a546be4c9edfd4cc8604a4d1197bd8c03107c7
Author: oxygen311 
Date:   2018-07-13T12:47:25Z

Fix line length




---

[GitHub] zeppelin pull request #3057: [ZEPPELIN-3582] Add type data to result of quer...

2018-07-17 Thread oxygen311 
Github user oxygen311 closed the pull request at:

https://github.com/apache/zeppelin/pull/3057


---

[GitHub] zeppelin issue #3064: [ZEPPELIN-3596] Saving resources from pool to SQL

2018-07-17 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3064
  
@zjffdu 
The user can transfer data not only from one database to another, but from 
flat files and interpreters, which are not available in the python (e.g. SAP).
Sending data through `ResourcePool` is not as effective as native methods, 
but can cover up to 80% of user needs.



---

[GitHub] zeppelin pull request #3064: [ZEPPELIN-3596] Saving resources from pool to S...

2018-07-12 Thread oxygen311 
GitHub user oxygen311 reopened a pull request:

https://github.com/apache/zeppelin/pull/3064

[ZEPPELIN-3596] Saving resources from pool to SQL

### What is this PR for?
> It's information in resourcePool, but it is only available for viewing. 
It would be nice if we can save this data to SQL via JDBC Driver.

Now you can access to `ResourcePool` data from SQL query. For example, if 
you write `SELECT * FROM 
{ResourcePool.note_id=SOME_NOTE_ID.paragraph_id=SOME_PARAGRAPH_ID};` and it 
will be correct SQL query.
How it works:
1. Creates and fills a table named like a `PARAGRAPH_ID`;
2. Expression `{*}` replaces with actual table name;
3. Updated SQL query is running.

Also, you can not specify the note_id, then the note_id of the current 
notebook will be used. For example, `SELECT * FROM 
{ResourcePool.paragraph_id=SOME_PARAGRAPH_ID};`.

### What type of PR is it?
Improvement

### What is the Jira issue?
[Zeppelin 
3596](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3596?filter=allopenissues)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3596

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3064.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3064


commit 6033d8fddb4b7f21f268a79143baa5903bf6c759
Author: oxygen311 
Date:   2018-07-10T10:18:37Z

Add `preparePoolData` function

commit 882a4ee9aa128d2d06d85841a4ea50e4d01f4aaa
Author: oxygen311 
Date:   2018-07-10T16:06:45Z

Code refactoring

commit af8747b6c19e7ab94e23352ab8162d72c9a19fe0
Author: oxygen311 
Date:   2018-07-11T09:41:28Z

Refactoring

commit 1a32689b101d5974f5e31d1d883befe9d0142eec
Author: oxygen311 
Date:   2018-07-11T11:41:03Z

Add tests

commit d5e57ad5cc5e19b77aded00efcc2a567283f1b1b
Author: oxygen311 
Date:   2018-07-11T11:55:47Z

Remove assignment operation from cycle




---

[GitHub] zeppelin pull request #3064: [ZEPPELIN-3596] Saving resources from pool to S...

2018-07-12 Thread oxygen311 
Github user oxygen311 closed the pull request at:

https://github.com/apache/zeppelin/pull/3064


---

[GitHub] zeppelin pull request #3057: [ZEPPELIN 3582] Add type data to result of quer...

2018-07-12 Thread oxygen311 
Github user oxygen311 closed the pull request at:

https://github.com/apache/zeppelin/pull/3057


---

[GitHub] zeppelin pull request #3057: [ZEPPELIN 3582] Add type data to result of quer...

2018-07-12 Thread oxygen311 
GitHub user oxygen311 reopened a pull request:

https://github.com/apache/zeppelin/pull/3057

[ZEPPELIN 3582] Add type data to result of query from SQL

### What is this PR for?
JDBCInterpreter knows type information for every SQL Query. We could save 
this info to pool and use it.
There are three types of table column:
- Number;
- String;
- Date.

### What type of PR is it?
Improvement

### What is the Jira issue?
[Zeppelin 
3582](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3582)

### Screenshots
![screenshot from 2018-07-06 
18-20-29](https://user-images.githubusercontent.com/16215034/42387208-51009482-814a-11e8-9bc9-bff8b2664f39.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3582

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3057.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3057


commit 5cd8d6d2b1bb2ea795824b0706b3b9bb4af1868f
Author: oxygen311 
Date:   2018-07-05T08:11:48Z

Extend InterpreterResultMessage for holds it's results type information

commit 86c76a9b76ffabb3874c365929fb1df88c92de4b
Author: oxygen311 
Date:   2018-07-05T09:18:12Z

Added the ability for JDBCInterpreter to export types of it's data

commit 235b27a3360060ea44485c6135b53dad459dc6a0
Author: oxygen311 
Date:   2018-07-05T09:45:53Z

Fix %table issue for passing tests (%table don't actually exists in result 
msg string and must be dropped)

commit 50141d2f2af20bea8d33ee6b5b6eec7996a394ae
Author: oxygen311 
Date:   2018-07-05T10:39:02Z

Add tests for column type information

commit 15212e811177b0679157b3a0bca48622911dfef4
Author: oxygen311 
Date:   2018-07-05T11:25:18Z

Add type info information to resource pool

commit 1f055f35740d83325ed788698881aed010458caf
Author: oxygen311 
Date:   2018-07-06T10:12:51Z

Add class for message column type information.

commit def58011c9b76425244b0b6251c694902d82ac7c
Author: oxygen311 
Date:   2018-07-06T11:33:47Z

Add new class JDBCUtils with JDBCInterpreter's static methods

commit 018c3319ec5c6c60afe14dfb3d92a44689aa9af0
Author: oxygen311 
Date:   2018-07-06T12:12:31Z

Fix tests

commit b1511214d638630b71ce7dc816c13a534b8e27c5
Author: oxygen311 
Date:   2018-07-09T08:47:43Z

Add new class JDBCUtils with JDBCInterpreter's static methods

commit fe75ae677e0f63e51d2340fcacb3f40d17371bf1
Author: oxygen311 
Date:   2018-07-09T08:47:43Z

Fix `InterpreterResultMessage` constructor

commit 36632cb0af29e08a44804c5187109a8c35f5a776
Author: oxygen311 
Date:   2018-07-09T08:54:12Z

Merge remote-tracking branch 'tinkoff/ZEPPELIN-3582' into ZEPPELIN-3582

commit 12f86927ff2e38da76b3533db0f0ac24d17cfede
Author: oxygen311 
Date:   2018-07-09T09:07:20Z

Store only `List` in `InterpreterResultMessage`




---

[GitHub] zeppelin issue #3064: [ZEPPELIN-3596] Saving resources from pool to SQL

2018-07-12 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3064
  
@zjffdu variable interpolation is about just using text variable. But with 
this feature you can transform `%table` text from ResourcePool to SQL table.


---

[GitHub] zeppelin pull request #3064: [ZEPPELIN-3596] Saving resources from pool to S...

2018-07-11 Thread oxygen311 
GitHub user oxygen311 opened a pull request:

https://github.com/apache/zeppelin/pull/3064

[ZEPPELIN-3596] Saving resources from pool to SQL

### What is this PR for?
> It's information in resourcePool, but it is only available for viewing. 
It would be nice if we can save this data to SQL via JDBC Driver.
Now you can access to `ResourcePool` data from SQL query. For example, if 
you write `SELECT * FROM 
{ResourcePool.note_id=SOME_NOTE_ID.paragraph_id=SOME_PARAGRAPH_ID};` and it 
will be correct SQL query.
How it works:
1. Creates and fills a table named like a `PARAGRAPH_ID`;
2. Expression `{*}` replaces with actual table name;
3. Updated SQL query is running.
Also, you can not specify the note_id, then the note_id of the current 
notebook will be used. For example, `SELECT * FROM 
{ResourcePool.paragraph_id=SOME_PARAGRAPH_ID};`.

### What type of PR is it?
Improvement

### What is the Jira issue?
[Zeppelin 
3596](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3596?filter=allopenissues)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3596

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3064.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3064


commit 6033d8fddb4b7f21f268a79143baa5903bf6c759
Author: oxygen311 
Date:   2018-07-10T10:18:37Z

Add `preparePoolData` function

commit 882a4ee9aa128d2d06d85841a4ea50e4d01f4aaa
Author: oxygen311 
Date:   2018-07-10T16:06:45Z

Code refactoring

commit af8747b6c19e7ab94e23352ab8162d72c9a19fe0
Author: oxygen311 
Date:   2018-07-11T09:41:28Z

Refactoring

commit 1a32689b101d5974f5e31d1d883befe9d0142eec
Author: oxygen311 
Date:   2018-07-11T11:41:03Z

Add tests

commit d5e57ad5cc5e19b77aded00efcc2a567283f1b1b
Author: oxygen311 
Date:   2018-07-11T11:55:47Z

Remove assignment operation from cycle




---

[GitHub] zeppelin issue #3057: [ZEPPELIN 3582] Add type data to result of query from ...

2018-07-11 Thread oxygen311 
Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3057
  
@zjffdu we plan to do it in next pool requests.


---

[GitHub] zeppelin pull request #3049: [ZEPPELIN-3580]

2018-07-03 Thread oxygen311 
GitHub user oxygen311 opened a pull request:

https://github.com/apache/zeppelin/pull/3049

[ZEPPELIN-3580]

### What is this PR for?
Adds rename note method to rest api

### What type of PR is it?
Improvement

### What is the Jira issue?
issue on Jira: https://issues.apache.org/jira/browse/ZEPPELIN-3580

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3585

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3049


commit ad880ed31d6158a5cdcecfff7759d3a03c644bb0
Author: oxygen311 
Date:   2018-07-02T16:31:09Z

Add rename method to rest api

commit 4df7c6dbaee5c3702f8da6d21cd981a5a17c557d
Author: oxygen311 
Date:   2018-07-03T12:07:23Z

Add rename method to rest api




---