Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3250
Will merge this to master if no more discussion.
---
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/3152
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3116
Tested on local.
LGTM
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3113
Will merge this, if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3113
Apart from minor comment, rest LGTM
---
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/3187
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3189
Also, since we are doing this; should there be a command line utility as
well? which on run from command-line can convert from old to new format.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3187
Thanks for the review will merge this soon.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3187
@oxygen311, @zjffdu can you help review this.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3187
[HOTFIX] Fix CI on branch-0.8
### What is this PR for?
The build is broken in branch-0.8 after the merge of
https://github.com/apache/zeppelin/pull/3117 (ZEPPELIN-3691
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3182
Will merge this soon.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3182
Sure, thanks for the review have added it.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3182
@zjffdu @astroshim can you help review this.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3182
[ZEPPELIN-3761] Aliasing is not working with JDBC interperter
### What is this PR for?
Using aliasing to rename the column name is not really working. For
instance, a SELECT like
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3180
Sure, thanks for the review will merge this soon to both master and
branch-0.8
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3180
Changes consist of two files;
- The larger one being package-lock.json; It stores an exact, versioned
dependency tree rather than using starred versioning like package.json itself
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3180
CI green.
@zjffdu @felixcheung can you help review this.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3180
[ZEPPELIN-3781] Bump up version of npm packages
### What is this PR for?
The goal of this PR is to track bump up version on babel, karma-coverage,
protractor, and webpack-dev-server
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3155
Will merge this to master if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3155
@zjffdu @felixcheung @r-kamath can you help review this.
I've tested this on latest versions of Chrome (Mac), Firefox (Mac), Edge
(Windows 10).
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3155
[ZEPPELIN-3741] Do not clear "Authorization" header if Z-server is running
behind proxy
### What is this PR for?
There can be a case where Zeppelin-Sever is running as
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3152
It takes about 2-3 seconds every time, about same time as in the screen
shot above.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3152
Update:
Option 2 that can be used alternatively over here:
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3152
Possibly because `/api/helium/package` API checks for both local and remote
(by default configure to https://s3.amazonaws.com/helium-package/helium.json)
helium.json.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3152
[ZEPPELIN-3736] Helium page's UI to show loading screen
### What is this PR for?
At times Helium page's API takes time to return the result, the idea of
this JIRA is to show a loading
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3144
Thanks for the review will merge this if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3144
@r-kamath Sure, I've aligned color with Zeppelin's background and header
color and updated the description to reflect the latest screenshot.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3144
@jongyoul Let me try to find/optimize for that (reduce our whole fe size)
as well if I find something will open up a new JIRA for the same.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3144
@zjffdu @r-kamath Can you help review this.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3144
[ZEPPELIN-3723] Pre-Loader for Zeppelin UI
### What is this PR for?
Given the size of vendor.js (2.6MB) alone, and the project has various
other CSS and JS as well.
I think
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3143
Sure, did not notice this, will close this.
---
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/3143
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3143
@zjffdu can you help review this.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3143
[ZEPPELIN-3722] Zeppelin UI shows "configured HomePage is not existed" with
default config
### What is this PR for?
With default `zeppelin-site.xml`
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3114
CI green https://travis-ci.org/prabhjyotsingh/zeppelin/builds/413004537
Will merge this if no more discussion.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3114
Update org.eclipse.jetty version to 9.4.11.v20180605 to avoid CVE issues
### What is this PR for?
Update org.eclipse.jetty version to 9.4.11.v20180605 to avoid CVE issues.
See
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3019
@shahsank3t can you enable CI, looks like Travis builds are not enabled
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3045
Merging this to master and branch-0.8 if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3045
@felixcheung Yes, that is how it is implemented for all the other realms as
well, but then later it gets limited to 5 user result.
And you are right, should we modify all
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3042
Tested on local, works as expected, LGTM.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3037
Thanks for the review will merge this if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3037
@VipinRathor @zjffdu can you help review this.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3037
[ZEPPELIN-3555] Zeppelin auth fails if `activeDirectoryRealm.groupRolesMap`
is not specified.
### What is this PR for?
Zeppelin auth fails if `activeDirectoryRealm.groupRolesMap
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Sure, looks good.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3018
Thanks for the review will merge this if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Tested this PR locally on FF, Safari, Chrome, and Edge25 works well.
The only concern over here is which one should we be removing the "legacy
method" or the one tha
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3018
[ZEPPELIN-3539] Add jceks stored password support for LDAP
### What is this PR for?
This is to add support for storing password in jceks for LDAP (realm
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3011
[HOTFIX][ZEPPELIN-3526] fix when no shiro.ini exists
### What is this PR for?
This is a side effect of ZEPPELIN-3526, occurs when there's no shiro.ini in
the classpath
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3009
Thanks for the review will merge this soon.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3009
@zjffdu @r-kamath please help review this.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3009
[ZEPPELIN-3513] Zeppelin Note Creation Failure is not shown on UI
### What is this PR for?
When creating a note from Zeppelin UI which fails due to permission denied
exception
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3003
Thanks for the review will merge this if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3003
@mebelousov sure I've added a doc.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3004
@zjffdu @VipinRathor can you help review this PR
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3004
[ZEPPELIN-2913] Support for both user and role for AuthorizationFilter
### What is this PR for?
Currently, Zeppelin only supports roles for AuthorizationFilter, but there
can
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3003
Agreed we should definitely do something like zeppelin-plugins for
authentication components as well in Zeppelin-0.9
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3003
@Leemoonsoo @felixcheung @zjffdu can you help review this.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3003
[ZEPPELIN-3526] Zeppelin auth mechanisms (LDAP or password based) should be
mutually exclusive
### What is this PR for?
Problem:
When any external authentication (like LDAP/AD
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2996
LGTM!
Merging this to master and branch-0.8 if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2977
Merging this if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
Will merge this to master (only) if no more discussion.
---
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/2981
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@Tagar @felixcheung not sure if I fully understand maven-shade-plugin is
this
https://github.com/apache/zeppelin/pull/2975/commits/19b21b1624da552ea8168fe07919134e1a7bcb2f
what we
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2981
Thanks for the review will merge this soon if no more discussion.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2981
[ZEPPELIN-3491][Minor] Add apple-touch-icon.png to Zeppelin project
Change-Id: Id4d15c30810402c9a815df1417448783abd93452
### What is this PR for?
This JIRA is to add apple
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2971
Yeah, I know it looks redundant and might be confusing, both have their ups
and downs, we can choose to hide one.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2963
Merging this to master and branch-0.8 if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
Have pushed a commit with regenerating those files with Thrift Version
0.9.3 hope
this(https://github.com/apache/zeppelin/pull/2975/commits/042511df573f5d0dfb81c2970791c7ad9cb2998e#diff
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@Tagar is this because of Zeppelin's thrift@0.9.2 and Spark/Hive's
thrift@0.93?
Should I also regenerate all the thrift files as well?
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2971
@Tagar It shows up on the table (comes as a part of angular-ui-grid)
![screenshot from 2018-05-22
22-35-07](https://user-images.githubusercontent.com/674497/40378232-90870f9e-5e10-11e8
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2976
@Tagar @r-kamath can you help review this.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2976
[ZEPPELIN-3478] Download Data as CSV downloads data as a single line
### What is this PR for?
All data is in one single line - lines separated with backslash and "n"
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@felixcheung yes, it only affects internal uses.
Thanks for the review will merge this if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@zjffdu , @r-kamath , @felixcheung can you help review this.
The variability doesn't apply to this, but this is for future accidental
usage.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2975
ZEPPELIN-3475: Bump up version of Apache Thrift
### What is this PR for?
Bump up version of Apache Thrift
### What type of PR is it?
[Improvement]
### What
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2971
Yes, this affects branch-0.8. I mean prior to ZEPPELIN-3289 there was no
"Table export to excel".
Let me merge this soon so that this also becomes part of the Zeppelin-0.8
release.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2971
[ZEPPELIN-3466] Table export to excel is not working due to missing
dependencies
### What is this PR for?
Table export to excel is not working due to missing dependencies.
angular
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2962
Merging this if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2961
I'll close this for now.
---
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/2961
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2962
Yes, nothing critical, but there have been a lot of fixes in
jackson-databind and some of those are security patches as well. I have tested
manually none those apply to Zeppelin (for now
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2962
[ZEPPELIN-3447] Bump up version of jackson-databind
### What is this PR for?
This is to upgrade the package jackson-databind libary to 2.27
### What type of PR
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2961
[ZEPPELIN-3448] Bump up version of org.scala-lang:scala-library
### What is this PR for?
This is to upgrade the package org.scala-lang:scala-library to 2.11.12
### What type
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2958
Thanks for the review will merge this if no more discussion.
CI failure is not relevant, have retriggered it to see if it changes.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2958
[ZEPPELIN-3442] bump up commons-collections to 3.2.2
### What is this PR for?
This is to upgrade Apache commons-collections to 3.2.2
### What type of PR
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2941
Thanks for the review will merge this if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2941
@r-kamath @zjffdu can you help review this PR.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2941
[ZEPPELIN-3311] Zeppelin should ask user to re-login after JWT cookie
expires (KnoxJwtRealm)
### What is this PR for?
Zeppelin should ask user to re-login after JWT cookie expires
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/zeppelin/commit/f4a798b6230b4f2389ad7ea9b41818b15d9ab5a7#commitcomment-28690929
@bern80 do you mind creating an issue for the same if it is not working?
will try to look into it.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2933
Merging this if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2923
https://travis-ci.org/VipinRathor/zeppelin/builds/369033290 looks flaky,
works well on local.
Merging this to master and branch-0.8 if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2933
@zjffdu @r-kamath Please help review this.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2933
ZEPPELIN-3416: Bump up the version of xercesImpl to 2.11.0.SP5
### What is this PR for?
Update xercesImpl to 2.11.0.SP5 to get some fixes. This is a required
dependency for jdbc
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2932
Merging this to master and branch-0.8 if no more discussion.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2932
[ZEPPELIN-3415] Fix export notebook functionality
### What is this PR for?
Export functionality for both notebook and download data as CSV stopped
working for Chrome
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2927
[HOTFIX] [ZEPPELIN-3384] Checkstyle violation.
### What is this PR for?
With https://github.com/apache/zeppelin/pull/2909 one of the indentation
rule was missed which is causing
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2922
Will merge this to master and branch-0.8 if no more discussion.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2922
@zjffdu Can you help review this.
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2922
[ZEPPELIN-3403] Zeppelin documentation not pointing to correct url
### What is this PR for?
Zeppelin documentation not pointing to correct URL.
Zeppelin documentation
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2909
Will merge this to master and branch-0.8 if no more discussion.
---
1 - 100 of 854 matches
Mail list logo
