[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-08-29 Thread shahsank3t
Github user shahsank3t commented on the issue: https://github.com/apache/zeppelin/pull/3019 @r-kamath - addressed your review comments. Please have a look again. Thanks in advance. ---

[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-08-07 Thread shahsank3t
Github user shahsank3t commented on the issue: https://github.com/apache/zeppelin/pull/3019 @zjffdu Thanks for the review, I wasn't aware of Zeppelin context as another thing. Have addressed your comments and fixed the wording. ---

[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-07-17 Thread shahsank3t
Github user shahsank3t commented on the issue: https://github.com/apache/zeppelin/pull/3019 @prabhjyotsingh Done enabling CI ---

[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-07-11 Thread shahsank3t
Github user shahsank3t commented on the issue: https://github.com/apache/zeppelin/pull/3019 @jongyoul @zjffdu @prabhjyotsingh Updated the code by reusing modal and other available methods. Please review it. ---

[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-07-02 Thread shahsank3t
Github user shahsank3t commented on the issue: https://github.com/apache/zeppelin/pull/3019 @zjffdu @felixcheung Integrated your suggestions. Below screenshot when single job is running: https://user-images.githubusercontent.com/6761317/42155612-7fc14e5c-7e06-11e8

[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-06-26 Thread shahsank3t
Github user shahsank3t commented on the issue: https://github.com/apache/zeppelin/pull/3019 >can we open a pop up with options, like clicking on a url link in google doc? possible options: open, open in new tab @zjffdu Above suggestion makes sense right? User can cl

[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-06-25 Thread shahsank3t
Github user shahsank3t commented on the issue: https://github.com/apache/zeppelin/pull/3019 @zjffdu Apologies missed out the earlier notification. > I didn't try this PR, but I didn't see backend pass spark.ui.allowFramingFrom to frontend, so how does frontend know whet

[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-06-18 Thread shahsank3t
Github user shahsank3t commented on the issue: https://github.com/apache/zeppelin/pull/3019 @prabhjyotsingh @r-kamath - Just a reminder to review this. ---

[GitHub] zeppelin pull request #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Sec...

2018-06-13 Thread shahsank3t
GitHub user shahsank3t opened a pull request: https://github.com/apache/zeppelin/pull/3019 [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mode ### What is this PR for? After running a paragraph via Spark interpreter, we will be showing a "Spark UI" link. On click