[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-06-02 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Hi Kun, Raised this PR for the fix. https://github.com/apache/zeppelin/pull/2392/files Regards, On Thu, Jun 1, 2017 at 9:11 PM, Kun <notificati...@github.com>

[GitHub] zeppelin pull request #2392: [HFix] : Fix JS exception because of Zeppelin-2...

2017-06-02 Thread vipul1409
GitHub user vipul1409 opened a pull request: https://github.com/apache/zeppelin/pull/2392 [HFix] : Fix JS exception because of Zeppelin-2519 ### What is this PR for? Fix JS exception because of Zeppelin-2519. Added the missing dependency for scroll monitor before viewport

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-05-20 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Fixed all the issues and the tests have also passed. Please let me know if any more details are needed. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #2326: [ZEPPELIN-2519] Disable watchers not in viewpor...

2017-05-19 Thread vipul1409
GitHub user vipul1409 reopened a pull request: https://github.com/apache/zeppelin/pull/2326 [ZEPPELIN-2519] Disable watchers not in viewport ### What is this PR for? Currently all the watchers are enabled by default. I came across this github project https://github.com/wix

[GitHub] zeppelin pull request #2326: [ZEPPELIN-2519] Disable watchers not in viewpor...

2017-05-19 Thread vipul1409
Github user vipul1409 closed the pull request at: https://github.com/apache/zeppelin/pull/2326 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-05-16 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Sorry for delayed response. Rerun of failed job passed. I have also addressed all the PR comments. Let me know if anything more is needed. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-05-11 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Even latest master is breaking with exactly same error. I am not able to figure out the issue. Any help or suggestions will be great. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-05-11 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Addressed review comments and moved the dependency to npm. One jenkins job is failing but looks unrelated to my changes. I also see build is marked as failed in master, just double checking

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-05-10 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 I checked Jenkins Job. The sub job failing is https://travis-ci.org/vipul1409/zeppelin/jobs/230634157 It is failing because of some git access issues. Any suggestions on what could be the issue

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-05-09 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Any suggestions on why jenkins job is failing? On checking in jenkins console output I don't see any smaller job failing. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin pull request #2326: [ZEPPELIN-2519] Disable watchers not in viewpor...

2017-05-09 Thread vipul1409
GitHub user vipul1409 opened a pull request: https://github.com/apache/zeppelin/pull/2326 [ZEPPELIN-2519] Disable watchers not in viewport ### What is this PR for? Currently all the watchers are enabled by default. I came across this github project https://github.com/wix

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-08 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2090 @felixcheung My user id is vipul.1...@gmail.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1357: ZEPPELIN-1364: Return only the ran paragraph details f...

2017-03-06 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/1357 Not needed any more. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1357: ZEPPELIN-1364: Return only the ran paragraph de...

2017-03-06 Thread vipul1409
Github user vipul1409 closed the pull request at: https://github.com/apache/zeppelin/pull/1357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-06 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2090 Can this PR be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-05 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2090 There is not SparkRInterpreterTest.java, looks like there are no test for SparkR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-05 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2090 Re ran the failed job and it passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-03 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2090 Thanks for your help @prabhjyotsingh . I can see the build started in travis now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-03 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2090 I have enabled travis for my fork. At this URL https://travis-ci.org/vipul1409/zeppelin/settings "Build pushes" and "Build pull requests" are enabled. is there any othe

[GitHub] zeppelin pull request #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-03 Thread vipul1409
Github user vipul1409 closed the pull request at: https://github.com/apache/zeppelin/pull/2090 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-03 Thread vipul1409
GitHub user vipul1409 reopened a pull request: https://github.com/apache/zeppelin/pull/2090 ZEPPELIN-2199: Fix lapply issue in sparkR ### What is this PR for? Function createRDDFromArray used for creating R RDD expects a JavaSparkContext object instead of spark context. This PR

[GitHub] zeppelin pull request #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-02 Thread vipul1409
GitHub user vipul1409 reopened a pull request: https://github.com/apache/zeppelin/pull/2090 ZEPPELIN-2199: Fix lapply issue in sparkR ### What is this PR for? Function createRDDFromArray used for creating R RDD expects a JavaSparkContext object instead of spark context. This PR

[GitHub] zeppelin pull request #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-02 Thread vipul1409
Github user vipul1409 closed the pull request at: https://github.com/apache/zeppelin/pull/2090 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-02 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2090 Can anyone help me understand the build error it looks unrelated to my change, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin pull request #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-02 Thread vipul1409
GitHub user vipul1409 opened a pull request: https://github.com/apache/zeppelin/pull/2090 ZEPPELIN-2199: Fix lapply issue in sparkR ### What is this PR for? Function createRDDFromArray used for creating R RDD expects a JavaSparkContext object instead of spark context. This PR

[GitHub] zeppelin issue #1357: ZEPPELIN-1364: Return only the ran paragraph details f...

2016-08-26 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/1357 Yes It is ready for review. The reason for CI failure looks unrelated to my changes as the build is failing in npm side and I have not made any JS changes. The build is passing for few

[GitHub] zeppelin pull request #1357: ZEPPELIN-1364: Return only the ran paragraph de...

2016-08-24 Thread vipul1409
GitHub user vipul1409 opened a pull request: https://github.com/apache/zeppelin/pull/1357 ZEPPELIN-1364: Return only the ran paragraph details for indiviual paragraph run. ### What is this PR for? If you run a note book having lots of paragraphs and few images and svgs. Every

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

2016-08-24 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/1283 +1 Looking forward to this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled