[GitHub] fred521 commented on issue #3294: [ZEPPELIN-3978] Change Jetty Server to use QueuedThreadPool and make it configurable

2019-02-01 Thread GitBox
fred521 commented on issue #3294: [ZEPPELIN-3978] Change Jetty Server to use 
QueuedThreadPool and make it configurable
URL: https://github.com/apache/zeppelin/pull/3294#issuecomment-459938186
 
 
   > @fred521 I think ZEPPELIN-3957 solve this issue, Could you do a rebase ? 
And I create another ticket to improve it as well (ZEPPELIN-3983)
   
   Yeah, thanks, finnally, passed all 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] fred521 commented on issue #3294: [ZEPPELIN-3978] Change Jetty Server to use QueuedThreadPool and make it configurable

2019-02-01 Thread GitBox
fred521 commented on issue #3294: [ZEPPELIN-3978] Change Jetty Server to use 
QueuedThreadPool and make it configurable
URL: https://github.com/apache/zeppelin/pull/3294#issuecomment-459879679
 
 
   > can you take a look at the test failures? 
https://travis-ci.org/fred521/zeppelin/builds/486180306
   
   checked it and re-run for a few times, each time actually taking for 30mins 
to 1 hour.
   My code changes shouldn't break any unit test, I guess there are 
configurations not match to the VM box.
   
   And I feel that will stop a lot of contributors, can Apache Zeppelin 
Community improve this?
   
   Otherwise, new contributors will feel wasting time to spend effort here.
   
   cc @Leemoonsoo @zjffdu 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] fred521 commented on issue #3294: [ZEPPELIN-3978] Change Jetty Server to use QueuedThreadPool and make it configurable

2019-02-01 Thread GitBox
fred521 commented on issue #3294: [ZEPPELIN-3978] Change Jetty Server to use 
QueuedThreadPool and make it configurable
URL: https://github.com/apache/zeppelin/pull/3294#issuecomment-459828468
 
 
   > Thanks @fred521 Could you add these configuration into 
`zeppelin-site.xml.template` ?
   
   yep, updated it, thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] fred521 commented on issue #3294: [ZEPPELIN-3978] Change Jetty Server to use QueuedThreadPool and make it configurable

2019-02-01 Thread GitBox
fred521 commented on issue #3294: [ZEPPELIN-3978] Change Jetty Server to use 
QueuedThreadPool and make it configurable
URL: https://github.com/apache/zeppelin/pull/3294#issuecomment-459828388
 
 
   > can you update the PR title? should it say "Change Jetty to use threadpool 
and make it configurable"
   
   Yes, I updated, thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services