[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2750 @felixcheung I revert the changes about spark 2.1.0 -> spark 2.1.2 and spark 2.2.0 -> spark 2.2.1, since this PR is only for supporting spark 2.3, I don't want to other things to block this and 0.8.0 release. Will do the download url change in another PR ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2750 Well, my question on the download link https://github.com/apache/zeppelin/pull/2750#issuecomment-363663111 ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2750 ping @felixcheung ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2750 These download are for spark interpreter integration test. So spark distribution is needed, only spark artifact is not sufficient. ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2750 I don't feel strongly about it, but fetching the url from the download script (.cgi url) is actually fairly simple to do, but I admit may not be what the maven download plugin support. I don't remember exactly what these downloads are for ... can some of these be artifacts on maven central repo? that might be easier. in any case, I'm only worry about push back from the ASF release process of downloading directly from dist.apache.org ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2750 Thanks @felixcheung , These examples seems to fetch the download url dynamically, I don't think maven download plugin support this. If you don't mind, I will leave it as follow up PR to improve. As I want to include this PR in 0.8 which I plan to release soon. ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2750 well... that's not my understand and other implementations are pulling from the download script and then to the referred mirror, eg. https://github.com/apache/spark/blob/master/build/mvn#L81 https://github.com/apache/spark/blob/master/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala#L64 https://github.com/apache/spark/blob/master/R/pkg/R/install.R#L213 https://github.com/apache/spark/blob/master/external/docker/spark-mesos/Dockerfile#L27 https://github.com/graphframes/graphframes/commit/a1427217a2458ae89dde038f0ce79eec7913a7d6 https://github.com/Homebrew/homebrew-core/blob/master/Formula/apache-spark.rb ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2750 @felixcheung IIUC, these are for release download page, for external project, we could use the dist link. ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2750 Ah sorry. Please see http://www.apache.org/dev/release-publishing.html#distribution And specifically http://www.apache.org/dev/release-download-pages.html#links ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2750 Fixed. Now using apache dist url ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2750 Hmm we cant fix to one or two mirrors either, i think they tend to disappear - please see how other projects handles this ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2750 @felixcheung , download url is fixed, please help review again. ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2750 The s3 is no longer being used. We need to move to apache mirrors as per ASF policy.. ---
