subject:"\[GitHub\] zjffdu commented on a change in pull request #3306\: \[ZEPPELIN\-4001\] zeppelin\-interpreter\-integration is ignored due to wrong folder structure"

[GitHub] zjffdu commented on a change in pull request #3306: [ZEPPELIN-4001] zeppelin-interpreter-integration is ignored due to wrong folder structure

2019-02-14 Thread GitBox

zjffdu commented on a change in pull request #3306: [ZEPPELIN-4001] 
zeppelin-interpreter-integration is ignored due to wrong folder structure
URL: https://github.com/apache/zeppelin/pull/3306#discussion_r256830232
 
 

 ##
 File path: 
spark/interpreter/src/main/java/org/apache/zeppelin/spark/SparkVersion.java
 ##
 @@ -86,7 +86,7 @@ public boolean isSpark2() {
   }
 
   public boolean isSecretSocketSupported() {
-return this.newerThanEquals(SPARK_2_3_1);
+return this.newerThanEquals(SPARK_2_3_1) || 
this.equals(SparkVersion.fromVersionString("2.1.2"));
 
 Review comment:
   This is by accident, I have removed it. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zjffdu commented on a change in pull request #3306: [ZEPPELIN-4001] zeppelin-interpreter-integration is ignored due to wrong folder structure

2019-02-14 Thread GitBox

zjffdu commented on a change in pull request #3306: [ZEPPELIN-4001] 
zeppelin-interpreter-integration is ignored due to wrong folder structure
URL: https://github.com/apache/zeppelin/pull/3306#discussion_r256829247
 
 

 ##
 File path: .travis.yml
 ##
 @@ -87,35 +91,43 @@ matrix:
   dist: trusty
   env: PYTHON="3" SPARKR="true" SCALA_VER="2.10" PROFILE="-Pscala-2.10" 
BUILD_FLAG="install -DskipTests -DskipRat" TEST_FLAG="test -DskipRat" 
MODULES="-pl $(echo 
.,zeppelin-interpreter,zeppelin-interpreter-api,${INTERPRETERS} | sed 
's/!//g')" TEST_PROJECTS=""
 
-# Run ZeppelinSparkClusterTest & SparkIntegrationTest in one build would 
exceed the time limitation of travis, so running them separately
+# Run Spark integration test and unit test separately for each spark 
version
 
-# Integration test of spark interpreter with different spark versions 
under python2, only run ZeppelinSparkClusterTest. Also run spark unit test of 
spark 2.4.0 in this build. And run JdbcIntegrationTest here as well.
+# ZeppelinSparkClusterTest24, SparkIntegrationTest24, JdbcIntegrationTest, 
Unit test of Spark 2.4
 - sudo: required
   jdk: "oraclejdk8"
   dist: trusty
-  env: BUILD_PLUGINS="true" PYTHON="2" SCALA_VER="2.11" 
PROFILE="-Pspark-2.4 -Pscala-2.11 -Phadoop2 -Pintegration" SPARKR="true" 
BUILD_FLAG="install -DskipTests -DskipRat -am" TEST_FLAG="test -DskipRat -am" 
MODULES="-pl 
zeppelin-interpreter-integration,jdbc,spark/interpreter,spark/spark-dependencies"
 
TEST_PROJECTS="-Dtest=ZeppelinSparkClusterTest,JdbcIntegrationTest,org.apache.zeppelin.spark.*
 -DfailIfNoTests=false"
+  env: BUILD_PLUGINS="true" PYTHON="2" SCALA_VER="2.11" 
PROFILE="-Pspark-2.4 -Pscala-2.11 -Phadoop2 -Pintegration" SPARKR="true" 
BUILD_FLAG="install -DskipTests -DskipRat -am" TEST_FLAG="test -DskipRat -am" 
MODULES="-pl 
zeppelin-interpreter-integration,jdbc,zeppelin-web,spark/spark-dependencies" 
TEST_PROJECTS="-Dtest=ZeppelinSparkClusterTest24,SparkIntegrationTest24,JdbcIntegrationTest,org.apache.zeppelin.spark.*
 -DfailIfNoTests=false"
 
-# Integration test of spark interpreter with different spark versions 
under python3, only run SparkIntegrationTestPt1. Also run spark unit test of 
spark 2.3 in this build.
+# ZeppelinSparkClusterTest23, SparkIntegrationTest23, Unit test of Spark 
2.3
 - sudo: required
   jdk: "oraclejdk8"
   dist: trusty
-  env: BUILD_PLUGINS="true" PYTHON="3" SCALA_VER="2.11" 
PROFILE="-Pspark-2.3 -Pscala-2.11 -Phadoop2 -Pintegration" SPARKR="true" 
BUILD_FLAG="install -DskipTests -DskipRat -am" TEST_FLAG="test -DskipRat -am" 
MODULES="-pl 
zeppelin-interpreter-integration,spark/interpreter,spark/spark-dependencies" 
TEST_PROJECTS="-Dtest=SparkIntegrationTestPt1,org.apache.zeppelin.spark.* 
-DfailIfNoTests=false"
+  env: BUILD_PLUGINS="true" PYTHON="2" SCALA_VER="2.11" 
PROFILE="-Pspark-2.3 -Pscala-2.11 -Phadoop2 -Pintegration" SPARKR="true" 
BUILD_FLAG="install -DskipTests -DskipRat -am" TEST_FLAG="test -DskipRat -am" 
MODULES="-pl 
zeppelin-interpreter-integration,zeppelin-web,spark/spark-dependencies" 
TEST_PROJECTS="-Dtest=ZeppelinSparkClusterTest23,SparkIntegrationTest23,org.apache.zeppelin.spark.*
 -DfailIfNoTests=false"
 
-# Integration test of spark interpreter with different spark versions 
under python3, only run SparkIntegrationTestPt2. Also run spark unit test of 
spark 2.2 in this build.
+# ZeppelinSparkClusterTest22, SparkIntegrationTest22, Unit test of Spark 
2.2
 - sudo: required
   jdk: "oraclejdk8"
   dist: trusty
-  env: BUILD_PLUGINS="true" PYTHON="3" SCALA_VER="2.10" 
PROFILE="-Pspark-2.2 -Phadoop2 -Pscala-2.10 -Pintegration" SPARKR="true" 
BUILD_FLAG="install -DskipTests -DskipRat -am" TEST_FLAG="test -DskipRat -am" 
MODULES="-pl 
zeppelin-interpreter-integration,spark/interpreter,spark/spark-dependencies" 
TEST_PROJECTS="-Dtest=SparkIntegrationTestPt2,org.apache.zeppelin.spark.* 
-DfailIfNoTests=false"
+  env: BUILD_PLUGINS="true" PYTHON="3" SCALA_VER="2.11" 
PROFILE="-Pspark-2.2 -Pscala-2.11 -Phadoop2 -Pintegration" SPARKR="true" 
BUILD_FLAG="install -DskipTests -DskipRat -am" TEST_FLAG="test -DskipRat -am" 
MODULES="-pl 
zeppelin-interpreter-integration,zeppelin-web,spark/spark-dependencies" 
TEST_PROJECTS="-Dtest=ZeppelinSparkClusterTest22,SparkIntegrationTest22,org.apache.zeppelin.spark.*
 -DfailIfNoTests=false"
 
-# Test spark module for 2.1 with scala 2.10
-- jdk: "oraclejdk8"
+# ZeppelinSparkClusterTest21, SparkIntegrationTest21, Unit test of Spark 
2.1
+- sudo: required
+  jdk: "oraclejdk8"
   dist: trusty
-  env: PYTHON="2" SCALA_VER="2.10" PROFILE="-Pspark-2.1 -Phadoop2 
-Pscala-2.10" SPARKR="true" BUILD_FLAG="install -DskipTests -DskipRat -am" 
TEST_FLAG="test -DskipRat -am" MODULES="-pl 
spark/interpreter,spark/spark-dependencies" 
TEST_PROJECTS="-Dtest=org.apache.zeppelin.spark.*,org.apache.zeppelin.rinterpreter.*,org.apache.spark.api.r.*

[GitHub] zjffdu commented on a change in pull request #3306: [ZEPPELIN-4001] zeppelin-interpreter-integration is ignored due to wrong folder structure

2019-02-14 Thread GitBox

zjffdu commented on a change in pull request #3306: [ZEPPELIN-4001] 
zeppelin-interpreter-integration is ignored due to wrong folder structure
URL: https://github.com/apache/zeppelin/pull/3306#discussion_r256828308
 
 

 ##
 File path: .travis.yml
 ##
 @@ -37,9 +37,13 @@ addons:
 - r-source
 - sourceline: 'deb http://cran.rstudio.com/bin/linux/ubuntu trusty/'
   key_url: 
'keyserver.ubuntu.com/pks/lookup?op=get=0x51716619E084DAB9'
+- r-packages-trusty
+- mysql-5.7-trusty
 packages:
 - r-base
 - r-base-dev
+- mysql-server
+- mysql-client
 
 Review comment:
   This is for `JdbcIntegrationTest`, otherwise this test will fail


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zjffdu commented on a change in pull request #3306: [ZEPPELIN-4001] zeppelin-interpreter-integration is ignored due to wrong folder structure

[GitHub] zjffdu commented on a change in pull request #3306: [ZEPPELIN-4001] zeppelin-interpreter-integration is ignored due to wrong folder structure

[GitHub] zjffdu commented on a change in pull request #3306: [ZEPPELIN-4001] zeppelin-interpreter-integration is ignored due to wrong folder structure

3 matches

Site Navigation

Mail list logo

Footer information