[GitHub] [zeppelin] Tagar commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter
Tagar commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-498924966 @felixcheung `libpty` is distributed under EPL license https://github.com/JetBrains/pty4j#license It falls into "WEAK COPYLEFT" LICENSES according to the link you posted above https://apache.org/legal/resolved.html#weak-copyleft-licenses So it's a `Category B` open-source software https://apache.org/legal/resolved.html#category-b And according to the same ASF link it has to be included in binary and not source code form - ``` Unless otherwise specified, all Category B licensed works should be included in binary-only form in Apache Software Foundation convenience binaries (and not source code). ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] Tagar commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter
Tagar commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492824721 As part of Zeppelin notes we have static %sh paragraphs (non-interactive) with or without variable embeddings (variable interpolations ) like described in https://zeppelin.apache.org/docs/0.8.1/interpreter/shell.html#object-interpolation Would this new implementation keep that possible? (without typing in a command each time) I totally agree it's a very cool feature, but we may need to preserve old good `%sh` interpreter if this new approach takes some of its functionality away. Thoughts? Thank you @liuxunorg This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] Tagar commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter
Tagar commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492314076 Very cool. Perhaps this should be a new interpreter called Terminal? And leave Shell interpreter as is? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services