[GitHub] [zeppelin] epugh commented on issue #3358: [ZEPPELIN-2444] Better error message on shell timeout being reached.

2019-05-10 Thread GitBox
epugh commented on issue #3358: [ZEPPELIN-2444] Better error message on shell 
timeout being reached.
URL: https://github.com/apache/zeppelin/pull/3358#issuecomment-491230906
 
 
   That definitly looks like a powerful feature!  I saw it briefly when I was 
researching this PR….  I wasn’t sure the timeline to put this in!  If this is 
the future, and the future is soon, please do close my PR in favor of this!
   
   
   > On May 10, 2019, at 5:42 AM, Xun Liu  wrote:
   > 
   > @epugh  , I refactored the shell interpreter and 
are preparing to submit the PR, Has made the shell interpreter function exactly 
the same as the terminal。
   > ZEPPELIN-4131 , 
Refactoring zeppelin shell interpreter Design Document 

   >  

   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub 
, or mute 
the thread 
.
   > 
   
   ___
   Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | 
http://www.opensourceconnections.com  | 
My Free/Busy   
   Co-Author: Apache Solr Enterprise Search Server, 3rd Ed 

 
   This e-mail and all contents, including attachments, is considered to be 
Company Confidential unless explicitly stated otherwise, regardless of whether 
attachments are marked as such.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zeppelin] epugh commented on issue #3358: [ZEPPELIN-2444] Better error message on shell timeout being reached.

2019-05-10 Thread GitBox
epugh commented on issue #3358: [ZEPPELIN-2444] Better error message on shell 
timeout being reached.
URL: https://github.com/apache/zeppelin/pull/3358#issuecomment-491224213
 
 
   It may be…  I didn’t realize that it was until months later when I google 
around, and found the issue ZEPPELIN-2444!  
   
   When I got the SIGTERM error, I though it was my shell command (in my case a 
python pip install) had died due to something random, I didn’t think “oh, it 
took too long and hit a time out”….  
   
   > On May 10, 2019, at 2:35 AM, Felix Cheung  wrote:
   > 
   > @felixcheung commented on this pull request.
   > 
   > In shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java 
:
   > 
   > > @@ -132,7 +132,7 @@ public InterpreterResult internalInterpret(String 
cmd,
   >String message = outStream.toString();
   >if (exitValue == 143) {
   >  code = Code.INCOMPLETE;
   > -message += "Paragraph received a SIGTERM\n";
   > +message += "Timeout of " + getProperty(TIMEOUT_PROPERTY) + " ms 
to run reached.\n";
   > hmm, I'm not sure these are the same? SIGTERM is not a timeout?
   > 
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
   > 
   
   ___
   Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | 
http://www.opensourceconnections.com  | 
My Free/Busy   
   Co-Author: Apache Solr Enterprise Search Server, 3rd Ed 

 
   This e-mail and all contents, including attachments, is considered to be 
Company Confidential unless explicitly stated otherwise, regardless of whether 
attachments are marked as such.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services