D01B commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution" URL: https://github.com/apache/zeppelin/pull/3281#discussion_r248267618
########## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java ########## @@ -86,6 +86,7 @@ /********************************** transient fields ******************************************/ private transient boolean loaded = false; + private transient boolean executionAborted = false; Review comment: oh, it's non-volatile object. It doesnt looks like thread safe code. You should use volatile w synchronized or something like java.util.concurrent.atomic.AtomicBoolean. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
