[GitHub] zeppelin issue #1172: [Zeppelin-1161] Revert precise execution time

2016-07-18 Thread bzz
Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1172
  
Looks great to me, and CI is green now!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1172: [Zeppelin-1161] Revert precise execution time

2016-07-18 Thread corneadoug
Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1172
  
@SachinJanani There should be a thread about 0.6.1.
If we want it to be part of it, I guess it should be added to  
https://issues.apache.org/jira/browse/ZEPPELIN-1203




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1172: [Zeppelin-1161] Revert precise execution time

2016-07-18 Thread SachinJanani
Github user SachinJanani commented on the issue:

https://github.com/apache/zeppelin/pull/1172
  
@corneadoug Will this changes also be available in 0.6.1 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1172: [Zeppelin-1161] Revert precise execution time

2016-07-13 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1172
  
@corneadoug When I build this PR in my local, i got this jscs warnings. 

https://cloud.githubusercontent.com/assets/10060731/16793638/7b1dc450-490d-11e6-837d-8f271a40d049.png;>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1172: [Zeppelin-1161] Revert precise execution time

2016-07-13 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1172
  
@corneadoug more graceful! Thanks for taking care of this 👍  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1172: [Zeppelin-1161] Revert precise execution time

2016-07-12 Thread corneadoug
Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1172
  
@AhyoungRyu Made modifications and added screenshot


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1172: [Zeppelin-1161] Revert precise execution time

2016-07-12 Thread corneadoug
Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1172
  
@AhyoungRyu No, that discussion was about the elapsed time.
Right, for long one, maybe we should show something else than seconds. I 
will modify that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1172: [Zeppelin-1161] Revert precise execution time

2016-07-12 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1172
  
@corneadoug Wasn't it intended behaviour because of 
[https://github.com/apache/zeppelin/pull/862#issuecomment-221474937](https://github.com/apache/zeppelin/pull/862#issuecomment-221474937)?
 Anyway I prefer to show the precise execution time even if it shows such as 
`3600 seconds` 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---