[GitHub] zeppelin issue #1211: [ZEPPELIN-910] New interpreter registration mechanism ...

2016-07-21 Thread bzz
Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1211
  
@rerngvit thank you for contributing! Please check if I have correctly 
assigned JIRA id for this issue to keep attribution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1211: [ZEPPELIN-910] New interpreter registration mechanism ...

2016-07-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1211
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1211: [ZEPPELIN-910] New interpreter registration mechanism ...

2016-07-21 Thread bzz
Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1211
  
Looks good to me.

CI failure is due to flaky R test and is treked under 
[ZEPPELIN-862](https://issues.apache.org/jira/browse/ZEPPELIN-862)

Merging if there is no further discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1211: [ZEPPELIN-910] New interpreter registration mechanism ...

2016-07-20 Thread rerngvit
Github user rerngvit commented on the issue:

https://github.com/apache/zeppelin/pull/1211
  
@jongyoul Please have a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---