[GitHub] zeppelin issue #1221: [MINOR] Change url in pom.xml files

2016-07-28 Thread minahlee
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1221 I removed URLs from all child pom. Merge if there is no further comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] zeppelin issue #1221: [MINOR] Change url in pom.xml files

2016-07-26 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1221 Looks good to me. The idea for inheriting URL from parent to reduce duplication sounds really good. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] zeppelin issue #1221: [MINOR] Change url in pom.xml files

2016-07-25 Thread lresende
Github user lresende commented on the issue: https://github.com/apache/zeppelin/pull/1221 If the URLs are all the same, and we set on the parent pom, wouldn't they be inherited ? In this case, we can actually remove all the child ones, and make future maintenance easier. --- If you

[GitHub] zeppelin issue #1221: [MINOR] Change url in pom.xml files

2016-07-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1221 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] zeppelin issue #1221: [MINOR] Change url in pom.xml files

2016-07-25 Thread minahlee
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1221 merge if there is no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena