[GitHub] zeppelin issue #1258: [ ZEPPELIN-1266 ] Code editor Optimization
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1258 @cloverhearts Thanks for the changes and keeping this PR focused. I saw some great improvements with big Notebook with those changes. @Leemoonsoo Can you try it too and tell us if you also think its better? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1258: [ ZEPPELIN-1266 ] Code editor Optimization
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1258 Looks great to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1258: [ ZEPPELIN-1266 ] Code editor Optimization
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1258 @bzz I removed the parts which you say. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1258: [ ZEPPELIN-1266 ] Code editor Optimization
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1258 @corneadoug I did modification. Please review for this pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1258: [ ZEPPELIN-1266 ] Code editor Optimization
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1258 I would limit this PR to the first commit, for me the rest is out of scope. Also, in the first PR, there is no need to make a if before calling `setParagraphMode`, the conditions you added is already at the beginning of the function. `$scope.setParagraphMode` can also be changed to `var setParagraphMode` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1258: [ ZEPPELIN-1266 ] Code editor Optimization
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1258 Would it make sense to change `isParagraphSaveAlready` => `wasParagraphAlreadySaved` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1258: [ ZEPPELIN-1266 ] Code editor Optimization
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1258 ci trigger. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
