[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

[vinayshukla]

Github user vinayshukla commented on the issue:

https://github.com/apache/zeppelin/pull/1362
  
Thanks @vensant 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1362
  
@vensant Thank you! Merging if there is no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

[vensant]

Github user vensant commented on the issue:

https://github.com/apache/zeppelin/pull/1362
  
Code changes done as per the review comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1362
  
+1 for @corneadoug, rest LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

[vensant]

Github user vensant commented on the issue:

https://github.com/apache/zeppelin/pull/1362
  
Hi all,

I will change the tool tip names as suggested.

Thank you all

Regards,
Venkat

On 26 Aug 2016 7:57 am, "Lee moon soo"  wrote:

> +1 for @corneadoug  's comment. Shorter
> name is actually more clear and easier to understand.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1362
  
Tested, LGTM
However maybe the tooltip names could be changed to something more simple:
* Multi Bar Chart -> Bar Chart
* Stacked Area Chart -> Area Chart
* Line With Focus Chart -> Line Chart


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1362
  
@vensant thank you for contributing improvement!

With GUI changes, in my experience, adding simple screenshots to the PR 
itself (drag'n'drop to description) before\after usually helps to speed up the 
review process a lot.

CI failure seems not related, look lik networking issue on Travis side :\

```
[INFO] Zeppelin: web Application .. FAILURE [01:20 
min]
[INFO] grunt-ng-annotate@0.10.0 node_modules/grunt-ng-annotate
[ERROR] npm ERR! argv 
"/home/travis/build/apache/zeppelin/zeppelin-web/node/node" 
"/home/travis/build/apache/zeppelin/zeppelin-web/node/node_modules/npm/bin/npm-cli.js"
 "install" "--color=false"
[ERROR] npm ERR! node v0.12.13
[ERROR] npm ERR! npm  v2.15.0
[ERROR] 
[ERROR] npm ERR! Callback called more than once.
[ERROR] npm ERR! 
[ERROR] npm ERR! If you need help, you may report this error at:
[ERROR] npm ERR! 
[ERROR] 
[ERROR] npm ERR! Please include the following file with any support request:
[ERROR] npm ERR! 
/home/travis/build/apache/zeppelin/zeppelin-web/npm-debug.log
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---