[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-28 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1390 @echarles you can also push gradually to facilitate review process --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-26 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1390 I have a prototype that supports the 3 modes. Give me a few days to polish and commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-26 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1390 I didn't look through the PR, but according @jongyoul 's last comments. If only `isolated` mode is supported, then I don't think is a good idea. We should not only consider isolatation of each

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-06 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1390 @echarles I've looked around your PR. I think your PR makes Zeppelin support separate users within a same instance. I have two questions regarding current behaviour. The first is about

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-06 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1390 @khalidhuseynov - have fixed the format issues - I didn't change Notebook#getNotebookAuthorization, it was already present. However, a single global NotebookAuthorization as you

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-05 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1390 @echarles I also believe having global/single NotebookAuthorization module would be more relevant --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-05 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1390 @echarles can you explain more about the `?runAs=`? I don't really see what this is used for. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-05 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1390 I have introduced a parameter in the URL `?runAs=...` that allows to impersonate from an authenticated user another user. The needed R/W authorization are respected. An alternative

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1390 @zjffdu Correct, this PR also implements ZEPPELIN-1338 User level interpreter setting (I have updated the title and description on this PR). @Leemoonsoo Will check and adapt if needed