Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1408
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
The CI build is green.
@corneadoug thanks for the update! Could you please take care of merging
this?
Thanks,
Kavin
MailTo: kavin.ku...@imaginea.com
---
If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1408
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
@corneadoug I checked the various combinations of file permissions for the
notebook folder eg. permissions 444,400. The issue that you reported above that
the notebook is not listed on
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1408
@kavinkumarks This look like a good start, but is it the only case we wan't
to handle here?
Maybe it's because of the way we test this PR, but if I change the system
notebook
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
The CI build is green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
Reopening to trigger the CI build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
@corneadoug Made changes to exit the paragraph execution when there are
errors with the notebook file system.
Thanks,
Kavin
MailTo: kavin.ku...@imaginea.com
---
If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1408
Tested with the new instructions.
But, while I do get the error message, it is still running the query
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
@corneadoug Sorry, I wasn't clear about the steps given in the PR.This was
about the permission issue with the actual notebook file system and not with
the permissions feature in the
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1408
@kavinkumarks I've tested this branch, but don't get the expected result
when I follow the `How should this be tested` section.
I'm getting:
![screen shot 2016-09-19 at 2 23 59
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
Could someone else review and merge this?
Thanks,
Kavin
MailTo: kavin.ku...@imaginea.com
---
If your project is set up for it, you can reply to this email and have your
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1408
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
The CI build is green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
Reopening to trigger the CI build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
@khalidhuseynov thanks for checking the changes.I have updated the
screenshot and triggered the CI build again.
Thanks,
Kavin
MailTo: kavin.ku...@imaginea.com
---
If your
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1408
@kavinkumarks this looks better and tested locally, works as expected. few
things:
* would be nice to update screenshot above
* CI build fails, could you take a look into that or
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
@khalidhuseynov I have made the changes and committed them.I have handled
the exception in runParagraph() instead of throwing custom exception from
VFSNotebookRepo class since the exception
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
@khalidhuseynov thanks for sharing the inputs on this.Basically I like your
idea of propagating the specific error to the user instead of the generic error
message so the user would be more
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1408
@kavinkumarks thanks for contribution. the idea of propagating error to the
user is a good one and definitely improves users experience. However, in your
implementation you basically
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
Could someone please review this?
Thanks,
Kavin
MailTo: kavin.ku...@imaginea.com
---
If your project is set up for it, you can reply to this email and have your
reply appear
21 matches
Mail list logo