[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1408 Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 The CI build is green. @corneadoug thanks for the update! Could you please take care of merging this? Thanks, Kavin MailTo: kavin.ku...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1408 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1408
@corneadoug I checked the various combinations of file permissions for the
notebook folder eg. permissions 444,400. The issue that you reported above that
the notebook is not listed on restarting the zeppelin server is due to the
below error in the logs on restarting the server,
`ERROR [2016-09-25 23:17:04,767] ({main} VFSNotebookRepo.java[list]:144) -
Can't read note file:///home/kavink/git/zeppelin/notebook/2BWTQ6UDY
java.io.IOException:
file:///home/kavink/git/zeppelin/notebook/2BWTQ6UDY/note.json not found
at
org.apache.zeppelin.notebook.repo.VFSNotebookRepo.getNote(VFSNotebookRepo.java:158)
at
org.apache.zeppelin.notebook.repo.VFSNotebookRepo.getNoteInfo(VFSNotebookRepo.java:194)
at
org.apache.zeppelin.notebook.repo.VFSNotebookRepo.list(VFSNotebookRepo.java:139)
at
org.apache.zeppelin.notebook.repo.NotebookRepoSync.list(NotebookRepoSync.java:124)
at org.apache.zeppelin.notebook.Notebook.loadAllNotes(Notebook.java:461)
at org.apache.zeppelin.notebook.Notebook.(Notebook.java:123)
at
org.apache.zeppelin.server.ZeppelinServer.(ZeppelinServer.java:97)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)`
The notebook folder should have both read and execute permission to list it
and this is being already caught in the logs.I think that we aren't missing
anything here.Please let me know your thoughts.
Thanks,
Kavin
MailTo: kavin.ku...@imaginea.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1408 @kavinkumarks This look like a good start, but is it the only case we wan't to handle here? Maybe it's because of the way we test this PR, but if I change the system notebook permission to read only (chmod 444), I can't run it, but everything I do is still there after page refresh. If I restart zeppelin-server, the notebook isn't there anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 The CI build is green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 Reopening to trigger the CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 @corneadoug Made changes to exit the paragraph execution when there are errors with the notebook file system. Thanks, Kavin MailTo: kavin.ku...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1408 Tested with the new instructions. But, while I do get the error message, it is still running the query  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 @corneadoug Sorry, I wasn't clear about the steps given in the PR.This was about the permission issue with the actual notebook file system and not with the permissions feature in the zeppelin UI.I have updated the PR description. Please let me know if you have any questions. Thanks, Kavin MailTo: kavin.ku...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1408 @kavinkumarks I've tested this branch, but don't get the expected result when I follow the `How should this be tested` section. I'm getting:  which is shown after receiving: `AUTH_INFO` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 Could someone else review and merge this? Thanks, Kavin MailTo: kavin.ku...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1408 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 The CI build is green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 Reopening to trigger the CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 @khalidhuseynov thanks for checking the changes.I have updated the screenshot and triggered the CI build again. Thanks, Kavin MailTo: kavin.ku...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1408 @kavinkumarks this looks better and tested locally, works as expected. few things: * would be nice to update screenshot above * CI build fails, could you take a look into that or re-trigger it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 @khalidhuseynov I have made the changes and committed them.I have handled the exception in runParagraph() instead of throwing custom exception from VFSNotebookRepo class since the exception need to be handled i.e FileSystemException (subclass of IOException) is already handled in different ways for other scenarios and in different implementations of NotebookRepo. Thanks, Kavin MailTo: kavin.ku...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 @khalidhuseynov thanks for sharing the inputs on this.Basically I like your idea of propagating the specific error to the user instead of the generic error message so the user would be more specific about the issue.If we need to handle other errors we can think about them in the future if there is need. Here is my thought to the approach.I will change org.apache.zeppelin.notebook.repo.VFSNotebookRepo.save(Note, AuthenticationInfo) to throw the specific exception with the error message and handle the exception in org.apache.zeppelin.socket.NotebookServer.runParagraph(NotebookSocket, HashSet, Notebook, Message) and then broadcast the error message to the user. Thanks, Kavin MailTo: kavin.ku...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1408 @kavinkumarks thanks for contribution. the idea of propagating error to the user is a good one and definitely improves users experience. However, in your implementation you basically propagate all kinds of errors (on on top level catch `Exception`) with the same message to the user and he still not sure what the problem is. I think we need more fine grained approach here and let every method/feature implementor to be able to send `ERROR_INFO` message on his own catch statement for say `PROPAGATE_USER_EXCEPTION` with the message specific to error and throw other kinds of errors up to the logs. does that makes sense? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...
Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1408 Could someone please review this? Thanks, Kavin MailTo: kavin.ku...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
