[GitHub] zeppelin issue #1517: [MINOR] ui improvement
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1517 @baekhoseok Thank you for the contribution! Do you mind to update `docs/assets/themes/zeppelin/img/ui-img/interpreter_menu.png` again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1517: [MINOR] ui improvement
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1517 @AhyoungRyu the issue you raised is not caused by this pr but #1501. Can you try after clean bower cache(`bower cache clean`) and remove `bower_components` directory under `zeppelin-web`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1517: [MINOR] ui improvement
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1517 @baekhoseok Tested and it looks good! You chose second option :) https://cloud.githubusercontent.com/assets/10060731/19586063/9f5f8646-978c-11e6-814c-623fb8d5a063.png;> This is the current status that I build locally. But one wired thing is I can't build with `./grunt build` in this branch. (no problem in master now) https://cloud.githubusercontent.com/assets/10060731/19586076/cfddc396-978c-11e6-9b02-0bae29b1d2b1.png;> IDK what the exact cause is, I fixed this with rebasing. So could you rebase with below steps? ``` $ git checkout master ``` if you didn't set upstream yet (or you can skip this step) ``` $ git remote add upstream https://github.com/apache/zeppelin ``` rebase from master ``` $ git fetch upstream $ git pull upstream master $ git checkout minor_ui_fix $ git rebase master $ git push origin -f minor_ui_fix ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1517: [MINOR] ui improvement
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1517 @baekhoseok Thanks for your contribution and looks nice to me! Probably it's a nitpick, how about keeping consistency for that two buttons in interpreter setting page? Here are two suggestions. # 1. Icons with tooltips and no button border  # 2. Icons with button border and no tooltip  What do you think? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1517: [MINOR] ui improvement
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1517 Change looks great to me, that you for your contribution. Awesome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1517: [MINOR] ui improvement
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1517 Looks good to me It's very clear :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1517: [MINOR] ui improvement
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1517 LGTM. It's simple and clean. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
