[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1577 Any updated? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1577 @yoonjs2 Yeah you're right, there is a typo. It should be one of them either `zeppelin-website` or `zeppelin_website`. I updated the comment :) And you did like below as you said ``` $ JEKYLL_ENV=production $ bundle exec jekyll build ``` But it should be in one line ``` $ JEKYLL_ENV=production bundle exec jekyll build ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user yoonjs2 commented on the issue: https://github.com/apache/zeppelin/pull/1577 @AhyoungRyu I've stucked with the first step you've mentioned... How do I workaround this error? 1) build gh-pages (website) branch ``` $ git checkout gh-pages $ JEKYLL_ENV=production $ bundle exec jekyll build Configuration file: /Users/yoonjesang/Desktop/openfrontier/zeppelin/_config.yml Source: /Users/yoonjesang/Desktop/openfrontier/zeppelin Destination: /Users/yoonjesang/Desktop/openfrontier/zeppelin/_site Incremental build: disabled. Enable with --incremental Generating... Liquid Exception: Could not locate the included file 'nav/announcements-4.0.html' in any of ["/Users/yoonjesang/Desktop/openfrontier/zeppelin/_includes"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source. in zeppelin-web/bower_components/select2/docs/announcements-4.0.html jekyll 3.2.1 | Error: Could not locate the included file 'nav/announcements-4.0.html' in any of ["/Users/yoonjesang/Desktop/openfrontier/zeppelin/_includes"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source. ``` And I found few lines of your instruction seems mistyped... Am I correct? ``` mkdir -p /tmp/zeppelin-website/docs/0.7.0-SNAPSHOT => mkdir -p /tmp/zeppelin_website/docs/0.7.0-SNAPSHOT cp -r _site/ /tmp/zeppelin_website/0.7.0-SNAPSHOT/ => cp -r _site/ /tmp/zeppelin_website/docs/0.7.0-SNAPSHOT/ ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user yoonjs2 commented on the issue: https://github.com/apache/zeppelin/pull/1577 @AhyoungRyu OK I'll investigate and resolve them ASAP. Thanks for the review :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user yoonjs2 commented on the issue: https://github.com/apache/zeppelin/pull/1577 @AhyoungRyu Fair enough, I'd just removed a todo (L10N support) and It will be proposed different PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1577 @yoonjs2 yes i think it would be better to handle " L10N support" in other PR since it's a bit different work with this PR. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user yoonjs2 commented on the issue: https://github.com/apache/zeppelin/pull/1577 @AhyoungRyu no, its under progress now. Should I changeunchecked todo to other PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1577 @yoonjs2 Seems "Prepare L10N support on documentation" is unchecked in the PR description. Is it done now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user yoonjs2 commented on the issue: https://github.com/apache/zeppelin/pull/1577 @AhyoungRyu @minahlee Thanks! Let me know if patch needs any change :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1577 @yoonjs2 just added your name to contributor role --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1577 @yoonjs2 Sure. And let me test this patch :) @minahlee Could you help me add @yoonjs2 (Jira username:Jesang Yoon) to the contributor list in Jira so that he can assign himself to assignee? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...
Github user yoonjs2 commented on the issue: https://github.com/apache/zeppelin/pull/1577 @AhyoungRyu Can I ask you to allow me to change JIRA ZEPPELIN-1554 assignee and progress? In case of self proposal and PR like this, It would be great to use JIRA as contributor access :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
