[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 2 Scala 2.11 profiles failed on IgniteSQL tests - a flaky test tracked under [ZEPPELIN-1738](https://issues.apache.org/jira/browse/ZEPPELIN-1738l) ``` Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.116 sec <<< FAILURE! - in org.apache.zeppelin.ignite.IgniteSqlInterpreterTest testSql(org.apache.zeppelin.ignite.IgniteSqlInterpreterTest) Time elapsed: 0.909 sec <<< FAILURE! java.lang.AssertionError: expected: but was: at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.zeppelin.ignite.IgniteSqlInterpreterTest.testSql(IgniteSqlInterpreterTest.java:95) Results : Failed tests: IgniteSqlInterpreterTest.testSql:95 expected: but was: Tests run: 4, Failures: 1, Errors: 0, Skipped: 0 ``` which is not relevant to the change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Waiting for CI to finish on https://travis-ci.org/1ambda/zeppelin/ Will merge to master right after that, if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Looks like it need a final re-base here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1668
It is safe to centralise `${plugin.download.version}` only in
`spark-dependency` to the root `pom.xml`
```
$ spark-dependencies git:(chore/centralize-maven-pom-versions) ag
"download-maven-plugin"
dependency-reduced-pom.xml
510:download-maven-plugin
579:download-maven-plugin
pom.xml
827:download-maven-plugin
905:download-maven-plugin
984:download-maven-plugin
$ spark-dependencies git:(chore/centralize-maven-pom-versions)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1668 @bzz I will add right now and push it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Will you also add `plugin.download.version` to [spark-dependencies/pom.xml](https://github.com/apache/zeppelin/pull/1668/files#diff-457fb4186c9640eac4e0808bbd0d849e) ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Thank you @1ambda ! Merging to master, if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1668 I will resolve conflict with https://github.com/apache/zeppelin/commit/4ac577f711b2d62afb2016b95b6ccc3a85afd108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 thanks a lot, @1ambda ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Sounds reasonable. CI is green, merging to master then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1668 rebased to keep sync with master (+ to see CI is green as well) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 @1ambda it looks like rebase is needed after few other `pom.xml` modifications got merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Looks great to me and CI is green now. Merging to master, if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1668 @bzz Failed due to not the related test. I will amend commit and trigger CI again ``` Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 110.105 sec - in org.apache.zeppelin.integration.ZeppelinIT Results : Tests in error: InterpreterIT.testShowDescriptionOnInterpreterCreate:69 » ElementNotVisible El... Tests run: 18, Failures: 0, Errors: 1, Skipped: 0 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Thank you for double-checking and explanations. Looks like CI is failing right now though --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1668 @bzz Thanks for review! I didn't know about `change_scala_version.sh` but it is very important if it's affected There are many ways to compare, but i choose simple and reproduceable way so that other can to do again. - run `./dev/change_scala_version.sh` in both branch `master` and `pr1668` - create diff files - compare the above files As you can see, `change_scala_version.sh` is no relevant with this PR. ``` $ zeppelin-review git:(master) git rev-parse HEAD abe03a866fc9ac2563c057d6edc00d3ec0a7d733 $ zeppelin-review git:(master) ./dev/change_scala_version.sh 2.11 ./dev/../alluxio/pom.xml ./dev/../angular/pom.xml ./dev/../beam/pom.xml ./dev/../bigquery/pom.xml ./dev/../cassandra/pom.xml ./dev/../elasticsearch/pom.xml ./dev/../file/pom.xml ./dev/../flink/pom.xml ./dev/../geode/pom.xml ./dev/../hbase/pom.xml ./dev/../ignite/pom.xml ./dev/../jdbc/pom.xml ./dev/../kylin/pom.xml ./dev/../lens/pom.xml ./dev/../livy/pom.xml ./dev/../markdown/pom.xml ./dev/../pig/pom.xml ./dev/../pom.xml ./dev/../postgresql/pom.xml ./dev/../python/pom.xml ./dev/../r/pom.xml ./dev/../scalding/pom.xml ./dev/../scio/pom.xml ./dev/../shell/pom.xml ./dev/../spark/pom.xml ./dev/../spark-dependencies/pom.xml ./dev/../zeppelin-display/pom.xml ./dev/../zeppelin-distribution/pom.xml ./dev/../zeppelin-examples/pom.xml ./dev/../zeppelin-examples/zeppelin-example-clock/pom.xml ./dev/../zeppelin-examples/zeppelin-example-horizontalbar/pom.xml ./dev/../zeppelin-interpreter/pom.xml ./dev/../zeppelin-server/pom.xml ./dev/../zeppelin-web/pom.xml ./dev/../zeppelin-zengine/pom.xml $ zeppelin-review git:(master) â git diff --no-color > ~/master $ zeppelin-master git:(chore/centralize-maven-pom-versions) git rev-parse HEAD b724218c446f3f740238e528c86ee32864f46e92 $ zeppelin-master git:(chore/centralize-maven-pom-versions) ./dev/change_scala_version.sh 2.11 ./dev/../alluxio/pom.xml ./dev/../angular/pom.xml ./dev/../beam/pom.xml ./dev/../bigquery/pom.xml ./dev/../cassandra/pom.xml ./dev/../elasticsearch/pom.xml ./dev/../file/pom.xml ./dev/../flink/pom.xml ./dev/../geode/pom.xml ./dev/../hbase/pom.xml ./dev/../ignite/pom.xml ./dev/../jdbc/pom.xml ./dev/../kylin/pom.xml ./dev/../lens/pom.xml ./dev/../livy/pom.xml ./dev/../markdown/pom.xml ./dev/../pig/pom.xml ./dev/../pom.xml ./dev/../postgresql/pom.xml ./dev/../python/pom.xml ./dev/../r/pom.xml ./dev/../scalding/pom.xml ./dev/../scio/pom.xml ./dev/../shell/pom.xml ./dev/../spark/pom.xml ./dev/../spark-dependencies/pom.xml ./dev/../zeppelin-display/pom.xml ./dev/../zeppelin-distribution/pom.xml ./dev/../zeppelin-examples/pom.xml ./dev/../zeppelin-examples/zeppelin-example-clock/pom.xml ./dev/../zeppelin-examples/zeppelin-example-horizontalbar/pom.xml ./dev/../zeppelin-interpreter/pom.xml ./dev/../zeppelin-server/pom.xml ./dev/../zeppelin-web/pom.xml ./dev/../zeppelin-zengine/pom.xml $ zeppelin-master git:(chore/centralize-maven-pom-versions) â git diff --no-color > ~/pr1668 $ ~ diff master pr1668 2c2 < index dc31594..c4ad855 100644 --- > index 02a7ab3..c821dbb 100644 5c5 < @@ -47,7 +47,7 @@ --- > @@ -52,7 +52,7 @@ 14c14 < @@ -59,15 +59,15 @@ --- > @@ -64,15 +64,15 @@ 33c33 < @@ -75,7 +75,7 @@ --- > @@ -80,7 +80,7 @@ 43c43 < index e425f48..7e6cc2b 100644 --- > index 267eb0d..a3d0ab9 100644 56c56 < index 1885a1f..6ffd328 100644 --- > index 7ed559f..d835f91 100644 69c69 < index d70c488..95b5bf9 100644 --- > index 4e7ed2c..6be9e69 100644 82c82 < index 1e717f8..17af6bc 100644 --- > index 0fc8847..af7a926 100644 85c85 < @@ -121,27 +121,27 @@ --- > @@ -133,27 +133,27 @@ 119c119 < @@ -181,27 +181,27 @@ --- > @@ -193,27 +193,27 @@ 153c153 < @@ -217,27 +217,27 @@ --- > @@ -229,27 +229,27 @@ 188c188 < index 2f7ac3c..491a0c9 100644 --- > index ccee507..fe4a502 100644 191,192c191 < @@ -83,7 +83,7 @@ < --- > @@ -84,7 +84,7 @@ 193a193 > 201c201 < index 2dc2eef..88f09e3 100644 --- > index c4ac898..e275f6e 100644 214c214 < index 937d11a..aff1d77 100644 --- > index 83485b0..5af4ffa 100644 227c227 < index 27f5433..4cd3c7e 100644 --- > index 5d385ac..cfafbf8 100644 240c240 < index 04b6983..2eb5cab 100644 --- > index 0185bb7..9b98473 100644 253c253 < index 9e1549d..b0f52a7 100644 --- > index a8d2616..126cb85 100644 266c266 < index
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Thank you - it's a great effort, a bit long to review so it took a while and have diverged from master. @1ambda could you rebase and also make sure it does not affect automation like https://github.com/apache/zeppelin/blob/master/dev/change_scala_version.sh ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
