[GitHub] zeppelin issue #1735: [ZEPPELIN-1767] Blank paragraph should not be run.

2016-12-13 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1735 LGTM 👍 Merge if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1735: [ZEPPELIN-1767] Blank paragraph should not be run.

2016-12-13 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1735 CI is green now. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1735: [ZEPPELIN-1767] Blank paragraph should not be run.

2016-12-11 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1735 @astroshim Thanks for your prompt update. Tested and it works well! But sadly 3 of CI tests are failed likw below and looks relevant with this change. Could you take a look this again

[GitHub] zeppelin issue #1735: [ZEPPELIN-1767] Blank paragraph should not be run.

2016-12-11 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1735 Testcase also added. @AhyoungRyu Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1735: [ZEPPELIN-1767] Blank paragraph should not be run.

2016-12-09 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1735 @astroshim Good catch! Tested and it was working well as expected. AFAIK there are 3 way to run a paragraph in Zeppelin note like below 1. \w keyboard shortcut `Shift + Enter` :

[GitHub] zeppelin issue #1735: [ZEPPELIN-1767] Blank paragraph should not be run.

2016-12-08 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1735 I just fixed typo. Thanks @rhymoid and @cloverhearts to review this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1735: [ZEPPELIN-1767] Blank paragraph should not be run.

2016-12-07 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1735 I think we need this feature. and on focus to good fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project