[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 Will merge into master if there are no more comments then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 @felixcheung Yeah that's my plan :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1750 LGTM! Maybe we can leverage this for more copy to clipboard features? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 CI has passed now. Ready to review again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 For the consistency with other menus in the dropdown menu, I removed the clippy icon and make paragraph id text itself as a button.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1750 Great but the concerns are with dependencies on Flash with this approach --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 @felixcheung I just tested this patch only in dev mode(`npm run start`). But after I checked at `localhost:8080` and found ``` 404 http://localhost:8080/bower_components/zeroclipboard/dist/ZeroClipboard.swf ``` So I fixed it in here: [616b743](https://github.com/apache/zeppelin/pull/1750/commits/616b743019fe10c45a4693565e1d2c18dcd060fb). There won't be `ZeroClipboard.swf` loading issue anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
