[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...

2016-12-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1756
  
Merge to master if there're no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...

2016-12-15 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1756
  
@Leemoonsoo @AhyoungRyu Thanks for review :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...

2016-12-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1756
  
At last! Tested and it works well. LGTM 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...

2016-12-15 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1756
  
Finally, the CI is GREEN! (After about 7 attempts) :sob: 
It's time to ready to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...

2016-12-14 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1756
  
Tested and LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...

2016-12-14 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1756
  
@tae-jun Sorry for many reopened PR. 
I had a weird CI problem like the link 
(https://travis-ci.org/apache/zeppelin/builds/183881539). But I solved with 
recommit PR. Now, CI fail again :crying_cat_face: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...

2016-12-14 Thread tae-jun
Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1756
  
OMG hope that it passes this time... :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---